rubocop-sorbet 0.13.1 → 0.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c51ae13ac2c32733024c71003fa884392ea9ba66a7a02638a7f000f1ca59ffc3
-  data.tar.gz: 3d665a684394894867652ee120361c9e03d2f41a6ef713d91b89f6a927bde8ea
+  metadata.gz: e4fb414d8d5df23d654fc8f861efb308e2a1d4c3a51fcea2d87ce65654179a1b
+  data.tar.gz: 320d66ec089e119e43a19630a5a144c9fd69ef415af600ff8abd9d1690e6cf98
 SHA512:
-  metadata.gz: 47098214ac3bf1ca4d3c26ebce8a7668bf02179180d4c7407965c4d3a6e436df67af6e7850b19787e5bbbe5265ebc35a5958bc424c4fb043d69cf7b157cdba76
-  data.tar.gz: bb120a2eab93d930a407a3d34e1f1d407eda219cfb0410d4a0a31cb8ccfc91d2d410634c8eb0c7d81e38af406631c458b29145c5f5e0e61455c0764d9477ab75
+  metadata.gz: 134904f291e25f0a766cef59a1e634b28f67083702eb9012e2e23d693d7eef09de7a484d43756a66ac15466c9f1f3f87c787c656e5391c948b3ac90f680f51ec
+  data.tar.gz: aaa261000213551b7591761df1be4b78932af5846578d9969e75cdb79d4c104fd75c3f66610d5248d80b5e36f74496f1938fc2c1e35b56582d8200b7829e04bc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.13.1)
+    rubocop-sorbet (0.13.2)
       lint_roller
       rubocop (>= 1.75.2)
 

data/VERSION

@@ -1 +1 @@
-0.13.1
+0.13.2

data/lib/rubocop/cop/sorbet/signatures/enforce_signatures.rb

@@ -118,9 +118,16 @@ module RuboCop
         end
 
         def autocorrect_with_signature_type(corrector, node, type)
-          suggest = create_signature_suggestion(node, type)
+          target = leftmost_send_ancestor(node)
+          suggest = create_signature_suggestion(target, type)
           populate_signature_suggestion(suggest, node)
-          corrector.insert_before(node, suggest.to_autocorrect)
+          corrector.insert_before(target, suggest.to_autocorrect)
+        end
+
+        def leftmost_send_ancestor(node)
+          ancestor = node
+          ancestor = ancestor.parent while ancestor.parent&.send_type?
+          ancestor
         end
 
         def create_signature_suggestion(node, type)
@@ -141,6 +148,8 @@ module RuboCop
         end
 
         def populate_method_definition_suggestion(suggest, node)
+          suggest.returns = "void" if instance_initialize?(node)
+
           node.arguments.each do |arg|
             if arg.blockarg_type? && suggest.respond_to?(:has_block=)
               suggest.has_block = true
@@ -150,10 +159,30 @@ module RuboCop
           end
         end
 
+        def instance_initialize?(node)
+          node.def_type? && node.method?(:initialize) && !in_sclass_context?(node)
+        end
+
+        def in_sclass_context?(node)
+          parent = node.parent
+          while parent
+            return true if parent.sclass_type?
+            return false if parent.type?(:class, :module)
+
+            parent = parent.parent
+          end
+          false
+        end
+
         def populate_accessor_suggestion(suggest, node)
           method = node.children[1]
           symbol = node.children[2]
 
+          if suggest.is_a?(RBSSuggestion)
+            suggest.attribute = true
+            return
+          end
+
           add_accessor_parameter_if_needed(suggest, symbol, method)
           set_void_return_for_writer(suggest, method)
         end
@@ -299,12 +328,13 @@ module RuboCop
         end
 
         class RBSSuggestion
-          attr_accessor :params, :returns, :has_block
+          attr_accessor :params, :returns, :has_block, :attribute
 
           def initialize(indent)
             @params = []
             @returns = nil
             @has_block = false
+            @attribute = false
             @indent = indent
           end
 
@@ -315,6 +345,8 @@ module RuboCop
           private
 
           def generate_signature
+            return @returns || "untyped" if @attribute
+
             param_types = @params.map { |param| rbs_param(param) }.join(", ")
             return_type = @returns || "untyped"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.13.2
 platform: ruby
 authors:
 - Ufuk Kayserilioglu