rubocop-sorbet 0.13.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5dcbac6e0a2af2d4bed5b33ef9bd2d9cfad4608a400dc2f81e0c8c338543615
-  data.tar.gz: 9960e81847d7cda7ffb4b94d9dff22ac65f3c2b9c74664c931684b492d7da14e
+  metadata.gz: c51ae13ac2c32733024c71003fa884392ea9ba66a7a02638a7f000f1ca59ffc3
+  data.tar.gz: 3d665a684394894867652ee120361c9e03d2f41a6ef713d91b89f6a927bde8ea
 SHA512:
-  metadata.gz: 7a0e44a9cc6fd67dd8fb564015f9dfee1e76c510d2b5e3dd853cffb72ee4f6b30948593f8d96f008749fdcbb5a70b02b11342396787a8e48f1fd9b11a6f308cd
-  data.tar.gz: 647911f5d12c0a8459e92ee71b0cd3bc01b7d4e8b15195555e82194499f4b57423d2307854f080f00132bf64f86d2356cefc6b22c545cda00b24427cbbb4fd9c
+  metadata.gz: 47098214ac3bf1ca4d3c26ebce8a7668bf02179180d4c7407965c4d3a6e436df67af6e7850b19787e5bbbe5265ebc35a5958bc424c4fb043d69cf7b157cdba76
+  data.tar.gz: bb120a2eab93d930a407a3d34e1f1d407eda219cfb0410d4a0a31cb8ccfc91d2d410634c8eb0c7d81e38af406631c458b29145c5f5e0e61455c0764d9477ab75

data/.github/workflows/stale.yml

@@ -12,7 +12,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@eb5cf3af3ac0a1aa4c9c45633dd1ae542a27a899 # v10.3.0
+      - uses: actions/stale@1e223db275d687790206a7acac4d1a11bd6fe629 # v10.4.0
         with:
           stale-pr-message: >
             This PR has been automatically marked as stale because it has not had

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.13.0)
+    rubocop-sorbet (0.13.1)
       lint_roller
       rubocop (>= 1.75.2)
 

data/VERSION

@@ -1 +1 @@
-0.13.0
+0.13.1

data/lib/rubocop/cop/sorbet/signatures/enforce_signatures.rb

@@ -31,6 +31,11 @@ module RuboCop
         VALID_STYLES = ["sig", "rbs", "both"].freeze
         VALID_AUTOCORRECT_STYLES = ["sig", "rbs"].freeze
 
+        # Represents a method parameter with its name and AST node kind.
+        # @kind is the RuboCop AST node type (:arg, :optarg, :restarg, :kwarg,
+        # :kwoptarg, :kwrestarg, :forward_arg, :blockarg).
+        Param = Struct.new(:name, :kind)
+
         # @!method accessor?(node)
         def_node_matcher(:accessor?, <<-PATTERN)
           (send nil? {:attr_reader :attr_writer :attr_accessor} ...)
@@ -140,7 +145,7 @@ module RuboCop
             if arg.blockarg_type? && suggest.respond_to?(:has_block=)
               suggest.has_block = true
             else
-              suggest.params << arg.children.first
+              suggest.params << Param.new(arg.children.first, arg.type)
             end
           end
         end
@@ -156,7 +161,7 @@ module RuboCop
         def add_accessor_parameter_if_needed(suggest, symbol, method)
           return unless symbol && writer_or_accessor?(method)
 
-          suggest.params << symbol.value
+          suggest.params << Param.new(symbol.value, :arg)
         end
 
         def set_void_return_for_writer(suggest, method)
@@ -278,7 +283,7 @@ module RuboCop
           def generate_params
             return "" if @params.empty?
 
-            param_list = @params.map { |param| "#{param}: #{@param_placeholder}" }.join(", ")
+            param_list = @params.map { |param| "#{param.name}: #{@param_placeholder}" }.join(", ")
             "params(#{param_list})."
           end
 
@@ -310,7 +315,7 @@ module RuboCop
           private
 
           def generate_signature
-            param_types = @params.map { "untyped" }.join(", ")
+            param_types = @params.map { |param| rbs_param(param) }.join(", ")
             return_type = @returns || "untyped"
 
             signature = if @params.empty?
@@ -324,6 +329,23 @@ module RuboCop
 
             signature
           end
+
+          def rbs_param(param)
+            case param.kind
+            when :kwarg
+              "#{param.name}: untyped"
+            when :kwoptarg
+              "?#{param.name}: untyped"
+            when :optarg
+              "?untyped"
+            when :restarg
+              "*untyped"
+            when :kwrestarg
+              "**untyped"
+            else
+              "untyped"
+            end
+          end
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.13.1
 platform: ruby
 authors:
 - Ufuk Kayserilioglu