rubocop-sketchup 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d69761990813abecd3a20633643a490c07df1a341c0ba6f36131d6aedf682fe3
-  data.tar.gz: 40ccb6f930c97bb0a716ac72d36c4963849dd40f9cd4e69f3bc3d26b86e3c6d7
+  metadata.gz: e9935671119993e41eef012a5f69fca2709a59d7db06d28c2e89ff9ea5721aa7
+  data.tar.gz: 05cba02d5fa27e8eab8b32cae46d586c68d5fec8922b959febf89ebd36660ced
 SHA512:
-  metadata.gz: 23b2fc55403fa6bc471e2769d7121418944901d0d30b75fa36bb7aa49c0bbdd1aa95dc1f26248cbfe5ddd1a29f88c807dcbf022612a78ff3e4029449920f1337
-  data.tar.gz: 7c389ffdda8af9df21dd805086af0a2e5863415296f9922c69c12a132402dfc5f188fca09486089bc4fb2a1c01560fd825748ac3abe7050229141f9bdf002352
+  metadata.gz: 06e197b228db557e7d1b0ab9eeec6550e9a70a8e64fa4079f6f4e093249f0057390f9ce6f4270d15e1be956e36b684ff66f5e926a55d0a2b862e33d113a8a3c2
+  data.tar.gz: 54242ae1e4bb983394e9976f02893d98794ae46971755751bdbcea1b4ecdfd9e1c6e3c9e4dde6cd995e7977b788d8ec5fa3dab693723bdd84f30dd3717b8a590

data/Gemfile

@@ -9,6 +9,8 @@ group :test do
   gem 'rake', '~> 12.0', require: false
   gem 'rspec', '~> 3.7', require: false
   gem 'rubocop-performance', '~> 1.11.0', require: false
+  gem 'rubocop-rake', '~> 0.6.0', require: false
+  gem 'rubocop-rspec', require: false
   gem 'simplecov', '~> 0.10', require: false
 end
 

data/lib/rubocop/sketchup/namespace_checker.rb

@@ -4,6 +4,35 @@ module RuboCop
   module SketchUp
     module NamespaceChecker
 
+      extend NodePattern::Macros
+
+      # Example:
+      #   Array.include(Example)
+      def_node_matcher :klass_include, <<-PATTERN
+        (send
+          (const nil? $_) { :include | :extend } _)
+      PATTERN
+
+      # Example:
+      #   class Array
+      #     include Example
+      #   end
+      def_node_matcher :klass_scope_include, <<-PATTERN
+        (
+          {
+            class (const nil? $_) nil? |
+            module (const nil? $_)
+          }
+          (send nil? { :include | :extend } _))
+      PATTERN
+
+      # Example:
+      #   include Example
+      def_node_matcher :include_call?, <<-PATTERN
+        (send nil? { :include | :extend } _)
+      PATTERN
+
+
       def on_class(node)
         check_namespace(node)
       end
@@ -22,12 +51,40 @@ module RuboCop
         check_namespace(node)
       end
 
+      def on_send(node)
+        klass = klass_include(node) || klass_scope_include(node.parent)
+
+        if klass
+          namespace = SketchUp::Namespace.new(klass.to_s)
+          return unless namespaces.include?(namespace.first)
+        else
+          # If klass is `nil` we either don't have a `include` call or we're in
+          # global namespace.
+          return unless top_level_include?(node)
+        end
+
+        add_offense(node, location: :selector, severity: :error)
+      end
+
       def check_namespace(node)
         return unless in_namespace?(node)
 
         add_offense(node, location: :name, severity: :error)
       end
 
+      def top_level?(node)
+        # parent_module_name might return nil if for instance a method is
+        # defined within a block. (Apparently that is possible...)
+        return false if node.parent_module_name.nil?
+
+        namespace = SketchUp::Namespace.new(node.parent_module_name)
+        namespace.top_level?
+      end
+
+      def top_level_include?(node)
+        include_call?(node) && top_level?(node)
+      end
+
       def in_namespace?(node)
         # parent_module_name might return nil if for instance a method is
         # defined within a block. (Apparently that is possible...)

data/lib/rubocop/sketchup/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module SketchUp
-    VERSION = '1.2.0'
+    VERSION = '1.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-25 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop