rubocop-sketchup 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9e87c5eb2f0e9d6ebeeac8f7b83686e40eb5357f
-  data.tar.gz: 51f64f97d094f38df5a730aa22677dcda3741617
+SHA256:
+  metadata.gz: f55bf3e2f4a93cec9b94539d6d4bcf713e962666975c92706ff64b2c3ba26819
+  data.tar.gz: 49784ee3c8506b69c3d9f2ff15166d2e53a169a5186e33bdd0bcd4e40b5b11ca
 SHA512:
-  metadata.gz: bc99a7230d75286b26ae86c6029458782b53b7ad841fa2863ee762ffaa4731a91122cc57361768b9201f9f6bc98da202e693c106f5bd31f8a68d02df4b119f04
-  data.tar.gz: e0b6b2b2f2a7fb8117f1e20830d4d56b3cb9667530012b13e0580c30f779d26eacd4b8dc20533a3ac668682163cde24785ba10966fe8cf71a87f0432c9334c2c
+  metadata.gz: 1bb0cd01b560f10d367adb0b8656be78f8db47bd73d3ce21fb2128194deacf791764a9cda0707e7c15c366a5194f5476315b39278753c755333a4549bc51e1b6
+  data.tar.gz: acedfe0376819dce12bcb722093659d2214bc965c44f46dcd4cef0aa7d7c9cfd8109be83c913dce6292caa8956b6f9e5172a1b14566313eba0ecd02a9c56ff84

data/config/default.yml

@@ -3,6 +3,14 @@ AllCops:
   SketchUp:
     SourcePath: src
     TargetSketchUpVersion: 2016
+    SketchupDeprecations:
+      Exclude: []
+    SketchupPerformance:
+      Exclude: []
+    SketchupRequirements:
+      Exclude: []
+    SketchupSuggestions:
+      Exclude: []
 
 SketchupDeprecations/AddSeparatorToMenu:
   Description: The method `add_separator_to_menu` is deprecated.

data/lib/rubocop-sketchup.rb

@@ -5,6 +5,7 @@ require 'rubocop/sketchup/inject'
 
 require 'rubocop/sketchup/formatter/extension_review'
 require 'rubocop/sketchup/config'
+require 'rubocop/sketchup/cop'
 require 'rubocop/sketchup/dc_globals'
 require 'rubocop/sketchup/dc_methods'
 require 'rubocop/sketchup/extension_project'
@@ -32,7 +33,7 @@ class RuboCop::Formatter::FormatterSet
 end
 
 # Load all custom cops.
-pattern = File.join(__dir__, 'rubocop', 'sketchup', '**/*rb')
+pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
 Dir.glob(pattern) { |file|
   require file
 }

data/lib/rubocop/sketchup/config.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Config
 
       DEFAULT_CONFIGURATION =
-        RuboCop::SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
+        SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
 
       private
 

data/lib/rubocop/sketchup/cop.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+
+    WorkaroundCop = RuboCop::Cop::Cop.dup
+
+    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
+    # the inherited method without breaking functionality
+    class WorkaroundCop
+      # Remove the Cop.inherited method to be a noop. Our SketchUp::Cop
+      # class will invoke the inherited hook instead
+      class << self
+        undef inherited
+        def inherited(*) end
+      end
+
+      # Special case `Module#<` so that the rspec support rubocop exports
+      # is compatible with our subclass
+      def self.<(other)
+        other.equal?(RuboCop::Cop::Cop) || super
+      end
+    end
+    private_constant(:WorkaroundCop)
+
+    # @abstract parent class to SketchUp cops
+    #
+    # The criteria for whether rubocop-sketchup analyzes a certain ruby file
+    # is configured via `AllCops/SketchUp`. For example, if you want to
+    # customize your project to scan all files within a `test/` directory
+    # then you could add this to your configuration:
+    #
+    # @example configuring analyzed paths
+    #
+    #   AllCops:
+    #     SketchUp:
+    #       SketchupDeprecations:
+    #         Exclude:
+    #         - '_test.rb$'
+    #         - '(?:^|/)test/'
+    class Cop < WorkaroundCop
+
+      include SketchUp::Config
+
+      # Invoke the original inherited hook so our cops are recognized
+      def self.inherited(subclass)
+        RuboCop::Cop::Cop.inherited(subclass)
+      end
+
+      def relevant_file?(file)
+        relevant_rubocop_sketchup_file?(file) && super
+      end
+
+      private
+
+      def department_name
+        self.class.department.to_s
+      end
+
+      def relevant_rubocop_sketchup_file?(file)
+        !(department_exclude_pattern =~ file)
+      end
+
+      def department_exclude_pattern
+        if department_exclude_config?
+          patterns = department_exclude_config.map(&Regexp.public_method(:new))
+          Regexp.union(patterns)
+        else
+          DEFAULT_CONFIGURATION
+            .fetch(department_name)
+            .fetch('Exclude')
+            .map(&Regexp.public_method(:new))
+        end
+      end
+
+      def department_exclude_config?
+        return false unless all_cops_config.key?('SketchUp')
+        sketchup_config = all_cops_config.fetch('SketchUp')
+        return false unless sketchup_config.key?(department_name)
+        sketchup_config.fetch(department_name).key?('Exclude')
+      end
+
+      def department_exclude_config
+        sketchup_cops_config
+          .fetch(department_name)
+          .fetch('Exclude')
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/add_separator_to_menu.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      class AddSeparatorToMenu < Cop
+      class AddSeparatorToMenu < SketchUp::Cop
 
         MSG = 'Method is deprecated.'.freeze
 

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/operation_next_transparent.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module SketchupDeprecations
       # Weak warning. (Question?)
-      class OperationNextTransparent < Cop
+      class OperationNextTransparent < SketchUp::Cop
         MSG = 'Third argument is deprecated.'.freeze
 
         def on_send(node)

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/require_all.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      class RequireAll < Cop
+      class RequireAll < SketchUp::Cop
 
         MSG = 'Method is deprecated because it adds the given path to $LOAD_PATH.'.freeze
 

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/set_texture_projection.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      class SetTextureProjection < Cop
+      class SetTextureProjection < SketchUp::Cop
 
         MSG = 'Method is deprecated. It creates invalid UV mapping.'.freeze
 

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/show_ruby_panel.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      class ShowRubyPanel < Cop
+      class ShowRubyPanel < SketchUp::Cop
 
         MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.'.freeze
 

data/lib/rubocop/sketchup/{deprecations → cop/deprecations}/sketchup_set.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      class SketchupSet < Cop
+      class SketchupSet < SketchUp::Cop
 
         MSG = 'Class is deprecated.'.freeze
 

data/lib/rubocop/sketchup/{performance → cop/performance}/openssl.rb

@@ -13,7 +13,7 @@ module RuboCop
       # `SecureRandom` is  also affected by this, as it uses OpenSSL to seed.
       #
       # It also affects Net::HTTP if making HTTPS connections.
-      class OpenSSL < Cop
+      class OpenSSL < SketchUp::Cop
 
         MSG = 'Avoid use of OpenSSL within SketchUp due to severe performance issues.'.freeze
 

data/lib/rubocop/sketchup/{performance → cop/performance}/operation_disable_ui.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module SketchupPerformance
       # Weak warning. (Question?)
-      class OperationDisableUI < Cop
+      class OperationDisableUI < SketchUp::Cop
         MSG = 'Operations should disable the UI for performance gain.'.freeze
 
         def on_send(node)

data/lib/rubocop/sketchup/{performance → cop/performance}/selection_bulk.rb

@@ -23,7 +23,7 @@ module RuboCop
       #   model = Sketchup.active_model
       #   faces = model.active_entities.grep(Sketchup::Face)
       #   model.selection.add(faces)
-      class SelectionBulkChanges < Cop
+      class SelectionBulkChanges < SketchUp::Cop
         MSG = 'Avoid modifying selecting within loops.'.freeze
 
         # http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern

data/lib/rubocop/sketchup/{performance → cop/performance}/typename.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupPerformance
-      class Typename < Cop
+      class Typename < SketchUp::Cop
         MSG = '`.typename` is very slow, prefer `.is_a?` instead.'.freeze
 
         def on_send(node)

data/lib/rubocop/sketchup/{requirements → cop/requirements}/api_namespace.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class ApiNamespace < Cop
+      class ApiNamespace < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::NamespaceChecker

data/lib/rubocop/sketchup/{requirements → cop/requirements}/exit.rb

@@ -8,7 +8,7 @@ module RuboCop
       # console. But `exit!` is not trapped and with terminate SketchUp without
       # shutting down cleanly.
       # Use `return`, `next` or `break` instead.
-      class Exit < Cop
+      class Exit < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
 

data/lib/rubocop/sketchup/{requirements → cop/requirements}/extension_namespace.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require 'rubocop/sketchup/requirements/api_namespace'
-require 'rubocop/sketchup/requirements/ruby_core_namespace'
-require 'rubocop/sketchup/requirements/ruby_stdlib_namespace'
+require 'rubocop/sketchup/cop/requirements/api_namespace'
+require 'rubocop/sketchup/cop/requirements/ruby_core_namespace'
+require 'rubocop/sketchup/cop/requirements/ruby_stdlib_namespace'
 
 module RuboCop
   module Cop
     module SketchupRequirements
-      class ExtensionNamespace < Cop
+      class ExtensionNamespace < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp

data/lib/rubocop/sketchup/{requirements → cop/requirements}/file_structure.rb

@@ -5,7 +5,7 @@ module RuboCop
     module SketchupRequirements
       # Check that the extension conform to expected file structure with a
       # single root .rb file and a support folder with matching name.
-      class FileStructure < Cop
+      class FileStructure < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::ExtensionProject

data/lib/rubocop/sketchup/{requirements → cop/requirements}/global_constants.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class GlobalConstants < Cop
+      class GlobalConstants < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp

data/lib/rubocop/sketchup/{requirements → cop/requirements}/global_include.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class GlobalInclude < Cop
+      class GlobalInclude < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp

data/lib/rubocop/sketchup/{requirements → cop/requirements}/global_methods.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class GlobalMethods < Cop
+      class GlobalMethods < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp

data/lib/rubocop/sketchup/{requirements → cop/requirements}/global_variables.rb

@@ -9,7 +9,7 @@ module RuboCop
       # users can allow additional variables via the AllowedVariables option.
       #
       # Note that backreferences like $1, $2, etc are not global variables.
-      class GlobalVariables < Cop
+      class GlobalVariables < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::DynamicComponentGlobals

data/lib/rubocop/sketchup/{requirements → cop/requirements}/language_handler_globals.rb

@@ -6,7 +6,7 @@ module RuboCop
       # Avoid using globals in general, but  especially these which are known to
       # be in use by other extensions made by SketchUp.
       # They are still in use due to compatibility reasons.
-      class LanguageHandlerGlobals < Cop
+      class LanguageHandlerGlobals < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
 

data/lib/rubocop/sketchup/{requirements → cop/requirements}/load_path.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class LoadPath < Cop
+      class LoadPath < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
 

data/lib/rubocop/sketchup/{requirements → cop/requirements}/minimal_registration.rb

@@ -7,7 +7,7 @@ module RuboCop
     module SketchupRequirements
       # Don't load extension files in the root file registering the extension.
       # Extensions should not load additional files when it's disabled.
-      class MinimalRegistration < Cop
+      class MinimalRegistration < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::ExtensionProject
@@ -16,9 +16,10 @@ module RuboCop
 
         # Reference: http://rubocop.readthedocs.io/en/latest/node_pattern/
         def_node_matcher :require_filename, <<-PATTERN
-          (send
-            {(const nil? :Sketchup) nil?} :require
-            (str $_))
+          {
+            (send {(const nil? :Sketchup) nil?} {:require :load} (str $_))
+            (send nil? :require_relative (str $_))
+          }
         PATTERN
 
         def investigate(processed_source)

data/lib/rubocop/sketchup/{requirements → cop/requirements}/observers_start_operation.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class ObserversStartOperation < Cop
+      class ObserversStartOperation < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include RangeHelp

data/lib/rubocop/sketchup/{requirements → cop/requirements}/register_extension.rb

@@ -5,7 +5,7 @@ module RuboCop
     module SketchupRequirements
       # Always register extensions to load by default. Otherwise it might
       # confuse users to think the extension isn't working.
-      class RegisterExtension < Cop
+      class RegisterExtension < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
 

data/lib/rubocop/sketchup/{requirements → cop/requirements}/ruby_core_namespace.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class RubyCoreNamespace < Cop
+      class RubyCoreNamespace < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::NamespaceChecker

data/lib/rubocop/sketchup/{requirements → cop/requirements}/ruby_stdlib_namespace.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupRequirements
-      class RubyStdLibNamespace < Cop
+      class RubyStdLibNamespace < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::NamespaceChecker

data/lib/rubocop/sketchup/{requirements → cop/requirements}/shipped_extensions_namespace.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module SketchupRequirements
       # Don't modify SketchUp's shipped extensions.
-      class ShippedExtensionsNamespace < Cop
+      class ShippedExtensionsNamespace < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::NamespaceChecker

data/lib/rubocop/sketchup/{requirements → cop/requirements}/sketchup_extension.rb

@@ -5,7 +5,7 @@ module RuboCop
     module SketchupRequirements
       # Register a single instance of SketchupExtension per extension.
       # This should be done by the root .rb file in the extension package.
-      class SketchupExtension < Cop
+      class SketchupExtension < SketchUp::Cop
 
         include SketchUp::NoCommentDisable
         include SketchUp::ExtensionProject

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/compatibility.rb

@@ -3,9 +3,8 @@
 module RuboCop
   module Cop
     module SketchupSuggestions
-      class Compatibility < Cop
+      class Compatibility < SketchUp::Cop
 
-        include SketchUp::Config
         include SketchUp::Features
 
         MSG = "Incompatible feature with target SketchUp version".freeze

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/dc_internals.rb

@@ -5,7 +5,7 @@ module RuboCop
     module SketchupSuggestions
       # Tapping into the internals of Dynamic Components is risky. It could
       # change at any time.
-      class DynamicComponentInternals < Cop
+      class DynamicComponentInternals < SketchUp::Cop
 
         include SketchUp::DynamicComponentGlobals
 

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/file_encoding.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   file = __FILE__.dup
       #   file.force_encoding('UTF-8') if file.respond_to?(:force_encoding)
       #   basename = File.basename(file, '.*')
-      class FileEncoding < Cop
+      class FileEncoding < SketchUp::Cop
 
         MSG = 'Beware encoding bug with `__FILE__` and `__dir__`.'.freeze
 

data/lib/rubocop/sketchup/cop/suggestions/model_entities.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupSuggestions
+      class ModelEntities < SketchUp::Cop
+
+        MSG = 'Typically one should use model.active_entities instead of model.entities.'.freeze
+
+        # Reference: http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
+        def_node_matcher :active_model_entities?, <<-PATTERN
+          (send
+            (send (const nil? :Sketchup) :active_model) :entities)
+        PATTERN
+
+        def_node_matcher :entities_receiver, <<-PATTERN
+          (send
+            ({lvar ivar cvar} $_) :entities)
+        PATTERN
+
+        MODEL_VARIABLE_NAMES = %w[model mod]
+
+        def model_entities?(node)
+          return true if active_model_entities?(node)
+          name = entities_receiver(node)
+          name && model_variable?(name)
+        end
+
+        def on_send(node)
+          add_offense(node, location: :expression) if model_entities?(node)
+        end
+
+        private
+
+        def model_variable?(name)
+          basename = variable_basename(name)
+          MODEL_VARIABLE_NAMES.include?(basename)
+        end
+
+        def variable_basename(name)
+          # Extract the basename from variables:
+          #  model => model
+          #  @model => model
+          #  @@model => model
+          name.to_s.tr('@', '')
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/monkey_patched_api.rb

@@ -8,7 +8,7 @@ module RuboCop
       # before the extension best-practices were established. These functions
       # might change or be removed at any time. They will also not work when
       # the extensions are disabled. Avoid using these methods.
-      class MonkeyPatchedApi < Cop
+      class MonkeyPatchedApi < SketchUp::Cop
 
         include SketchUp::DynamicComponentMethods
 

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/operation_name.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module SketchupSuggestions
-      class OperationName < Cop
+      class OperationName < SketchUp::Cop
 
         include RangeHelp
 

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/sketchup_find_support_file.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module SketchupSuggestions
       # Avoid Sketchup.find_support_file to find your extension's files.
-      class SketchupFindSupportFile < Cop
+      class SketchupFindSupportFile < SketchUp::Cop
 
         MSG = "Avoid Sketchup.find_support_file to find your extension's files.".freeze
 

data/lib/rubocop/sketchup/{suggestions → cop/suggestions}/sketchup_require.rb

@@ -5,7 +5,7 @@ module RuboCop
     module SketchupSuggestions
       # Omit file extensions when using Sketchup.require to allow encrypted
       # files to be loaded.
-      class SketchupRequire < Cop
+      class SketchupRequire < SketchUp::Cop
 
         MSG = "Don't hard code file extensions with Sketchup.require".freeze
 
@@ -41,6 +41,9 @@ module RuboCop
         PATTERN
 
 
+        TOOLS_RUBY_FILES = %w[extensions.rb langhandler.rb sketchup.rb]
+
+
         def on_send(node)
           if sketchup_require?(node)
             filename = sketchup_require(node)
@@ -55,7 +58,7 @@ module RuboCop
         private
 
         def valid_filename?(filename)
-          File.extname(filename).empty?
+          File.extname(filename).empty? || TOOLS_RUBY_FILES.include?(filename)
         end
 
       end

data/lib/rubocop/sketchup/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module SketchUp
-    VERSION = '0.3.0'
+    VERSION = '0.3.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-26 00:00:00.000000000 Z
+date: 2018-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -49,14 +49,44 @@ files:
 - lib/rubocop-sketchup.rb
 - lib/rubocop/sketchup.rb
 - lib/rubocop/sketchup/config.rb
+- lib/rubocop/sketchup/cop.rb
+- lib/rubocop/sketchup/cop/deprecations/add_separator_to_menu.rb
+- lib/rubocop/sketchup/cop/deprecations/operation_next_transparent.rb
+- lib/rubocop/sketchup/cop/deprecations/require_all.rb
+- lib/rubocop/sketchup/cop/deprecations/set_texture_projection.rb
+- lib/rubocop/sketchup/cop/deprecations/show_ruby_panel.rb
+- lib/rubocop/sketchup/cop/deprecations/sketchup_set.rb
+- lib/rubocop/sketchup/cop/performance/openssl.rb
+- lib/rubocop/sketchup/cop/performance/operation_disable_ui.rb
+- lib/rubocop/sketchup/cop/performance/selection_bulk.rb
+- lib/rubocop/sketchup/cop/performance/typename.rb
+- lib/rubocop/sketchup/cop/requirements/api_namespace.rb
+- lib/rubocop/sketchup/cop/requirements/exit.rb
+- lib/rubocop/sketchup/cop/requirements/extension_namespace.rb
+- lib/rubocop/sketchup/cop/requirements/file_structure.rb
+- lib/rubocop/sketchup/cop/requirements/global_constants.rb
+- lib/rubocop/sketchup/cop/requirements/global_include.rb
+- lib/rubocop/sketchup/cop/requirements/global_methods.rb
+- lib/rubocop/sketchup/cop/requirements/global_variables.rb
+- lib/rubocop/sketchup/cop/requirements/language_handler_globals.rb
+- lib/rubocop/sketchup/cop/requirements/load_path.rb
+- lib/rubocop/sketchup/cop/requirements/minimal_registration.rb
+- lib/rubocop/sketchup/cop/requirements/observers_start_operation.rb
+- lib/rubocop/sketchup/cop/requirements/register_extension.rb
+- lib/rubocop/sketchup/cop/requirements/ruby_core_namespace.rb
+- lib/rubocop/sketchup/cop/requirements/ruby_stdlib_namespace.rb
+- lib/rubocop/sketchup/cop/requirements/shipped_extensions_namespace.rb
+- lib/rubocop/sketchup/cop/requirements/sketchup_extension.rb
+- lib/rubocop/sketchup/cop/suggestions/compatibility.rb
+- lib/rubocop/sketchup/cop/suggestions/dc_internals.rb
+- lib/rubocop/sketchup/cop/suggestions/file_encoding.rb
+- lib/rubocop/sketchup/cop/suggestions/model_entities.rb
+- lib/rubocop/sketchup/cop/suggestions/monkey_patched_api.rb
+- lib/rubocop/sketchup/cop/suggestions/operation_name.rb
+- lib/rubocop/sketchup/cop/suggestions/sketchup_find_support_file.rb
+- lib/rubocop/sketchup/cop/suggestions/sketchup_require.rb
 - lib/rubocop/sketchup/dc_globals.rb
 - lib/rubocop/sketchup/dc_methods.rb
-- lib/rubocop/sketchup/deprecations/add_separator_to_menu.rb
-- lib/rubocop/sketchup/deprecations/operation_next_transparent.rb
-- lib/rubocop/sketchup/deprecations/require_all.rb
-- lib/rubocop/sketchup/deprecations/set_texture_projection.rb
-- lib/rubocop/sketchup/deprecations/show_ruby_panel.rb
-- lib/rubocop/sketchup/deprecations/sketchup_set.rb
 - lib/rubocop/sketchup/extension_project.rb
 - lib/rubocop/sketchup/features.rb
 - lib/rubocop/sketchup/formatter/extension_review.rb
@@ -64,36 +94,7 @@ files:
 - lib/rubocop/sketchup/namespace.rb
 - lib/rubocop/sketchup/namespace_checker.rb
 - lib/rubocop/sketchup/no_comment_disable.rb
-- lib/rubocop/sketchup/performance/openssl.rb
-- lib/rubocop/sketchup/performance/operation_disable_ui.rb
-- lib/rubocop/sketchup/performance/selection_bulk.rb
-- lib/rubocop/sketchup/performance/typename.rb
-- lib/rubocop/sketchup/requirements/api_namespace.rb
-- lib/rubocop/sketchup/requirements/exit.rb
-- lib/rubocop/sketchup/requirements/extension_namespace.rb
-- lib/rubocop/sketchup/requirements/file_structure.rb
-- lib/rubocop/sketchup/requirements/global_constants.rb
-- lib/rubocop/sketchup/requirements/global_include.rb
-- lib/rubocop/sketchup/requirements/global_methods.rb
-- lib/rubocop/sketchup/requirements/global_variables.rb
-- lib/rubocop/sketchup/requirements/language_handler_globals.rb
-- lib/rubocop/sketchup/requirements/load_path.rb
-- lib/rubocop/sketchup/requirements/minimal_registration.rb
-- lib/rubocop/sketchup/requirements/observers_start_operation.rb
-- lib/rubocop/sketchup/requirements/register_extension.rb
-- lib/rubocop/sketchup/requirements/ruby_core_namespace.rb
-- lib/rubocop/sketchup/requirements/ruby_stdlib_namespace.rb
-- lib/rubocop/sketchup/requirements/shipped_extensions_namespace.rb
-- lib/rubocop/sketchup/requirements/sketchup_extension.rb
 - lib/rubocop/sketchup/sketchup_version.rb
-- lib/rubocop/sketchup/suggestions/compatibility.rb
-- lib/rubocop/sketchup/suggestions/dc_internals.rb
-- lib/rubocop/sketchup/suggestions/file_encoding.rb
-- lib/rubocop/sketchup/suggestions/model_entities.rb
-- lib/rubocop/sketchup/suggestions/monkey_patched_api.rb
-- lib/rubocop/sketchup/suggestions/operation_name.rb
-- lib/rubocop/sketchup/suggestions/sketchup_find_support_file.rb
-- lib/rubocop/sketchup/suggestions/sketchup_require.rb
 - lib/rubocop/sketchup/version.rb
 - rubocop-sketchup.gemspec
 homepage: http://github.com/sketchup/rubocop-sketchup
@@ -116,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: RuboCop rules for SketchUp extensions.

data/lib/rubocop/sketchup/suggestions/model_entities.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupSuggestions
-      class ModelEntities < Cop
-
-        MSG = 'Typically one should use model.active_entities instead of model.entities.'.freeze
-
-        # Reference: http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
-        #
-        # {} will match any of the patterns inside the brackets.
-        #
-        # Testing for; Sketchup.active_model
-        #   (send (const nil :Sketchup) :active_model)
-        #
-        # Testing for; model.entities or mod.entities
-        #   (lvar {:model :mod})
-        def_node_matcher :model_entities?, <<-PATTERN
-          (send
-            {
-              (send (const nil? :Sketchup) :active_model)
-              (lvar {:model :mod})
-            }
-            :entities)
-        PATTERN
-
-        def on_send(node)
-          add_offense(node, location: :expression) if model_entities?(node)
-        end
-      end
-    end
-  end
-end