rubocop-sketchup 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d7b803688f7c17a0b11ab8b6ac5452d1a4fa925
-  data.tar.gz: 3b0c7b2667761ea2d5a298f9906aeb5c0dd90c93
+  metadata.gz: 2641cf07a13c7fa7c33f484a10bcfcb22f8daa4f
+  data.tar.gz: a235e082f106d088b245768d5f639d503b75a4db
 SHA512:
-  metadata.gz: bb8900616392157c20a242834e96163a94aa73a98179679e518b4882297b9875916431383e90ff2883fe109de663783b78d6d274f6f3be338575c2cf83986396
-  data.tar.gz: 0ac20236f7f5e6046dd072ae3722861f3e008709fa9e4e39b5b9f93036124710718c8bfb170df2c8c5a73ecad9f949dc6b7efcbf455214eee1dc4d3138f3c880
+  metadata.gz: 55caaf069752bc471b957b034b7c62702639be84596f21745a21ecd4e06b66bc5091ffdf13c30fd72aa9144f70bc53affecf8b410f904496a7b483908fcd230c
+  data.tar.gz: 96327fe0f81942432a3bf4895e4256f69d9b7ba978e3c98c9087bf356cec06788498633f72ac54c78957a27c0d5bd8ce40ce46f4ca5d5d2e73868a30d3c22d67

data/config/default.yml

@@ -3,6 +3,13 @@ AllCops:
   SketchUp:
     SourcePath: src
 
+SketchupDeprecations/AddSeparatorToMenu:
+  Description: The method `add_separator_to_menu` is deprecated.
+  Details: >-
+              Avoid adding separators to top level menus. If you require
+              grouping use a sub-menu instead.
+  Enabled: true
+
 SketchupDeprecations/OperationNextTransparent:
   Description: Third argument in `model.start_operation` is deprecated.
   Details: >-
@@ -10,6 +17,33 @@ SketchupDeprecations/OperationNextTransparent:
               making the next operation transparent.
   Enabled: true
 
+SketchupDeprecations/RequireAll:
+  Description: The method `require_all` is deprecated.
+  Details: >-
+              This method adds the path given to `$LOAD_PATH` which can affect
+              other extensions.
+  Enabled: true
+
+SketchupDeprecations/SetTextureProjection:
+  Description: The method `Sketchup::Face#set_texture_projection` is deprecated.
+  Details: >-
+              This method never worked right. It's not possible to control the
+              position and orientation of the texture.
+  Enabled: true
+
+SketchupDeprecations/ShowRubyPanel:
+  Description: The method `show_ruby_panel` is deprecated.
+  Details: >-
+              Use `SKETCHUP_CONSOLE.show` instead.
+  Enabled: true
+
+SketchupDeprecations/SketchupSet:
+  Description: The class `Sketchup::Set` is deprecated.
+  Details: >-
+              It's slow and with limited functionality. Use the `Set` class in
+              the Ruby StdLib instead.
+  Enabled: true
+
 SketchupPerformance/OpenSSL:
   Description: Avoid using Ruby's OpenSSL within SketchUp.
   Details: >-

data/lib/rubocop/sketchup/deprecations/add_separator_to_menu.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      class AddSeparatorToMenu < Cop
+
+        MSG = 'Method is deprecated.'.freeze
+
+        def_node_matcher :add_separator_to_menu?, <<-PATTERN
+          (send nil? :add_separator_to_menu _)
+        PATTERN
+
+        def on_send(node)
+          return unless add_separator_to_menu?(node)
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/deprecations/require_all.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      class RequireAll < Cop
+
+        MSG = 'Method is deprecated because it adds the given path to $LOAD_PATH.'.freeze
+
+        def_node_matcher :require_all?, <<-PATTERN
+          (send nil? :require_all _)
+        PATTERN
+
+        def on_send(node)
+          return unless require_all?(node)
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/deprecations/set_texture_projection.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      class SetTextureProjection < Cop
+
+        MSG = 'Method is deprecated. It creates invalid UV mapping.'.freeze
+
+        def_node_matcher :set_texture_projection?, <<-PATTERN
+          (send _ :set_texture_projection ...)
+        PATTERN
+
+        def on_send(node)
+          return unless set_texture_projection?(node)
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/deprecations/show_ruby_panel.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      class ShowRubyPanel < Cop
+
+        MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.'.freeze
+
+        def_node_matcher :show_ruby_panel?, <<-PATTERN
+          (send nil? :show_ruby_panel)
+        PATTERN
+
+        def on_send(node)
+          return unless show_ruby_panel?(node)
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/deprecations/sketchup_set.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupDeprecations
+      class SketchupSet < Cop
+
+        MSG = 'Class is deprecated.'.freeze
+
+        def_node_matcher :sketchup_set?, <<-PATTERN
+          (const (const nil? :Sketchup) :Set)
+        PATTERN
+
+        def on_const(node)
+          return unless sketchup_set?(node)
+          add_offense(node, location: :expression)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module SketchUp
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-02 00:00:00.000000000 Z
+date: 2018-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -50,7 +50,12 @@ files:
 - lib/rubocop/sketchup.rb
 - lib/rubocop/sketchup/config.rb
 - lib/rubocop/sketchup/dc_globals.rb
+- lib/rubocop/sketchup/deprecations/add_separator_to_menu.rb
 - lib/rubocop/sketchup/deprecations/operation_next_transparent.rb
+- lib/rubocop/sketchup/deprecations/require_all.rb
+- lib/rubocop/sketchup/deprecations/set_texture_projection.rb
+- lib/rubocop/sketchup/deprecations/show_ruby_panel.rb
+- lib/rubocop/sketchup/deprecations/sketchup_set.rb
 - lib/rubocop/sketchup/extension_project.rb
 - lib/rubocop/sketchup/formatter/extension_review.rb
 - lib/rubocop/sketchup/inject.rb
@@ -72,7 +77,6 @@ files:
 - lib/rubocop/sketchup/requirements/load_path.rb
 - lib/rubocop/sketchup/requirements/minimal_registration.rb
 - lib/rubocop/sketchup/requirements/register_extension.rb
-- lib/rubocop/sketchup/requirements/require_tools_ruby_files.rb
 - lib/rubocop/sketchup/requirements/ruby_core_namespace.rb
 - lib/rubocop/sketchup/requirements/ruby_stdlib_namespace.rb
 - lib/rubocop/sketchup/requirements/shipped_extensions_namespace.rb

data/lib/rubocop/sketchup/requirements/require_tools_ruby_files.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # Due to how require and Sketchup.require checks whether a file has been
-      # loaded, files from SketchUp's Tools folder should be required in using
-      # `require` and with their file extension to avoid duplicate loading.
-      class RequireToolsRubyFiles < Cop
-
-        include SketchUp::NoCommentDisable
-
-        MSG = "Require files from SketchUp's Tools directory with require.".freeze
-
-        RUBY_FILES = %w[extensions.rb langhandler.rb sketchup.rb]
-
-
-        def_node_matcher :ruby_require, <<-PATTERN
-          (send nil? :require (str $_))
-        PATTERN
-
-        def_node_matcher :ruby_require?, <<-PATTERN
-          (send nil? :require (str _))
-        PATTERN
-
-
-        def_node_matcher :sketchup_require, <<-PATTERN
-          (send
-            (const nil? :Sketchup) :require
-            (str $_)
-          )
-        PATTERN
-
-        def_node_matcher :sketchup_require?, <<-PATTERN
-          (send
-            (const nil? :Sketchup) :require
-            (str _)
-          )
-        PATTERN
-
-
-        def on_send(node)
-          if ruby_require?(node)
-            # The Tools folder Ruby files should be loaded using `require` and
-            # include the ".rb" file extension.
-            filename = ruby_require(node)
-            return unless tools_file_required?(filename)
-            return if expected_require_syntax?(filename)
-            add_offense(node, location: :expression, severity: :error)
-          elsif sketchup_require?(node)
-            # The Tools folder Ruby files should not be loaded using
-            # `Sketchup.require`.
-            filename = sketchup_require(node)
-            return unless tools_file_required?(filename)
-            add_offense(node, location: :expression, severity: :error)
-          end
-        end
-
-        private
-
-        def tools_file_required?(filename)
-          ext = File.extname(filename)
-          full_filename = ext.empty? ? "#{filename}.rb" : filename
-          RUBY_FILES.include?(full_filename.downcase)
-        end
-
-        def expected_require_syntax?(filename)
-          RUBY_FILES.include?(filename)
-        end
-
-      end
-    end
-  end
-end