rubocop-sequel 0.3.7 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4023b536f86132312aefef7c17bbef5f85b3036bb0a1ac61fb8b53a532afbc19
-  data.tar.gz: 2a317cc181637b43163e3757e11235298ff49d3bf2a8cb284a1a30302623432a
+  metadata.gz: 43689260646cb1428cd6629924d01648a005939d8f1094a6fcbb88ecc1a7fc68
+  data.tar.gz: b95f6400f9d2857ac7ce9d32c8931a71db14ba6e8cd86e128289fe1ef836d95b
 SHA512:
-  metadata.gz: 9992c88db3726a7ffa555f3a978f3985245d4cf606fecf5710a02e850b04325849c9b48c11c86e7e80d3a4c24efcc909399d77181e51ad0e51db2f5aff0ffc8b
-  data.tar.gz: a195f6dab7e9bcec0e129cb1cee6f9cacfccde5db0ef7e99d5e7d7960e71442add297face4f04b72d874e7b328aa0262b03ad1be09e75ccab514fe5fd57c2ac8
+  metadata.gz: a78387c550cc09564f2fffee05a5dda77c370130dd41f9c8b8a0f8bb26683813b97c1c2540250574c95ae7a192743d1873f59b82cdf02de501ff1d679a029bb5
+  data.tar.gz: 2e91b8df57f918c221d2d2319037264d347b84eaa082ed6f378d85f5023f9b6bcf19a5b2854553cc56707e986551c9bf5dd2ff1f17aaa1e04a3e5bd7c94221a9

data/config/default.yml

@@ -17,7 +17,7 @@ Sequel/IrreversibleMigration:
   Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/IrreversibleMigration
   Enabled: true
   VersionAdded: 0.3.5
-  VersionChanged: 0.3.7
+  VersionChanged: 0.3.8
 
 Sequel/JSONColumn:
   Description: >-

data/lib/rubocop/cop/sequel/irreversible_migration.rb

@@ -28,7 +28,7 @@ module RuboCop
           set_column_allow_null
         ].freeze
 
-        MSG = 'Avoid using "%<name>s" inside a "change" block. Use "up" & "down" blocks instead.'
+        MSG = 'Using "%<name>s" inside a "change" block may cause an irreversible migration. Use "up" & "down" instead.'
         PRIMARY_KEY_MSG = 'Avoid using "add_primary_key" with an array argument inside a "change" block.'
 
         def on_block(node)
@@ -46,6 +46,8 @@ module RuboCop
         def validate_node(node)
           return if within_create_table_block?(node)
 
+          return if part_of_method_call?(node)
+
           add_offense(node.loc.selector, message: format(MSG, name: node.method_name)) unless valid_change_method?(node)
 
           add_offense(node.loc.selector, message: PRIMARY_KEY_MSG) if invalid_primary_key_method?(node)
@@ -68,6 +70,10 @@ module RuboCop
             ancestor.method_name == :create_table
           end
         end
+
+        def part_of_method_call?(node)
+          node.each_ancestor(:send).count.positive?
+        end
       end
     end
   end

data/lib/rubocop/sequel/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Sequel
     # This module holds the RuboCop Sequel version information.
     module Version
-      STRING = '0.3.7'
+      STRING = '0.3.8'
     end
   end
 end

data/rubocop-sequel.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.3.7'
+  gem.version       = '0.3.8'
   gem.metadata['rubygems_mfa_required'] = 'true'
 
   gem.required_ruby_version = '>= 2.5'

data/spec/rubocop/cop/sequel/irreversible_migration_spec.rb

@@ -103,6 +103,52 @@ RSpec.describe RuboCop::Cop::Sequel::IrreversibleMigration do
         expect(offenses.size).to eq(1)
       end
     end
+
+    describe 'and a method is used within an argument' do
+      let(:source) do
+        <<~SOURCE
+          change do
+            alter_table(:stores) do
+              add_column(:products, JSON, null: false, default: Sequel.pg_json({}))
+              add_constraint(
+                :only_one_user,
+                (
+                  Sequel.cast(Sequel.~(user_id: nil), Integer) +
+                  Sequel.cast(Sequel.~(owner_id: nil), Integer)
+                ) => 1,
+              )
+            end
+          end
+        SOURCE
+      end
+
+      it 'does not register an offense with valid methods' do
+        offenses = inspect_source_within_migration(source)
+        expect(offenses).to be_empty
+      end
+    end
+
+    describe 'and an invalid change method contains another invalid change method as an argument' do
+      let(:source) do
+        <<~SOURCE
+          change do
+            alter_table(:stores) do
+              drop_column(:products, JSON, null: false, default: Sequel.pg_json({}))
+            end
+          end
+        SOURCE
+      end
+
+      it 'only registers 1 offense' do
+        offenses = inspect_source_within_migration(source)
+        expect(offenses.size).to eq(1)
+      end
+
+      it 'only registers an offense for the parent method' do
+        offenses = inspect_source_within_migration(source)
+        expect(offenses.first.message).to include('drop_column')
+      end
+    end
   end
 
   context 'when inside an up block' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
 platform: ruby
 authors:
 - Timothée Peignier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-11-05 00:00:00.000000000 Z
+date: 2024-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop