rubocop-sequel 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9946d5d75823d8bf843b76fcf363080f6fe7b89898a5cd83fda2c2474f75e188
-  data.tar.gz: ca925b88e4778ae0a255f24d3ab03c1802989d64943b3b74128c305fb99405d5
+  metadata.gz: af5f93d560c9a6dcb0216440641d3b108a466f5f536d296f1602ab9e38cc9d9e
+  data.tar.gz: e76e3f9bc6f6a768d500955c88e94b2b05c70486e6978317542cbf7d808e6e5b
 SHA512:
-  metadata.gz: f68ad1bd6c68025ed7d974e4d68f900583bfa9e7136247be140930a9d40a5c6a22c6be9a671c6f3042d6a0ce3655c9932405c0d4ce0900a1e4a9d991f425aff0
-  data.tar.gz: 7f020ea08ebc0f993e4809ff47c240663ca4b0d4854fafb28773fc25d16f210cabf435e194ee3c2d4bf7dd5acc7c1bc2a3364de7ca0501bc2f412d7383bbbac4
+  metadata.gz: d7eb9f7f0c40b0ad3cf542fabd76d3ab506505e0d4f40cf831b6de91719186b57750e13036a600b303928cbc28ebf5d2dfec68802c692b9b3580b8943821ad2d
+  data.tar.gz: 5cd74af9570a31c507b45fe5258234e2204cb112bbb7fb051f5531d8e08ffcfd1bdeb93d8757d9c8e77d37babc16e7e6b3dee2c3729631c205ea1cf5ef8b1d07

data/.github/dependabot.yml

@@ -4,3 +4,7 @@ updates:
     directory: /
     schedule:
       interval: "weekly"
+  - package-ecosystem: 'github-actions'
+    directory: '/'
+    schedule:
+      interval: 'weekly'

data/.github/workflows/actions.yml

@@ -1,6 +1,5 @@
 name: CI
 on: [push, pull_request]
-
 jobs:
   main:
     name: Ruby ${{ matrix.ruby }}
@@ -8,22 +7,18 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - 2.5
-          - 2.6
           - 2.7
           - 3.0
+          - 3.1
+          - 3.2
     steps:
-      - uses: actions/checkout@v2
-
+      - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-
       - name: Install gems
         run: bundle install
-
       - name: RuboCop
         run: bundle exec rubocop --parallel
-
       - name: RSpec
         run: bundle exec rspec

data/Gemfile

@@ -3,3 +3,10 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'rake', '~> 13.2.1'
+gem 'rspec', '~> 3.7'
+gem 'rubocop-rspec', '~> 2.0'
+gem 'sequel', '~> 5.47'
+gem 'simplecov', '~> 0.16'
+gem 'sqlite3', '~> 1.3', '>= 1.3.12'

data/config/default.yml

@@ -0,0 +1,54 @@
+# This is the default configuration file.
+
+Sequel:
+  Enabled: true
+  DocumentationBaseURL: https://github.com/rubocop/rubocop-sequel/blob/master/README.md
+
+Sequel/ConcurrentIndex:
+  Description: Encourages the creation of indexes with the `NOT VALID` option to avoid locking tables.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/ConcurrentIndex
+  Enabled: true
+  VersionAdded: 0.0.1
+  VersionChanged: 0.3.3
+
+Sequel/IrreversibleMigration:
+  Description: >-
+    Warns against using certain methods inside a migration file's `change` block that would cause the migration to become irreversible.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/IrreversibleMigration
+  Enabled: true
+  VersionAdded: 0.3.4
+  VersionChanged: 0.3.4
+
+Sequel/JSONColumn:
+  Description: >-
+    Advocates the use of the `jsonb` column type over `json` or `hstore` for performance
+    benefits and additional functionality.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/JSONColumn
+  Enabled: true
+  Safe: false
+  VersionAdded: 0.0.1
+  VersionChanged: 0.3.3
+
+Sequel/MigrationName:
+  Description: >-
+    Helps to name migration files descriptively in order to avoid the use of default or generic names.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/MigrationName
+  Enabled: true
+  VersionAdded: '0.0.1'
+  VersionChanged: '0.3.3'
+  DefaultName: new_migration
+
+Sequel/PartialConstraint:
+  Description: Advises on the correct use of partial indexes by specifying the `where' argument.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/PartialConstraint
+  Enabled: true
+  VersionAdded: '0.3.0'
+  VersionChanged: '0.3.3'
+
+Sequel/SaveChanges:
+  Description: Ensures the use of save_changes instead of save to persist changes to models.
+  Reference: https://www.rubydoc.info/gems/rubocop-sequel/RuboCop/Cop/Sequel/SaveChanges
+  Enabled: true
+  SafeAutoCorrect: false
+  VersionAdded: '0.0.1'
+  VersionChanged: '0.3.3'

data/config/obsoletion.yml

@@ -0,0 +1,14 @@
+#
+# Configuration for obsoletion.
+#
+# See: https://docs.rubocop.org/rubocop/extensions.html#config-obsoletions
+#
+extracted:
+  Sequel/*: ~
+
+removed:
+  Sequel/ColumnDefault:
+    reason: >-
+      ColumnDefault cop since it's mostly outdated advice.
+      Details [#33](https://github.com/rubocop/rubocop-sequel/issues/32)
+

data/lib/rubocop/cop/sequel/concurrent_index.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Sequel
       # ConcurrentIndex looks for non-concurrent index creation.
       class ConcurrentIndex < Base
-        MSG = 'Prefer creating or dropping new index concurrently'
+        MSG = 'Specify `concurrently` option when creating or dropping an index.'
         RESTRICT_ON_SEND = %i[add_index drop_index].freeze
 
         def_node_matcher :indexes?, <<-MATCHER

data/lib/rubocop/cop/sequel/irreversible_migration.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sequel
+      # IrreversibleMigration looks for methods inside a `change` block that cannot be reversed.
+      class IrreversibleMigration < Base
+        # https://sequel.jeremyevans.net/rdoc/files/doc/migration_rdoc.html#label-A+Basic+Migration
+        VALID_CHANGE_METHODS = %i[
+          create_table
+          create_join_table
+          create_view
+          add_column
+          add_index
+          rename_column
+          rename_table
+          alter_table
+          add_column
+          add_constraint
+          add_foreign_key
+          add_primary_key
+          add_index
+          add_full_text_index
+          add_spatial_index
+          rename_column
+          set_column_allow_null
+        ].freeze
+
+        MSG = 'Avoid using `%<name>s` inside a `change` block. Use `up` & `down` blocks instead.'
+        PRIMARY_KEY_MSG = 'Avoid using `add_primary_key` with an array argument inside a `change` block.'
+
+        def on_block(node)
+          return unless node.method_name == :change
+
+          body = node.body
+          return unless body
+
+          body.each_node(:send) { |child_node| validate_node(child_node) }
+        end
+
+        private
+
+        def validate_node(node)
+          name = node.method_name
+
+          add_offense(node.loc.selector, message: format(MSG, name: name)) unless VALID_CHANGE_METHODS.include?(name)
+
+          return unless name == :add_primary_key
+
+          return unless node.arguments.any?(&:array_type?)
+
+          add_offense(node.loc.selector, message: PRIMARY_KEY_MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sequel/save_changes.rb

@@ -7,8 +7,7 @@ module RuboCop
       class SaveChanges < Base
         extend AutoCorrector
 
-        MSG = 'Use `Sequel::Model#save_changes` instead of '\
-              '`Sequel::Model#save`.'
+        MSG = 'Use `Sequel::Model#save_changes` instead of `Sequel::Model#save`.'
         RESTRICT_ON_SEND = %i[save].freeze
 
         def_node_matcher :model_save?, <<-MATCHER

data/lib/rubocop/sequel/inject.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Sequel
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration.
+    module Inject
+      def self.defaults!
+        path = CONFIG_DEFAULT.to_s
+        hash = ConfigLoader.send(:load_yaml_configuration, path)
+        config = Config.new(hash, path).tap(&:make_excludes_absolute)
+        puts "configuration from #{path}" if ConfigLoader.debug?
+        config = ConfigLoader.merge_with_default(config, path, unset_nil: false)
+        ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

data/lib/rubocop/sequel/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Sequel
     # This module holds the RuboCop Sequel version information.
     module Version
-      STRING = '0.3.4'
+      STRING = '0.3.5'
     end
   end
 end

data/lib/rubocop/sequel.rb

@@ -3,5 +3,14 @@
 module RuboCop
   # RuboCop Sequel project namespace
   module Sequel
+    PROJECT_ROOT = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+    CONFIG = YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
+
+    if ::RuboCop.const_defined?(:ConfigObsoletion)
+      ::RuboCop::ConfigObsoletion.files << PROJECT_ROOT.join('config', 'obsoletion.yml')
+    end
   end
 end

data/lib/rubocop-sequel.rb

@@ -1,10 +1,14 @@
 # frozen_string_literal: true
 
 require 'rubocop'
-
+require 'rubocop/sequel'
 require 'rubocop/sequel/version'
-require 'rubocop/cop/sequel/column_default'
+require 'rubocop/sequel/inject'
+
+RuboCop::Sequel::Inject.defaults!
+
 require 'rubocop/cop/sequel/concurrent_index'
+require 'rubocop/cop/sequel/irreversible_migration'
 require 'rubocop/cop/sequel/json_column'
 require 'rubocop/cop/sequel/migration_name'
 require 'rubocop/cop/sequel/save_changes'

data/rubocop-sequel.gemspec

@@ -12,18 +12,10 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.3.4'
+  gem.version       = '0.3.5'
   gem.metadata['rubygems_mfa_required'] = 'true'
 
   gem.required_ruby_version = '>= 2.5'
 
-  gem.add_runtime_dependency 'rubocop', '~> 1.0'
-
-  gem.add_development_dependency 'rake', '~> 13.0.6'
-  gem.add_development_dependency 'rspec', '~> 3.7'
-  gem.add_development_dependency 'rubocop-rake', '~> 0.6.0'
-  gem.add_development_dependency 'rubocop-rspec', '~> 2.0'
-  gem.add_development_dependency 'sequel', '~> 5.47'
-  gem.add_development_dependency 'simplecov', '~> 0.16'
-  gem.add_development_dependency 'sqlite3', '~> 1.3', '>= 1.3.12'
+  gem.add_dependency 'rubocop', '~> 1.0'
 end

data/spec/project_spec.rb

@@ -0,0 +1,111 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'config/default.yml', type: :feature do
+  subject(:config) { RuboCop::ConfigLoader.load_file('config/default.yml') }
+
+  let(:configuration_keys) { config.tap { |c| c.delete('inherit_mode') }.keys }
+  let(:version_regexp) { /\A\d+\.\d+(?:\.\d+)?\z|\A<<next>>\z/ }
+
+  shared_examples 'has a nicely formatted description' do |cop_name|
+    it 'does not contain new lines' do
+      description = config.dig(cop_name, 'Description')
+
+      expect(description.include?("\n")).to be(false)
+    end
+
+    it 'stars from a verb' do # rubocop:disable RSpec/ExampleLength
+      description = config.dig(cop_name, 'Description')
+      start_with_subject = description.match(/\AThis cop (?<verb>.+?) .*/)
+      suggestion = start_with_subject[:verb]&.capitalize if start_with_subject
+      suggestion ||= 'a verb'
+
+      expect(start_with_subject).to(
+        be_nil, "should be started with `#{suggestion}` instead of `This cop ...`."
+      )
+    end
+
+    it 'has a period at EOL of description' do
+      description = config.dig(cop_name, 'Description')
+
+      expect(description).to match(/\.\z/)
+    end
+  end
+
+  shared_examples 'has metadata' do |cop_name|
+    context 'with VersionAdded' do
+      it 'required' do
+        version = config.dig(cop_name, 'VersionAdded')
+        expect(version).not_to be_nil
+      end
+
+      it 'nicely formatted' do
+        version = config.dig(cop_name, 'VersionAdded')
+        expect(version).to match(version_regexp), "should be format ('X.Y' or 'X.Y.Z' or '<<next>>')"
+      end
+    end
+
+    context 'with VersionChanged' do
+      it 'nicely formatted' do
+        version = config.dig(cop_name, 'VersionChanged')
+        next unless version
+
+        expect(version).to match(version_regexp), "should be format ('X.Y' or 'X.Y.Z' or '<<next>>')"
+      end
+    end
+
+    context 'with VersionRemoved' do
+      it 'nicely formatted' do
+        version = config.dig(cop_name, 'VersionRemoved')
+        next unless version
+
+        expect(version).to match(version_regexp), "should be format ('X.Y' or 'X.Y.Z' or '<<next>>')"
+      end
+    end
+
+    context 'with Safe' do
+      it 'does not include `true`' do
+        safe = config.dig(cop_name, 'Safe')
+        expect(safe).not_to be(true), 'has unnecessary `Safe: true` config.'
+      end
+    end
+
+    context 'with SafeAutoCorrect' do
+      it 'does not include unnecessary `false`' do
+        next unless config.dig(cop_name, 'Safe') == false
+
+        safe_autocorrect = config.dig(cop_name, 'SafeAutoCorrect')
+
+        expect(safe_autocorrect).not_to be(false), 'has unnecessary `SafeAutoCorrect: false` config.'
+      end
+    end
+  end
+
+  cop_names = RuboCop::Cop::Registry.global.with_department(:Sequel).cops.map(&:cop_name)
+  cop_names.each do |cop_name|
+    describe "Cop #{cop_name}" do
+      include_examples 'has a nicely formatted description', cop_name
+      include_examples 'has metadata', cop_name
+    end
+  end
+
+  it 'sorts configuration keys alphabetically' do
+    expected = configuration_keys.sort
+    configuration_keys.each_with_index do |key, idx|
+      expect(key).to eq expected[idx]
+    end
+  end
+
+  it 'sorts cop names alphabetically' do # rubocop:disable RSpec/ExampleLength
+    previous_key = ''
+    config_default = YAML.load_file('config/default.yml')
+
+    config_default.each_key do |key|
+      next if %w[inherit_mode AllCops].include?(key)
+
+      expect(previous_key <= key).to be(true), "Cops should be sorted alphabetically. Please sort #{key}."
+      previous_key = key
+    end
+  end
+end

data/spec/rubocop/cop/sequel/concurrent_index_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::ConcurrentIndex do
+RSpec.describe RuboCop::Cop::Sequel::ConcurrentIndex do
   subject(:cop) { described_class.new }
 
   context 'without the concurrent option' do

data/spec/rubocop/cop/sequel/irreversible_migration_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Sequel::IrreversibleMigration do
+  subject(:cop) { described_class.new }
+
+  context 'when inside a change block' do
+    let(:invalid_source) do
+      <<~SOURCE
+        change do
+          alter_table(:stores) do
+            drop_column(:products, :name)
+            drop_index(:products, :price)
+          end
+        end
+      SOURCE
+    end
+
+    let(:valid_source) do
+      <<~SOURCE
+        change do
+          alter_table(:stores) do
+            add_primary_key(:id)
+            add_column(:products, :name)
+            add_index(:products, :price)
+          end
+        end
+      SOURCE
+    end
+
+    it 'registers an offense when there is an invalid method' do
+      offenses = inspect_source(invalid_source)
+      expect(offenses.size).to eq(2)
+    end
+
+    it 'does not register an offense with valid methods' do
+      offenses = inspect_source(valid_source)
+      expect(offenses).to be_empty
+    end
+
+    describe 'and an array is passed into `add_primary_key`' do
+      let(:source) do
+        <<~SOURCE
+          change do
+            alter_table(:stores) do
+              add_primary_key([:owner_id, :name])
+            end
+          end
+        SOURCE
+      end
+
+      it 'registers an offense' do
+        offenses = inspect_source(source)
+        expect(offenses.size).to eq(1)
+      end
+    end
+  end
+
+  context 'when inside an up block' do
+    let(:source) do
+      <<~SOURCE
+        up do
+          alter_table(:stores) do
+            add_primary_key([:owner_id, :name])
+            add_column(:products, :name)
+            drop_index(:products, :price)
+          end
+        end
+      SOURCE
+    end
+
+    it 'does not register an offense with any methods' do
+      offenses = inspect_source(source)
+      expect(offenses).to be_empty
+    end
+  end
+end

data/spec/rubocop/cop/sequel/json_column_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::JSONColumn do
+RSpec.describe RuboCop::Cop::Sequel::JSONColumn do
   subject(:cop) { described_class.new }
 
   context 'with add_column' do

data/spec/rubocop/cop/sequel/migration_name_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::MigrationName, :config do
+RSpec.describe RuboCop::Cop::Sequel::MigrationName, :config do
   subject(:cop) { described_class.new(config) }
 
   let(:config) do

data/spec/rubocop/cop/sequel/partial_constraint_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::PartialConstraint do
+RSpec.describe RuboCop::Cop::Sequel::PartialConstraint do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when using where for constraint' do

data/spec/rubocop/cop/sequel/save_changes_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::SaveChanges do
+RSpec.describe RuboCop::Cop::Sequel::SaveChanges do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when using save' do

data/spec/spec_helper.rb

@@ -5,33 +5,12 @@ require 'rubocop/rspec/support'
 require 'rubocop-sequel'
 
 RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #     # => "be bigger than 2"
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
+  config.include RuboCop::RSpec::ExpectOffense
+  config.disable_monkey_patching!
+  config.raise_errors_for_deprecations!
+  config.raise_on_warning = true
+  config.fail_if_no_examples = true
 
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
-  end
-
-  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
-  # have no way to turn it off -- the option exists only for backwards
-  # compatibility in RSpec 3). It causes shared context metadata to be
-  # inherited by the metadata hash of host groups and examples, rather than
-  # triggering implicit auto-inclusion in groups with matching metadata.
-  config.shared_context_metadata_behavior = :apply_to_host_groups
+  config.order = :random
+  Kernel.srand config.seed
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Timothée Peignier
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-08 00:00:00.000000000 Z
+date: 2024-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,110 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 13.0.6
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 13.0.6
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.7'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.6.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.6.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: sequel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.47'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.47'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.16'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.16'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.12
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.12
 description: Code style checking for Sequel
 email:
 - timothee.peignier@tryphon.org
@@ -143,18 +39,22 @@ files:
 - Gemfile
 - LICENSE
 - README.md
+- config/default.yml
+- config/obsoletion.yml
 - lib/rubocop-sequel.rb
-- lib/rubocop/cop/sequel/column_default.rb
 - lib/rubocop/cop/sequel/concurrent_index.rb
+- lib/rubocop/cop/sequel/irreversible_migration.rb
 - lib/rubocop/cop/sequel/json_column.rb
 - lib/rubocop/cop/sequel/migration_name.rb
 - lib/rubocop/cop/sequel/partial_constraint.rb
 - lib/rubocop/cop/sequel/save_changes.rb
 - lib/rubocop/sequel.rb
+- lib/rubocop/sequel/inject.rb
 - lib/rubocop/sequel/version.rb
 - rubocop-sequel.gemspec
-- spec/rubocop/cop/sequel/column_default_spec.rb
+- spec/project_spec.rb
 - spec/rubocop/cop/sequel/concurrent_index_spec.rb
+- spec/rubocop/cop/sequel/irreversible_migration_spec.rb
 - spec/rubocop/cop/sequel/json_column_spec.rb
 - spec/rubocop/cop/sequel/migration_name_spec.rb
 - spec/rubocop/cop/sequel/partial_constraint_spec.rb
@@ -165,7 +65,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -180,8 +80,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: A Sequel plugin for RuboCop
 test_files: []

data/lib/rubocop/cop/sequel/column_default.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Sequel
-      # ColumnDefault looks for column creation with a default value.
-      class ColumnDefault < Base
-        MSG = "Don't create new column with default values"
-        RESTRICT_ON_SEND = %i[add_column].freeze
-
-        def_node_matcher :add_column_default?, <<-MATCHER
-          (send _ :add_column ... (hash (pair (sym :default) _)))
-        MATCHER
-
-        def on_send(node)
-          return unless add_column_default?(node)
-
-          add_offense(node.loc.selector, message: MSG)
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/sequel/column_default_spec.rb

@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Sequel::ColumnDefault do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense when setting a default' do
-    offenses = inspect_source('add_column(:products, :type, :text, default: "cop")')
-    expect(offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense when not setting a default' do
-    offenses = inspect_source('add_column(:products, :type, :text)')
-    expect(offenses).to be_empty
-  end
-end