rubocop-sequel 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b48c970ba23412aca37456e02bc2e3cd27856338494132bfe0ef2e43fe2bf0b
-  data.tar.gz: 55f74cf994978072f005b0c23603e12d2eb79a9cb680f49496aaf430500ee2fe
+  metadata.gz: 260beb7a94809075be127b7eac43b03b1acc661038009ea8c189bb91f543bdf0
+  data.tar.gz: '0815a252def8ee363d59bdc19f8c317b8f68bf9a89a50ed15bd79730bbc9fa60'
 SHA512:
-  metadata.gz: '069b933d71802921ffdbf4e763686c00f69104ec6b181c1854f259e4bb9a13352ed39ccc76197341bc39487908eed2eecfd3d9e1ea1bd3453441de3a45f4f774'
-  data.tar.gz: c6273c16039bf43725eaa6218881fcd84c64835fcae46dc18393d15e32bb944a69252800d312f2a0f23b5d29aeb81c8ac28468ed3f5620cbfa1aa605731532c0
+  metadata.gz: fa012f6644b9360e4d3d8c3d9ceb1b00165bab142f6dab7521d7289a8caa09704b6d27224cae6490b9a86067a7058bd657ac59f975c51e242807d65243678b3a
+  data.tar.gz: 19aa510cdf0b8ec211d1bca4377652afa877a7c4e52d8804a45099008d0a763c008dac616b15e5074e71bbe98800d5c3d54f98fde5dc1fd29600ca197a6233ea

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: /
+    schedule:
+      interval: "weekly"

data/.github/workflows/actions.yml

@@ -8,7 +8,6 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - 2.4
           - 2.5
           - 2.6
           - 2.7

data/.rubocop.yml

@@ -2,7 +2,8 @@ require:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
+  NewCops: enable
 
 # Offense count: 1
 # Configuration parameters: CountComments, ExcludedMethods.

data/lib/rubocop-sequel.rb

@@ -7,3 +7,4 @@ require 'rubocop/cop/sequel/concurrent_index'
 require 'rubocop/cop/sequel/json_column'
 require 'rubocop/cop/sequel/migration_name'
 require 'rubocop/cop/sequel/save_changes'
+require 'rubocop/cop/sequel/partial_constraint'

data/lib/rubocop/cop/sequel/partial_constraint.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sequel
+      # PartialConstraint looks for missed usage of partial indexes.
+      class PartialConstraint < Cop
+        MSG = "Constraint can't be partial, use where argument with index"
+
+        def_node_matcher :add_partial_constraint?, <<-MATCHER
+          (send _ :add_unique_constraint ... (hash (pair (sym :where) _)))
+        MATCHER
+
+        def on_send(node)
+          return unless add_partial_constraint?(node)
+
+          add_offense(node, location: :selector, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sequel/save_changes.rb

@@ -8,7 +8,7 @@ module RuboCop
         extend AutoCorrector
 
         MSG = 'Use `Sequel::Model#save_changes` instead of '\
-          '`Sequel::Model#save`.'
+              '`Sequel::Model#save`.'
 
         def_node_matcher :model_save?, <<-MATCHER
           (send _ :save)

data/rubocop-sequel.gemspec

@@ -13,16 +13,17 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.2.0'
+  gem.version       = '0.3.0'
 
-  gem.required_ruby_version = '>= 2.4'
+  gem.required_ruby_version = '>= 2.5'
 
   gem.add_runtime_dependency 'rubocop', '~> 1.0'
 
-  gem.add_development_dependency 'rake', '~> 12.3.0'
+  gem.add_development_dependency 'rake', '~> 13.0.6'
   gem.add_development_dependency 'rspec', '~> 3.7'
+  gem.add_development_dependency 'rubocop-rake', '~> 0.6.0'
   gem.add_development_dependency 'rubocop-rspec', '~> 2.0'
-  gem.add_development_dependency 'sequel', '~> 4.49'
+  gem.add_development_dependency 'sequel', '~> 5.47'
   gem.add_development_dependency 'simplecov', '~> 0.16'
   gem.add_development_dependency 'sqlite3', '~> 1.3', '>= 1.3.12'
 end

data/spec/rubocop/cop/sequel/partial_constraint_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Sequel::PartialConstraint do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense when using where for constraint' do
+    inspect_source <<-RUBY
+      add_unique_constraint %i[col_1 col_2], where: "state != 'deleted'"
+    RUBY
+
+    expect(cop.offenses.size).to eq(1)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Timothée Peignier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-26 00:00:00.000000000 Z
+date: 2021-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.0
+        version: 13.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.0
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.49'
+        version: '5.47'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.49'
+        version: '5.47'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -121,6 +135,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/actions.yml"
 - ".gitignore"
 - ".rspec"
@@ -133,6 +148,7 @@ files:
 - lib/rubocop/cop/sequel/concurrent_index.rb
 - lib/rubocop/cop/sequel/json_column.rb
 - lib/rubocop/cop/sequel/migration_name.rb
+- lib/rubocop/cop/sequel/partial_constraint.rb
 - lib/rubocop/cop/sequel/save_changes.rb
 - lib/rubocop/sequel.rb
 - rubocop-sequel.gemspec
@@ -140,6 +156,7 @@ files:
 - spec/rubocop/cop/sequel/concurrent_index_spec.rb
 - spec/rubocop/cop/sequel/json_column_spec.rb
 - spec/rubocop/cop/sequel/migration_name_spec.rb
+- spec/rubocop/cop/sequel/partial_constraint_spec.rb
 - spec/rubocop/cop/sequel/save_changes_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/rubocop-hq/rubocop-sequel
@@ -154,14 +171,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: A Sequel plugin for RuboCop
@@ -170,5 +187,6 @@ test_files:
 - spec/rubocop/cop/sequel/concurrent_index_spec.rb
 - spec/rubocop/cop/sequel/json_column_spec.rb
 - spec/rubocop/cop/sequel/migration_name_spec.rb
+- spec/rubocop/cop/sequel/partial_constraint_spec.rb
 - spec/rubocop/cop/sequel/save_changes_spec.rb
 - spec/spec_helper.rb