rubocop-sequel 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7073b0420635bddacfe692ad89623e834d7f576cc6ca04cef3e3ec60523b1928
-  data.tar.gz: a6b020500eddc1c6936cbf1759aaff0191e0f214186f6d4a746b80845a093ba5
+  metadata.gz: 1426529648e896758505cc0f580c8a9dfd04eaaadf041e01fe8a38f1452fc549
+  data.tar.gz: 8105c3044c2536f0f57fc79346ecf2349036b5d918fa7312f1d35e55ffc41bc0
 SHA512:
-  metadata.gz: 6bc69edcb167c25de701d0d1825ec44ce9581e08148d93261719b9c25253c1dcbfd566b6d4073bc231b0300f6c2f5cda4c0c5f93a07392e9253d850bc736ddb0
-  data.tar.gz: c539f918bac9007971a1b21ca58cc984c5ee4ae3fb1d5b951522f6e08b0d49df08264f55e8e20d6b4dce8e7b8e4d9aab736dcd3822e08515742c923fa6f5279b
+  metadata.gz: 3eb093802d46566d8a0e0e4920af488673448bbd1ae9e8dab89b4dd2aedd11494f2222bfd4ae1fcaff01104b848d50510fef518daa0b947e741f85d009a04d33
+  data.tar.gz: 5570ee0d798a47808cacb9a162db33a141c0055147dbedbb88fba614ecc9b14ce6c50bd66f9911f01136515f5d94ed4634cbdb76355a68d628755426b8d4c3d4

data/.rubocop.yml

@@ -1,10 +1,13 @@
 require:
   - rubocop-rspec
 
+AllCops:
+  TargetRubyVersion: 2.3
+
 # Offense count: 1
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 30
+  Max: 31
 
 # Offense count: 1
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.

data/.travis.yml

@@ -6,3 +6,5 @@ rvm:
 script:
   - bundle exec rubocop --parallel
   - bundle exec rspec
+notifications:
+  email: false

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/lib/rubocop-sequel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 
 require 'rubocop/cop/sequel/column_default'

data/lib/rubocop/cop/sequel/column_default.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Sequel
       # ColumnDefault looks for column creation with a default value.
       class ColumnDefault < Cop
-        MSG = "Don't create new column with default values".freeze
+        MSG = "Don't create new column with default values"
 
         def_node_matcher :add_column_default, <<-MATCHER
           (send _ :add_column ... (hash (pair (sym :default) _)))

data/lib/rubocop/cop/sequel/concurrent_index.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Sequel
       # ConcurrentIndex looks for non-concurrent index creation.
       class ConcurrentIndex < Cop
-        MSG = 'Prefer creating new index concurrently'.freeze
+        MSG = 'Prefer creating or dropping new index concurrently'
 
-        def_node_matcher :add_index, <<-MATCHER
-          (send _ :add_index $...)
+        def_node_matcher :indexes, <<-MATCHER
+          (send _ {:add_index :drop_index} $...)
         MATCHER
 
         def on_send(node)
-          add_index(node) do |args|
+          indexes(node) do |args|
             if offensive?(args)
               add_offense(node, location: :selector, message: MSG)
             end

data/lib/rubocop/cop/sequel/migration_name.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Sequel
       # MigrationName looks for migration files named with a default name.
       class MigrationName < Cop
-        MSG = 'Migration files should not use default name.'.freeze
+        include RangeHelp
+
+        MSG = 'Migration files should not use default name.'
 
         def investigate(processed_source)
           file_path = processed_source.buffer.name

data/lib/rubocop/cop/sequel/save_changes.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Sequel
       # SaveChanges promotes the use of save_changes.
       class SaveChanges < Cop
         MSG = 'Use `Sequel::Model#save_changes` instead of '\
-          '`Sequel::Model#save`.'.freeze
+          '`Sequel::Model#save`.'
 
         def_node_matcher :model_save, <<-MATCHER
           (send _ :save)

data/lib/rubocop/sequel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   # RuboCop Sequel project namespace
   module Sequel

data/rubocop-sequel.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |gem|
   gem.authors       = ['Timothée Peignier']
   gem.email         = ['timothee.peignier@tryphon.org']
@@ -11,7 +13,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.0.4'
+  gem.version       = '0.0.5'
 
   gem.add_runtime_dependency 'rubocop', '~> 0.52', '>= 0.52'
 

data/spec/rubocop/cop/sequel/column_default_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RuboCop::Cop::Sequel::ColumnDefault do

data/spec/rubocop/cop/sequel/concurrent_index_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RuboCop::Cop::Sequel::ConcurrentIndex do
@@ -5,25 +7,35 @@ describe RuboCop::Cop::Sequel::ConcurrentIndex do
 
   context 'without the concurrent option' do
     it 'registers an offense without options' do
-      inspect_source('add_index(:products, :name)')
-      expect(cop.offenses.size).to eq(1)
+      inspect_source(<<~SOURCE)
+        add_index(:products, :name)
+        drop_index(:products, :name)
+      SOURCE
+      expect(cop.offenses.size).to eq(2)
     end
 
     it 'registers an offense with other options' do
-      inspect_source('add_index(:products, :name, unique: true)')
-      expect(cop.offenses.size).to eq(1)
+      inspect_source(<<~SOURCE)
+        add_index(:products, :name, unique: true)
+        drop_index(:products, :name, unique: true)
+      SOURCE
+      expect(cop.offenses.size).to eq(2)
     end
 
     it 'registers an offense with composite index' do
-      inspect_source('add_index(:products, [:name, :price], unique: true)')
-      expect(cop.offenses.size).to eq(1)
+      inspect_source(<<~SOURCE)
+        add_index(:products, [:name, :price], unique: true)
+        drop_index(:products, [:name, :price])
+      SOURCE
+      expect(cop.offenses.size).to eq(2)
     end
   end
 
   it 'does not register an offense when using concurrent option' do
-    inspect_source(
-      'add_index(:products, :name, unique: true, concurrently: true)'
-    )
+    inspect_source(<<~SOURCE)
+      add_index(:products, :name, unique: true, concurrently: true)
+      drop_index(:products, :name, concurrently: true)
+    SOURCE
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/sequel/migration_name_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RuboCop::Cop::Sequel::MigrationName, :config do

data/spec/rubocop/cop/sequel/save_changes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RuboCop::Cop::Sequel::SaveChanges do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 require 'rubocop/rspec/support'
 require 'rubocop-sequel'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Timothée Peignier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-14 00:00:00.000000000 Z
+date: 2018-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -191,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A plugin for the RuboCop code style & linting tool.