rubocop-schema-gen 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ff5bc99403bcd28ab66842dd257ed4545e2d851ea63873dbe2df6e53f2f318b
-  data.tar.gz: f5f66291a3b0df9731ff5aa2ba0cdf07fffed213f322f853802c986b98674a69
+  metadata.gz: 99db5861b36cfdf148861814554c532213934e810770b8ed61f570b81a51ea1c
+  data.tar.gz: f7a310fbab5d4889cf24d8e138ca3acacf1fe66ab823699561d60b6db4320b02
 SHA512:
-  metadata.gz: 111af51292fe380d04ae4cf2c6abdb2302cba7351a30e32363072d091806f1cd5a7376a7620db7221ffd219f4c7096eee94bc0a8e01fd7eb82be48c34601407d
-  data.tar.gz: 67d26efe4e48e445143cfddce071286a0ef4ad72871578d412ad5fde56feb29d4d4f12d91ef710baad687212c335d7842fef4ab9ddd7cdddec98b5be130e5957
+  metadata.gz: 6b646939f86c4db226daf43887e9039fb487143d8ceea498124d9b84f0297a0815558494982531edab03a2754e2a26c8f6c6f06e04f6d3a406f63f3ac7d526e9
+  data.tar.gz: 42c0d2d6769be3de1ec6aec0dbb8efa8a609bfd59f82615587757a8bcbe5b79cad6e7ccbda6186cbe0f6ae59b4dc4fb84c106182b58ea05dcecabf8b059dc660

data/lib/rubocop/schema/ascii_doc/base.rb

@@ -1,5 +1,3 @@
-require 'nokogiri'
-
 require 'rubocop/schema/ascii_doc/stringifier'
 require 'rubocop/schema/helpers'
 
@@ -26,8 +24,7 @@ module RuboCop
 
         def link_text(str)
           # The Asciidoctor API doesn't provide access to the raw title, or parts of it.
-          # If performance becomes an issue, this could become a regexp or similarly crude solution.
-          Nokogiri::HTML(str).at_css('a')&.text
+          str[%r{<a\s.+?>(.+?)</a>}, 1]&.then &method(:strip_html)
         end
 
         # @param [Asciidoctor::Table] table

data/lib/rubocop/schema/defaults_ripper.rb

@@ -19,13 +19,15 @@ module RuboCop
       # @param [Hash] defaults
       def initialize(defaults)
         @cops = defaults.map do |cop_name, attributes|
+          next unless attributes.is_a? Hash
+
           CopInfo.new(
             name:               cop_name,
             description:        attributes['Description'],
             enabled_by_default: attributes['Enabled'] == true,
             attributes:         transform_attributes(attributes)
           )
-        end
+        end.compact
       end
 
       private

data/lib/rubocop/schema/helpers.rb

@@ -1,7 +1,7 @@
-require 'nokogiri'
 require 'uri'
 require 'yaml'
 require 'net/http'
+require 'cgi'
 
 module RuboCop
   module Schema
@@ -47,9 +47,8 @@ module RuboCop
 
       # Used for stripping HTML from Asciidoctor output, where raw output is not available, or not
       # appropriate to use.
-      # TODO: look into the Asciidoctor for a way to do a non-HTML conversion
       def strip_html(str)
-        Nokogiri::HTML(str).text
+        CGI.unescapeHTML str.gsub(/<.*?>/, '').gsub(/\s+/, ' ')
       end
 
       def http_get(url)

data/lib/rubocop/schema/repo.rb

@@ -10,7 +10,10 @@ module RuboCop
     class Repo
       include Helpers
 
-      TAGS_URL_TEMPLATE = -'https://api.github.com/repos/rubocop/%s/tags'
+      # GitHub public APIs have a rate limit of 60/hour when making unauthenticated requests. 100 items
+      # per page is the maximum allowed, which we'll use to keep the number of requests to a minimum.
+      TAGS_PER_PAGE     = 100
+      TAGS_URL_TEMPLATE = -"https://api.github.com/repos/rubocop/%s/tags?page=%d&per_page=#{TAGS_PER_PAGE}"
 
       def initialize(dir, loader, &event_handler)
         @dir           = Pathname(dir)
@@ -71,10 +74,17 @@ module RuboCop
       end
 
       def versions_of(name)
-        json = http_get(format(TAGS_URL_TEMPLATE, name))
-        raise "No tags available for #{name}" if json == ''
+        tags = []
+        loop do
+          json = http_get(format(TAGS_URL_TEMPLATE, name, (tags.length / TAGS_PER_PAGE) + 1))
+          raise "No tags available for #{name}" if json == ''
 
-        JSON.parse(json).reverse.map { |obj| obj['name'].to_s[/(?<=\Av)\d.+/] }.compact
+          parsed = JSON.parse(json)
+          tags += parsed
+          break unless parsed.length == TAGS_PER_PAGE
+        end
+
+        tags.reverse.map { |obj| obj['name'].to_s[/(?<=\Av)\d.+/] }.compact
       end
     end
   end

data/lib/rubocop/schema/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Schema
-    VERSION = -'0.1.4'
+    VERSION = -'0.1.5'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-schema-gen
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Neil E. Pearson
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-06-02 00:00:00.000000000 Z
+date: 2021-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: asciidoctor
@@ -24,34 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.14
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.17'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.17'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
 description: Generate JSON schemas for IDE integration with RuboCop
 email:
 - neil@helium.net.au
@@ -106,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Generate JSON schemas for IDE integration with RuboCop