rubocop-scc 0.2.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78494b0a918b525ad912cda5e333c3cda12f328b9a318a6c97929e563311db61
-  data.tar.gz: b369263e3fe3c0a7a03e59f62ff712726bca05cc9f3aa52c4c66810e50bba08a
+  metadata.gz: f00c8d00c7989c4142a2127787fbdd4563f9cfb9ce599f4acae514a41fa341b9
+  data.tar.gz: 37e75c158ee38448769e28d1b4b51d2bbcb41cb9194034b5467a793ed170eef3
 SHA512:
-  metadata.gz: b27de17b481f3d9a512919cfad59059b06ffde9ec0982e80c246b15816866f05196da4cb8d158d6ce87579b3cca94aa041d02d5be9a37927acb59b348ff774b6
-  data.tar.gz: 91d161c566f0a557b8d26aa13525b69f0cfe0faf0363b1c75f74c790e3b2a8676d361def26ae099112b76df07e85f3b741178aeba340be20382cd718b3f39816
+  metadata.gz: 5b31efdd916434ac19a15058ebf1e22998f5915d4b617a8c99f2df1ed211b41e0ac929a5206b28947eb32a4a09aea72a22ead324477a06ca3e36d54c181340b5
+  data.tar.gz: 72ef8bc1f2949688b254b1db56c32bd907e9d327722f5534d1e0aab3378468bb181e82d4b660aa7ca3ade30bed853d85c739448f9af046321204c95245836996

data/config/default.yml

@@ -585,7 +585,7 @@ Style/InfiniteLoop:
   Enabled: true
 
 Style/InlineComment:
-  Enabled: true
+  Enabled: false
 
 Style/MethodMissingSuper:
   Enabled: true

data/config/rails.yml

@@ -1,4 +1,4 @@
-require: rubocop/cop/sequioacap
+require: rubocop/cop/sequoiacap
 
 Rails:
   Enabled: true
@@ -98,47 +98,47 @@ Rails/Validation:
 Rails/UniqBeforePluck:
   Enabled: true
 
-Sequioacap/RailsControllerRenderActionSymbol:
+sequoiacap/RailsControllerRenderActionSymbol:
   Enabled: true
   Include:
     - 'app/controllers/**/*.rb'
 
-Sequioacap/RailsControllerRenderLiteral:
+sequoiacap/RailsControllerRenderLiteral:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
   Include:
     - 'app/controllers/**/*.rb'
 
-Sequioacap/RailsControllerRenderPathsExist:
-  Enabled: true
+sequoiacap/RailsControllerRenderPathsExist:
+  Enabled: false
   ViewPath:
     - 'app/views'
   Include:
     - 'app/controllers/**/*.rb'
 
-Sequioacap/RailsControllerRenderShorthand:
+sequoiacap/RailsControllerRenderShorthand:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-shorthand.md
   Include:
     - 'app/controllers/**/*.rb'
 
-Sequioacap/ClassName:
+sequoiacap/ClassName:
   Description: Use :class_name => "Model" instead of :class_name => Model.name
     to avoid a long cascade of autoloading.
   Enabled: true
 
-Sequioacap/DefaultScope:
+sequoiacap/DefaultScope:
   Description: Avoid `default_scope`.  Default scopes make it difficult to
     refactor data access patterns since the scope becomes part of every query unless
     explicitly excluded, even when it is unnecessary or incidental to the desired logic.
   Enabled: true
 
-Sequioacap/FactoryClassUseString:
+sequoiacap/FactoryClassUseString:
   Description: Cop to tell developers to use :class => "MyClass" instead of :class => MyClass,
     because the latter slows down reloading zeus.
   Enabled: true
 
-Sequioacap/NoTimeout:
+sequoiacap/NoTimeout:
   Description: Do not use Timeout.timeout. In combination with Rails autoloading,
     timeout can cause Segmentation Faults in version of Ruby we use.
     It can also cause logic errors since it can raise in
@@ -146,7 +146,7 @@ Sequioacap/NoTimeout:
     ensure proper timing behavior for web requests.
   Enabled: true
 
-Sequioacap/SimpleModifierConditional:
+sequoiacap/SimpleModifierConditional:
   Enabled: true
   StyleGuide: https://github.com/airbnb/ruby#only-simple-if-unless
 

data/guides/rails-controller-render-shorthand.md

@@ -1,4 +1,4 @@
-# Sequioacap/RailsControllerRenderShorthand
+# sequoiacap/RailsControllerRenderShorthand
 
 Prefer `render "path/to/template"` shorthand in controllers.
 

data/guides/rails-render-inline.md

@@ -1,4 +1,4 @@
-# Sequioacap/RailsRenderInline
+# sequoiacap/RailsRenderInline
 
 tldr; Do not use `render inline:`.
 

data/guides/rails-render-literal.md

@@ -1,4 +1,4 @@
-# Sequioacap/RailsRenderLiteral
+# sequoiacap/RailsRenderLiteral
 
 tldr; `render` MUST be passed a string literal template path.
 

data/lib/rubocop/cop/sequoiacap.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'rubocop/cop/sequoiacap/class_name'
+require 'rubocop/cop/sequoiacap/default_scope'
+require 'rubocop/cop/sequoiacap/factory_class_use_string'
+require 'rubocop/cop/sequoiacap/no_timeout'
+require 'rubocop/cop/sequoiacap/rails_controller_render_action_symbol'
+require 'rubocop/cop/sequoiacap/rails_controller_render_literal'
+require 'rubocop/cop/sequoiacap/rails_controller_render_paths_exist'
+require 'rubocop/cop/sequoiacap/rails_controller_render_shorthand'
+require 'rubocop/cop/sequoiacap/simple_modifier_conditional'

data/lib/rubocop/cop/{sequioacap → sequoiacap}/class_name.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       # Cop to prevent cross-model references, which result in a cascade of autoloads. E.g.,
       # belongs_to :user, :class_name => User.name
       class ClassName < Cop
@@ -24,9 +24,7 @@ module RuboCop
 
           class_pair = class_name_node(node)
 
-          if class_pair && !string_class_name?(class_pair)
-            add_offense(class_pair)
-          end
+          add_offense(class_pair) if class_pair && !string_class_name?(class_pair)
         end
 
         private

data/lib/rubocop/cop/{sequioacap → sequoiacap}/default_scope.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       # Cop to help prevent the scorge of Default Scopes from ActiveRecord.
       # Once in place they are almost impossible to remove.
       class DefaultScope < Cop

data/lib/rubocop/cop/{sequioacap → sequoiacap}/factory_class_use_string.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       # Cop to tell developers to use :class => "MyClass" instead of :class => MyClass,
       # because the latter slows down reloading zeus.
       class FactoryClassUseString < Cop
@@ -16,9 +16,7 @@ module RuboCop
 
           class_pair = class_node(node)
 
-          if class_pair && !string_class_name?(class_pair)
-            add_offense(class_pair)
-          end
+          add_offense(class_pair) if class_pair && !string_class_name?(class_pair)
         end
 
         private

data/lib/rubocop/cop/{sequioacap → sequoiacap}/no_timeout.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       class NoTimeout < Cop
         MSG =
             'Do not use Timeout.timeout. In combination with Rails autoloading, ' \

data/lib/rubocop/cop/{sequioacap → sequoiacap}/rails_controller_render_action_symbol.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       class RailsControllerRenderActionSymbol < Cop
         MSG = 'Prefer `render` with string instead of symbol'
 

data/lib/rubocop/cop/{sequioacap → sequoiacap}/rails_controller_render_literal.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       class RailsControllerRenderLiteral < Cop
         MSG = 'render must be used with a string literal'
 
@@ -70,9 +70,7 @@ module RuboCop
             return if option_pairs.any? { |pair| ignore_key?(pair) }
             template_node = option_pairs.map { |pair| template_key?(pair) }.compact.first
             if template_node
-              if !literal?(template_node)
-                add_offense(node, location: :expression)
-              end
+              add_offense(node, location: :expression) if !literal?(template_node)
             else
               add_offense(node, location: :expression)
             end

data/lib/rubocop/cop/{sequioacap → sequoiacap}/rails_controller_render_paths_exist.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       class RailsControllerRenderPathsExist < Cop
         def_node_matcher :render?, <<-PATTERN
           (send nil? :render $...)
@@ -27,22 +27,16 @@ module RuboCop
 
           if args == render_str?(node)
             node, path = args
-            unless resolve_template(path.to_s)
-              add_offense(node, location: :expression, message: 'Template could not be found')
-            end
+            add_offense(node, location: :expression, message: 'Template could not be found') unless resolve_template(path.to_s)
           elsif pairs == render_options?(node)
             if pair == pairs.detect { |p| render_key?(p) }
               key, node, path = render_key?(pair)
 
               case key
                 when :action, :template
-                  unless resolve_template(path.to_s)
-                    add_offense(node, location: :expression, message: 'Template could not be found')
-                  end
+                  add_offense(node, location: :expression, message: 'Template could not be found') unless resolve_template(path.to_s)
                 when :partial
-                  unless resolve_partial(path.to_s)
-                    add_offense(node, location: :expression, message: 'Partial template could not be found')
-                  end
+                  add_offense(node, location: :expression, message: 'Partial template could not be found') unless resolve_partial(path.to_s)
               end
             end
           end

data/lib/rubocop/cop/{sequioacap → sequoiacap}/rails_controller_render_shorthand.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       class RailsControllerRenderShorthand < Cop
         MSG = 'Prefer `render` template shorthand'
 

data/lib/rubocop/cop/{sequioacap → sequoiacap}/simple_modifier_conditional.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module RuboCop
   module Cop
-    module Sequioacap
+    module Sequoiacap
       # Cop to tackle prevent more complicated modifier if/unless statements
       # https://github.com/airbnb/ruby#only-simple-if-unless
       class SimpleModifierConditional < Cop

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-scc
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 1.0.0
 platform: ruby
 authors:
 - borisding
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -28,22 +28,22 @@ dependencies:
   name: actionview
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 6.0.0.beta3
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 6.0.0.beta3
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
@@ -112,16 +112,16 @@ files:
 - guides/rails-controller-render-shorthand.md
 - guides/rails-render-inline.md
 - guides/rails-render-literal.md
-- lib/rubocop/cop/sequioacap.rb
-- lib/rubocop/cop/sequioacap/class_name.rb
-- lib/rubocop/cop/sequioacap/default_scope.rb
-- lib/rubocop/cop/sequioacap/factory_class_use_string.rb
-- lib/rubocop/cop/sequioacap/no_timeout.rb
-- lib/rubocop/cop/sequioacap/rails_controller_render_action_symbol.rb
-- lib/rubocop/cop/sequioacap/rails_controller_render_literal.rb
-- lib/rubocop/cop/sequioacap/rails_controller_render_paths_exist.rb
-- lib/rubocop/cop/sequioacap/rails_controller_render_shorthand.rb
-- lib/rubocop/cop/sequioacap/simple_modifier_conditional.rb
+- lib/rubocop/cop/sequoiacap.rb
+- lib/rubocop/cop/sequoiacap/class_name.rb
+- lib/rubocop/cop/sequoiacap/default_scope.rb
+- lib/rubocop/cop/sequoiacap/factory_class_use_string.rb
+- lib/rubocop/cop/sequoiacap/no_timeout.rb
+- lib/rubocop/cop/sequoiacap/rails_controller_render_action_symbol.rb
+- lib/rubocop/cop/sequoiacap/rails_controller_render_literal.rb
+- lib/rubocop/cop/sequoiacap/rails_controller_render_paths_exist.rb
+- lib/rubocop/cop/sequoiacap/rails_controller_render_shorthand.rb
+- lib/rubocop/cop/sequoiacap/simple_modifier_conditional.rb
 homepage: https://github.com/sequoia-china/rubocop-scc
 licenses:
 - MIT
@@ -141,8 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: RuboCop SCC

data/lib/rubocop/cop/sequioacap.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-require 'rubocop/cop/sequioacap/class_name'
-require 'rubocop/cop/sequioacap/default_scope'
-require 'rubocop/cop/sequioacap/factory_class_use_string'
-require 'rubocop/cop/sequioacap/no_timeout'
-require 'rubocop/cop/sequioacap/rails_controller_render_action_symbol'
-require 'rubocop/cop/sequioacap/rails_controller_render_literal'
-require 'rubocop/cop/sequioacap/rails_controller_render_paths_exist'
-require 'rubocop/cop/sequioacap/rails_controller_render_shorthand'
-require 'rubocop/cop/sequioacap/simple_modifier_conditional'