rubocop-rspec_rails 2.31.0 → 2.32.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a532f361a0657a600a657dd22a2344028ce648996179c8c4df27ea29302537ac
-  data.tar.gz: f7d10a791b1c5ee7d6a4444ee15eea12622cec6ecfd2174fafe037d37651a6bb
+  metadata.gz: 6a750fc4e562218ed87ba5242d34797589b5df5598ad0cac33799546bf2a0230
+  data.tar.gz: 76e8e5c35753d371fa4fd4fdb41ced69adb33c2168d0232f6b2ba5f73a82b5da
 SHA512:
-  metadata.gz: 976d9b3320ea2923c627597dc7cffb0e0f212ea16430084e60c53345093cebc4dff74e28ee7730900e0955920e2f7fee8f7206c4b583731d9cc58d5c67d67688
-  data.tar.gz: 657c590a5cb85f4f3b97b08f5dfc57409b07392db055ea1f0e2f7a04e78cd6d9920ca21f298c5d9c3120dc971776fb5429213d576cb91e4ae85713da704dc30a
+  metadata.gz: 8929c0661a8c342e41d652597c24549eefef4a3fad2ad566588df2bae35aeed79d68c44ea2a1d7270ee91d089c698095889e41b3f9012b3cddad2fadba6a4d48
+  data.tar.gz: a4a1dfde481062a1d2445100d753bfb66df082537c0157a2189ba6af9ab4f5dd8a459561278db7e2b80c434009455b908927549f201a7aa692f66fc4b28f1adc

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Master (Unreleased)
 
+## 2.32.0 (2025-11-12)
+
+- Add `RSpecRails/HttpStatusNameConsistency` cop. ([@taketo1113])
+- Support correcting `assert_response` assertion in in `RSpec/Rails/MinitestAssertions`. ([@nzlaura])
+
 ## 2.31.0 (2025-03-10)
 
 - Handle unknown HTTP status codes for `RSpecRails/HttpStatus` cop. ([@viralpraxis])
@@ -82,10 +87,12 @@
 [@jojos003]: https://github.com/jojos003
 [@mothonmars]: https://github.com/MothOnMars
 [@mvz]: https://github.com/mvz
+[@nzlaura]: https://github.com/nzlaura
 [@paydaylight]: https://github.com/paydaylight
 [@pirj]: https://github.com/pirj
 [@r7kamura]: https://github.com/r7kamura
 [@splattael]: https://github.com/splattael
+[@taketo1113]: https://github.com/taketo1113
 [@tmaier]: https://github.com/tmaier
 [@viralpraxis]: https://github.com/viralpraxis
 [@ydah]: https://github.com/ydah

data/config/default.yml

@@ -35,6 +35,12 @@ RSpecRails/HttpStatus:
   VersionChanged: '2.20'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec_rails/RuboCop/Cop/RSpecRails/HttpStatus
 
+RSpecRails/HttpStatusNameConsistency:
+  Description: Enforces consistency by using the current HTTP status names.
+  Enabled: pending
+  VersionAdded: '2.32'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec_rails/RuboCop/Cop/RSpecRails/HttpStatusNameConsistency
+
 RSpecRails/InferredSpecType:
   Description: Identifies redundant spec type.
   Enabled: pending

data/lib/rubocop/cop/rspec_rails/http_status_name_consistency.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpecRails
+      # Enforces consistency by using the current HTTP status names.
+      #
+      # @example
+      #
+      #   # bad
+      #   it { is_expected.to have_http_status :unprocessable_entity }
+      #
+      #   # good
+      #   it { is_expected.to have_http_status :unprocessable_content }
+      #
+      class HttpStatusNameConsistency < ::RuboCop::Cop::Base
+        extend AutoCorrector
+
+        requires_gem 'rack', '>= 3.1.0'
+
+        MSG = 'Use `Prefer `:%<preferred>s` over `:%<current>s`.'
+
+        RESTRICT_ON_SEND = %i[have_http_status].freeze
+
+        PREFERRED_STATUSES = {
+          unprocessable_entity: :unprocessable_content,
+          payload_too_large: :content_too_large
+        }.freeze
+
+        # @!method http_status(node)
+        def_node_matcher :http_status, <<~PATTERN
+          (send nil? :have_http_status ${sym})
+        PATTERN
+
+        def on_send(node)
+          http_status(node) do |arg|
+            check_status_name_consistency(arg)
+          end
+        end
+        alias on_csend on_send
+
+        private
+
+        def check_status_name_consistency(node)
+          return unless node.sym_type? && PREFERRED_STATUSES.key?(node.value)
+
+          current_status = node.value
+          preferred_status = PREFERRED_STATUSES[current_status]
+
+          message = format(MSG, current: current_status,
+                                preferred: preferred_status)
+
+          add_offense(node, message: message) do |corrector|
+            corrector.replace(node, ":#{preferred_status}")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec_rails/minitest_assertions.rb

@@ -18,6 +18,7 @@ module RuboCop
       #   refute_empty(b)
       #   assert_true(a)
       #   assert_false(a)
+      #   assert_response :ok
       #
       #   # good
       #   expect(b).to eq(a)
@@ -28,6 +29,7 @@ module RuboCop
       #   expect(a).not_to be_empty
       #   expect(a).to be(true)
       #   expect(a).to be(false)
+      #   expect(response).to have_http_status(:ok)
       #
       class MinitestAssertions < ::RuboCop::Cop::Base
         extend AutoCorrector
@@ -315,6 +317,28 @@ module RuboCop
           end
         end
 
+        # :nodoc:
+        class ResponseAssertion < BasicAssertion
+          MATCHERS = %i[
+            assert_response
+          ].freeze
+
+          ASSERT_ACTUAL_NODE = Struct.new(:source).new('response')
+
+          # @!method self.minitest_assertion(node)
+          def_node_matcher 'self.minitest_assertion', <<~PATTERN # rubocop:disable InternalAffairs/NodeMatcherDirective
+            (send nil? {:assert_response} $_ $_?)
+          PATTERN
+
+          def self.match(expected, failure_message)
+            new(expected, ASSERT_ACTUAL_NODE, failure_message.first)
+          end
+
+          def assertion
+            "have_http_status(#{expected})"
+          end
+        end
+
         MSG = 'Use `%<prefer>s`.'
 
         # TODO: replace with `BasicAssertion.subclasses` in Ruby 3.1+

data/lib/rubocop/cop/rspec_rails_cops.rb

@@ -3,6 +3,7 @@
 require_relative 'rspec_rails/avoid_setup_hook'
 require_relative 'rspec_rails/have_http_status'
 require_relative 'rspec_rails/http_status'
+require_relative 'rspec_rails/http_status_name_consistency'
 require_relative 'rspec_rails/inferred_spec_type'
 require_relative 'rspec_rails/minitest_assertions'
 require_relative 'rspec_rails/negation_be_valid'

data/lib/rubocop/rspec_rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpecRails
     # Version information for the RSpec Rails RuboCop plugin.
     module Version
-      STRING = '2.31.0'
+      STRING = '2.32.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_rails
 version: !ruby/object:Gem::Version
-  version: 2.31.0
+  version: 2.32.0
 platform: ruby
 authors:
 - Benjamin Quorning
@@ -10,7 +10,7 @@ authors:
 - Yudai Takada
 bindir: bin
 cert_chain: []
-date: 2025-03-10 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -78,6 +78,7 @@ files:
 - lib/rubocop/cop/rspec_rails/avoid_setup_hook.rb
 - lib/rubocop/cop/rspec_rails/have_http_status.rb
 - lib/rubocop/cop/rspec_rails/http_status.rb
+- lib/rubocop/cop/rspec_rails/http_status_name_consistency.rb
 - lib/rubocop/cop/rspec_rails/inferred_spec_type.rb
 - lib/rubocop/cop/rspec_rails/minitest_assertions.rb
 - lib/rubocop/cop/rspec_rails/negation_be_valid.rb
@@ -110,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Code style checking for RSpec Rails files
 test_files: []