rubocop-rspec_parity 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 944e7c309cb2d5e95c94878066fdee5483054e1585bf272116825603ac2fc265
-  data.tar.gz: e72069e31fc0ee1b0b63db9d33f316cb9a5b3d52dcfd8d6de65071d406f3514e
+  metadata.gz: a292f9a4bfd8a377704932840853dc8ab47f7e8b6665c0a99d9039b806e1e75c
+  data.tar.gz: a35e6b56eb08faa4ecbc0561ed1dc39b53f1c892c9c5ecb9342c9f73bd5734ac
 SHA512:
-  metadata.gz: 0d6e482836054a7069f89f2a2a350c70579c5459c58897d7cd4f539c670f3099512e71efc93f26fde2877d1582dfa3a2e238f0ba355c3a449ef50b1417379e61
-  data.tar.gz: 91eac7edad8d9d7f54fd3e3c7b0bb8973fa89e4c3d33ddd869c9db36ab0d6ae607162e4c7e097cd6203b541bc57ee39d01905598f69b629ff899e4293ccb4bfc
+  metadata.gz: d41834a22a635130c9f6fce2657a353988f3517a003ad2a2c8f31181a81cd55b48227509919d304433a92f2abecec172ad05c193b8788f0d007e18b77083cc47
+  data.tar.gz: 604c27a89fe267823aa79fe275d50f8247e0ed09246dc114895d937d5824c879290c5eadedcda185a7a6cb22e9703ae9636a03eca86e50b3c5de91928a616d43

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.4.2] - 2026-03-03
+
+Fixed: `PublicMethodHasSpec` now reports violations even when the spec file does not exist, since a missing spec file means the method is untested
+Fixed: Department-level config keys (`DescribeAliases`, `SkipMethodDescribeFor`) no longer trigger unsupported parameter warnings when overridden at cop level
+Added: `Include` and `Exclude` can now be set at department level (`RSpecParity:`) to apply to all cops
+
 ## [1.4.1] - 2026-03-03
 
 Fixed: `PublicMethodHasSpec` now reports violations even when the spec file does not exist, since a missing spec file means the method is untested

data/config/default.yml

@@ -1,16 +1,12 @@
 # Default configuration for rubocop-rspec_parity
 
 # Department-level shared configuration for all RSpecParity cops.
-# Cop-level settings override these when explicitly set per-cop.
+# Set these in your .rubocop.yml under RSpecParity: to share across all cops.
+# Supported keys: SpecFilePathMappings, DescribeAliases, SkipMethodDescribeFor,
+# Include, Exclude.
+# Department-level values override cop-level defaults.
+# Cop-level values set explicitly in your .rubocop.yml override department-level.
 RSpecParity:
-  SpecFilePathMappings:
-    'app/': ['spec/']
-  DescribeAliases: {}
-  SkipMethodDescribeFor: []
-
-RSpecParity/FileHasSpec:
-  Description: 'Checks that each Ruby file in the app directory has a corresponding spec file.'
-  Enabled: true
   Include:
     - 'app/**/*.rb'
   Exclude:
@@ -18,23 +14,19 @@ RSpecParity/FileHasSpec:
     - 'app/views/**/*'
     - 'app/javascript/**/*'
 
+RSpecParity/FileHasSpec:
+  Description: 'Checks that each Ruby file in the app directory has a corresponding spec file.'
+  Enabled: true
+
 RSpecParity/PublicMethodHasSpec:
   Description: 'Checks that each public method has a corresponding spec test.'
   Enabled: true
-  Include:
-    - 'app/**/*.rb'
-  Exclude:
-    - 'app/assets/**/*'
-    - 'app/views/**/*'
-    - 'app/javascript/**/*'
+  SkipMethodDescribeFor: []
+  DescribeAliases: {}
 
 RSpecParity/SufficientContexts:
   Description: 'Ensures specs have at least as many contexts as the method has branches.'
   Enabled: true
   IgnoreMemoization: true
-  Include:
-    - 'app/**/*.rb'
-  Exclude:
-    - 'app/assets/**/*'
-    - 'app/views/**/*'
-    - 'app/javascript/**/*'
+  SkipMethodDescribeFor: []
+  DescribeAliases: {}

data/lib/rubocop/cop/rspec_parity/department_config.rb

@@ -7,6 +7,12 @@ module RuboCop
       # Provides config resolution (cop-level > department-level > default),
       # spec file path mappings, and shared describe aliases / skip paths.
       module DepartmentConfig
+        SHARED_CONFIG_DEFAULTS = {
+          "SpecFilePathMappings" => { "app/" => ["spec/"] },
+          "DescribeAliases" => {},
+          "SkipMethodDescribeFor" => []
+        }.freeze
+
         private
 
         def department_config
@@ -14,15 +20,15 @@ module RuboCop
         end
 
         def spec_file_path_mappings
-          resolve_config("SpecFilePathMappings", { "app/" => ["spec/"] })
+          resolve_config("SpecFilePathMappings")
         end
 
         def shared_describe_aliases
-          resolve_config("DescribeAliases", {})
+          resolve_config("DescribeAliases")
         end
 
         def shared_skip_method_describe_paths
-          resolve_config("SkipMethodDescribeFor", [])
+          resolve_config("SkipMethodDescribeFor")
         end
 
         def expected_spec_paths(source_path = nil) # rubocop:disable Metrics/MethodLength
@@ -55,14 +61,17 @@ module RuboCop
           root ? spec_path.sub("#{root}/", "") : spec_path
         end
 
-        def resolve_config(key, default)
-          if cop_config.key?(key)
-            cop_config[key]
-          elsif department_config.key?(key)
-            department_config[key]
-          else
-            default
-          end
+        # Precedence: cop-level user override > department-level > default.
+        # Detects cop-level user overrides by comparing against the known default.
+        def resolve_config(key)
+          default = SHARED_CONFIG_DEFAULTS[key]
+          cop_value = cop_config.key?(key) ? cop_config[key] : nil
+          user_overrode_cop = !cop_value.nil? && cop_value != default
+
+          return cop_value if user_overrode_cop
+          return department_config[key] if department_config.key?(key)
+
+          cop_value || default
         end
 
         def path_matches_mapping?(source_path, source_dir)

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "1.4.1"
+    VERSION = "1.4.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Povilas Jurcys