rubocop-rspec_parity 1.3.3 → 1.3.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +4 -0
- data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb +14 -2
- data/lib/rubocop/rspec_parity/version.rb +1 -1
- metadata +1 -1
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: b634068a8fe93d9576c210988a5ebab48f22f25058cf7c50e21710de1b7fb775
|
|
4
|
+
data.tar.gz: 9ac6bd2fc8503e43013e25e03413cb32dd8eb3d6ee44480f1a243f41e006781f
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: ab0f3101fd7603ec83438f91772b6991446c9fbb2102cc32ebb948a02df1cfe8a6217e71b2629ba695135b717322d9ba6bd686bfe1a9f58fbe292ea1b70357ba
|
|
7
|
+
data.tar.gz: d30491decd3a61710bf1c873bbd268aad7d5a40e6d209b46676bf469871c54087e13a6111a47ad83437d5becb6416e5075cec6ca6a0e00a7b7657c873bb44ce2
|
data/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,9 @@
|
|
|
1
1
|
## [Unreleased]
|
|
2
2
|
|
|
3
|
+
## [1.3.4] - 2026-02-23
|
|
4
|
+
|
|
5
|
+
Added: `PublicMethodHasSpec` now treats methods inside `class_methods do` blocks (ActiveSupport::Concern) as class methods, expecting `.method_name` in specs
|
|
6
|
+
|
|
3
7
|
## [1.3.3] - 2026-02-20
|
|
4
8
|
|
|
5
9
|
Fixed: `PublicMethodHasSpec` offense message now shows correct method prefix (`#` for instance methods, `.` for class methods) and includes configured `DescribeAliases` in the expected describes
|
|
@@ -34,7 +34,7 @@ module RuboCop
|
|
|
34
34
|
return unless checkable_method?(node) && public_method?(node)
|
|
35
35
|
return if inside_inner_class?(node)
|
|
36
36
|
|
|
37
|
-
check_method_has_spec(node, instance_method: !inside_eigenclass?(node))
|
|
37
|
+
check_method_has_spec(node, instance_method: !inside_eigenclass?(node) && !inside_class_methods_block?(node))
|
|
38
38
|
end
|
|
39
39
|
|
|
40
40
|
def on_defs(node)
|
|
@@ -77,6 +77,12 @@ module RuboCop
|
|
|
77
77
|
node.each_ancestor.any? { |a| a.sclass_type? && a.children.first&.self_type? }
|
|
78
78
|
end
|
|
79
79
|
|
|
80
|
+
def inside_class_methods_block?(node)
|
|
81
|
+
node.each_ancestor(:block).any? do |block_node|
|
|
82
|
+
block_node.send_node.method_name == :class_methods
|
|
83
|
+
end
|
|
84
|
+
end
|
|
85
|
+
|
|
80
86
|
def inside_inner_class?(node)
|
|
81
87
|
enclosing = find_class_or_module(node)
|
|
82
88
|
return false unless enclosing
|
|
@@ -127,7 +133,13 @@ module RuboCop
|
|
|
127
133
|
end
|
|
128
134
|
|
|
129
135
|
def find_enclosing_scope(node)
|
|
130
|
-
node.each_ancestor.find
|
|
136
|
+
node.each_ancestor.find do |n|
|
|
137
|
+
n.class_type? || n.module_type? || n.sclass_type? || class_methods_block?(n)
|
|
138
|
+
end
|
|
139
|
+
end
|
|
140
|
+
|
|
141
|
+
def class_methods_block?(node)
|
|
142
|
+
node.block_type? && node.send_node.method_name == :class_methods
|
|
131
143
|
end
|
|
132
144
|
|
|
133
145
|
def find_class_or_module(node)
|