rubocop-rspec_parity 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f6cb712ad716f1a6c82659cd5114785bd93f7ed7344fb2ba6317de8bae3d37e
-  data.tar.gz: 2588d5b16c636142a361c2d0723d049099e7e1da76ed30b72b0c78b211734fb9
+  metadata.gz: e3c642272877446cd87c6b7d88339e284fe29fac025f153489d28398e20e73bd
+  data.tar.gz: bb91681c2f70a3a35febf88a132344a125e0f5a6735df0a2a0b5c39bcee79c97
 SHA512:
-  metadata.gz: a2d8de79c7cf285c21e656b96ac473037aabd21c9d206753d44c863b6844d9393217bdf1850b21646f96996355270467e07d711230702fbbb6ed51b4c3536699
-  data.tar.gz: 65836a3ae64470aa713d5c3492fb33b993d137f66f1be2d464104a3ce75a22733dd0a055fd2875f6d7ad24c25b407869d42bfebb9d494c3416a4d7003813d8b8
+  metadata.gz: 83ee14e1845f77229138051716410f1cc1c9d751430800300d4e204b6a4ab07df7c0380549e200723d8ff861a8ce52a5ed02fe461ef8059a02217ffe2da3467b
+  data.tar.gz: d9300dd4aacf6711bbfc2135c9814f03cfef4b42981f6cc5c9f7c8291ee1f525ebd092cb5645e25faf31c9171311e92a2841f9cc67ba0780ee2cce6e56297057

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [1.2.3] - 2026-02-10
+
+Fixed: `PublicMethodHasSpec` correctly detects visibility for `private :method_name`, `protected :method_name`, `private def method_name`, `protected def method_name`, and `private`/`protected` inside `class << self`
+
 ## [1.2.2] - 2026-02-10
 
 Added: `PublicMethodHasSpec` now skips class methods marked with `private_class_method` (both inline and post-hoc forms)

data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb

@@ -83,16 +83,50 @@ module RuboCop
         def public_method?(node)
           return false if node.nil?
 
-          class_or_module = find_class_or_module(node)
-          return true unless class_or_module
+          # Inline form: private def method_name / protected def method_name
+          if node.parent&.send_type? && VISIBILITY_METHODS.key?(node.parent.method_name)
+            return node.parent.method_name == :public
+          end
+
+          scope = find_enclosing_scope(node)
+          return true unless scope
 
-          compute_visibility(class_or_module, node) == :public
+          # Post-hoc targeted form overrides section-level visibility
+          targeted = targeted_visibility(scope, node.method_name)
+          return targeted == :public unless targeted.nil?
+
+          compute_visibility(scope, node) == :public
+        end
+
+        def find_enclosing_scope(node)
+          node.each_ancestor.find { |n| n.class_type? || n.module_type? || n.sclass_type? }
         end
 
         def find_class_or_module(node)
           node.each_ancestor.find { |n| n.class_type? || n.module_type? }
         end
 
+        def targeted_visibility(scope, method_name)
+          return nil unless scope.body
+
+          scope_children(scope).each do |child|
+            next unless targeted_visibility_call?(child, method_name)
+
+            return VISIBILITY_METHODS[child.method_name]
+          end
+          nil
+        end
+
+        def targeted_visibility_call?(node, method_name)
+          node&.send_type? &&
+            VISIBILITY_METHODS.key?(node.method_name) &&
+            node.arguments.any? { |arg| arg.sym_type? && arg.value == method_name }
+        end
+
+        def scope_children(scope)
+          scope.body.begin_type? ? scope.body.children : [scope.body]
+        end
+
         def compute_visibility(class_or_module, target_node)
           visibility = :public
           class_or_module.body&.each_child_node do |child|
@@ -105,6 +139,7 @@ module RuboCop
 
         def update_visibility(child, current_visibility)
           return current_visibility unless child.send_type?
+          return current_visibility if child.arguments.any? # targeted/inline, not section-level
 
           VISIBILITY_METHODS.fetch(child.method_name, current_visibility)
         end
@@ -222,23 +257,17 @@ module RuboCop
           return 0 unless class_node&.body
 
           public_methods = []
+          targeted_non_public = []
           visibility = :public
-
-          # Get all child nodes, handling both single method and begin-wrapped bodies
-          children = if class_node.body.begin_type?
-                       class_node.body.children
-                     else
-                       [class_node.body]
-                     end
+          children = scope_children(class_node)
 
           children.each do |child|
             next unless child
 
             case child.type
             when :send
-              visibility = VISIBILITY_METHODS[child.method_name] if VISIBILITY_METHODS.key?(child.method_name)
+              count_public_methods_handle_send(child, visibility, targeted_non_public).tap { |v| visibility = v if v }
             when :def
-              # Only count instance methods (def), not class methods (defs)
               if visibility == :public
                 method_name = child.method_name.to_s
                 public_methods << method_name unless excluded_method?(method_name)
@@ -246,10 +275,29 @@ module RuboCop
             end
           end
 
-          public_methods.size
+          (public_methods - targeted_non_public).size
         end
         # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
+        def count_public_methods_handle_send(child, visibility, targeted_non_public)
+          return visibility unless VISIBILITY_METHODS.key?(child.method_name)
+
+          if child.arguments.empty?
+            VISIBILITY_METHODS[child.method_name]
+          else
+            collect_targeted_non_public(child, targeted_non_public)
+            nil
+          end
+        end
+
+        def collect_targeted_non_public(child, targeted_non_public)
+          return if VISIBILITY_METHODS[child.method_name] == :public
+
+          child.arguments.each do |arg|
+            targeted_non_public << arg.value.to_s if arg.sym_type?
+          end
+        end
+
         def spec_has_examples?(spec_path, class_name)
           spec_content = File.read(spec_path)
           escaped_class_name = Regexp.escape(class_name)

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "1.2.2"
+    VERSION = "1.2.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Povilas Jurcys