rubocop-rspec_parity 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9e0dc1e3be84865d59b94dfae0d55c808bb307c2bfefd5f85bc66921048afbe
-  data.tar.gz: e6abf7807ddc099af831d46b90e5c18913c76f0be754553dbffef0c83f723eba
+  metadata.gz: 2d2f62960e2b46b31972221b577d79aed5b54db2f90b6d9cf277dcaa9b432e92
+  data.tar.gz: 320594b7e229f9910535fe7e30233a1f0d56a286676cc8fc636cd782f1c8f113
 SHA512:
-  metadata.gz: c434bf6e258c007681582e7666184bd5233ba260ab60f981e46140f7a420a28e6079ecc506810728f552e2aaacc3aa71f181df6d684e6fd8f8f28d4279ee2b8f
-  data.tar.gz: 4671da5c79fe882e1cc8808764430d819b30646594d39aadc774559eb1055c01903b869577bf38139f8a32acc9f6a10f72afcde256cc49bb7d88324785ece872
+  metadata.gz: da7f6916ecd8946f04ffdf8d67af1c566cbee961d120e2e1ad8fd2d78c8b0238989d4321b5eb5f3179aee0d28197bc88284283bffed042019001cffbaf2d2fc3
+  data.tar.gz: 43653613dfcef10d0a7c21485171a9532c045372354fc1df0ae244d436e4076568696b3b38591e015d0cd75360d39762d19243bd9ab1424a089530f2b04cd693

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [1.2.0] - 2026-02-09
+
+Added: `SufficientContexts` now counts direct `it` blocks alongside `context` blocks as an additional implicit context
+
 ## [1.1.0] - 2026-02-06
 
 Added: Support for checking wildcard spec files (`<model>_*_spec.rb`) in addition to base spec file, with automatic class validation

data/lib/rubocop/cop/rspec_parity/sufficient_contexts.rb

@@ -218,18 +218,25 @@ module RuboCop
 
         def count_contexts_for_method(spec_content, method_name)
           method_pattern = Regexp.escape(method_name)
-          context_count, has_examples = parse_spec_content(spec_content, method_pattern)
+          context_count, has_examples, has_direct_examples = parse_spec_content(spec_content, method_pattern)
 
-          # If no contexts but has examples, count as 1 scenario
-          context_count.zero? && has_examples ? 1 : context_count
+          if context_count.positive? && has_direct_examples
+            context_count + 1
+          elsif context_count.zero? && has_examples
+            1
+          else
+            context_count
+          end
         end
 
         # rubocop:disable Metrics/MethodLength
-        def parse_spec_content(spec_content, method_pattern)
+        def parse_spec_content(spec_content, method_pattern) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
           in_method_block = false
           context_count = 0
           has_examples = false
+          has_direct_examples = false
           base_indent = 0
+          child_indent = nil
 
           spec_content.each_line do |line|
             current_indent = line[/^\s*/].length
@@ -237,34 +244,30 @@ module RuboCop
             if matches_method_describe?(line, method_pattern)
               in_method_block = true
               base_indent = current_indent
+              child_indent = nil
               next
             end
 
             if in_method_block
-              context_count, has_examples, in_method_block = process_method_block_line(
-                line, current_indent, base_indent, context_count, has_examples
-              )
+              if exiting_block?(line, current_indent, base_indent)
+                in_method_block = false
+              elsif nested_context?(line)
+                child_indent ||= current_indent
+                context_count += 1
+              elsif nested_example?(line)
+                has_examples = true
+                child_indent ||= current_indent
+                has_direct_examples = true if current_indent == child_indent
+              end
             elsif matches_context_pattern?(line, method_pattern)
               context_count += 1
             end
           end
 
-          [context_count, has_examples]
+          [context_count, has_examples, has_direct_examples]
         end
         # rubocop:enable Metrics/MethodLength
 
-        def process_method_block_line(line, current_indent, base_indent, context_count, has_examples)
-          in_method_block = !exiting_block?(line, current_indent, base_indent)
-
-          if nested_context?(line)
-            context_count += 1
-          elsif nested_example?(line)
-            has_examples = true
-          end
-
-          [context_count, has_examples, in_method_block]
-        end
-
         def matches_method_describe?(line, method_pattern)
           line =~ /^\s*describe\s+['"](?:#|\.)?#{method_pattern}['"]/ ||
             line =~ /^\s*describe\s+:#{method_pattern}/
@@ -434,6 +437,8 @@ module RuboCop
           base_indent = lines[describe_line_index].match(/^(\s*)/)[1].length
           context_count = 0
           has_examples = false
+          has_direct_examples = false
+          child_indent = nil
 
           lines[(describe_line_index + 1)..].each do |line|
             indent = line.match(/^(\s*)/)[1].length
@@ -442,14 +447,22 @@ module RuboCop
             next unless indent > base_indent
 
             if line.match?(/^\s*(?:context|describe)\s+/)
+              child_indent ||= indent
               context_count += 1
             elsif line.match?(/^\s*(?:it|example|specify)\s+/)
               has_examples = true
+              child_indent ||= indent
+              has_direct_examples = true if indent == child_indent
             end
           end
 
-          # If no contexts but has examples, count as 1
-          context_count.zero? && has_examples ? 1 : context_count
+          if context_count.positive? && has_direct_examples
+            context_count + 1
+          elsif context_count.zero? && has_examples
+            1
+          else
+            context_count
+          end
         end
         # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
       end

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "1.1.0"
+    VERSION = "1.2.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Povilas Jurcys