rubocop-rspec 2.15.0 → 2.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e120f8d06ef760cbe4f3a3d077ca6cd8ceeb274a26042a6e1469fe9a280c969
-  data.tar.gz: 0c80cc155e8f64b03a97de1327e454d9ff2efb1a75b02e3b098f868afed30d17
+  metadata.gz: c31ad963289938a78bf4a8439ad44c6f1a2eaf852a25d715be483ebe71e622fc
+  data.tar.gz: 70b4e942004dd6654fa12c3ecaf7367c1f6bcf4bcd122573129984f5f0a66ff5
 SHA512:
-  metadata.gz: e982f97a23de2473c5cae6cd20bb653bcbcee806abddf0dda09c7b30692193858fc105c7b46ce3c004f28a7f680d1b3a475298c7b10d0e1499d5b80333fde504
-  data.tar.gz: c3b79b39a2c98d9103cb4edbf6c2d8e2cc957790fd8fa617e1fdece172f3dfaaf652bf482e7236a1da663f3b9afae943c17efee1e4a5f0293acc771bbc1c3c43
+  metadata.gz: 250a68082a8e6406df3934035e5ccba4e1a7f9a13e021e196911c15981a2f4557e7b7a98efa93f995ad164d2a52e41bf948f4c1fa7c9637829c3c219c8116f74
+  data.tar.gz: 7ce965fc56bf214eb65b63d2138cc710766ac16b476a63399271cc5562fb259cefc81cddcf3878f6324faf104d6552e48efcba2eff1fa0865bf463963e5a1a8e

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## Master (Unreleased)
 
+## 2.16.0 (2022-12-13)
+
+- Add new `RSpec/FactoryBot/FactoryNameStyle` cop. ([@ydah])
+- Improved processing speed for `RSpec/Be`, `RSpec/ExpectActual`, `RSpec/ImplicitExpect`, `RSpec/MessageSpies`, `RSpec/PredicateMatcher` and `RSpec/Rails/HaveHttpStatus`. ([@ydah])
+- Fix wrong autocorrection in `n_times` style on `RSpec/FactoryBot/CreateList`. ([@r7kamura])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` when using `generate` with multiple arguments. ([@ydah])
+- Mark `RSpec/BeEq` as `Safe: false` ([@r7kamura])
+- Add `RSpec/DuplicatedMetadata` cop. ([@r7kamura])
+- Mark `RSpec/BeEql` as `Safe: false`. ([@r7kamura])
+- Add `RSpec/PendingWithoutReason` cop. ([@r7kamura])
+
 ## 2.15.0 (2022-11-03)
 
 - Fix a false positive for `RSpec/RepeatedDescription` when different its block expectations are used. ([@ydah])

data/config/default.yml

@@ -147,13 +147,17 @@ RSpec/Be:
 RSpec/BeEq:
   Description: Check for expectations where `be(...)` can replace `eq(...)`.
   Enabled: pending
+  Safe: false
   VersionAdded: 2.9.0
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEq
 
 RSpec/BeEql:
   Description: Check for expectations where `be(...)` can replace `eql(...)`.
   Enabled: true
+  Safe: false
   VersionAdded: '1.7'
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEql
 
 RSpec/BeNil:
@@ -284,6 +288,12 @@ RSpec/Dialect:
   VersionAdded: '1.33'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
+RSpec/DuplicatedMetadata:
+  Description: Avoid duplicated metadata.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata
+
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
@@ -356,12 +366,6 @@ RSpec/ExampleWithoutDescription:
   VersionAdded: '1.22'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWithoutDescription
 
-RSpec/ExcessiveDocstringSpacing:
-  Description: Checks for excessive whitespace in example descriptions.
-  Enabled: pending
-  VersionAdded: '2.5'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
-
 RSpec/ExampleWording:
   Description: Checks for common mistakes in example descriptions.
   Enabled: true
@@ -378,6 +382,12 @@ RSpec/ExampleWording:
   StyleGuide: https://rspec.rubystyle.guide/#should-in-example-docstrings
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 
+RSpec/ExcessiveDocstringSpacing:
+  Description: Checks for excessive whitespace in example descriptions.
+  Enabled: pending
+  VersionAdded: '2.5'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
+
 RSpec/ExpectActual:
   Description: Checks for `expect(...)` calls containing literal values.
   Enabled: true
@@ -664,6 +674,12 @@ RSpec/Pending:
   VersionAdded: '1.25'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Pending
 
+RSpec/PendingWithoutReason:
+  Description: Checks for pending or skipped examples without reason.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason
+
 RSpec/PredicateMatcher:
   Description: Prefer using predicate matcher over using predicate method directly.
   Enabled: true
@@ -960,6 +976,16 @@ RSpec/FactoryBot/FactoryClassName:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName
 
+RSpec/FactoryBot/FactoryNameStyle:
+  Description: Checks for name style for argument of FactoryBot::Syntax::Methods.
+  Enabled: pending
+  VersionAdded: '2.16'
+  EnforcedStyle: symbol
+  SupportedStyles:
+    - symbol
+    - string
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryNameStyle
+
 RSpec/FactoryBot/SyntaxMethods:
   Description: Use shorthands from `FactoryBot::Syntax::Methods` in your specs.
   Enabled: pending
@@ -985,6 +1011,17 @@ RSpec/Rails/HaveHttpStatus:
   VersionAdded: '2.12'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HaveHttpStatus
 
+RSpec/Rails/HttpStatus:
+  Description: Enforces use of symbolic or numeric value to describe HTTP status.
+  Enabled: true
+  EnforcedStyle: symbolic
+  SupportedStyles:
+    - numeric
+    - symbolic
+  VersionAdded: '1.23'
+  VersionChanged: '2.0'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
+
 RSpec/Rails/InferredSpecType:
   Description: Identifies redundant spec type.
   Enabled: pending
@@ -1007,14 +1044,3 @@ RSpec/Rails/InferredSpecType:
     routing: routing
     system: system
     views: view
-
-RSpec/Rails/HttpStatus:
-  Description: Enforces use of symbolic or numeric value to describe HTTP status.
-  Enabled: true
-  EnforcedStyle: symbolic
-  SupportedStyles:
-    - numeric
-    - symbolic
-  VersionAdded: '1.23'
-  VersionChanged: '2.0'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus

data/lib/rubocop/cop/rspec/be.rb

@@ -21,6 +21,8 @@ module RuboCop
       class Be < Base
         MSG = "Don't use `be` without an argument."
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method be_without_args(node)
         def_node_matcher :be_without_args, <<-PATTERN
           (send _ #Runners.all $(send nil? :be))

data/lib/rubocop/cop/rspec/be_eq.rb

@@ -9,6 +9,9 @@ module RuboCop
       # using `==`. Booleans and nil can be compared by identity and therefore
       # the `be` matcher is preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eq(true)

data/lib/rubocop/cop/rspec/be_eql.rb

@@ -10,6 +10,9 @@ module RuboCop
       # can be compared by identity and therefore the `be` matcher is
       # preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eql(1)

data/lib/rubocop/cop/rspec/capybara/current_path_expectation.rb

@@ -29,7 +29,7 @@ module RuboCop
         #   # good
         #   expect(page).to have_current_path('/callback')
         #
-        class CurrentPathExpectation < Base
+        class CurrentPathExpectation < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Do not set an RSpec expectation on `current_path` in ' \
@@ -47,14 +47,14 @@ module RuboCop
           # @!method as_is_matcher(node)
           def_node_matcher :as_is_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               ${(send nil? :eq ...) (send nil? :match (regexp ...))})
           PATTERN
 
           # @!method regexp_str_matcher(node)
           def_node_matcher :regexp_str_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               $(send nil? :match (str $_)))
           PATTERN
 

data/lib/rubocop/cop/rspec/capybara/negation_matcher.rb

@@ -24,7 +24,7 @@ module RuboCop
         #   expect(page).to have_no_selector
         #   expect(page).to have_no_css('a')
         #
-        class NegationMatcher < Base
+        class NegationMatcher < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
 

data/lib/rubocop/cop/rspec/capybara/specific_actions.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   click_link(exact_text: 'foo')
         #   find('div').click_button
         #
-        class SpecificActions < Base
+        class SpecificActions < ::RuboCop::Cop::Base
           MSG = "Prefer `%<good_action>s` over `find('%<selector>s').click`."
           RESTRICT_ON_SEND = %i[click].freeze
           SPECIFIC_ACTION = {

data/lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -15,7 +15,7 @@ module RuboCop
         #   find_by_id('some-id')
         #   find_by_id('some-id', visible: true)
         #
-        class SpecificFinders < Base
+        class SpecificFinders < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           include RangeHelp

data/lib/rubocop/cop/rspec/capybara/specific_matcher.rb

@@ -26,9 +26,7 @@ module RuboCop
         #   expect(page).to have_select
         #   expect(page).to have_field('foo')
         #
-        class SpecificMatcher < Base
-          include CapybaraHelp
-
+        class SpecificMatcher < ::RuboCop::Cop::Base
           MSG = 'Prefer `%<good_matcher>s` over `%<bad_matcher>s`.'
           RESTRICT_ON_SEND = %i[have_selector have_no_selector have_css
                                 have_no_css].freeze
@@ -49,8 +47,8 @@ module RuboCop
             first_argument(node) do |arg|
               next unless (matcher = specific_matcher(arg))
               next if CssSelector.multiple_selectors?(arg)
-              next unless specific_option?(node, arg, matcher)
-              next unless specific_pseudo_classes?(arg)
+              next unless CapybaraHelp.specific_option?(node, arg, matcher)
+              next unless CapybaraHelp.specific_pseudo_classes?(arg)
 
               add_offense(node, message: message(node, matcher))
             end

data/lib/rubocop/cop/rspec/capybara/visibility_matcher.rb

@@ -26,7 +26,7 @@ module RuboCop
         #   expect(page).to have_css('.foo', visible: :all)
         #   expect(page).to have_link('my link', visible: :hidden)
         #
-        class VisibilityMatcher < Base
+        class VisibilityMatcher < ::RuboCop::Cop::Base
           MSG_FALSE = 'Use `:all` or `:hidden` instead of `false`.'
           MSG_TRUE = 'Use `:visible` instead of `true`.'
           CAPYBARA_MATCHER_METHODS = %w[

data/lib/rubocop/cop/rspec/duplicated_metadata.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Avoid duplicated metadata.
+      #
+      # @example
+      #   # bad
+      #   describe 'Something', :a, :a
+      #
+      #   # good
+      #   describe 'Something', :a
+      class DuplicatedMetadata < Base
+        extend AutoCorrector
+
+        include Metadata
+        include RangeHelp
+
+        MSG = 'Avoid duplicated metadata.'
+
+        def on_metadata(symbols, _pairs)
+          symbols.each do |symbol|
+            on_metadata_symbol(symbol)
+          end
+        end
+
+        private
+
+        def on_metadata_symbol(node)
+          return unless duplicated?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        def autocorrect(corrector, node)
+          corrector.remove(
+            range_with_surrounding_comma(
+              range_with_surrounding_space(
+                node.location.expression,
+                side: :left
+              ),
+              :left
+            )
+          )
+        end
+
+        def duplicated?(node)
+          node.left_siblings.any? do |sibling|
+            sibling.eql?(node)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/empty_line_after_example.rb

@@ -55,6 +55,8 @@ module RuboCop
           end
         end
 
+        private
+
         def allowed_one_liner?(node)
           consecutive_one_liner?(node) && allow_consecutive_one_liners?
         end

data/lib/rubocop/cop/rspec/expect_actual.rb

@@ -26,6 +26,8 @@ module RuboCop
 
         MSG = 'Provide the actual you are testing to `expect(...)`.'
 
+        RESTRICT_ON_SEND = Runners.all
+
         SIMPLE_LITERALS = %i[
           true
           false

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -25,7 +25,7 @@ module RuboCop
         #   # good
         #   count { 1 }
         #
-        class AttributeDefinedStatically < Base
+        class AttributeDefinedStatically < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Use a block to declare attribute values.'

data/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb

@@ -40,7 +40,7 @@ module RuboCop
         #     name: 'foo'
         #   )
         #
-        class ConsistentParenthesesStyle < Base
+        class ConsistentParenthesesStyle < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -69,6 +69,8 @@ module RuboCop
             return if ambiguous_without_parentheses?(node)
 
             factory_call(node) do
+              return if node.method?(:generate) && node.arguments.count > 1
+
               if node.parenthesized?
                 process_with_parentheses(node)
               else
@@ -77,6 +79,8 @@ module RuboCop
             end
           end
 
+          private
+
           def process_with_parentheses(node)
             return unless style == :omit_parentheses
             return unless same_line?(node, node.first_argument)
@@ -102,8 +106,6 @@ module RuboCop
               node.parent&.array_type?
           end
 
-          private
-
           def remove_parentheses(corrector, node)
             corrector.replace(node.location.begin, ' ')
             corrector.remove(node.location.end)

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -31,7 +31,7 @@ module RuboCop
         #   # good
         #   3.times { create :user }
         #
-        class CreateList < Base
+        class CreateList < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -143,7 +143,7 @@ module RuboCop
 
             def call(corrector)
               replacement = generate_n_times_block(node)
-              corrector.replace(node, replacement)
+              corrector.replace(node.block_node || node, replacement)
             end
 
             private
@@ -159,8 +159,15 @@ module RuboCop
 
               replacement = format_receiver(node.receiver)
               replacement += format_method_call(node, 'create', arguments)
+              replacement += " #{factory_call_block_source}" if node.block_node
               "#{count.source}.times { #{replacement} }"
             end
+
+            def factory_call_block_source
+              node.block_node.location.begin.with(
+                end_pos: node.block_node.location.end.end_pos
+              ).source
+            end
           end
 
           # :nodoc:

data/lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   factory :foo, class: 'Foo' do
         #   end
         #
-        class FactoryClassName < Base
+        class FactoryClassName < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = "Pass '%<class_name>s' string instead of `%<class_name>s` " \

data/lib/rubocop/cop/rspec/factory_bot/factory_name_style.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module FactoryBot
+        # Checks for name style for argument of FactoryBot::Syntax::Methods.
+        #
+        # @example EnforcedStyle: symbol (default)
+        #   # bad
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        #   # good
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        # @example EnforcedStyle: string
+        #   # bad
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        #   # good
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        class FactoryNameStyle < ::RuboCop::Cop::Base
+          extend AutoCorrector
+          include ConfigurableEnforcedStyle
+          include RuboCop::RSpec::FactoryBot::Language
+
+          MSG = 'Use %<prefer>s to refer to a factory.'
+          FACTORY_CALLS = RuboCop::RSpec::FactoryBot::Language::METHODS
+          RESTRICT_ON_SEND = FACTORY_CALLS
+
+          # @!method factory_call(node)
+          def_node_matcher :factory_call, <<-PATTERN
+          (send
+            {#factory_bot? nil?} %FACTORY_CALLS
+            ${str sym} ...
+          )
+          PATTERN
+
+          def on_send(node)
+            factory_call(node) do |name|
+              if offense_for_symbol_style?(name)
+                register_offense(name, name.value.to_sym.inspect)
+              elsif offense_for_string_style?(name)
+                register_offense(name, name.value.to_s.inspect)
+              end
+            end
+          end
+
+          private
+
+          def offense_for_symbol_style?(name)
+            name.str_type? && style == :symbol
+          end
+
+          def offense_for_string_style?(name)
+            name.sym_type? && style == :string
+          end
+
+          def register_offense(name, prefer)
+            add_offense(name,
+                        message: format(MSG, prefer: style.to_s)) do |corrector|
+              corrector.replace(name, prefer)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/implicit_expect.rb

@@ -28,6 +28,8 @@ module RuboCop
 
         MSG = 'Prefer `%<good>s` over `%<bad>s`.'
 
+        RESTRICT_ON_SEND = Runners.all + %i[should should_not]
+
         # @!method implicit_expect(node)
         def_node_matcher :implicit_expect, <<-PATTERN
           {

data/lib/rubocop/cop/rspec/leading_subject.rb

@@ -44,6 +44,8 @@ module RuboCop
           check_previous_nodes(node)
         end
 
+        private
+
         def check_previous_nodes(node)
           offending_node(node) do |offender|
             msg = format(MSG, offending: offender.method_name)
@@ -53,8 +55,6 @@ module RuboCop
           end
         end
 
-        private
-
         def offending_node(node)
           parent(node).each_child_node.find do |sibling|
             break if sibling.equal?(node)

data/lib/rubocop/cop/rspec/message_spies.rb

@@ -41,6 +41,8 @@ module RuboCop
 
         SUPPORTED_STYLES = %w[have_received receive].freeze
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method message_expectation(node)
         def_node_matcher :message_expectation, %(
           (send (send nil? :expect $_) #Runners.all ...)

data/lib/rubocop/cop/rspec/mixin/metadata.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Helper methods to find RSpec metadata.
+      module Metadata
+        extend RuboCop::NodePattern::Macros
+
+        include RuboCop::RSpec::Language
+
+        # @!method rspec_metadata(node)
+        def_node_matcher :rspec_metadata, <<~PATTERN
+          (block
+            (send
+              #rspec? {#Examples.all #ExampleGroups.all #SharedGroups.all #Hooks.all} _ ${send str sym}* (hash $...)?)
+            ...)
+        PATTERN
+
+        # @!method rspec_configure(node)
+        def_node_matcher :rspec_configure, <<~PATTERN
+          (block (send #rspec? :configure) (args (arg $_)) ...)
+        PATTERN
+
+        # @!method metadata_in_block(node)
+        def_node_search :metadata_in_block, <<~PATTERN
+          (send (lvar %) #Hooks.all _ ${send str sym}* (hash $...)?)
+        PATTERN
+
+        def on_block(node)
+          rspec_configure(node) do |block_var|
+            metadata_in_block(node, block_var) do |symbols, pairs|
+              on_metadata(symbols, pairs.flatten)
+            end
+          end
+
+          rspec_metadata(node) do |symbols, pairs|
+            on_metadata(symbols, pairs.flatten)
+          end
+        end
+        alias on_numblock on_block
+
+        def on_metadata(_symbols, _pairs)
+          raise ::NotImplementedError
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/pending_without_reason.rb

@@ -0,0 +1,123 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for pending or skipped examples without reason.
+      #
+      # @example
+      #   # bad
+      #   pending 'does something' do
+      #   end
+      #
+      #   # bad
+      #   it 'does something', :pending do
+      #   end
+      #
+      #   # bad
+      #   it 'does something' do
+      #     pending
+      #   end
+      #
+      #   # bad
+      #   xdescribe 'something' do
+      #   end
+      #
+      #   # bad
+      #   skip 'does something' do
+      #   end
+      #
+      #   # bad
+      #   it 'does something', :skip do
+      #   end
+      #
+      #   # bad
+      #   it 'does something' do
+      #     skip
+      #   end
+      #
+      #   # bad
+      #   it 'does something'
+      #
+      #   # good
+      #   it 'does something' do
+      #     pending 'reason'
+      #   end
+      #
+      #   # good
+      #   it 'does something' do
+      #     skip 'reason'
+      #   end
+      #
+      #   # good
+      #   it 'does something', pending: 'reason' do
+      #   end
+      #
+      #   # good
+      #   it 'does something', skip: 'reason' do
+      #   end
+      class PendingWithoutReason < Base
+        MSG = 'Give the reason for pending or skip.'
+
+        # @!method pending_by_example_method?(node)
+        def_node_matcher :pending_by_example_method?, block_pattern(<<~PATTERN)
+          #Examples.pending
+        PATTERN
+
+        # @!method pending_by_metadata_without_reason?(node)
+        def_node_matcher :pending_by_metadata_without_reason?, <<~PATTERN
+          (send #rspec? {#ExampleGroups.all #Examples.all} ... {<(sym :pending) ...> (hash <(pair (sym :pending) true) ...>)})
+        PATTERN
+
+        # @!method skipped_by_example_method?(node)
+        def_node_matcher :skipped_by_example_method?, block_pattern(<<~PATTERN)
+          #Examples.skipped
+        PATTERN
+
+        # @!method skipped_by_example_group_method?(node)
+        def_node_matcher(
+          :skipped_by_example_group_method?,
+          block_pattern(<<~PATTERN)
+            #ExampleGroups.skipped
+          PATTERN
+        )
+
+        # @!method skipped_by_metadata_without_reason?(node)
+        def_node_matcher :skipped_by_metadata_without_reason?, <<~PATTERN
+          (send #rspec? {#ExampleGroups.all #Examples.all} ... {<(sym :skip) ...> (hash <(pair (sym :skip) true) ...>)})
+        PATTERN
+
+        def on_send(node)
+          if pending_without_reason?(node)
+            add_offense(node, message: 'Give the reason for pending.')
+          elsif skipped_without_reason?(node)
+            add_offense(node, message: 'Give the reason for skip.')
+          end
+        end
+
+        private
+
+        def pending_by_pending_step_without_reason?(node)
+          node.method?(:pending) && node.first_argument.nil?
+        end
+
+        def pending_without_reason?(node)
+          pending_by_example_method?(node.block_node) ||
+            pending_by_metadata_without_reason?(node) ||
+            pending_by_pending_step_without_reason?(node)
+        end
+
+        def skipped_by_skip_step_without_reason?(node)
+          node.method?(:skip) && node.first_argument.nil?
+        end
+
+        def skipped_without_reason?(node)
+          skipped_by_example_group_method?(node.block_node) ||
+            skipped_by_example_method?(node.block_node) ||
+            skipped_by_metadata_without_reason?(node) ||
+            skipped_by_skip_step_without_reason?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -283,6 +283,8 @@ module RuboCop
         include InflectedHelper
         include ExplicitHelper
 
+        RESTRICT_ON_SEND = Runners.all
+
         def on_send(node)
           case style
           when :inflected

data/lib/rubocop/cop/rspec/rails/have_http_status.rb

@@ -13,20 +13,23 @@ module RuboCop
         #   # good
         #   expect(response).to have_http_status(200)
         #
-        class HaveHttpStatus < Base
+        class HaveHttpStatus < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG =
             'Prefer `expect(response).%<to>s have_http_status(%<status>i)` ' \
             'over `expect(response.status).%<to>s %<match>s`.'
 
+          RUNNERS = %i[to to_not not_to].to_set
+          RESTRICT_ON_SEND = RUNNERS
+
           # @!method match_status(node)
           def_node_matcher :match_status, <<-PATTERN
             (send
               (send nil? :expect
                 $(send (send nil? :response) :status)
               )
-              $#Runners.all
+              $RUNNERS
               $(send nil? {:be :eq :eql :equal} (int $_))
             )
           PATTERN

data/lib/rubocop/cop/rspec/rails/inferred_spec_type.rb

@@ -33,7 +33,7 @@ module RuboCop
         #
         # @example `Inferences` configuration
         #   # .rubocop.yml
-        #   # RSpec/InferredSpecType:
+        #   # RSpec/Rails/InferredSpecType:
         #   #   Inferences:
         #   #     services: service
         #

data/lib/rubocop/cop/rspec/scattered_setup.rb

@@ -41,6 +41,8 @@ module RuboCop
           end
         end
 
+        private
+
         def repeated_hooks(node)
           hooks = RuboCop::RSpec::ExampleGroup.new(node)
             .hooks

data/lib/rubocop/cop/rspec/sort_metadata.rb

@@ -18,45 +18,12 @@ module RuboCop
       #
       class SortMetadata < Base
         extend AutoCorrector
+        include Metadata
         include RangeHelp
 
         MSG = 'Sort metadata alphabetically.'
 
-        # @!method rspec_metadata(node)
-        def_node_matcher :rspec_metadata, <<~PATTERN
-          (block
-            (send
-              #rspec? {#Examples.all #ExampleGroups.all #SharedGroups.all #Hooks.all} _ ${send str sym}* (hash $...)?)
-            ...)
-        PATTERN
-
-        # @!method rspec_configure(node)
-        def_node_matcher :rspec_configure, <<~PATTERN
-          (block (send #rspec? :configure) (args (arg $_)) ...)
-        PATTERN
-
-        # @!method metadata_in_block(node)
-        def_node_search :metadata_in_block, <<~PATTERN
-          (send (lvar %) #Hooks.all _ ${send str sym}* (hash $...)?)
-        PATTERN
-
-        def on_block(node)
-          rspec_configure(node) do |block_var|
-            metadata_in_block(node, block_var) do |symbols, pairs|
-              investigate(symbols, pairs.flatten)
-            end
-          end
-
-          rspec_metadata(node) do |symbols, pairs|
-            investigate(symbols, pairs.flatten)
-          end
-        end
-
-        alias on_numblock on_block
-
-        private
-
-        def investigate(symbols, pairs)
+        def on_metadata(symbols, pairs)
           return if sorted?(symbols, pairs)
 
           crime_scene = crime_scene(symbols, pairs)
@@ -65,6 +32,8 @@ module RuboCop
           end
         end
 
+        private
+
         def crime_scene(symbols, pairs)
           metadata = symbols + pairs
 

data/lib/rubocop/cop/rspec/stubbed_mock.rb

@@ -133,6 +133,8 @@ module RuboCop
           }
         PATTERN
 
+        RESTRICT_ON_SEND = %i[to].freeze
+
         def on_send(node)
           expectation(node, &method(:on_expectation))
         end

data/lib/rubocop/cop/rspec/unspecified_exception.rb

@@ -50,6 +50,8 @@ module RuboCop
           add_offense(node.children.last)
         end
 
+        private
+
         def empty_exception_matcher?(node)
           empty_raise_error_or_exception(node) && !block_with_args?(node.parent)
         end

data/lib/rubocop/cop/rspec_cops.rb

@@ -12,6 +12,7 @@ require_relative 'rspec/factory_bot/attribute_defined_statically'
 require_relative 'rspec/factory_bot/consistent_parentheses_style'
 require_relative 'rspec/factory_bot/create_list'
 require_relative 'rspec/factory_bot/factory_class_name'
+require_relative 'rspec/factory_bot/factory_name_style'
 require_relative 'rspec/factory_bot/syntax_methods'
 
 require_relative 'rspec/rails/avoid_setup_hook'
@@ -42,6 +43,7 @@ require_relative 'rspec/describe_symbol'
 require_relative 'rspec/described_class'
 require_relative 'rspec/described_class_module_wrapping'
 require_relative 'rspec/dialect'
+require_relative 'rspec/duplicated_metadata'
 require_relative 'rspec/empty_example_group'
 require_relative 'rspec/empty_hook'
 require_relative 'rspec/empty_line_after_example'
@@ -87,6 +89,7 @@ require_relative 'rspec/no_expectation_example'
 require_relative 'rspec/not_to_not'
 require_relative 'rspec/overwriting_setup'
 require_relative 'rspec/pending'
+require_relative 'rspec/pending_without_reason'
 require_relative 'rspec/predicate_matcher'
 require_relative 'rspec/receive_counts'
 require_relative 'rspec/receive_never'

data/lib/rubocop/rspec/config_formatter.rb

@@ -9,7 +9,7 @@ module RuboCop
       EXTENSION_ROOT_DEPARTMENT = %r{^(RSpec/)}.freeze
       SUBDEPARTMENTS = %(RSpec/Capybara RSpec/FactoryBot RSpec/Rails)
       AMENDMENTS = %(Metrics/BlockLength)
-      COP_DOC_BASE_URL = 'https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/'
+      COP_DOC_BASE_URL = 'https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/'
 
       def initialize(config, descriptions)
         @config       = config
@@ -47,7 +47,7 @@ module RuboCop
       end
 
       def reference(cop)
-        COP_DOC_BASE_URL + cop.sub('RSpec/', '')
+        COP_DOC_BASE_URL + cop
       end
 
       attr_reader :config, :descriptions

data/lib/rubocop/rspec/description_extractor.rb

@@ -21,7 +21,8 @@ module RuboCop
 
       # Decorator of a YARD code object for working with documented rspec cops
       class CodeObject
-        COP_CLASS_NAME = 'RuboCop::Cop::RSpec::Base'
+        RSPEC_COP_CLASS_NAME = 'RuboCop::Cop::RSpec::Base'
+        RUBOCOP_COP_CLASS_NAME = 'RuboCop::Cop::Base'
         RSPEC_NAMESPACE = 'RuboCop::Cop::RSpec'
 
         def initialize(yardoc)
@@ -32,10 +33,7 @@ module RuboCop
         #
         # @return [Boolean]
         def rspec_cop?
-          class_documentation? &&
-            rspec_cop_namespace? &&
-            cop_subclass? &&
-            !abstract?
+          cop_subclass? && !abstract? && rspec_cop_namespace?
         end
 
         # Configuration for the documented cop that would live in default.yml
@@ -55,10 +53,6 @@ module RuboCop
           yardoc.docstring.split("\n\n").first.to_s
         end
 
-        def class_documentation?
-          yardoc.type.equal?(:class)
-        end
-
         def rspec_cop_namespace?
           documented_constant.start_with?(RSPEC_NAMESPACE)
         end
@@ -68,7 +62,8 @@ module RuboCop
         end
 
         def cop_subclass?
-          yardoc.superclass.path == COP_CLASS_NAME
+          yardoc.superclass.path == RSPEC_COP_CLASS_NAME ||
+            yardoc.superclass.path == RUBOCOP_COP_CLASS_NAME
         end
 
         def abstract?

data/lib/rubocop/rspec/language.rb

@@ -160,8 +160,12 @@ module RuboCop
 
       module Runners # :nodoc:
         ALL = %i[to to_not not_to].freeze
-        def self.all(element)
-          ALL.include?(element)
+        class << self
+          def all(element = nil)
+            return ALL if element.nil?
+
+            ALL.include?(element)
+          end
         end
       end
 

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '2.15.0'
+      STRING = '2.16.0'
     end
   end
 end

data/lib/rubocop-rspec.rb

@@ -6,34 +6,39 @@ require 'yaml'
 require 'rubocop'
 
 require_relative 'rubocop/rspec'
-require_relative 'rubocop/rspec/version'
 require_relative 'rubocop/rspec/inject'
+require_relative 'rubocop/rspec/language/node_pattern'
 require_relative 'rubocop/rspec/node'
+require_relative 'rubocop/rspec/version'
 require_relative 'rubocop/rspec/wording'
-require_relative 'rubocop/rspec/language/node_pattern'
+
+# Dependent on `RuboCop::RSpec::Language::NodePattern`.
 require_relative 'rubocop/rspec/language'
 
 require_relative 'rubocop/rspec/factory_bot/language'
 
-require_relative 'rubocop/cop/rspec/mixin/top_level_group'
-require_relative 'rubocop/cop/rspec/mixin/variable'
+require_relative 'rubocop/cop/rspec/mixin/capybara_help'
+require_relative 'rubocop/cop/rspec/mixin/css_selector'
 require_relative 'rubocop/cop/rspec/mixin/final_end_location'
-require_relative 'rubocop/cop/rspec/mixin/comments_help'
-require_relative 'rubocop/cop/rspec/mixin/empty_line_separation'
 require_relative 'rubocop/cop/rspec/mixin/inside_example_group'
+require_relative 'rubocop/cop/rspec/mixin/metadata'
 require_relative 'rubocop/cop/rspec/mixin/namespace'
-require_relative 'rubocop/cop/rspec/mixin/css_selector'
 require_relative 'rubocop/cop/rspec/mixin/skip_or_pending'
-require_relative 'rubocop/cop/rspec/mixin/capybara_help'
+require_relative 'rubocop/cop/rspec/mixin/top_level_group'
+require_relative 'rubocop/cop/rspec/mixin/variable'
+
+# Dependent on `RuboCop::Cop::RSpec::FinalEndLocation`.
+require_relative 'rubocop/cop/rspec/mixin/comments_help'
+require_relative 'rubocop/cop/rspec/mixin/empty_line_separation'
 
-require_relative 'rubocop/rspec/concept'
-require_relative 'rubocop/rspec/example_group'
-require_relative 'rubocop/rspec/example'
-require_relative 'rubocop/rspec/hook'
 require_relative 'rubocop/cop/rspec/base'
 require_relative 'rubocop/rspec/align_let_brace'
-require_relative 'rubocop/rspec/factory_bot'
+require_relative 'rubocop/rspec/concept'
 require_relative 'rubocop/rspec/corrector/move_node'
+require_relative 'rubocop/rspec/example'
+require_relative 'rubocop/rspec/example_group'
+require_relative 'rubocop/rspec/factory_bot'
+require_relative 'rubocop/rspec/hook'
 
 RuboCop::RSpec::Inject.defaults!
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 2.15.0
+  version: 2.16.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-03 00:00:00.000000000 Z
+date: 2022-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -73,6 +73,7 @@ files:
 - lib/rubocop/cop/rspec/described_class.rb
 - lib/rubocop/cop/rspec/described_class_module_wrapping.rb
 - lib/rubocop/cop/rspec/dialect.rb
+- lib/rubocop/cop/rspec/duplicated_metadata.rb
 - lib/rubocop/cop/rspec/empty_example_group.rb
 - lib/rubocop/cop/rspec/empty_hook.rb
 - lib/rubocop/cop/rspec/empty_line_after_example.rb
@@ -92,6 +93,7 @@ files:
 - lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb
 - lib/rubocop/cop/rspec/factory_bot/create_list.rb
 - lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb
+- lib/rubocop/cop/rspec/factory_bot/factory_name_style.rb
 - lib/rubocop/cop/rspec/factory_bot/syntax_methods.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
@@ -119,6 +121,7 @@ files:
 - lib/rubocop/cop/rspec/mixin/empty_line_separation.rb
 - lib/rubocop/cop/rspec/mixin/final_end_location.rb
 - lib/rubocop/cop/rspec/mixin/inside_example_group.rb
+- lib/rubocop/cop/rspec/mixin/metadata.rb
 - lib/rubocop/cop/rspec/mixin/namespace.rb
 - lib/rubocop/cop/rspec/mixin/skip_or_pending.rb
 - lib/rubocop/cop/rspec/mixin/top_level_group.rb
@@ -133,6 +136,7 @@ files:
 - lib/rubocop/cop/rspec/not_to_not.rb
 - lib/rubocop/cop/rspec/overwriting_setup.rb
 - lib/rubocop/cop/rspec/pending.rb
+- lib/rubocop/cop/rspec/pending_without_reason.rb
 - lib/rubocop/cop/rspec/predicate_matcher.rb
 - lib/rubocop/cop/rspec/rails/avoid_setup_hook.rb
 - lib/rubocop/cop/rspec/rails/have_http_status.rb