rubocop-rspec 2.13.1 → 2.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: beb4503a6d6d420e50748e9fd6c679a2968888d783293c33da2dbaf6d7a9fc3f
-  data.tar.gz: 4dff5e6a61c80d1acc943169efdb65a24fa5dd05654bf758c4f6b291aedad63c
+  metadata.gz: f7da4fe826259c4b6981fabc58abafd9d91d121a35b538f40953af7f152dca15
+  data.tar.gz: fd8a448c3534ad861e218b92d198d1ca0a6375f95dfc9fdf87cb4bbfe7fd956a
 SHA512:
-  metadata.gz: 7937a46e61db588b4b9354ec362af79585526e7d95a7bc735435ace552b44e354f32e8f10310460059b71870a1caf8617414edd663cf8b50e9f13405977123a4
-  data.tar.gz: 7c4a57c7635e827717d10f253233837e7b9c11c5769fd4d9aab7c7c110d808f83c6099663684237c499432f606891b7a8aa9142c302e09ad5e73391b70f29a8e
+  metadata.gz: 5bf56052d556e623c3b7ffd93eed6dd2931c59b869de859a9f58ff8408ae87ad87a576cd53ce351c759ced16434749b4e2d18f5bfc5547c124b81c7c17432014
+  data.tar.gz: 0134a9c72e903bf20e60a7e0ac16cee7d9e3846e7e65832b4950d5d9dca3292e76238e6c1382984c050a07d475978efdf65b54961de3a95b11a0833b4da5f00d

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Master (Unreleased)
 
+## 2.13.2 (2022-09-23)
+
+* Fix an error for `RSpec/Capybara/SpecificFinders` with no parentheses. ([@ydah][])
+* Fix a false positive for `RSpec/NoExpectationExample` with pending using `skip` or `pending` inside an example. ([@ydah][])
+* Exclude `have_text` and `have_content` that raise `ArgumentError` with `RSpec/Capybara/VisibilityMatcher` where `:visible` is an invalid option. ([@ydah][])
+* Fix a false negative for `RSpec/Capybara/VisibilityMatcher` with negative matchers. ([@ydah][])
+
 ## 2.13.1 (2022-09-12)
 
 * Include config/obsoletion.yml in the gemspec. ([@hosamaly][])

data/lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -76,8 +76,15 @@ module RuboCop
           end
 
           def offense_range(node)
-            range_between(node.loc.selector.begin_pos,
-                          node.loc.end.end_pos)
+            range_between(node.loc.selector.begin_pos, end_pos(node))
+          end
+
+          def end_pos(node)
+            if node.loc.end
+              node.loc.end.end_pos
+            else
+              node.loc.expression.end_pos
+            end
           end
         end
       end

data/lib/rubocop/cop/rspec/capybara/visibility_matcher.rb

@@ -29,20 +29,20 @@ module RuboCop
         class VisibilityMatcher < Base
           MSG_FALSE = 'Use `:all` or `:hidden` instead of `false`.'
           MSG_TRUE = 'Use `:visible` instead of `true`.'
-          CAPYBARA_MATCHER_METHODS = %i[
-            have_selector
-            have_css
-            have_xpath
-            have_link
-            have_button
-            have_field
-            have_select
-            have_table
-            have_checked_field
-            have_unchecked_field
-            have_text
-            have_content
-          ].freeze
+          CAPYBARA_MATCHER_METHODS = %w[
+            button
+            checked_field
+            css
+            field
+            link
+            select
+            selector
+            table
+            unchecked_field
+            xpath
+          ].flat_map do |element|
+            ["have_#{element}".to_sym, "have_no_#{element}".to_sym]
+          end
 
           RESTRICT_ON_SEND = CAPYBARA_MATCHER_METHODS
 

data/lib/rubocop/cop/rspec/no_expectation_example.rb

@@ -49,10 +49,18 @@ module RuboCop
           send_pattern('#Expectations.all')
         )
 
+        # @!method including_any_skip_example?(node)
+        # @param [RuboCop::AST::Node] node
+        # @return [Boolean]
+        def_node_search :including_any_skip_example?, <<~PATTERN
+          (send nil? {:pending :skip} ...)
+        PATTERN
+
         # @param [RuboCop::AST::BlockNode] node
         def on_block(node)
           return unless regular_or_focused_example?(node)
           return if including_any_expectation?(node)
+          return if including_any_skip_example?(node)
 
           add_offense(node)
         end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '2.13.1'
+      STRING = '2.13.2'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 2.13.1
+  version: 2.13.2
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-12 00:00:00.000000000 Z
+date: 2022-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop