rubocop-rspec 1.7.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc482ce2af79693a4824889cb1f4e418936466f9
-  data.tar.gz: f0f1ff329a1a1cf4642f38c64258370ae4b269f6
+  metadata.gz: 6bfc346a6e12eab244a17f9fc8401bfb1c4c8d86
+  data.tar.gz: f0b9285af75fab2774940505d868ef097936d8ec
 SHA512:
-  metadata.gz: 871f9e04aaa056cbe3d0b3b73ef22b0ebcf6b1d2c242d94dc823e73a5b93a87683ffc24844a81bfe82849a85baf66d27800a07c7e069b62329da563c3467ef46
-  data.tar.gz: 866bf67d2e134be5e153ad066f7c6c04eec42647e2aad769745a4a4708005a93a437cf0427389170a57c00463bd02a66a05995e5d1f5362cfb38d0d7c025c8c6
+  metadata.gz: ed95fbfc52c82a0f4c7674a675e805ca1649c8088734fc19c31d73c70eb2c15cee292d36579184ff2f61beb13492543d9cac5b19abb3190de23ebbfc168dd0a1
+  data.tar.gz: b225fca79ccc76547a283c140b2e5add1430c13dcb5bd3db74a0b68d7fa7a4546be8aa5d1ad9e67387969f9c72bd3ce8702e6255d7a048e542a9ff975ddfa596

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Master (unreleased)
 
+## 1.8.0 (2016-10-27)
+
+* Optionally ignore method names in the `describe` argument when running the `FilePath` cop. ([@bquorning][])
+* Fix regression in how `FilePath` converts alphanumeric class names into paths. ([@bquorning][])
+* Add `ImplicitExpect` cop for enforcing `should` vs. `is_expected.to`. ([@backus][])
+* Disable `MessageExpectation` cop in the default configuration. ([@bquorning][])
+
 ## 1.7.0 (2016-08-24)
 
 * Add support for checking all example groups with `ExampleLength`. ([@backus][])

data/README.md

@@ -1,10 +1,11 @@
 # RuboCop RSpec
 
+[![Join the chat at https://gitter.im/rubocop-rspec/Lobby](https://badges.gitter.im/rubocop-rspec/Lobby.svg)](https://gitter.im/rubocop-rspec/Lobby)
 [![Gem Version](https://badge.fury.io/rb/rubocop-rspec.svg)](https://rubygems.org/gems/rubocop-rspec)
-[![Dependency Status](https://gemnasium.com/nevir/rubocop-rspec.svg)](https://gemnasium.com/nevir/rubocop-rspec)
-[![Build Status](https://secure.travis-ci.org/nevir/rubocop-rspec.svg?branch=master)](http://travis-ci.org/nevir/rubocop-rspec)
-[![Coverage Status](https://codeclimate.com/github/nevir/rubocop-rspec/badges/coverage.svg)](https://codeclimate.com/github/nevir/rubocop-rspec/coverage)
-[![Code Climate](https://codeclimate.com/github/nevir/rubocop-rspec.svg)](https://codeclimate.com/github/nevir/rubocop-rspec)
+[![Dependency Status](https://gemnasium.com/backus/rubocop-rspec.svg)](https://gemnasium.com/backus/rubocop-rspec)
+[![Build Status](https://secure.travis-ci.org/backus/rubocop-rspec.svg?branch=master)](http://travis-ci.org/backus/rubocop-rspec)
+[![Coverage Status](https://codeclimate.com/github/backus/rubocop-rspec/badges/coverage.svg)](https://codeclimate.com/github/backus/rubocop-rspec/coverage)
+[![Code Climate](https://codeclimate.com/github/backus/rubocop-rspec/badges/gpa.svg)](https://codeclimate.com/github/backus/rubocop-rspec)
 
 RSpec-specific analysis for your projects, as an extension to
 [RuboCop](https://github.com/bbatsov/rubocop).

data/Rakefile

@@ -24,10 +24,7 @@ end
 
 desc 'Run RuboCop over this gem'
 task :internal_investigation do
-  require 'rubocop-rspec'
-
-  result = RuboCop::CLI.new.run
-  abort('RuboCop failed!') unless result.zero?
+  sh('bundle exec rubocop --require rubocop-rspec')
 end
 
 desc 'Build config/default.yml'

data/config/default.yml

@@ -13,15 +13,6 @@ RSpec/BeEql:
   Description: Check for expectations where `be(...)` can replace `eql(...)`.
   Enabled: true
 
-RSpec/HookArgument:
-  Description: Checks the arguments passed to `before`, `around`, and `after`.
-  Enabled: true
-  EnforcedStyle: implicit
-  SupportedStyles:
-  - implicit
-  - each
-  - example
-
 RSpec/DescribeClass:
   Description: Check that the first argument to the top level describe is a constant.
   Enabled: true
@@ -35,6 +26,16 @@ RSpec/DescribeMethod:
   Description: Checks that the second argument to `describe` specifies a method.
   Enabled: true
 
+RSpec/EmptyExampleGroup:
+  Description: Checks if an example group does not include any tests.
+  Enabled: true
+  CustomIncludeMethods: []
+
+RSpec/ExampleLength:
+  Description: Checks for long examples.
+  Enabled: true
+  Max: 5
+
 RSpec/ExampleWording:
   Description: Checks that example descriptions do not start with "should".
   Enabled: true
@@ -44,87 +45,95 @@ RSpec/ExampleWording:
     not: does not
   IgnoredWords: []
 
-RSpec/EmptyExampleGroup:
-  Description: Checks if an example group does not include any tests.
-  Enabled: true
-  CustomIncludeMethods: []
-
 RSpec/ExpectActual:
   Description: Checks for `expect(...)` calls containing literal values.
   Enabled: true
 
-RSpec/MessageChain:
-  Description: Check that chains of messages are not being stubbed.
+RSpec/FilePath:
+  Description: Checks that spec file paths are consistent with the test subject.
   Enabled: true
+  CustomTransform:
+    RuboCop: rubocop
+    RSpec: rspec
+  IgnoreMethods: false
 
-RSpec/MultipleDescribes:
-  Description: Checks for multiple top level describes.
+RSpec/Focus:
+  Description: Checks if examples are focused.
   Enabled: true
 
-RSpec/MultipleExpectations:
-  Description: Checks if examples contain too many `expect` calls.
+RSpec/HookArgument:
+  Description: Checks the arguments passed to `before`, `around`, and `after`.
   Enabled: true
-  Max: 1
+  EnforcedStyle: implicit
+  SupportedStyles:
+  - implicit
+  - each
+  - example
 
-RSpec/NestedGroups:
-  Description: Checks for nested example groups.
+RSpec/ImplicitExpect:
+  Description: Check that a consistent implicit expectation style is used.
   Enabled: true
-  MaxNesting: 2
+  EnforcedStyle: is_expected
+  SupportedStyles:
+  - is_expected
+  - should
 
 RSpec/InstanceVariable:
   Description: Checks for instance variable usage in specs.
   AssignmentOnly: false
   Enabled: true
 
-RSpec/LetSetup:
-  Description: Checks unreferenced `let!` calls being used for test setup.
-  Enabled: true
-
 RSpec/LeadingSubject:
   Description: Checks for `subject` definitions that come after `let` definitions.
   Enabled: true
 
-RSpec/FilePath:
-  Description: Checks that spec file paths are consistent with the test subject.
-  Enabled: true
-  CustomTransform:
-    RuboCop: rubocop
-    RSpec: rspec
-
-RSpec/VerifiedDoubles:
-  Description: Prefer using verifying doubles over normal doubles.
-  Enabled: true
-  IgnoreSymbolicNames: false
-
-RSpec/NotToNot:
-  Description: Checks for consistent method usage for negating expectations.
-  EnforcedStyle: not_to
-  SupportedStyles:
-  - not_to
-  - to_not
-  Enabled: true
-
-RSpec/Focus:
-  Description: Checks if examples are focused.
+RSpec/LetSetup:
+  Description: Checks unreferenced `let!` calls being used for test setup.
   Enabled: true
 
-RSpec/ExampleLength:
-  Description: Checks for long examples.
+RSpec/MessageChain:
+  Description: Check that chains of messages are not being stubbed.
   Enabled: true
-  Max: 5
 
 RSpec/MessageExpectation:
   Description: Checks for consistent message expectation style.
-  Enabled: true
+  Enabled: false
   EnforcedStyle: allow
   SupportedStyles:
   - allow
   - expect
 
+RSpec/MultipleDescribes:
+  Description: Checks for multiple top level describes.
+  Enabled: true
+
+RSpec/MultipleExpectations:
+  Description: Checks if examples contain too many `expect` calls.
+  Enabled: true
+  Max: 1
+
 RSpec/NamedSubject:
   Description: Checks for explicitly referenced test subjects.
   Enabled: true
 
+RSpec/NestedGroups:
+  Description: Checks for nested example groups.
+  Enabled: true
+  MaxNesting: 2
+
+RSpec/NotToNot:
+  Description: Checks for consistent method usage for negating expectations.
+  EnforcedStyle: not_to
+  SupportedStyles:
+  - not_to
+  - to_not
+  Enabled: true
+
 RSpec/SubjectStub:
   Description: Checks for stubbed test subjects.
   Enabled: true
+
+RSpec/VerifiedDoubles:
+  Description: Prefer using verifying doubles over normal doubles.
+  Enabled: true
+  IgnoreSymbolicNames: false

data/lib/rubocop-rspec.rb

@@ -28,6 +28,7 @@ require 'rubocop/cop/rspec/expect_actual'
 require 'rubocop/cop/rspec/file_path'
 require 'rubocop/cop/rspec/focus'
 require 'rubocop/cop/rspec/hook_argument'
+require 'rubocop/cop/rspec/implicit_expect'
 require 'rubocop/cop/rspec/instance_variable'
 require 'rubocop/cop/rspec/leading_subject'
 require 'rubocop/cop/rspec/let_setup'

data/lib/rubocop/cop/rspec/be_eql.rb

@@ -4,7 +4,7 @@ module RuboCop
       # Check for expectations where `be(...)` can replace `eql(...)`.
       #
       # The `be` matcher compares by identity while the `eql` matcher
-      # compares using `eql?`. Integers, floats, booleans, and symbols
+      # compares using `eql?`. Integers, floats, booleans, symbols, and nil
       # can be compared by identity and therefore the `be` matcher is
       # preferable as it is a more strict test.
       #
@@ -16,6 +16,7 @@ module RuboCop
       #   expect(foo).to eql(true)
       #   expect(foo).to eql(false)
       #   expect(foo).to eql(:bar)
+      #   expect(foo).to eql(nil)
       #
       #   # good
       #   expect(foo).to be(1)
@@ -23,6 +24,7 @@ module RuboCop
       #   expect(foo).to be(true)
       #   expect(foo).to be(false)
       #   expect(foo).to be(:bar)
+      #   expect(foo).to be(nil)
       #
       # This cop only looks for instances of `expect(...).to eql(...)`. We
       # do not check `to_not` or `not_to` since `!eql?` is more strict
@@ -38,7 +40,7 @@ module RuboCop
         MSG = 'Prefer `be` over `eql`'.freeze
 
         def_node_matcher :eql_type_with_identity, <<-PATTERN
-          (send _ :to $(send nil :eql {true false int float sym}))
+          (send _ :to $(send nil :eql {true false int float sym nil_type?}))
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/rspec/file_path.rb

@@ -8,19 +8,43 @@ module RuboCop
       # Checks the path of the spec file and enforces that it reflects the
       # described class/module and its optionally called out method.
       #
+      # With the configuration option `IgnoreMethods` the called out method will
+      # be ignored when determining the enforced path.
+      #
       # With the configuration option `CustomTransform` modules or classes can
       # be specified that should not as usual be transformed from CamelCase to
       # snake_case (e.g. 'RuboCop' => 'rubocop' ).
       #
       # @example
-      #   my_class/method_spec.rb  # describe MyClass, '#method'
+      #   # bad
+      #   whatever_spec.rb         # describe MyClass
+      #
+      #   # bad
+      #   my_class_spec.rb         # describe MyClass, '#method'
+      #
+      #   # good
+      #   my_class_spec.rb         # describe MyClass
+      #
+      #   # good
       #   my_class_method_spec.rb  # describe MyClass, '#method'
+      #
+      #   # good
+      #   my_class/method_spec.rb  # describe MyClass, '#method'
+      #
+      # @example when configuration is `IgnoreMethods: true`
+      #   # bad
+      #   whatever_spec.rb         # describe MyClass
+      #
+      #   # good
       #   my_class_spec.rb         # describe MyClass
+      #
+      #   # good
+      #   my_class_spec.rb         # describe MyClass, '#method'
+      #
       class FilePath < Cop
         include RuboCop::RSpec::SpecOnly, RuboCop::RSpec::TopLevelDescribe
 
         MESSAGE = 'Spec path should end with `%s`'.freeze
-        METHOD_STRING_MATCHER = /^[\#\.].+/
         ROUTING_PAIR = s(:pair, s(:sym, :type), s(:sym, :routing))
 
         def on_top_level_describe(node, args)
@@ -46,7 +70,7 @@ module RuboCop
 
         def matcher(object, method)
           path = File.join(parts(object))
-          if method && method.type.equal?(:str)
+          if method && method.type.equal?(:str) && !ignore_methods?
             path += '*' + method.str_content.gsub(/\W+/, '')
           end
 
@@ -65,8 +89,8 @@ module RuboCop
 
         def camel_to_underscore(string)
           string
-            .gsub(/([^A-Z])([A-Z]+)/, '\\1_\\2')
-            .gsub(/([A-Z])([A-Z\d][^A-Z\d]+)/, '\\1_\\2')
+            .gsub(/([^A-Z])([A-Z]+)/, '\1_\2')
+            .gsub(/([A-Z])([A-Z][^A-Z\d]+)/, '\1_\2')
             .downcase
         end
 
@@ -74,6 +98,10 @@ module RuboCop
           Regexp.new(glob.sub('.', '\\.').gsub('*', '.*') + '$')
         end
 
+        def ignore_methods?
+          cop_config['IgnoreMethods']
+        end
+
         def custom_transform
           cop_config['CustomTransform'] || {}
         end

data/lib/rubocop/cop/rspec/implicit_expect.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Check that a consistent implicit expectation style is used.
+      #
+      # This cop can be configured using the `EnforcedStyle` option
+      # and supports the `--auto-gen-config` flag.
+      #
+      # @example `EnforcedStyle: is_expected`
+      #
+      #   # bad
+      #   it { should be_truthy }
+      #
+      #   # good
+      #   it { is_expected.to be_truthy }
+      #
+      # @example `EnforcedStyle: should`
+      #
+      #   # bad
+      #   it { is_expected.to be_truthy }
+      #
+      #   # good
+      #   it { should be_truthy }
+      #
+      class ImplicitExpect < Cop
+        include RuboCop::RSpec::SpecOnly, ConfigurableEnforcedStyle
+
+        MSG = 'Prefer `%<good>s` over `%<bad>s`.'.freeze
+
+        def_node_matcher :implicit_expect, <<-PATTERN
+          {
+            (send nil ${:should :should_not} ...)
+            (send (send nil $:is_expected) {:to :to_not :not_to} ...)
+          }
+        PATTERN
+
+        alternatives = {
+          'is_expected.to'     => 'should',
+          'is_expected.not_to' => 'should_not',
+          'is_expected.to_not' => 'should_not'
+        }
+
+        ENFORCED_REPLACEMENTS = alternatives.merge(alternatives.invert).freeze
+
+        def on_send(node)
+          return unless (source_range = offending_expect(node))
+
+          expectation_source = source_range.source
+
+          if expectation_source.start_with?(style.to_s)
+            correct_style_detected
+          else
+            opposite_style_detected
+
+            add_offense(node, source_range, offense_message(expectation_source))
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            offense     = offending_expect(node)
+            replacement = replacement_source(offense.source)
+
+            corrector.replace(offense, replacement)
+          end
+        end
+
+        private
+
+        def offending_expect(node)
+          case implicit_expect(node)
+          when :is_expected
+            is_expected_range(node.loc)
+          when :should, :should_not
+            node.loc.selector
+          end
+        end
+
+        def is_expected_range(source_map) # rubocop:disable PredicateName
+          Parser::Source::Range.new(
+            source_map.expression.source_buffer,
+            source_map.expression.begin_pos,
+            source_map.selector.end_pos
+          )
+        end
+
+        def offense_message(offending_source)
+          MSG % {
+            good: replacement_source(offending_source),
+            bad:  offending_source
+          }
+        end
+
+        def replacement_source(offending_source)
+          ENFORCED_REPLACEMENTS.fetch(offending_source)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.7.0'.freeze
+      STRING = '1.8.0'.freeze
     end
   end
 end

data/rubocop-rspec.gemspec

@@ -10,14 +10,18 @@ Gem::Specification.new do |spec|
     Code style checking for RSpec files.
     A plugin for the RuboCop code style enforcing & linting tool.
   end_description
-  spec.homepage = 'http://github.com/nevir/rubocop-rspec'
-  spec.authors = ['Ian MacLeod', 'Nils Gemeinhardt']
-  spec.email = ['ian@nevir.net', 'git@nilsgemeinhardt.de']
+  spec.homepage = 'http://github.com/backus/rubocop-rspec'
+  spec.authors = ['John Backus', 'Ian MacLeod', 'Nils Gemeinhardt']
+  spec.email = [
+    'johncbackus@gmail.com',
+    'ian@nevir.net',
+    'git@nilsgemeinhardt.de'
+  ]
   spec.licenses = ['MIT']
 
   spec.version = RuboCop::RSpec::Version::STRING
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.2.0'
+  spec.required_ruby_version = '>= 2.1.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[

data/spec/project/default_config_spec.rb

@@ -20,7 +20,7 @@ describe 'config/default.yml' do
 
   def cop_configuration(config_key)
     cop_names.map do |cop_name|
-      cop_config = default_config.fetch(cop_name)
+      cop_config = default_config[cop_name]
 
       cop_config.fetch(config_key) do
         raise "Expected #{cop_name} to have #{config_key} configuration key"
@@ -47,6 +47,6 @@ describe 'config/default.yml' do
   end
 
   it 'includes Enabled: true for every cop' do
-    expect(cop_configuration('Enabled')).to all(be(true))
+    expect(cop_configuration('Enabled')).to all(be(true).or(be(false)))
   end
 end

data/spec/rubocop/cop/rspec/be_eql_spec.rb

@@ -35,6 +35,13 @@ describe RuboCop::Cop::RSpec::BeEql do
     RUBY
   end
 
+  it 'registers an offense for `eql` when argument is nil' do
+    expect_violation(<<-RUBY)
+      it { expect(foo).to eql(nil) }
+                          ^^^ Prefer `be` over `eql`
+    RUBY
+  end
+
   it 'does not register an offense for `eql` when argument is a string' do
     expect_no_violations(<<-RUBY)
       it { expect(foo).to eql('foo') }
@@ -47,13 +54,7 @@ describe RuboCop::Cop::RSpec::BeEql do
     RUBY
   end
 
-  it 'autocorrects offense to use `be`' do
-    corrected =
-      autocorrect_source(
-        cop,
-        ['it { expect(foo).to eql(1) }'],
-        'spec/foo_spec.rb'
-      )
-    expect(corrected).to eq 'it { expect(foo).to be(1) }'
-  end
+  include_examples 'autocorrect',
+                   'it { expect(foo).to eql(1) }',
+                   'it { expect(foo).to be(1) }'
 end

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -195,25 +195,15 @@ describe RuboCop::Cop::RSpec::DescribedClass, :config do
     RUBY
   end
 
-  it 'autocorrects an offenses' do
-    new_source = autocorrect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  include MyClass',
-        '  subject { MyClass.do_something }',
-        '  before { MyClass.do_something }',
-        'end'
-      ], 'spec/foo_spec.rb'
-    )
-    expect(new_source).to eq(
-      [
-        'describe MyClass do',
-        '  include described_class',
-        '  subject { described_class.do_something }',
-        '  before { described_class.do_something }',
-        'end'
-      ].join("\n")
-    )
-  end
+  include_examples 'autocorrect',
+                   'describe(Foo) { include Foo }',
+                   'describe(Foo) { include described_class }'
+
+  include_examples 'autocorrect',
+                   'describe(Foo) { subject { Foo.do_something } }',
+                   'describe(Foo) { subject { described_class.do_something } }'
+
+  include_examples 'autocorrect',
+                   'describe(Foo) { before { Foo.do_something } }',
+                   'describe(Foo) { before { described_class.do_something } }'
 end

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -44,39 +44,18 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
       RUBY
     end
 
-    it 'corrects `it "should only have"` to it "only has"' do
-      corrected =
-        autocorrect_source(
-          cop,
-          'it "should only have trait" do end',
-          'spec/foo_spec.rb'
-        )
-
-      expect(corrected).to eql('it "only has trait" do end')
-    end
+    include_examples 'autocorrect',
+                     'it "should only have trait" do end',
+                     'it "only has trait" do end'
   end
 
   context 'when configuration is empty' do
-    it 'only does not correct "have"' do
-      corrected =
-        autocorrect_source(
-          cop,
-          'it "should have trait" do end',
-          'spec/foo_spec.rb'
-        )
-
-      expect(corrected).to eql('it "haves trait" do end')
-    end
-
-    it 'only does not make an exception for the word "only"' do
-      corrected =
-        autocorrect_source(
-          cop,
-          'it "should only fail" do end',
-          'spec/foo_spec.rb'
-        )
+    include_examples 'autocorrect',
+                     'it "should have trait" do end',
+                     'it "haves trait" do end'
 
-      expect(corrected).to eql('it "onlies fail" do end')
-    end
+    include_examples 'autocorrect',
+                     'it "should only fail" do end',
+                     'it "onlies fail" do end'
   end
 end

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -116,8 +116,8 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   it 'handles alphanumeric class names' do
     inspect_source(
       cop,
-      'describe IPv4AndIPv6 do; end',
-      'i_pv4_and_i_pv6_spec.rb'
+      'describe IPV4AndIPV6 do; end',
+      'ipv4_and_ipv6_spec.rb'
     )
     expect(cop.offenses).to be_empty
   end
@@ -212,7 +212,7 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
     expect(cop.offenses).to be_empty
   end
 
-  context 'when configured' do
+  context 'when configured with CustomTransform' do
     let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
 
     it 'respects custom module name transformation' do
@@ -233,4 +233,17 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
       expect(cop.offenses).to be_empty
     end
   end
+
+  context 'when configured with IgnoreMethods' do
+    let(:cop_config) { { 'IgnoreMethods' => true } }
+
+    it 'does not care about the described method' do
+      inspect_source(
+        cop,
+        "describe MyClass, '#look_here_a_method' do; end",
+        'my_class_spec.rb'
+      )
+      expect(cop.offenses).to be_empty
+    end
+  end
 end

data/spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -32,43 +32,17 @@ describe RuboCop::Cop::RSpec::HookArgument, :config do
     end
   end
 
-  shared_examples 'generated config' do |source, detected_style|
-    it 'generates a todo based on the detected style' do
-      inspect_source(cop, source, 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses)
-        .to eq('EnforcedStyle' => detected_style)
-    end
-  end
-
   shared_examples 'hook autocorrect' do |output|
-    it 'autocorrects :each to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before(:each) { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
-
-    it 'autocorrects :example to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before(:example) { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
-
-    it 'autocorrects :implicit to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
+    include_examples 'autocorrect', 'before(:each) { }', output
+    include_examples 'autocorrect', 'before(:example) { }', output
+    include_examples 'autocorrect', 'before { }', output
   end
 
   shared_examples 'an example hook' do
     include_examples 'ignored hooks'
-    include_examples 'generated config', 'before(:each) { foo }', 'each'
-    include_examples 'generated config', 'before(:example) { foo }', 'example'
-    include_examples 'generated config', 'before { foo }', 'implicit'
+    include_examples 'detects style', 'before(:each) { foo }', 'each'
+    include_examples 'detects style', 'before(:example) { foo }', 'example'
+    include_examples 'detects style', 'before { foo }', 'implicit'
   end
 
   context 'when EnforcedStyle is :implicit' do

data/spec/rubocop/cop/rspec/implicit_expect_spec.rb

@@ -0,0 +1,101 @@
+# frozen_string_literal: true
+
+describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when EnforcedStyle is is_expected' do
+    let(:cop_config) do
+      { 'EnforcedStyle' => 'is_expected' }
+    end
+
+    it 'flags it { should }' do
+      expect_violation(<<-RUBY)
+        it { should be_truthy }
+             ^^^^^^ Prefer `is_expected.to` over `should`.
+      RUBY
+    end
+
+    it 'flags it { should_not }' do
+      expect_violation(<<-RUBY)
+        it { should_not be_truthy }
+             ^^^^^^^^^^ Prefer `is_expected.to_not` over `should_not`.
+      RUBY
+    end
+
+    it 'approves of is_expected.to' do
+      expect_no_violations('it { is_expected.to be_truthy }')
+    end
+
+    it 'approves of is_expected.to_not' do
+      expect_no_violations('it { is_expected.to_not be_truthy }')
+    end
+
+    it 'approves of is_expected.to_not' do
+      expect_no_violations('it { is_expected.not_to be_truthy }')
+    end
+
+    include_examples 'detects style', 'it { should be_truthy }', 'should'
+    include_examples 'autocorrect',
+                     'it { should be_truthy }',
+                     'it { is_expected.to be_truthy }'
+
+    include_examples 'autocorrect',
+                     'it { should_not be_truthy }',
+                     'it { is_expected.to_not be_truthy }'
+  end
+
+  context 'when EnforcedStyle is should' do
+    let(:cop_config) do
+      { 'EnforcedStyle' => 'should' }
+    end
+
+    it 'flags it { is_expected.to }' do
+      expect_violation(<<-RUBY)
+        it { is_expected.to be_truthy }
+             ^^^^^^^^^^^^^^ Prefer `should` over `is_expected.to`.
+      RUBY
+    end
+
+    it 'flags it { is_expected.to_not }' do
+      expect_violation(<<-RUBY)
+        it { is_expected.to_not be_truthy }
+             ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.to_not`.
+      RUBY
+    end
+
+    it 'flags it { is_expected.not_to }' do
+      expect_violation(<<-RUBY)
+        it { is_expected.not_to be_truthy }
+             ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.not_to`.
+      RUBY
+    end
+
+    it 'approves of should' do
+      expect_no_violations('it { should be_truthy }')
+    end
+
+    it 'approves of should_not' do
+      expect_no_violations('it { should_not be_truthy }')
+    end
+
+    include_examples 'detects style',
+                     'it { is_expected.to be_truthy }',
+                     'is_expected'
+
+    include_examples 'detects style',
+                     'it { should be_truthy }',
+                     'should'
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to be_truthy }',
+                     'it { should be_truthy }'
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to_not be_truthy }',
+                     'it { should_not be_truthy }'
+
+    include_examples 'autocorrect',
+                     'it { is_expected.not_to be_truthy }',
+                     'it { should_not be_truthy }'
+  end
+end

data/spec/rubocop/cop/rspec/nested_groups_spec.rb

@@ -35,7 +35,7 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
     RUBY
   end
 
-  context 'when MaxNesting is configured as 2' do
+  context 'when MaxNesting is configured as 3' do
     let(:cop_config) { { 'MaxNesting' => '3' } }
 
     it 'only flags third level of nesting' do

data/spec/rubocop/cop/rspec/not_to_not_spec.rb

@@ -17,15 +17,9 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
       RUBY
     end
 
-    it 'auto-corrects `to_not` to `not_to`' do
-      corrected =
-        autocorrect_source(
-          cop,
-          ['it { expect(0).to_not equal 1 }'],
-          'spec/foo_spec.rb'
-        )
-      expect(corrected).to eq 'it { expect(0).not_to equal 1 }'
-    end
+    include_examples 'autocorrect',
+                     'it { expect(0).to_not equal 1 }',
+                     'it { expect(0).not_to equal 1 }'
   end
 
   context 'when AcceptedMethod is `to_not`' do
@@ -44,14 +38,8 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
       RUBY
     end
 
-    it 'auto-corrects `not_to` to `to_not`' do
-      corrected =
-        autocorrect_source(
-          cop,
-          ['it { expect(0).not_to equal 1 }'],
-          'spec/foo_spec.rb'
-        )
-      expect(corrected).to eq 'it { expect(0).to_not equal 1 }'
-    end
+    include_examples 'autocorrect',
+                     'it { expect(0).not_to equal 1 }',
+                     'it { expect(0).to_not equal 1 }'
   end
 end

data/spec/shared/autocorrect_behavior.rb

@@ -0,0 +1,7 @@
+RSpec.shared_examples 'autocorrect' do |original, corrected|
+  it "autocorrects `#{original}` to `#{corrected}`" do
+    autocorrected = autocorrect_source(cop, original, 'spec/foo_spec.rb')
+
+    expect(autocorrected).to eql(corrected)
+  end
+end

data/spec/shared/detects_style_behavior.rb

@@ -0,0 +1,8 @@
+RSpec.shared_examples 'detects style' do |source, detected_style|
+  it 'generates a todo based on the detected style' do
+    inspect_source(cop, source, 'foo_spec.rb')
+
+    expect(cop.config_to_allow_offenses)
+      .to eq('EnforcedStyle' => detected_style)
+  end
+end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.8.0
 platform: ruby
 authors:
+- John Backus
 - Ian MacLeod
 - Nils Gemeinhardt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-24 00:00:00.000000000 Z
+date: 2016-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -127,6 +128,7 @@ description: |2
       Code style checking for RSpec files.
       A plugin for the RuboCop code style enforcing & linting tool.
 email:
+- johncbackus@gmail.com
 - ian@nevir.net
 - git@nilsgemeinhardt.de
 executables: []
@@ -154,6 +156,7 @@ files:
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
+- lib/rubocop/cop/rspec/implicit_expect.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
 - lib/rubocop/cop/rspec/leading_subject.rb
 - lib/rubocop/cop/rspec/let_setup.rb
@@ -194,6 +197,7 @@ files:
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
+- spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
@@ -212,10 +216,12 @@ files:
 - spec/rubocop/rspec/spec_only_spec.rb
 - spec/rubocop/rspec/util/one_spec.rb
 - spec/rubocop/rspec/wording_spec.rb
+- spec/shared/autocorrect_behavior.rb
+- spec/shared/detects_style_behavior.rb
 - spec/shared/rspec_only_cop_behavior.rb
 - spec/spec_helper.rb
 - spec/support/expect_violation.rb
-homepage: http://github.com/nevir/rubocop-rspec
+homepage: http://github.com/backus/rubocop-rspec
 licenses:
 - MIT
 metadata: {}
@@ -227,7 +233,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -256,6 +262,7 @@ test_files:
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
+- spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
@@ -274,6 +281,8 @@ test_files:
 - spec/rubocop/rspec/spec_only_spec.rb
 - spec/rubocop/rspec/util/one_spec.rb
 - spec/rubocop/rspec/wording_spec.rb
+- spec/shared/autocorrect_behavior.rb
+- spec/shared/detects_style_behavior.rb
 - spec/shared/rspec_only_cop_behavior.rb
 - spec/spec_helper.rb
 - spec/support/expect_violation.rb