rubocop-rspec 1.22.2 → 1.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45305dc24c290781dd6ea63a81c7ec1c99badf079e3f52cce42f92da63c360b4
-  data.tar.gz: e2532b3fd549df87cccbd1e060f6a7dbb01b94ed290a3ee32b63961a4cfc57bd
+  metadata.gz: 3b88289ae95383f02044f1bf61e01950e5637c1b7d5b454a58e025a31f7562c7
+  data.tar.gz: 066a150e7e974240b6678f29c6104e157a634b753602c9f41b746fa2a3f0733b
 SHA512:
-  metadata.gz: 462eb5bf9cfd3aa17eddf02aca0a223fecb50f915adf6715c1484c7153b8b650b2205d9d2e6d12989c8097acd68d07e03104c6809f0ed67d901972efe9edf7ac
-  data.tar.gz: 01662e9fa466a98a282eb5d2256bf5f1c7c9680390c22c2b8e8af0a7eb5313dcf2ada617cda57f2d682b661ea04652548869cd711e1990f9e739df08071aa2d5
+  metadata.gz: 2cf65077bc9fa485cf1b734918a0279f7925185ecc21196488d24740e5f0d9151672a87521abde59429a5306c7148cd489309c40f6999dedfff0e26972f5e724
+  data.tar.gz: 1173b7e16b85c33f08df3998b70f8accfd39da5f40b61c4bdf8c988c5a6169a26761395035de4919808078a3c26976e0a9a8d67b1585cde081ee0c35c8634bf2

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Master (Unreleased)
 
+## 1.23.0 (2018-02-23)
+
+* Add `RSpec/Rails/HttpStatus` cop to enforce consistent usage of the status format (numeric or symbolic). ([@anthony-robin][], [@jojos003][])
+* Fix false negative in `RSpec/ReturnFromStub` when a constant is being returned by the stub. ([@Darhazer][])
+* Fix `FactoryBot/DynamicAttributeDefinedStatically` to handle dynamic attributes inside arrays/hashes. ([@abrom][])
+* Add `FactoryBot/StaticAttributeDefinedDynamically` (based on dynamic attribute cop). ([@abrom][])
+
 ## 1.22.2 (2018-02-01)
 
 * Fix error in `RSpec/DescribedClass` when working on an empty `describe` block. ([@bquorning][])
@@ -298,3 +305,6 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@pirj]: https://github.com/pirj
 [@telmofcosta]: https://github.com/telmofcosta
 [@EliseFitz15]: https://github.com/EliseFitz15
+[@anthony-robin]: https://github.com/anthony-robin
+[@jojos003]: https://github.com/jojos003
+[@abrom]: https://github.com/abrom

data/config/default.yml

@@ -368,3 +368,17 @@ FactoryBot/DynamicAttributeDefinedStatically:
   Description: Prefer declaring dynamic attribute values in a block.
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/DynamicAttributeDefinedStatically
+
+FactoryBot/StaticAttributeDefinedDynamically:
+  Description: Prefer declaring static attribute values without a block.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/StaticAttributeDefinedDynamically
+
+Rails/HttpStatus:
+  Description: Enforces use of symbolic or numeric value to describe HTTP status.
+  Enabled: true
+  EnforcedStyle: symbolic
+  SupportedStyles:
+  - numeric
+  - symbolic
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus

data/lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb

@@ -6,6 +6,8 @@ module RuboCop
       module FactoryBot
         # Prefer declaring dynamic attribute values in a block.
         #
+        # @see StaticAttributeDefinedDynamically
+        #
         # @example
         #   # bad
         #   kind [:active, :rejected].sample
@@ -18,54 +20,59 @@ module RuboCop
         #
         #   # good
         #   closed_at { 1.day.from_now }
-        #
-        #   # good
-        #   kind :static
-        #
-        #   # good
-        #   comments_count 0
-        #
-        #   # good
-        #   type User::MAGIC
         class DynamicAttributeDefinedStatically < Cop
           MSG = 'Use a block to set a dynamic value to an attribute.'.freeze
 
-          def_node_matcher :dynamic_defined_statically?, <<-PATTERN
-          (send nil? _ (send ... ))
+          def_node_matcher :value_matcher, <<-PATTERN
+            (send nil? _ $...)
           PATTERN
 
           def_node_search :factory_attributes, <<-PATTERN
-          (block (send nil? {:factory :trait} ...) _ { (begin $...) $(send ...) } )
+            (block (send nil? {:factory :trait} ...) _ { (begin $...) $(send ...) } )
           PATTERN
 
           def on_block(node)
-            return if node.method_name == :trait
             factory_attributes(node).to_a.flatten.each do |attribute|
-              if dynamic_defined_statically?(attribute)
-                add_offense(attribute, location: :expression)
-              end
+              next if value_matcher(attribute).to_a.all? { |v| static?(v) }
+              add_offense(attribute, location: :expression)
             end
           end
 
           def autocorrect(node)
-            if method_uses_parens?(node.location)
-              autocorrect_replacing_parens(node)
-            else
+            if !method_uses_parens?(node.location)
               autocorrect_without_parens(node)
+            elsif value_hash_without_braces?(node.descendants.first)
+              autocorrect_hash_without_braces(node)
+            else
+              autocorrect_replacing_parens(node)
             end
           end
 
           private
 
+          def static?(node)
+            node.recursive_literal? || node.const_type?
+          end
+
+          def value_hash_without_braces?(node)
+            node.hash_type? && !node.braces?
+          end
+
           def method_uses_parens?(location)
             return false unless location.begin && location.end
             location.begin.source == '(' && location.end.source == ')'
           end
 
-          def autocorrect_replacing_parens(node)
+          def autocorrect_hash_without_braces(node)
+            autocorrect_replacing_parens(node, ' { { ', ' } }')
+          end
+
+          def autocorrect_replacing_parens(node,
+                                           start_token = ' { ',
+                                           end_token = ' }')
             lambda do |corrector|
-              corrector.replace(node.location.begin, ' { ')
-              corrector.replace(node.location.end, ' }')
+              corrector.replace(node.location.begin, start_token)
+              corrector.replace(node.location.end, end_token)
             end
           end
 

data/lib/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module FactoryBot
+        # Prefer declaring static attribute values without a block.
+        #
+        # @see DynamicAttributeDefinedStatically
+        #
+        # @example
+        #   # bad
+        #   kind { :static }
+        #
+        #   # good
+        #   kind :static
+        #
+        #   # bad
+        #   comments_count { 0 }
+        #
+        #   # good
+        #   comments_count 0
+        #
+        #   # bad
+        #   type { User::MAGIC }
+        #
+        #   # good
+        #   type User::MAGIC
+        class StaticAttributeDefinedDynamically < Cop
+          MSG = 'Do not use a block to set a static value ' \
+                'to an attribute.'.freeze
+
+          def_node_matcher :block_value_matcher, <<-PATTERN
+            (block (send nil? _) _ $...)
+          PATTERN
+
+          def_node_search :factory_attributes, <<-PATTERN
+            (block (send nil? { :factory :trait } ...) _ { (begin $...) $(send ...) $(block ...) } )
+          PATTERN
+
+          def on_block(node)
+            factory_attributes(node).to_a.flatten.each do |attribute|
+              values = block_value_matcher(attribute)
+              next if values.to_a.none? { |v| static?(v) }
+              add_offense(attribute, location: :expression)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(
+                node.loc.expression,
+                autocorrected_source(node)
+              )
+            end
+          end
+
+          private
+
+          def static?(node)
+            node.recursive_literal? || node.const_type?
+          end
+
+          def autocorrected_source(node)
+            if node.body.hash_type?
+              "#{node.send_node.source}(#{node.body.source})"
+            else
+              "#{node.send_node.source} #{node.body.source}"
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/rails/http_status.rb

@@ -0,0 +1,162 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module Rails
+        # Enforces use of symbolic or numeric value to describe HTTP status.
+        #
+        # @example `EnforcedStyle: symbolic` (default)
+        #   # bad
+        #   it { is_expected.to have_http_status 200 }
+        #   it { is_expected.to have_http_status 404 }
+        #
+        #   # good
+        #   it { is_expected.to have_http_status :ok }
+        #   it { is_expected.to have_http_status :not_found }
+        #   it { is_expected.to have_http_status :success }
+        #   it { is_expected.to have_http_status :error }
+        #
+        # @example `EnforcedStyle: numeric`
+        #   # bad
+        #   it { is_expected.to have_http_status :ok }
+        #   it { is_expected.to have_http_status :not_found }
+        #
+        #   # good
+        #   it { is_expected.to have_http_status 200 }
+        #   it { is_expected.to have_http_status 404 }
+        #   it { is_expected.to have_http_status :success }
+        #   it { is_expected.to have_http_status :error }
+        #
+        class HttpStatus < Cop
+          begin
+            require 'rack/utils'
+            RACK_LOADED = true
+          rescue LoadError
+            RACK_LOADED = false
+          end
+
+          include ConfigurableEnforcedStyle
+
+          def_node_matcher :http_status, <<-PATTERN
+            (send nil? :have_http_status ${int sym})
+          PATTERN
+
+          def on_send(node)
+            http_status(node) do |ast_node|
+              checker = checker_class.new(ast_node)
+              return unless checker.offensive?
+              add_offense(checker.node, message: checker.message)
+            end
+          end
+
+          def support_autocorrect?
+            RACK_LOADED
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              checker = checker_class.new(node)
+              corrector.replace(node.loc.expression, checker.preferred_style)
+            end
+          end
+
+          private
+
+          def checker_class
+            case style
+            when :symbolic
+              SymbolicStyleChecker
+            when :numeric
+              NumericStyleChecker
+            end
+          end
+
+          # :nodoc:
+          class SymbolicStyleChecker
+            MSG = 'Prefer `%<prefer>s` over `%<current>s` ' \
+                  'to describe HTTP status code.'.freeze
+            DEFAULT_MSG = 'Prefer `symbolic` over `numeric` ' \
+                  'to describe HTTP status code.'.freeze
+
+            attr_reader :node
+            def initialize(node)
+              @node = node
+            end
+
+            def offensive?
+              !node.sym_type?
+            end
+
+            def message
+              if RACK_LOADED
+                format(MSG, prefer: preferred_style, current: number.to_s)
+              else
+                DEFAULT_MSG
+              end
+            end
+
+            def preferred_style
+              symbol.inspect
+            end
+
+            private
+
+            def symbol
+              ::Rack::Utils::SYMBOL_TO_STATUS_CODE.key(number)
+            end
+
+            def number
+              node.source.to_i
+            end
+          end
+
+          # :nodoc:
+          class NumericStyleChecker
+            MSG = 'Prefer `%<prefer>s` over `%<current>s` ' \
+                  'to describe HTTP status code.'.freeze
+            DEFAULT_MSG = 'Prefer `numeric` over `symbolic` ' \
+                  'to describe HTTP status code.'.freeze
+
+            WHITELIST_STATUS = %i[error success missing redirect].freeze
+
+            attr_reader :node
+            def initialize(node)
+              @node = node
+            end
+
+            def offensive?
+              !node.int_type? && !whitelisted_symbol?
+            end
+
+            def message
+              if RACK_LOADED
+                format(MSG, prefer: preferred_style, current: symbol.inspect)
+              else
+                DEFAULT_MSG
+              end
+            end
+
+            def preferred_style
+              number.to_s
+            end
+
+            private
+
+            def number
+              ::Rack::Utils::SYMBOL_TO_STATUS_CODE[symbol]
+            end
+
+            def symbol
+              node.value
+            end
+
+            def whitelisted_symbol?
+              node.sym_type? && WHITELIST_STATUS.include?(node.value)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/return_from_stub.rb

@@ -92,7 +92,7 @@ module RuboCop
         end
 
         def dynamic?(node)
-          !node.recursive_literal?
+          !node.recursive_literal? && !node.const_type?
         end
 
         # :nodoc:

data/lib/rubocop/cop/rspec/verified_doubles.rb

@@ -9,13 +9,18 @@ module RuboCop
       #
       # @example
       #   # bad
-      #   it '...' do
-      #     widget = double("Widget")
+      #   let(:foo) do
+      #     double(method_name: 'returned value')
+      #   end
+      #
+      #   # bad
+      #   let(:foo) do
+      #     double("ClassName", method_name: 'returned value')
       #   end
       #
       #   # good
-      #   it '...' do
-      #     widget = instance_double("Widget")
+      #   let(:foo) do
+      #     instance_double("ClassName", method_name: 'returned value')
       #   end
       class VerifiedDoubles < Cop
         MSG = 'Prefer using verifying doubles over normal doubles.'.freeze

data/lib/rubocop/cop/rspec_cops.rb

@@ -2,6 +2,9 @@ require_relative 'rspec/capybara/current_path_expectation'
 require_relative 'rspec/capybara/feature_methods'
 
 require_relative 'rspec/factory_bot/dynamic_attribute_defined_statically'
+require_relative 'rspec/factory_bot/static_attribute_defined_dynamically'
+
+require_relative 'rspec/rails/http_status'
 
 require_relative 'rspec/align_left_let_brace'
 require_relative 'rspec/align_right_let_brace'

data/lib/rubocop/rspec/config_formatter.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Builds a YAML config file from two config hashes
     class ConfigFormatter
-      NAMESPACES = /^(#{Regexp.union('RSpec', 'Capybara', 'FactoryBot')})/
+      NAMESPACES = /^(RSpec|Capybara|FactoryBot|Rails)/
       STYLE_GUIDE_BASE_URL = 'http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/'.freeze
 
       def initialize(config, descriptions)

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.22.2'.freeze
+      STRING = '1.23.0'.freeze
     end
   end
 end

data/rubocop-rspec.gemspec

@@ -34,6 +34,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'rubocop', '>= 0.52.1'
 
+  spec.add_development_dependency 'rack'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '>= 3.4'
   spec.add_development_dependency 'simplecov'

data/spec/project/default_config_spec.rb

@@ -7,10 +7,11 @@ RSpec.describe 'config/default.yml' do
     namespaces = {
       'rspec' => 'RSpec',
       'capybara' => 'Capybara',
-      'factory_bot' => 'FactoryBot'
+      'factory_bot' => 'FactoryBot',
+      'rails' => 'Rails'
     }
-    glob = SpecHelper::ROOT.join('lib', 'rubocop', 'cop',
-                                 'rspec', '{capybara/,,factory_bot/}*.rb')
+    glob = SpecHelper::ROOT.join('lib', 'rubocop', 'cop', 'rspec',
+                                 '{,capybara,factory_bot,rails}', '*.rb')
     cop_names =
       Pathname.glob(glob).map do |file|
         file_name = file.basename('.rb').to_s

data/spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb

@@ -20,6 +20,10 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
               created_at 1.day.ago
               ^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+              update_times [Time.current]
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+              meta_tags(foo: Time.current)
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
             end
           end
         RUBY
@@ -39,7 +43,7 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
         RUBY
       end
 
-      it 'accepts' do
+      it 'accepts valid factory definitions' do
         expect_no_offenses(<<-RUBY)
           #{factory_bot}.define do
             factory :post do
@@ -52,6 +56,9 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
               title "Static"
               description { FFaker::Lorem.paragraph(10) }
               tag Tag::MAGIC
+              recent_statuses [:published, :draft]
+              meta_tags(like_count: 2)
+              other_tags({ foo: nil })
             end
           end
         RUBY
@@ -62,6 +69,8 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
           status [:draft, :published].sample
           published_at 1.day.from_now
           created_at 1.day.ago
+          update_times [Time.current]
+          meta_tags(foo: Time.current)
         RUBY
       end
 
@@ -72,6 +81,13 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
             published_at 1.day.from_now
             created_at(1.day.ago)
             updated_at Time.current
+            update_times [Time.current]
+            meta_tags(foo: Time.current)
+            other_tags({ foo: Time.current })
+
+            trait :old do
+              published_at 1.week.ago
+            end
           end
         end
       RUBY
@@ -83,6 +99,13 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
             published_at { 1.day.from_now }
             created_at { 1.day.ago }
             updated_at { Time.current }
+            update_times { [Time.current] }
+            meta_tags { { foo: Time.current } }
+            other_tags { { foo: Time.current } }
+
+            trait :old do
+              published_at { 1.week.ago }
+            end
           end
         end
       RUBY

data/spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/LineLength
+RSpec.describe RuboCop::Cop::RSpec::FactoryBot::StaticAttributeDefinedDynamically do
+  # rubocop:enable Metrics/LineLength
+
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) { RuboCop::Config.new }
+
+  %w[FactoryBot FactoryGirl].each do |factory_bot|
+    context "when using #{factory_bot}" do
+      it 'registers an offense for offending code' do
+        expect_offense(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              kind { :static }
+              ^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              comments_count { 0 }
+              ^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              type { User::MAGIC }
+              ^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              description { nil }
+              ^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              recent_statuses { [:published, :draft] }
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              meta_tags { { foo: 1 } }
+              ^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+            end
+          end
+        RUBY
+      end
+
+      it 'registers an offense in a trait' do
+        expect_offense(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              title "Something"
+              trait :something_else do
+                title { "Something Else" }
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
+              end
+            end
+          end
+        RUBY
+      end
+
+      it 'accepts valid factory definitions' do
+        expect_no_offenses(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              trait :something_else do
+                title "Something Else"
+              end
+              title "Something"
+              comments_count 0
+              description { FFaker::Lorem.paragraph(10) }
+              tag Tag::MAGIC
+              recent_updates { [Time.current] }
+              meta_tags { { first_like: Time.current } }
+            end
+          end
+        RUBY
+      end
+
+      it 'does not add offense if out of factory girl block' do
+        expect_no_offenses(<<-RUBY)
+          kind { :static }
+          comments_count { 0 }
+          type { User::MAGIC }
+          description { nil }
+        RUBY
+      end
+
+      bad = <<-RUBY
+        #{factory_bot}.define do
+          factory :post do
+            comments_count { 0 }
+            type { User::MAGIC }
+            description { nil }
+            recent_statuses { [:published, :draft] }
+            meta_tags { { foo: 1 } }
+          end
+        end
+      RUBY
+
+      corrected = <<-RUBY
+        #{factory_bot}.define do
+          factory :post do
+            comments_count 0
+            type User::MAGIC
+            description nil
+            recent_statuses [:published, :draft]
+            meta_tags({ foo: 1 })
+          end
+        end
+      RUBY
+
+      include_examples 'autocorrect', bad, corrected
+    end
+  end
+end

data/spec/rubocop/cop/rspec/rails/http_status_spec.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::Rails::HttpStatus, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when EnforcedStyle is `symbolic`' do
+    let(:cop_config) { { 'EnforcedStyle' => 'symbolic' } }
+
+    it 'registers an offense when using numeric value' do
+      expect_offense(<<-RUBY)
+        it { is_expected.to have_http_status 200 }
+                                             ^^^ Prefer `:ok` over `200` to describe HTTP status code.
+      RUBY
+    end
+
+    it 'does not register an offense when using symbolic value' do
+      expect_no_offenses(<<-RUBY)
+        it { is_expected.to have_http_status :ok }
+      RUBY
+    end
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to have_http_status 200 }',
+                     'it { is_expected.to have_http_status :ok }'
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to have_http_status 404 }',
+                     'it { is_expected.to have_http_status :not_found }'
+
+    context 'with parenthesis' do
+      include_examples 'autocorrect',
+                       'it { is_expected.to have_http_status(200) }',
+                       'it { is_expected.to have_http_status(:ok) }'
+
+      include_examples 'autocorrect',
+                       'it { is_expected.to have_http_status(404) }',
+                       'it { is_expected.to have_http_status(:not_found) }'
+    end
+
+    context 'when rack is not loaded' do
+      before { stub_const("#{described_class}::RACK_LOADED", false) }
+
+      it 'registers an offense when using numeric value' do
+        expect_offense(<<-RUBY)
+          it { is_expected.to have_http_status 200 }
+                                               ^^^ Prefer `symbolic` over `numeric` to describe HTTP status code.
+        RUBY
+      end
+    end
+  end
+
+  context 'when EnforcedStyle is `numeric`' do
+    let(:cop_config) { { 'EnforcedStyle' => 'numeric' } }
+
+    it 'registers an offense when using symbolic value' do
+      expect_offense(<<-RUBY)
+        it { is_expected.to have_http_status :ok }
+                                             ^^^ Prefer `200` over `:ok` to describe HTTP status code.
+      RUBY
+    end
+
+    it 'does not register an offense when using numeric value' do
+      expect_no_offenses(<<-RUBY)
+        it { is_expected.to have_http_status 200 }
+      RUBY
+    end
+
+    it 'does not register an offense when using whitelisted symbols' do
+      expect_no_offenses(<<-RUBY)
+        it { is_expected.to have_http_status :error }
+        it { is_expected.to have_http_status :success }
+        it { is_expected.to have_http_status :missing }
+        it { is_expected.to have_http_status :redirect }
+      RUBY
+    end
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to have_http_status :ok }',
+                     'it { is_expected.to have_http_status 200 }'
+
+    include_examples 'autocorrect',
+                     'it { is_expected.to have_http_status :not_found }',
+                     'it { is_expected.to have_http_status 404 }'
+
+    context 'with parenthesis' do
+      include_examples 'autocorrect',
+                       'it { is_expected.to have_http_status(:ok) }',
+                       'it { is_expected.to have_http_status(200) }'
+
+      include_examples 'autocorrect',
+                       'it { is_expected.to have_http_status(:not_found) }',
+                       'it { is_expected.to have_http_status(404) }'
+    end
+
+    context 'when rack is not loaded' do
+      before { stub_const("#{described_class}::RACK_LOADED", false) }
+
+      it 'registers an offense when using numeric value' do
+        expect_offense(<<-RUBY)
+          it { is_expected.to have_http_status :ok }
+                                               ^^^ Prefer `numeric` over `symbolic` to describe HTTP status code.
+        RUBY
+      end
+    end
+  end
+end

data/spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -53,6 +53,15 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
       RUBY
     end
 
+    it 'finds constants returned from block' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { Life::MEANING }
+                                      ^ Use `and_return` for static values.
+        end
+      RUBY
+    end
+
     it 'ignores dynamic values returned from block' do
       expect_no_offenses(<<-RUBY)
         it do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.22.2
+  version: 1.23.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-01 00:00:00.000000000 Z
+date: 2018-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -26,6 +26,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.52.1
+- !ruby/object:Gem::Dependency
+  name: rack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -127,6 +141,7 @@ files:
 - lib/rubocop/cop/rspec/expect_in_hook.rb
 - lib/rubocop/cop/rspec/expect_output.rb
 - lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb
+- lib/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
@@ -150,6 +165,7 @@ files:
 - lib/rubocop/cop/rspec/not_to_not.rb
 - lib/rubocop/cop/rspec/overwriting_setup.rb
 - lib/rubocop/cop/rspec/predicate_matcher.rb
+- lib/rubocop/cop/rspec/rails/http_status.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
 - lib/rubocop/cop/rspec/return_from_stub.rb
@@ -207,6 +223,7 @@ files:
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -230,6 +247,7 @@ files:
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
+- spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/return_from_stub_spec.rb
@@ -272,7 +290,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
@@ -305,6 +323,7 @@ test_files:
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -328,6 +347,7 @@ test_files:
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
+- spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/return_from_stub_spec.rb