rubocop-rspec 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 781c177bf195bc9ec0663b45b2312aa2a94f6da2
-  data.tar.gz: 44414a1e7ea2f3ee8ac707b8d6e5659e5789588b
+  metadata.gz: 33cc3eb121d9cb56164a721c6856c1b640f7bed6
+  data.tar.gz: 668538c6096e0beee8e9acbffc0b7639c3a50c22
 SHA512:
-  metadata.gz: f95537228be6ba9d25328bfcb375091ba5bcfc2bc58ba384c910e6f87fd367a5510dfec4f47cdf07a2e863794a614d657c22b7d744b94380db6e6a67e6f6f78c
-  data.tar.gz: 157e06d0dc76c034b8a2704dad0747d15cb59654412206957fa4c4365686adf8764544de0b8ad1ca6f21c7bc54d6e21b30a0e04526ec51636663d6b2f1dbe176
+  metadata.gz: 80ae0ce41af162ecbf52082e626a9921daf66b1f2e2b3b907105a6d247b611c548ba60228055e777a6fc06ac22e0702ce57b5a2afdc1c5eaac10ef7d8979cb8e
+  data.tar.gz: c10dc7627d94f250ffb294a62db891c8a9854208cfe4f40856653759858f0c6079bc38e3e6b3b573b904eefaf0d17f48fbacd9e1d3dc87f30e2bcea5e571da51

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+# 1.2.2
+
+* Make `RSpec::ExampleWording` case insensitive. ([@geniou][])
+
 ## 1.2.1
 
 * Add `RSpec::VerifiedDoubles` cop. ([@andyw8][])

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -28,7 +28,7 @@ module RuboCop
 
           arguments = *(args.first)
           message = arguments.first.to_s
-          return unless message.start_with?('should')
+          return unless message.downcase.start_with?('should')
 
           arg1 = args.first.loc.expression
           message = Parser::Source::Range

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.2.1'
+      STRING = '1.2.2'
     end
   end
 end

data/spec/rubocop/cop/rspec/describe_class_spec.rb

@@ -4,7 +4,7 @@ describe RuboCop::Cop::RSpec::DescribeClass do
   subject(:cop) { described_class.new }
 
   it 'checks first-line describe statements' do
-    inspect_source(cop, ['describe "bad describe" do; end'])
+    inspect_source(cop, 'describe "bad describe" do; end')
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages).to eq(['The first argument to describe should be ' \
@@ -28,7 +28,7 @@ describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it "doesn't blow up on single-line describes" do
-    inspect_source(cop, ['describe Some::Class'])
+    inspect_source(cop, 'describe Some::Class')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/rspec/describe_method_spec.rb

@@ -4,7 +4,7 @@ describe RuboCop::Cop::RSpec::DescribeMethod do
   subject(:cop) { described_class.new }
 
   it 'enforces non-method names' do
-    inspect_source(cop, ["describe Some::Class, 'nope' do; end"])
+    inspect_source(cop, "describe Some::Class, 'nope' do; end")
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -86,7 +86,7 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   end
 
   it 'checks for the use of described class with module' do
-    pending 'TODO'
+    skip
     inspect_source(cop, ['module MyNamespace',
                          '  describe MyClass do',
                          '    subject { MyNamespace::MyClass }',

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -18,6 +18,15 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
     expect(cop.highlights).to eq(['should do something'])
   end
 
+  it 'finds description with `Should` at the beginning' do
+    inspect_source(cop, ["it 'Should do something' do", 'end'])
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses.map(&:line).sort).to eq([1])
+    expect(cop.messages)
+      .to eq(['Do not use should when describing your tests.'])
+    expect(cop.highlights).to eq(['Should do something'])
+  end
+
   it 'finds description with `shouldn\'t` at the beginning' do
     inspect_source(cop, ['it "shouldn\'t do something" do', 'end'])
     expect(cop.offenses.size).to eq(1)

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -6,7 +6,7 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
 
   it 'checks the path' do
     inspect_source(cop,
-                   ["describe MyClass, 'foo' do; end"],
+                   "describe MyClass, 'foo' do; end",
                    'wrong_path_foo_spec.rb')
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
@@ -16,7 +16,7 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
 
   it 'checks the path' do
     inspect_source(cop,
-                   ["describe MyClass, '#foo' do; end"],
+                   "describe MyClass, '#foo' do; end",
                    'wrong_class_foo_spec.rb')
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
@@ -26,7 +26,7 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
 
   it 'checks class spec paths' do
     inspect_source(cop,
-                   ['describe MyClass do; end'],
+                   'describe MyClass do; end',
                    'wrong_class_spec.rb')
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
@@ -36,7 +36,7 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
 
   it 'skips specs that do not describe a class / method' do
     inspect_source(cop,
-                   ["describe 'Test something' do; end"],
+                   "describe 'Test something' do; end",
                    'some/class/spec.rb')
     expect(cop.offenses).to be_empty
   end
@@ -51,98 +51,98 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
 
   it 'checks class specs' do
     inspect_source(cop,
-                   ['describe Some::Class do; end'],
+                   'describe Some::Class do; end',
                    'some/class_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'handles CamelCaps class names' do
     inspect_source(cop,
-                   ['describe MyClass do; end'],
+                   'describe MyClass do; end',
                    'my_class_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'handles ACRONYMClassNames' do
     inspect_source(cop,
-                   ['describe ABCOne::Two do; end'],
+                   'describe ABCOne::Two do; end',
                    'abc_one/two_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'handles ALLCAPS class names' do
     inspect_source(cop,
-                   ['describe ALLCAPS do; end'],
+                   'describe ALLCAPS do; end',
                    'allcaps_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'checks instance methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '#inst' do; end"],
+                   "describe Some::Class, '#inst' do; end",
                    'some/class/inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'checks class methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '.inst' do; end"],
+                   "describe Some::Class, '.inst' do; end",
                    'some/class/inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flat hierarchies for instance methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '#inst' do; end"],
+                   "describe Some::Class, '#inst' do; end",
                    'some/class_inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flat hierarchies for class methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '.inst' do; end"],
+                   "describe Some::Class, '.inst' do; end",
                    'some/class_inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows subdirs for instance methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '#inst' do; end"],
+                   "describe Some::Class, '#inst' do; end",
                    'some/class/instance_methods/inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows subdirs for class methods' do
     inspect_source(cop,
-                   ["describe Some::Class, '.inst' do; end"],
+                   "describe Some::Class, '.inst' do; end",
                    'some/class/class_methods/inst_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores non-alphanumeric characters' do
     inspect_source(cop,
-                   ["describe Some::Class, '#pred?' do; end"],
+                   "describe Some::Class, '#pred?' do; end",
                    'some/class/pred_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flexibility with predicates' do
     inspect_source(cop,
-                   ["describe Some::Class, '#thing?' do; end"],
+                   "describe Some::Class, '#thing?' do; end",
                    'some/class/thing_predicate_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flexibility with operators' do
     inspect_source(cop,
-                   ["describe MyClass, '#<=>' do; end"],
+                   "describe MyClass, '#<=>' do; end",
                    'my_class/spaceship_operator_spec.rb')
     expect(cop.offenses).to be_empty
   end
 
   it 'respects custom module name transformation' do
     inspect_source(cop,
-                   ["describe FooFoo::Some::Class, '#bar' do; end"],
+                   "describe FooFoo::Some::Class, '#bar' do; end",
                    'foofoo/some/class/bar_spec.rb')
     expect(cop.offenses).to be_empty
   end

data/spec/spec_helper.rb

@@ -1,9 +1,21 @@
 # encoding: utf-8
 
-# As much as possible, we try to reuse RuboCop's spec environment.
-require File.join(
-  Gem::Specification.find_by_name('rubocop').gem_dir, 'spec', 'spec_helper.rb'
-)
+require 'rubocop'
+
+rubocop_gem_path = Gem::Specification.find_by_name('rubocop').gem_dir
+Dir["#{rubocop_gem_path}/spec/support/**/*.rb"].each { |f| require f }
+
+RSpec.configure do |config|
+  config.order = :random
+
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect # Disable `should`
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.syntax = :expect # Disable `should_receive` and `stub`
+  end
+end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Ian MacLeod
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-03 00:00:00.000000000 Z
+date: 2015-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop