rubocop-rspec 1.13.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94ad662f54f32cf6cbde51f8c2fdd788fa44e989
-  data.tar.gz: d0c3723b84a23c6589aa10d9f379b7d56b332bcc
+  metadata.gz: 0d76ad6b5a03029a44d0df0b733fd13816be3ffd
+  data.tar.gz: 430a2169a27502c780f3ab10d9e0bae261a31f94
 SHA512:
-  metadata.gz: fbc83814064a1e25163689e9da12bcfcac4c8f0849c62fe34adb13b6fa7a569f8a37a627bd04fe067f28bec140c4d8f89c9b2bed537b21eaafdeac9ad32c8663
-  data.tar.gz: cf26853505de97b2ba385add43eb5cbf71cac5395c9f773208f93d4bd02b9650e023ee9a27b4c0f23e0ee7909370d8c8060fa05fa2299aa639ba3837054cdfb1
+  metadata.gz: 54815c238a360be303b16144d9dcb3338770948de917b0a5a6f292dd25721b9d48c042edab0361f203b050be82cb18bcd2dcd1250b4ee111f9e3f3d15dd1ed1d
+  data.tar.gz: 1d39b6af29a27b1cda1ae5f223e74dfba11f494381920ae821941546322d3688cd30e3666a245535c6bc8998c2b7bb13c4aafc378ebc7b3469ee434b60741db3

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## Master (Unreleased)
 
+## 1.14.0 (2017-03-24)
+
+* Add `RSpec/OverwritingSetup` cop. ([@Darhazer][])
+* Add autocorrect support for `RSpec/LeadingSubject` cop. ([@Darhazer][])
+* Add `RSpec/ScatteredLet` cop. ([@Darhazer][])
+* Add `RSpec/IteratedExpectation` cop. ([@Darhazer][])
+* Add `RSpec/EmptyLineAfterSubject` cop. ([@Darhazer][])
+* Add `RSpec/EmptyLineAfterFinalLet` cop. ([@Darhazer][])
+
 ## 1.13.0 (2017-03-07)
 
 * Add repeated 'it' detection to `RSpec/ExampleWording` cop. ([@dgollahon][])

data/config/default.yml

@@ -42,11 +42,23 @@ RSpec/DescribeMethod:
   Description: Checks that the second argument to `describe` specifies a method.
   Enabled: true
 
+RSpec/IteratedExpectation:
+  Description: Check that `all` matcher is used instead of iterating over an array.
+  Enabled: true
+
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
   CustomIncludeMethods: []
 
+RSpec/EmptyLineAfterFinalLet:
+  Description: Checks if there is an empty line after the last let block.
+  Enabled: true
+
+RSpec/EmptyLineAfterSubject:
+  Description: Checks if there is an empty line after subject block.
+  Enabled: true
+
 RSpec/ExampleLength:
   Description: Checks for long examples.
   Enabled: true
@@ -171,6 +183,10 @@ RSpec/NotToNot:
   - to_not
   Enabled: true
 
+RSpec/OverwritingSetup:
+  Enabled: true
+  Description: Checks if there is a let/subject that overwrites an existing one.
+
 RSpec/RepeatedDescription:
   Enabled: true
   Description: Check for repeated description strings in example groups.
@@ -187,6 +203,10 @@ RSpec/SingleArgumentMessageChain:
   Description: Checks that chains of messages contain more than one element.
   Enabled: true
 
+RSpec/ScatteredLet:
+  Description: Checks for let scattered across the example group.
+  Enabled: true
+
 RSpec/ScatteredSetup:
   Description: Checks for setup scattered across multiple hooks in an example group.
   Enabled: true

data/lib/rubocop-rspec.rb

@@ -28,6 +28,8 @@ require 'rubocop/cop/rspec/describe_class'
 require 'rubocop/cop/rspec/describe_method'
 require 'rubocop/cop/rspec/described_class'
 require 'rubocop/cop/rspec/empty_example_group'
+require 'rubocop/cop/rspec/empty_line_after_final_let'
+require 'rubocop/cop/rspec/empty_line_after_subject'
 require 'rubocop/cop/rspec/example_length'
 require 'rubocop/cop/rspec/example_wording'
 require 'rubocop/cop/rspec/expect_actual'
@@ -39,6 +41,7 @@ require 'rubocop/cop/rspec/implicit_expect'
 require 'rubocop/cop/rspec/instance_spy'
 require 'rubocop/cop/rspec/instance_variable'
 require 'rubocop/cop/rspec/it_behaves_like'
+require 'rubocop/cop/rspec/iterated_expectation'
 require 'rubocop/cop/rspec/leading_subject'
 require 'rubocop/cop/rspec/let_setup'
 require 'rubocop/cop/rspec/message_chain'
@@ -49,8 +52,10 @@ require 'rubocop/cop/rspec/multiple_expectations'
 require 'rubocop/cop/rspec/named_subject'
 require 'rubocop/cop/rspec/nested_groups'
 require 'rubocop/cop/rspec/not_to_not'
+require 'rubocop/cop/rspec/overwriting_setup'
 require 'rubocop/cop/rspec/repeated_description'
 require 'rubocop/cop/rspec/repeated_example'
+require 'rubocop/cop/rspec/scattered_let'
 require 'rubocop/cop/rspec/scattered_setup'
 require 'rubocop/cop/rspec/shared_context'
 require 'rubocop/cop/rspec/single_argument_message_chain'

data/lib/rubocop/cop/rspec/empty_line_after_final_let.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks if there is an empty line after the last let block.
+      #
+      # @example
+      #   # bad
+      #     let(:foo) { bar }
+      #     let(:something) { other }
+      #     it do
+      #       ...
+      #     end
+      #
+      #   # good
+      #     let(:foo) { bar }
+      #     let(:something) { other }
+      #
+      #     it do
+      #       ...
+      #     end
+      class EmptyLineAfterFinalLet < Cop
+        MSG = 'Add an empty line after the last `let` block.'.freeze
+
+        def_node_matcher :let?, '(block $(send nil {:let :let!} ...) args ...)'
+
+        def on_block(node)
+          return unless let?(node) && !in_spec_block?(node)
+
+          latest_let = node
+          node.parent.each_child_node do |sibling|
+            latest_let = sibling if let?(sibling)
+          end
+
+          return if latest_let.equal?(node.parent.children.last)
+
+          no_new_line_after(latest_let) do
+            add_offense(latest_let, :expression)
+          end
+        end
+
+        def autocorrect(node)
+          loc = last_node_loc(node)
+          ->(corrector) { corrector.insert_after(loc.end, "\n") }
+        end
+
+        private
+
+        def no_new_line_after(node)
+          loc = last_node_loc(node)
+
+          next_line = processed_source[loc.line]
+
+          yield unless next_line.blank?
+        end
+
+        def last_node_loc(node)
+          last_line = node.loc.end.line
+          heredoc_line(node) do |loc|
+            return loc if loc.line > last_line
+          end
+          node.loc.end
+        end
+
+        def heredoc_line(node, &block)
+          yield node.loc.heredoc_end if node.loc.respond_to?(:heredoc_end)
+
+          node.each_child_node { |child| heredoc_line(child, &block) }
+        end
+
+        def in_spec_block?(node)
+          node.each_ancestor(:block).any? do |ancestor|
+            Examples::ALL.include?(ancestor.method_name)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/empty_line_after_subject.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks if there is an empty line after subject block.
+      #
+      # @example
+      #   # bad
+      #     subject(:obj) { described_class }
+      #     let(:foo) { bar }
+      #
+      #   # good
+      #     subject(:obj) { described_class }
+      #
+      #     let(:foo) { bar }
+      class EmptyLineAfterSubject < Cop
+        MSG = 'Add empty line after `subject`.'.freeze
+
+        def_node_matcher :subject?, '(block $(send nil :subject ...) args ...)'
+
+        def on_block(node)
+          return unless subject?(node) && !in_spec_block?(node)
+          return if node.equal?(node.parent.children.last)
+
+          send_line = node.loc.end.line
+          next_line = processed_source[send_line]
+          return if next_line.blank?
+
+          add_offense(node, :expression, MSG)
+        end
+
+        def autocorrect(node)
+          ->(corrector) { corrector.insert_after(node.loc.end, "\n") }
+        end
+
+        private
+
+        def in_spec_block?(node)
+          node.each_ancestor(:block).any? do |ancestor|
+            Examples::ALL.include?(ancestor.method_name)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/iterated_expectation.rb

@@ -0,0 +1,52 @@
+module RuboCop
+  module Cop
+    module RSpec
+      # Check that `all` matcher is used instead of iterating over an array.
+      #
+      # @example
+      #   # bad
+      #   it 'validates users' do
+      #     [user1, user2, user3].each { |user| expect(user).to be_valid }
+      #   end
+      #
+      #   # good
+      #   it 'validates users' do
+      #     expect([user1, user2, user3]).to all(be_valid)
+      #   end
+      class IteratedExpectation < Cop
+        MSG = 'Prefer using the `all` matcher instead ' \
+                  'of iterating over an array.'.freeze
+
+        def_node_matcher :each?, <<-PATTERN
+          (block
+            (send ... :each)
+            (args (arg $_))
+            $(...)
+          )
+        PATTERN
+
+        def_node_matcher :expectation?, <<-PATTERN
+          (send (send nil :expect (lvar %)) :to ...)
+        PATTERN
+
+        def on_block(node)
+          each?(node) do |arg, body|
+            if single_expectation?(body, arg) || only_expectations?(body, arg)
+              add_offense(node.children.first, :expression)
+            end
+          end
+        end
+
+        private
+
+        def single_expectation?(body, arg)
+          expectation?(body, arg)
+        end
+
+        def only_expectations?(body, arg)
+          body.children.all? { |child| expectation?(child, arg) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/leading_subject.rb

@@ -37,14 +37,37 @@ module RuboCop
           node.parent.each_child_node do |sibling|
             break if sibling.equal?(node)
 
-            if sibling.method_name.equal?(:let)
-              break add_offense(node, :expression)
-            end
+            break add_offense(node, :expression) if let?(sibling)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            first_let = find_first_let(node)
+            first_let_position = first_let.loc.expression
+            indent = "\n" + ' ' * first_let.loc.column
+            corrector.insert_before(first_let_position, node.source + indent)
+            corrector.remove(node_range(node))
           end
         end
 
         private
 
+        def let?(node)
+          [:let, :let!].include?(node.method_name)
+        end
+
+        def find_first_let(node)
+          node.parent.children.find { |sibling| let?(sibling) }
+        end
+
+        def node_range(node)
+          range = node.source_range
+          range = range_with_surrounding_space(range, :left, false)
+          range = range_with_surrounding_space(range, :right, true)
+          range
+        end
+
         def in_spec_block?(node)
           node.each_ancestor(:block).any? do |ancestor|
             Examples::ALL.include?(ancestor.method_name)

data/lib/rubocop/cop/rspec/overwriting_setup.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks if there is a let/subject that overwrites an existing one.
+      #
+      # @example
+      #   # bad
+      #     let(:foo) { bar }
+      #     let(:foo) { baz }
+      #
+      #     subject(:foo) { bar }
+      #     let(:foo) { baz }
+      #
+      #     let(:foo) { bar }
+      #     let!(:foo) { baz }
+      #
+      #   # good
+      #     subject(:test) { something }
+      #     let(:foo) { bar }
+      #     let(:baz) { baz }
+      #     let!(:other) { other }
+      class OverwritingSetup < Cop
+        MSG = '`%{name}` is already defined.'.freeze
+
+        def_node_matcher :setup?, <<-PATTERN
+          (block (send nil {:let :let! :subject} (sym $_)) ...)
+        PATTERN
+
+        def on_block(node)
+          return unless example_group?(node)
+
+          _describe, _args, body = *node
+
+          find_duplicates(body) do |duplicate, name|
+            add_offense(duplicate, :expression, format(MSG, name: name))
+          end
+        end
+
+        private
+
+        def find_duplicates(node)
+          setup_expressions = Set.new
+          node.each_child_node do |child|
+            setup?(child) do |name|
+              yield child, name unless setup_expressions.add?(name)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/scattered_let.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for let scattered across the example group.
+      #
+      # Group lets together
+      #
+      # @example
+      #   # bad
+      #   describe Foo do
+      #     let(:foo) { 1 }
+      #     subject { Foo }
+      #     let(:bar) { 2 }
+      #     before { prepare }
+      #     let!(:baz) { 3 }
+      #   end
+      #
+      #   # good
+      #   describe Foo do
+      #     subject { Foo }
+      #     before { prepare }
+      #     let(:foo) { 1 }
+      #     let(:bar) { 2 }
+      #     let!(:baz) { 3 }
+      #   end
+      #
+      class ScatteredLet < Cop
+        MSG = 'Group all let/let! blocks in the example group together.'.freeze
+
+        def_node_matcher :let?, '(block (send nil {:let :let!} ...) ...)'
+
+        def on_block(node)
+          return unless example_group?(node)
+
+          _describe, _args, body = *node
+
+          check_let_declarations(body)
+        end
+
+        def check_let_declarations(node)
+          let_found = false
+          mix_found = false
+
+          node.each_child_node do |child|
+            if let?(child)
+              add_offense(child, :expression) if mix_found
+              let_found = true
+            elsif let_found
+              mix_found = true
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.13.0'.freeze
+      STRING = '1.14.0'.freeze
     end
   end
 end

data/spec/project/changelog_spec.rb

@@ -10,18 +10,15 @@ RSpec.describe 'CHANGELOG.md' do
 
   describe 'entry' do
     subject(:entries) { lines.grep(/^\*/).map(&:chomp) }
+
     let(:lines) { changelog.each_line }
 
     it 'has a whitespace between the * and the body' do
-      entries.each do |entry|
-        expect(entry).to match(/^\* \S/)
-      end
+      expect(entries).to all(match(/^\* \S/))
     end
 
     it 'has a link to the contributors at the end' do
-      entries.each do |entry|
-        expect(entry).to match(/\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/)
-      end
+      expect(entries).to all(match(/\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/))
     end
 
     describe 'link to related issue on github' do
@@ -50,9 +47,7 @@ RSpec.describe 'CHANGELOG.md' do
           entry.match(/^\*\s*\[/)
         end
 
-        entries_including_issue_link.each do |entry|
-          expect(entry).to include('): ')
-        end
+        expect(entries_including_issue_link).to all(include('): '))
       end
     end
 
@@ -72,9 +67,7 @@ RSpec.describe 'CHANGELOG.md' do
       end
 
       it 'ends with a punctuation' do
-        bodies.each do |body|
-          expect(body).to match(/[\.\!]$/)
-        end
+        expect(bodies).to all(match(/[\.\!]$/))
       end
     end
   end

data/spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb

@@ -0,0 +1,142 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
+  subject(:cop) { described_class.new }
+
+  it 'checks for empty line after last let' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        let(:b) { b }
+        ^^^^^^^^^^^^^ Add an empty line after the last `let` block.
+        it { expect(a).to eq(b) }
+      end
+    RUBY
+  end
+
+  it 'check for empty line after the last `let!`' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        let!(:b) do
+        ^^^^^^^^^^^ Add an empty line after the last `let` block.
+          b
+        end
+        it { expect(a).to eq(b) }
+      end
+    RUBY
+  end
+
+  it 'approves empty line after let' do
+    expect_no_violations(<<-RUBY)
+    RSpec.describe User do
+      let(:a) { a }
+      let(:b) { b }
+
+      it { expect(a).to eq(b) }
+    end
+    RUBY
+  end
+
+  it 'ignores empty lines between the lets' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+
+        subject { described_class }
+
+        let!(:b) { b }
+        ^^^^^^^^^^^^^^ Add an empty line after the last `let` block.
+        it { expect(a).to eq(b) }
+      end
+    RUBY
+  end
+
+  it 'handles let in tests' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        # This shouldn't really ever happen in a sane codebase but I still
+        # want to avoid false positives
+        it "doesn't mind me calling a method called let in the test" do
+          let(foo)
+          subject { bar }
+        end
+      end
+    RUBY
+  end
+
+  it 'handles multiline let block' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        let(:b) do
+          b
+        end
+
+        it { expect(a).to eq(b) }
+      end
+    RUBY
+  end
+
+  it 'handles let being the latest node' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        let(:b) { b }
+      end
+    RUBY
+  end
+
+  it 'handles HEREDOC for let' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) do
+          <<-BAR
+          hello
+          world
+          BAR
+        end
+
+        it 'uses heredoc' do
+          expect(foo).to eql("  hello\n  world\n")
+        end
+      end
+    RUBY
+  end
+
+  it 'handles silly HEREDOC syntax for let' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe 'silly heredoc syntax' do
+        let(:foo) { <<-BAR }
+        hello
+        world
+        BAR
+
+        it 'has tricky syntax' do
+          expect(foo).to eql("  hello\n  world\n")
+        end
+      end
+    RUBY
+  end
+
+  bad_example = <<-RUBY
+  RSpec.describe User do
+    let(:params) { foo }
+    it 'has a new line' do
+    end
+  end
+  RUBY
+
+  good_example = <<-RUBY
+  RSpec.describe User do
+    let(:params) { foo }
+
+    it 'has a new line' do
+    end
+  end
+  RUBY
+
+  include_examples 'autocorrect',
+                   bad_example,
+                   good_example
+end

data/spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
+  subject(:cop) { described_class.new }
+
+  it 'checks for empty line after subject' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Add empty line after `subject`.
+        let(:params) { foo }
+      end
+    RUBY
+  end
+
+  it 'approves empty line after subject' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+
+        let(:params) { foo }
+      end
+    RUBY
+  end
+
+  it 'handles subjects in tests' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        # This shouldn't really ever happen in a sane codebase but I still
+        # want to avoid false positives
+        it "doesn't mind me calling a method called subject in the test" do
+          subject { bar }
+          let(foo)
+        end
+      end
+    RUBY
+  end
+
+  it 'handles multiline subject block' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        subject do
+          described_class.new
+        end
+
+        let(:params) { foo }
+      end
+    RUBY
+  end
+
+  it 'handles let being the latest node' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        subject { described_user }
+      end
+    RUBY
+  end
+
+  bad_example = <<-RUBY
+  RSpec.describe User do
+    subject { described_class.new }
+    let(:params) { foo }
+  end
+  RUBY
+
+  good_example = <<-RUBY
+  RSpec.describe User do
+    subject { described_class.new }
+
+    let(:params) { foo }
+  end
+  RUBY
+
+  include_examples 'autocorrect',
+                   bad_example,
+                   good_example
+end

data/spec/rubocop/cop/rspec/iterated_expectation_spec.rb

@@ -0,0 +1,72 @@
+RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
+  subject(:cop) { described_class.new }
+
+  it 'flags `each` with an expectation' do
+    expect_violation(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each { |user| expect(user).to be_valid }
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
+      end
+    RUBY
+  end
+
+  it 'flags `each` when expectation calls method with arguments' do
+    expect_violation(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each { |user| expect(user).to be_a(User) }
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
+      end
+    RUBY
+  end
+
+  it 'ignores `each` without expectation' do
+    expect_no_violations(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each { |user| allow(user).to receive(:method) }
+      end
+    RUBY
+  end
+
+  it 'flags `each` with multiple expectations' do
+    expect_violation(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each do |user|
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
+          expect(user).to receive(:method)
+          expect(user).to receive(:other_method)
+        end
+      end
+    RUBY
+  end
+
+  it 'ignore `each` when the body does not contain only expectations' do
+    expect_no_violations(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each do |user|
+          allow(Something).to receive(:method).and_return(user)
+          expect(user).to receive(:method)
+          expect(user).to receive(:other_method)
+        end
+      end
+    RUBY
+  end
+
+  it 'ignores `each` with expectation on property' do
+    expect_no_violations(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each { |user| expect(user.name).to be }
+      end
+    RUBY
+  end
+
+  it 'ignores `each` when there is a negative expectation' do
+    expect_no_violations(<<-RUBY)
+      it 'validates users' do
+        [user1, user2, user3].each do |user|
+          expect(user).not_to receive(:method)
+          expect(user).to receive(:other_method)
+        end
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/leading_subject_spec.rb

@@ -14,6 +14,17 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
     RUBY
   end
 
+  it 'checks subject below let!' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let!(:params) { foo }
+
+        subject { described_class.new }
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations.
+      end
+    RUBY
+  end
+
   it 'approves of subject above let' do
     expect_no_violations(<<-RUBY)
       RSpec.describe User do
@@ -51,4 +62,50 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
       end
     RUBY
   end
+
+  bad_code = <<-RUBY
+    RSpec.describe User do
+      let(:params) { foo }
+      let(:bar) { baz }
+
+      subject { described_class.new }
+      it { is_expected.to do_something }
+    end
+  RUBY
+
+  good_code = <<-RUBY
+    RSpec.describe User do
+      subject { described_class.new }
+      let(:params) { foo }
+      let(:bar) { baz }
+
+      it { is_expected.to do_something }
+    end
+  RUBY
+
+  include_examples 'autocorrect', bad_code, good_code
+
+  bad_code = <<-RUBY
+    RSpec.describe User do
+      let(:params) { foo }
+      let(:bar) { baz }
+      subject do
+        described_class.new
+      end
+      it { is_expected.to do_something }
+    end
+  RUBY
+
+  good_code = <<-RUBY
+    RSpec.describe User do
+      subject do
+        described_class.new
+      end
+      let(:params) { foo }
+      let(:bar) { baz }
+      it { is_expected.to do_something }
+    end
+  RUBY
+
+  include_examples 'autocorrect', bad_code, good_code
 end

data/spec/rubocop/cop/rspec/overwriting_setup_spec.rb

@@ -0,0 +1,46 @@
+RSpec.describe RuboCop::Cop::RSpec::OverwritingSetup do
+  subject(:cop) { described_class.new }
+
+  it 'finds overwriten `let`' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        let(:a) { b }
+        ^^^^^^^^^^^^^ `a` is already defined.
+      end
+    RUBY
+  end
+
+  it 'finds overwriten `subject`' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        subject(:a) { a }
+
+        let(:a) { b }
+        ^^^^^^^^^^^^^ `a` is already defined.
+      end
+    RUBY
+  end
+
+  it 'finds `let!` overwriting `let`' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { b }
+        let!(:a) { b }
+        ^^^^^^^^^^^^^^ `a` is already defined.
+      end
+    RUBY
+  end
+
+  it 'ignores overwriting in different context' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+
+        context `different` do
+          let(:a) { b }
+        end
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -0,0 +1,26 @@
+RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
+  subject(:cop) { described_class.new }
+
+  it 'flags `let` after the first different node ' do
+    expect_violation(<<-RUBY)
+      RSpec.describe User do
+        let(:a) { a }
+        subject { User }
+        let(:b) { b }
+        ^^^^^^^^^^^^^ Group all let/let! blocks in the example group together.
+      end
+    RUBY
+  end
+
+  it 'doesnt flag `let!` in the middle of multiple `let`s' do
+    expect_no_violations(<<-RUBY)
+      RSpec.describe User do
+        subject { User }
+
+        let(:a) { a }
+        let!(:b) { b }
+        let(:c) { c }
+      end
+    RUBY
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+date: 2017-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -153,6 +153,8 @@ files:
 - lib/rubocop/cop/rspec/describe_method.rb
 - lib/rubocop/cop/rspec/described_class.rb
 - lib/rubocop/cop/rspec/empty_example_group.rb
+- lib/rubocop/cop/rspec/empty_line_after_final_let.rb
+- lib/rubocop/cop/rspec/empty_line_after_subject.rb
 - lib/rubocop/cop/rspec/example_length.rb
 - lib/rubocop/cop/rspec/example_wording.rb
 - lib/rubocop/cop/rspec/expect_actual.rb
@@ -164,6 +166,7 @@ files:
 - lib/rubocop/cop/rspec/instance_spy.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
 - lib/rubocop/cop/rspec/it_behaves_like.rb
+- lib/rubocop/cop/rspec/iterated_expectation.rb
 - lib/rubocop/cop/rspec/leading_subject.rb
 - lib/rubocop/cop/rspec/let_setup.rb
 - lib/rubocop/cop/rspec/message_chain.rb
@@ -174,8 +177,10 @@ files:
 - lib/rubocop/cop/rspec/named_subject.rb
 - lib/rubocop/cop/rspec/nested_groups.rb
 - lib/rubocop/cop/rspec/not_to_not.rb
+- lib/rubocop/cop/rspec/overwriting_setup.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
+- lib/rubocop/cop/rspec/scattered_let.rb
 - lib/rubocop/cop/rspec/scattered_setup.rb
 - lib/rubocop/cop/rspec/shared_context.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
@@ -209,6 +214,8 @@ files:
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
 - spec/rubocop/cop/rspec/empty_example_group_spec.rb
+- spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb
+- spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
@@ -220,6 +227,7 @@ files:
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/it_behaves_like_spec.rb
+- spec/rubocop/cop/rspec/iterated_expectation_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
@@ -230,8 +238,10 @@ files:
 - spec/rubocop/cop/rspec/named_subject_spec.rb
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
+- spec/rubocop/cop/rspec/overwriting_setup_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
@@ -269,7 +279,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
@@ -287,6 +297,8 @@ test_files:
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
 - spec/rubocop/cop/rspec/empty_example_group_spec.rb
+- spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb
+- spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
@@ -298,6 +310,7 @@ test_files:
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/it_behaves_like_spec.rb
+- spec/rubocop/cop/rspec/iterated_expectation_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
@@ -308,8 +321,10 @@ test_files:
 - spec/rubocop/cop/rspec/named_subject_spec.rb
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
+- spec/rubocop/cop/rspec/overwriting_setup_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb