rubocop-redis 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88c0751305ae0be68873bb027ea34611d02059c3654606f6d5b77ff935edd243
-  data.tar.gz: 6e2c5281ebbe7fa262938b722aeabe69c07f9ed20ad3966b2e70ad4e14b06454
+  metadata.gz: 32561f1c19ab9a331fbf7a88828bae2c51e3b688235e8f8d632439c7ed4e94a6
+  data.tar.gz: ffb1a9c65495fff2393ec0f8a3ad5550c1a469b018bc5fce2772890c1bb7167b
 SHA512:
-  metadata.gz: 2b9afb62bf8d1c0c49c5aa12ad03d1b53bc2d2eee67b24414fb0ee0ea373d682c7611eee4e4f4d97fc996305e8f64619b4c44f109dc1cd77e6a0f1884a57f3b3
-  data.tar.gz: 275ad6cee5146caed431c517a661ac9d919029a55e3412374dccaaed47628751595d89e54a863515caffafbb05b2e302559afa346ef3877b0378cbb0cdfa6d26
+  metadata.gz: fe622f73bfcbabf171f47123943bf8be995cbfd2725190126d377bda9b2e0b504db423706b027e8935050a06d60a4ba9e35845059b4acf9dd7652a4043c5e135
+  data.tar.gz: 57d7310c4f3f42fa851aaa6114c38ac221ebcb330ae342a89a12d27b3a0b2c3f935e8e66aedda59bf69068202c135d2afa5f23163e4651a0feeb70678c20e5b7

data/.rubocop.yml

@@ -17,3 +17,6 @@ Layout/LineLength:
 
 Naming/FileName:
   Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false

data/docs/modules/ROOT/pages/cops_redis.adoc

@@ -16,18 +16,23 @@ This cop detects the use of `KEYS` query that should be noted when used in a pro
 Consider using `SCAN` query instead of `KEYS` query.
 See https://redis.io/commands/keys/ for details.
 
+To avoid detecting `Hash#keys` calling, this cop adds an offense if a receiver of `keys` method is named `redis`.
+
 === Examples
 
 [source,ruby]
 ----
 # bad
-Redis.current.keys("pattern-*")
+redis.keys("pattern-*")
+
+# bad
+Redis.new.keys("pattern-*")
 
 # good
 cursor = 0
 all_keys = []
 loop do
-  cursor, keys = Redis.current.scan(cursor, match: "pattern-*")
+  cursor, keys = redis.scan(cursor, match: "pattern-*")
   all_keys += keys
   break if cursor == "0"
 end

data/lib/rubocop/cop/redis/not_keys.rb

@@ -7,15 +7,20 @@ module RuboCop
       # Consider using `SCAN` query instead of `KEYS` query.
       # See https://redis.io/commands/keys/ for details.
       #
+      # To avoid detecting `Hash#keys` calling, this cop adds an offense only if a receiver of `keys` method is named `redis`.
+      #
       # @example
       #   # bad
-      #   Redis.current.keys("pattern-*")
+      #   redis.keys("pattern-*")
+      #
+      #   # bad
+      #   Redis.new.keys("pattern-*")
       #
       #   # good
       #   cursor = 0
       #   all_keys = []
       #   loop do
-      #     cursor, keys = Redis.current.scan(cursor, match: "pattern-*")
+      #     cursor, keys = redis.scan(cursor, match: "pattern-*")
       #     all_keys += keys
       #     break if cursor == "0"
       #   end
@@ -27,16 +32,28 @@ module RuboCop
         def_node_matcher :keys_call?, <<~PATTERN
           (send
             (send
-              (const {cbase nil?} :Redis) :current) :keys $...)
+              (const {cbase nil?} :Redis) {:new | :current} ...) :keys ...)
+        PATTERN
+
+        def_node_matcher :keys_call_for_object?, <<~PATTERN
+          (send ($...) :keys ...)
         PATTERN
 
         RESTRICT_ON_SEND = %i[keys].freeze
 
         def on_send(node)
-          return unless keys_call?(node)
+          return unless keys_call?(node) || keys_call_for_object_named_redis?(node)
 
           add_offense(node)
         end
+
+        private
+
+        def keys_call_for_object_named_redis?(node)
+          receiver, message = keys_call_for_object?(node)
+
+          receiver.nil? && message == :redis
+        end
       end
     end
   end

data/lib/rubocop/redis/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Redis
-    VERSION = "0.1.3"
+    VERSION = "0.1.4"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-redis
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - 9sako6
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-09-04 00:00:00.000000000 Z
+date: 2022-09-09 00:00:00.000000000 Z
 dependencies: []
 description: An extension of RuboCop for redis/redis gem.
 email:
@@ -41,7 +41,7 @@ metadata:
   homepage_uri: https://github.com/9sako6/rubocop-redis
   source_code_uri: https://github.com/9sako6/rubocop-redis
   changelog_uri: https://github.com/9sako6/rubocop-redis/releases
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -56,8 +56,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
-signing_key:
+rubygems_version: 3.3.4
+signing_key: 
 specification_version: 4
 summary: An extension of RuboCop for redis/redis gem.
 test_files: []