rubocop-rbs_inline 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d23ee9bd49cabe4e0b153c7d1423768c42172f800fecd4c8a1786dc9c110078
-  data.tar.gz: 7605f5de5e26c0ea0134f5a842503beaa49b5099ec4bf9c149a149342be15b84
+  metadata.gz: '00947d7a01908093d8cd62383b06d9b944b5b5f33de6f900c0e1d7397a780156'
+  data.tar.gz: 884446ced80f488bcd8397d5b9c9461e8c111564400a0b5fe89024b6d36c41eb
 SHA512:
-  metadata.gz: 2cc7f50364b7bdb9db4258aadb53cc9b88e4f5c1e4de691ab0e9630df5821e91ce07d4935ef5784a09a9667d9e3042566293921f710c9312a3c0231775e7a735
-  data.tar.gz: c396f462d1d3ab5e8342595e392e65f9105e44b8c8457ad477a15415122a364969e04324c597b5d68b25c58fd43fb8bdb1fdade219951e8dce888df89d676138
+  metadata.gz: ef3cfff6c721505beb2de6f0f57cdafe776f0bec6dbeb8c175562738879a986e09b08ae0a9d4a11038d9e70beda1a453d426efb8b9566d9a0ffc65e097ac0847
+  data.tar.gz: 669626ab0e4a5a08630508ff99bef9c2d7f606a79edcfafd46746b173a2e44e67ac2e51b1a0857ceddb55005dfe66a9acd8741a1ac1737cb101c8a562a88c8ee

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.5.1 (2026-02-24)
+
+### Bug Fixes
+
+- **Style/RbsInline/UntypedInstanceVariable**: No longer reports an offense for instance variables that are only read without being assigned in the class. Read-only references are excluded because the variable may be defined in a parent class, making it impossible to determine whether a type annotation is needed.
+
 ## 1.5.0 (2026-02-24)
 
 ### New Cops

data/lib/rubocop/cop/style/rbs_inline/untyped_instance_variable.rb

@@ -11,11 +11,14 @@ module RuboCop
         # Instance variables must either have a `# @rbs @ivar: Type` annotation
         # or be covered by a typed `attr_reader/writer/accessor` declaration.
         #
+        # Only instance variables that are **assigned** within the class/module are checked.
+        # Read-only references are ignored because the variable may be defined in a parent class.
+        #
         # @example
         #   # bad
         #   class Foo
-        #     def bar
-        #       @baz
+        #     def initialize
+        #       @baz = 1
         #     end
         #   end
         #
@@ -23,8 +26,8 @@ module RuboCop
         #   class Foo
         #     # @rbs @baz: Integer
         #
-        #     def bar
-        #       @baz
+        #     def initialize
+        #       @baz = 1
         #     end
         #   end
         #
@@ -32,6 +35,13 @@ module RuboCop
         #   class Foo
         #     attr_reader :baz  #: Integer
         #
+        #     def initialize
+        #       @baz = 1
+        #     end
+        #   end
+        #
+        #   # good (only read, may be defined in parent class)
+        #   class Foo
         #     def bar
         #       @baz
         #     end
@@ -46,7 +56,7 @@ module RuboCop
 
           ATTR_METHODS = %i[attr_reader attr_writer attr_accessor].freeze
 
-          # @rbs! type scope = { typed_ivars: Set[Symbol], used_ivars: Hash[Symbol, Parser::AST::Node] }
+          # @rbs! type scope = { typed_ivars: Set[Symbol], assigned_ivars: Hash[Symbol, Parser::AST::Node] }
 
           attr_reader :scope_stack #: Array[scope]
           attr_reader :ivar_type_annotations #: Hash[Integer, Symbol]
@@ -81,13 +91,11 @@ module RuboCop
           alias after_module after_class
 
           # @rbs node: Parser::AST::Node
-          def on_ivar(node) #: void
+          def on_ivasgn(node) #: void
             name = node.children.first #: Symbol
-            current_scope[:used_ivars][name] ||= node
+            current_scope[:assigned_ivars][name] ||= node
           end
 
-          alias on_ivasgn on_ivar
-
           # @rbs node: Parser::AST::Node
           def on_send(node) #: void
             return unless attr_method?(node)
@@ -112,7 +120,7 @@ module RuboCop
           end
 
           def push_scope #: void
-            scope_stack.push({ typed_ivars: Set.new, used_ivars: {} })
+            scope_stack.push({ typed_ivars: Set.new, assigned_ivars: {} })
           end
 
           def pop_scope #: void
@@ -143,7 +151,7 @@ module RuboCop
           end
 
           def report_offenses #: void
-            current_scope[:used_ivars].each do |name, node|
+            current_scope[:assigned_ivars].each do |name, node|
               next if current_scope[:typed_ivars].include?(name)
 
               bare_name = name.to_s.delete_prefix('@')

data/lib/rubocop/rbs_inline/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RbsInline
-    VERSION = '1.5.0'
+    VERSION = '1.5.1'
   end
 end

data/sig/rubocop/cop/style/rbs_inline/untyped_instance_variable.rbs

@@ -9,11 +9,14 @@ module RuboCop
         # Instance variables must either have a `# @rbs @ivar: Type` annotation
         # or be covered by a typed `attr_reader/writer/accessor` declaration.
         #
+        # Only instance variables that are **assigned** within the class/module are checked.
+        # Read-only references are ignored because the variable may be defined in a parent class.
+        #
         # @example
         #   # bad
         #   class Foo
-        #     def bar
-        #       @baz
+        #     def initialize
+        #       @baz = 1
         #     end
         #   end
         #
@@ -21,8 +24,8 @@ module RuboCop
         #   class Foo
         #     # @rbs @baz: Integer
         #
-        #     def bar
-        #       @baz
+        #     def initialize
+        #       @baz = 1
         #     end
         #   end
         #
@@ -30,6 +33,13 @@ module RuboCop
         #   class Foo
         #     attr_reader :baz  #: Integer
         #
+        #     def initialize
+        #       @baz = 1
+        #     end
+        #   end
+        #
+        #   # good (only read, may be defined in parent class)
+        #   class Foo
         #     def bar
         #       @baz
         #     end
@@ -43,7 +53,7 @@ module RuboCop
 
           ATTR_METHODS: untyped
 
-          type scope = { typed_ivars: Set[Symbol], used_ivars: Hash[Symbol, Parser::AST::Node] }
+          type scope = { typed_ivars: Set[Symbol], assigned_ivars: Hash[Symbol, Parser::AST::Node] }
 
           attr_reader scope_stack: Array[scope]
 
@@ -64,9 +74,7 @@ module RuboCop
           alias after_module after_class
 
           # @rbs node: Parser::AST::Node
-          def on_ivar: (Parser::AST::Node node) -> void
-
-          alias on_ivasgn on_ivar
+          def on_ivasgn: (Parser::AST::Node node) -> void
 
           # @rbs node: Parser::AST::Node
           def on_send: (Parser::AST::Node node) -> void

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rbs_inline
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Takeshi KOMIYA