rubocop-rake 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b6574fbdd64dbe9c5df47c71132c17feb7b0399491902c8e01480e333a361ec
-  data.tar.gz: d24998e7452dbd98f07f29b63db9fc7a10392f6d91244b8eec333afdb3484ef8
+  metadata.gz: b71580a8ba42edbae65f9f46e4e5fd2af9e64b4bda2a8eff8a9e719e35ff4ca1
+  data.tar.gz: 6083afa2054e8ccd3e4148335d663b6872f05cdeca02265601b3a7e4d5b1501a
 SHA512:
-  metadata.gz: 0d56524f419e37ee6d62469f3cc7a1b940d62793673bfd51fa8b86f991adf6adfeed20dcb7d0f17297defe1eb334bbe2fa6654dfcfeba0828740caf19755aafc
-  data.tar.gz: b331328c525c4c441277e96f2eec388360c2648469da9cbe86ce1b1adb6ab814f20425002288c5c378906d1d15a37b7db3b37eabedd861177da55ed12826c3e8
+  metadata.gz: f71f3e174dae2a4a310483393c506bd3508576d93bfe6e8bd6c7cbf66fbe3104b35ac287f0b69568fb3b169e3ee20ceebb4c77219fbb8c8a9d258cb676ad79a3
+  data.tar.gz: ecd03e5d7cafc964fe1c501c85d554d07a3bdce600d1ba046cf372fcfbab5c0cde93b7fedf5c9781fdf9274e6c0adfbdd626dd59ac93f9c39e9c9c2f8b3de0cc

data/.circleci/config.yml

@@ -0,0 +1,50 @@
+version: 2
+
+steps: &steps
+  steps:
+    - checkout
+    - run: bundle install
+    - run: bundle exec rake
+
+jobs:
+
+  ruby-2.3:
+    docker:
+      - image: circleci/ruby:2.3
+    <<: *steps
+
+  ruby-2.4:
+    docker:
+      - image: circleci/ruby:2.4
+    <<: *steps
+
+  ruby-2.5:
+    docker:
+      - image: circleci/ruby:2.5
+    <<: *steps
+
+  ruby-2.6:
+    docker:
+      - image: circleci/ruby:2.6
+    <<: *steps
+
+  ruby-2.7:
+    docker:
+      - image: circleci/ruby:2.7
+    <<: *steps
+
+  ruby-head:
+    docker:
+      - image: rubocophq/circleci-ruby-snapshot:latest
+    <<: *steps
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - ruby-2.3
+      - ruby-2.4
+      - ruby-2.5
+      - ruby-2.6
+      - ruby-2.7
+      - ruby-head

data/.rubocop.yml

@@ -7,6 +7,9 @@ require:
 AllCops:
   TargetRubyVersion: 2.4
 
+Layout/LineLength:
+  Enabled: false
+
 Metrics:
   Enabled: false
 

data/CHANGELOG.md

@@ -2,15 +2,11 @@
 
 ## master (unreleased)
 
-<!--
-
-### New features
+## 0.5.1 (2020-02-14)
 
 ### Bug fixes
 
-### Changes
-
--->
+* [#28](https://github.com/rubocop-hq/rubocop-rake/issues/28): Fix `Rake/Desc` to avoid an error when `task` is not a task definition. ([@pocke][])
 
 ## 0.5.0 (2019-10-31)
 

data/README.md

@@ -1,3 +1,6 @@
+[![Gem Version](https://badge.fury.io/rb/rubocop-rake.svg)](https://rubygems.org/gems/rubocop-rake)
+[![CircleCI](https://circleci.com/gh/rubocop-hq/rubocop-rake.svg?style=svg)](https://circleci.com/gh/rubocop-hq/rubocop-rake)
+
 # RuboCop Rake
 
 A [RuboCop](https://github.com/rubocop-hq/rubocop) plugin for Rake.
@@ -7,7 +10,7 @@ A [RuboCop](https://github.com/rubocop-hq/rubocop) plugin for Rake.
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rubocop-rake'
+gem 'rubocop-rake', require: false
 ```
 
 And then execute:

data/lib/rubocop/cop/rake/desc.rb

@@ -42,6 +42,7 @@ module RuboCop
         private def task_with_desc?(node)
           parent, task = parent_and_task(node)
           return false unless parent
+          return true unless can_insert_desc_to?(parent)
 
           idx = parent.children.find_index(task) - 1
           desc_candidate = parent.children[idx]
@@ -55,15 +56,17 @@ module RuboCop
           return nil, task_node unless parent
           return parent, task_node unless parent.block_type?
 
-          # rubocop:disable Style/GuardClause
           if parent.children.find_index(task_node) == 0
             # when task {}
-            return parent.parent, parent
+            [parent.parent, parent]
           else
             # when something { task }
-            return parent, task_node
+            [parent, task_node]
           end
-          # rubocop:enable Style/GuardClause
+        end
+
+        private def can_insert_desc_to?(parent)
+          parent.begin_type? || parent.block_type? || parent.kwbegin_type?
         end
       end
     end

data/lib/rubocop/cop/rake/helper/task_name.rb

@@ -11,7 +11,7 @@ module RuboCop
             first_arg = node.arguments[0]
             case first_arg&.type
             when :sym, :str
-              return first_arg.value.to_sym
+              first_arg.value.to_sym
             when :hash
               return nil if first_arg.children.size != 1
 

data/lib/rubocop/rake/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Rake
-    VERSION = "0.5.0"
+    VERSION = "0.5.1"
   end
 end

data/rubocop-rake.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary       = %q{A RuboCop plugin for Rake}
   spec.description   = %q{A RuboCop plugin for Rake}
   spec.homepage      = "https://github.com/rubocop-hq/rubocop-rake"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
   spec.licenses = ['MIT']
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rake
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Masataka Pocke Kuwabara
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-31 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -31,11 +31,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -76,14 +76,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.0.pre1
 signing_key: 
 specification_version: 4
 summary: A RuboCop plugin for Rake

data/.travis.yml

@@ -1,22 +0,0 @@
-language: ruby
-
-rvm:
-  - 2.4.7
-  - 2.5.6
-  - 2.6.4
-  - ruby-head
-
-cache: bundler
-bundler_args: --jobs=4 --retry=3
-sudo: false
-
-
-before_install: 'gem update --system'
-
-script:
-  - bundle exec rake
-
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-  fast_finish: true