rubocop-rake 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14304d50b67b9946c5962a7d4a120f924b1fa12f0236e51dab8b58d106b4a81c
-  data.tar.gz: d827d6b122b63d7ce6e012551d389f9e3ee34597d99e9d7b6739e533243d8fe7
+  metadata.gz: 2b6574fbdd64dbe9c5df47c71132c17feb7b0399491902c8e01480e333a361ec
+  data.tar.gz: d24998e7452dbd98f07f29b63db9fc7a10392f6d91244b8eec333afdb3484ef8
 SHA512:
-  metadata.gz: 1079f85fad77e44350769a85a5d925d4ca46c249952d3903f6b0e4804ed22b8435a4e27f0a717296bf024389413852ee89f45ae36cad44c4106560914fe97f1e
-  data.tar.gz: f32b18ca6c6db87e80b6ee71bb754717aab1750fc4596949a6e4b2d001034319a5843d5b9771171e332ec9b9ff2e86a7af2ddbbfded90e6c35659d7ef5d7f078
+  metadata.gz: 0d56524f419e37ee6d62469f3cc7a1b940d62793673bfd51fa8b86f991adf6adfeed20dcb7d0f17297defe1eb334bbe2fa6654dfcfeba0828740caf19755aafc
+  data.tar.gz: b331328c525c4c441277e96f2eec388360c2648469da9cbe86ce1b1adb6ab814f20425002288c5c378906d1d15a37b7db3b37eabedd861177da55ed12826c3e8

data/.rubocop.yml

@@ -19,7 +19,7 @@ Style/AccessModifierDeclarations:
 Style/NumericPredicate:
   Enabled: false
 
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Exclude:
     - '*.gemspec'
 

data/CHANGELOG.md

@@ -12,6 +12,12 @@
 
 -->
 
+## 0.5.0 (2019-10-31)
+
+### New features
+
+* [#14](https://github.com/rubocop-hq/rubocop-rake/issues/14): Add Rake/DuplicateNamespace cop. ([@jaruuuu][])
+
 ## 0.4.0 (2019-10-13)
 
 ### New features
@@ -48,3 +54,4 @@
 * Add `Rake/Desc`. ([@pocke][])
 
 [@pocke]: https://github.com/pocke
+[@jaruuuu]: https://github.com/jaruuuu

data/Gemfile

@@ -7,4 +7,5 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem 'rspec'
+gem 'rubocop', '>= 0.76'
 gem 'rubocop-rspec'

data/config/default.yml

@@ -1,4 +1,5 @@
 Rake:
+  Enabled: true
   Include:
     - 'Rakefile'
     - '**/*.rake'
@@ -13,6 +14,11 @@ Rake/Desc:
   Enabled: true
   VersionAdded: '0.1.0'
 
+Rake/DuplicateNamespace:
+  Description: 'Do not define namespace with the same name'
+  Enabled: true
+  VersionAdded: '0.5.0'
+
 Rake/DuplicateTask:
   Description: 'Do not define tasks with the same name'
   Enabled: true

data/lib/rubocop-rake.rb

@@ -12,4 +12,5 @@ require_relative 'rubocop/cop/rake/helper/class_definition'
 require_relative 'rubocop/cop/rake/helper/on_task'
 require_relative 'rubocop/cop/rake/helper/task_definition'
 require_relative 'rubocop/cop/rake/helper/task_name'
+require_relative 'rubocop/cop/rake/helper/on_namespace'
 require_relative 'rubocop/cop/rake_cops'

data/lib/rubocop/cop/rake/duplicate_namespace.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rake
+      # If namespaces are defined with the same name, Rake executes the both namespaces
+      # in definition order.
+      # It is redundant. You should squash them into one definition.
+      # This cop detects it.
+      #
+      # @example
+      #   # bad
+      #   namespace :foo do
+      #     task :bar do
+      #     end
+      #   end
+      #   namespace :foo do
+      #     task :hoge do
+      #     end
+      #   end
+      #
+      #   # good
+      #   namespace :foo do
+      #     task :bar do
+      #     end
+      #     task :hoge do
+      #     end
+      #   end
+      #
+      class DuplicateNamespace < Cop
+        include Helper::OnNamespace
+
+        MSG = 'Namespace `%<namespace>s` is defined at both %<previous>s and %<current>s.'
+
+        def initialize(*)
+          super
+          @namespaces = {}
+        end
+
+        def on_namespace(node)
+          namespaces = namespaces(node)
+          return if namespaces.include?(nil)
+
+          full_name = namespaces.reverse.join(':')
+          if (previous = @namespaces[full_name])
+            message = message_for_dup(previous: previous, current: node, namespace: full_name)
+            add_offense(node, message: message)
+          else
+            @namespaces[full_name] = node
+          end
+        end
+
+        def namespaces(node)
+          ns = []
+
+          node.each_ancestor(:block) do |block_node|
+            send_node = block_node.send_node
+            next unless send_node.method_name == :namespace
+
+            name = Helper::TaskName.task_name(send_node)
+            ns << name
+          end
+
+          ns
+        end
+
+        def message_for_dup(previous:, current:, namespace:)
+          format(
+            MSG,
+            namespace: namespace,
+            previous: source_location(previous),
+            current: source_location(current),
+          )
+        end
+
+        def source_location(node)
+          range = node.location.expression
+          path = smart_path(range.source_buffer.name)
+          "#{path}:#{range.line}"
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rake/helper/on_namespace.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rake
+      module Helper
+        module OnNamespace
+          extend NodePattern::Macros
+
+          def_node_matcher :namespace?, <<~PATTERN
+            (send nil? :namespace ...)
+          PATTERN
+
+          def on_send(node)
+            return unless namespace?(node)
+
+            on_namespace(node)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rake_cops.rb

@@ -3,4 +3,5 @@
 require_relative 'rake/class_definition_in_task'
 require_relative 'rake/desc'
 require_relative 'rake/duplicate_task'
+require_relative 'rake/duplicate_namespace'
 require_relative 'rake/method_definition_in_task'

data/lib/rubocop/rake/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Rake
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rake
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Masataka Pocke Kuwabara
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-13 00:00:00.000000000 Z
+date: 2019-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -47,8 +47,10 @@ files:
 - lib/rubocop-rake.rb
 - lib/rubocop/cop/rake/class_definition_in_task.rb
 - lib/rubocop/cop/rake/desc.rb
+- lib/rubocop/cop/rake/duplicate_namespace.rb
 - lib/rubocop/cop/rake/duplicate_task.rb
 - lib/rubocop/cop/rake/helper/class_definition.rb
+- lib/rubocop/cop/rake/helper/on_namespace.rb
 - lib/rubocop/cop/rake/helper/on_task.rb
 - lib/rubocop/cop/rake/helper/task_definition.rb
 - lib/rubocop/cop/rake/helper/task_name.rb