rubocop-rails_deprecation 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50c57a07baf6ba0d3d701e8b399394b240e0303f60ea4db9f790b02fa62b8fe4
-  data.tar.gz: 76a9afe9155e2154810e512e3a2e657c0f6df2a142f6c55724c261a3cf62099f
+  metadata.gz: 8cd931c5484f2340724c62e6027b6b9cb42fb5a66556a73a8b9776510f5bef53
+  data.tar.gz: 6aa4dcb475684c260b069c098dfab8fe9f59ec644ba4f0a883b2a63105cd21e0
 SHA512:
-  metadata.gz: 21378a6e0eb10d8f9ce8f472ab0cf002eaaf12514e3f22b29be8667b30a0eea162801e5fc686cf94afabcb3ee6bea63f0e25d23327e7cf458a116e28a4d35522
-  data.tar.gz: '07901cc6b3f6b5e0aa0cc5dd1c0a2eb4dad61195af75fa94e99061c6c3a647bab8852426334000f381e2f348ef3d78a4090b6d41b6834434a79772142c05871b'
+  metadata.gz: 0b221fc6c392b527f86c59eac7841781fe3c9fe94815451596c3b2134f01709accb3fae86befc3c92fd53fe2b3df106718fe2d8b435a737bfc4f06d328b6d9eb
+  data.tar.gz: 954e9a81b8c16d01ea55412123c9a8b72254379c01331ebd4309b9dd0e6e9c9a937a44ec3e6bf0417cbf5ca9dfc36456c710a689e52fd7fe63af4e4121d6990f

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+## 0.6.0 - 2022-04-10
+
+### Added
+
+- Add RailsDeprecation/WhereNot cop.
+
 ## 0.5.0 - 2022-04-10
 
 ### Changed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-rails_deprecation (0.5.0)
+    rubocop-rails_deprecation (0.6.0)
       rubocop (>= 1.27)
 
 GEM

data/lib/rubocop/cop/rails_deprecation/base.rb

@@ -4,10 +4,20 @@ module RuboCop
   module Cop
     module RailsDeprecation
       class Base < ::RuboCop::Cop::Base
+        DEFAULT_MAXIMUM_TARGET_RAILS_VERSION = ::Float::INFINITY
+
         DEFAULT_MINIMUM_TARGET_RAILS_VERSION = 5.0
 
         class << self
-          attr_writer :minimum_target_rails_version
+          attr_writer(
+            :maximum_target_rails_version,
+            :minimum_target_rails_version
+          )
+
+          # @return [Float]
+          def maximum_target_rails_version
+            @maximum_target_rails_version ||= DEFAULT_MAXIMUM_TARGET_RAILS_VERSION
+          end
 
           # @return [Float]
           def minimum_target_rails_version
@@ -18,7 +28,7 @@ module RuboCop
           # @param [Float] version
           # @return [Boolean]
           def support_target_rails_version?(version)
-            minimum_target_rails_version <= version
+            (minimum_target_rails_version..maximum_target_rails_version).include?(version)
           end
         end
       end

data/lib/rubocop/cop/rails_deprecation/where_not.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RailsDeprecation
+      # This cop identifies passing Hash with multiple elements to `where.not`.
+      #
+      # @example
+      #
+      #   # bad
+      #   where.not(key1: value1, key2: value2)
+      #
+      #   # good
+      #   where.not(key1: value1).where.not(key2: value2)
+      #
+      #   # good
+      #   where.not(key1: value1)
+      #
+      class WhereNot < Base
+        extend AutoCorrector
+
+        self.maximum_target_rails_version = 6.0
+
+        MSG = 'Use `where.not(key1: value1).where.not(key2: value2)` instead of `where.not(key1: value1, key2: value2)`.'
+
+        def_node_matcher :where_not_with_multiple_elements_hash?, <<~PATTERN
+          (send
+            (send _ :where) :not
+            ({ hash | kwargs }
+              (pair _ _)
+              (pair _ _)+))
+        PATTERN
+
+        def on_send(node)
+          return unless where_not_with_multiple_elements_hash?(node)
+
+          add_offense(node) do |corrector|
+            pairs = node.children[2].children
+            last_end_pos = pairs[0].location.expression.end_pos
+            pairs[1..].each do |pair|
+              corrector.remove(pair.location.expression.with(begin_pos: last_end_pos))
+              last_end_pos = pair.location.expression.end_pos
+              corrector.insert_after(node.location.expression, ".where.not(#{pair.source})")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rails_deprecation_cops.rb

@@ -2,3 +2,4 @@
 
 require_relative 'rails_deprecation/base'
 require_relative 'rails_deprecation/to_formatted_s'
+require_relative 'rails_deprecation/where_not'

data/lib/rubocop/rails_deprecation/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RailsDeprecation
-    VERSION = '0.5.0'
+    VERSION = '0.6.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails_deprecation
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ryo Nakamura
@@ -44,6 +44,7 @@ files:
 - lib/rubocop-rails_deprecation.rb
 - lib/rubocop/cop/rails_deprecation/base.rb
 - lib/rubocop/cop/rails_deprecation/to_formatted_s.rb
+- lib/rubocop/cop/rails_deprecation/where_not.rb
 - lib/rubocop/cop/rails_deprecation_cops.rb
 - lib/rubocop/rails_deprecation.rb
 - lib/rubocop/rails_deprecation/inject.rb