rubocop-rails_config 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f11c8e792e06a1fb792f4424004666ce2b9c4ea4bb9fcbbdc6b4a3a853d0f069
-  data.tar.gz: 49c406533c5a6701af9d222ee9f0dbc1b47ea9e1bac5ffebd9280ea9b509dac1
+  metadata.gz: b2d585cf6a121e18fbdab8b05d809608d06c288e235c4b6dbacc9e4d789625d7
+  data.tar.gz: 7e2ba34e0e410cee40181cef3dd3920d5e7e4912154e99e59d64abcd758a8aa8
 SHA512:
-  metadata.gz: b5e799c684a27d6e13f39bbc6c84b3ccea2a4cc27cfbb738bf7f8a139cdefd439a98676a0074eda1deef1ceb4e2a677ea90614c48fa371de79d86007a0a95f02
-  data.tar.gz: a7b78ebce77d185196e2f1143dfe5274508acac7445c91da3923e75c60af276acb5bf890d5c43850b966a6d955be971be8333c216984c28e4dfccf4e5b7da860
+  metadata.gz: d2459c00127f240a3189603ad44713a092ed415bf2db12499d8f75e78f6d5f0f560ef7dc4805f426243f945858a270b6eb1d6a470957028ea440ae32a36a2005
+  data.tar.gz: '0280f272444c001b947314721630f102f93ad6031e93646add259c5a4537fa51cf2987b80a2c8c44adeae4cc2fd1706d067460ff6529951cffb2edba3ccb4658'

data/config/rails.yml

@@ -1,5 +1,3 @@
-require: custom_cops
-
 AllCops:
   TargetRubyVersion: 2.2
   # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
@@ -15,13 +13,16 @@ AllCops:
     - 'db/migrate/**/*.rb'
     - 'db/*.rb'
 
-# Prefer assert_not_x over refute_x
-CustomCops/RefuteNot:
+Rails:
+  Enabled: true
+
+# Prefer assert_not over assert !
+Rails/AssertNot:
   Include:
     - '**/test/**/*'
 
-# Prefer assert_not over assert !
-CustomCops/AssertNot:
+# Prefer assert_not_x over refute_x
+Rails/RefuteMethods:
   Include:
     - '**/test/**/*'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails_config
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Toshimaru
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-14 00:00:00.000000000 Z
+date: 2018-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.53'
+        version: '0.56'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.53'
+        version: '0.56'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -90,9 +104,6 @@ files:
 - LICENSE
 - README.md
 - config/rails.yml
-- lib/custom_cops.rb
-- lib/custom_cops/assert_not.rb
-- lib/custom_cops/refute_not.rb
 - lib/generators/rubocop_rails_config/install_generator.rb
 - lib/generators/rubocop_rails_config/update_generator.rb
 homepage: https://github.com/toshimaru/rubocop-rails_config

data/lib/custom_cops.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "custom_cops/refute_not"

data/lib/custom_cops/assert_not.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module CustomCops
-  # Enforces the use of `assert_not` over `assert !`.
-  #
-  # @example
-  #   # bad
-  #   assert !x
-  #   assert ! x
-  #
-  #   # good
-  #   assert_not x
-  #
-  class AssertNot < RuboCop::Cop::Cop
-    MSG = "Prefer `assert_not` over `assert !`"
-
-    def_node_matcher :offensive?, "(send nil? :assert (send ... :!) ...)"
-
-    def on_send(node)
-      add_offense(node) if offensive?(node)
-    end
-
-    def autocorrect(node)
-      expression = node.loc.expression
-
-      ->(corrector) do
-        corrector.replace(
-          expression,
-          corrected_source(expression.source)
-        )
-      end
-    end
-
-    private
-
-      def corrected_source(source)
-        source.gsub(/^assert(\(| ) *! */, "assert_not\\1")
-      end
-  end
-end

data/lib/custom_cops/refute_not.rb

@@ -1,71 +0,0 @@
-# frozen_string_literal: true
-
-module CustomCops
-  # Enforces the use of `#assert_not` methods over `#refute` methods.
-  #
-  # @example
-  #   # bad
-  #   refute false
-  #   refute_empty [1, 2, 3]
-  #   refute_equal true, false
-  #
-  #   # good
-  #   assert_not false
-  #   assert_not_empty [1, 2, 3]
-  #   assert_not_equal true, false
-  #
-  class RefuteNot < RuboCop::Cop::Cop
-    MSG = "Prefer `%<assert_method>s` over `%<refute_method>s`"
-
-    CORRECTIONS = {
-      refute:             "assert_not",
-      refute_empty:       "assert_not_empty",
-      refute_equal:       "assert_not_equal",
-      refute_in_delta:    "assert_not_in_delta",
-      refute_in_epsilon:  "assert_not_in_epsilon",
-      refute_includes:    "assert_not_includes",
-      refute_instance_of: "assert_not_instance_of",
-      refute_kind_of:     "assert_not_kind_of",
-      refute_nil:         "assert_not_nil",
-      refute_operator:    "assert_not_operator",
-      refute_predicate:   "assert_not_predicate",
-      refute_respond_to:  "assert_not_respond_to",
-      refute_same:        "assert_not_same",
-      refute_match:       "assert_no_match"
-    }.freeze
-
-    OFFENSIVE_METHODS = CORRECTIONS.keys.freeze
-
-    def_node_matcher :offensive?, "(send nil? #offensive_method? ...)"
-
-    def on_send(node)
-      return unless offensive?(node)
-
-      message = offense_message(node.method_name)
-      add_offense(node, location: :selector, message: message)
-    end
-
-    def autocorrect(node)
-      ->(corrector) do
-        corrector.replace(
-          node.loc.selector,
-          CORRECTIONS[node.method_name]
-        )
-      end
-    end
-
-    private
-
-      def offensive_method?(method_name)
-        OFFENSIVE_METHODS.include?(method_name)
-      end
-
-      def offense_message(method_name)
-        format(
-          MSG,
-          refute_method: method_name,
-          assert_method: CORRECTIONS[method_name]
-        )
-      end
-  end
-end