rubocop-rails 2.36.0 → 2.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5fcf30164d8e9727b16702ab937a902890c342d02c1865e4588295a355380f7a
-  data.tar.gz: 8c88a959e8b7b07e6751c6a385302deabc39f8bf328278b979d62c46becaccc7
+  metadata.gz: 9258d56d31fc4adeef0526b551dbe652abe70dd4599debc25ee39be54b743330
+  data.tar.gz: ab2d60fe9b2a61ac47f8f15f8753fb60dd26e278d5452d23501f59a398fd7b0a
 SHA512:
-  metadata.gz: bc070f9148d8b3b8d87c06cf95ae2b604eb81758548cfab082a38300760ac714ac0d1741e19c8c7d604563868be6b03b4c1b1bdc87af6d7999a4386aa37701d4
-  data.tar.gz: 14e8a2fa9886a93625e49678688e7b00e2075bfcfa00a04adc23c3de5d3b8e9fd3c5be88b19e532d4cd30b1dc746320b273f0a2c7f7b984625e1a6874f16d649
+  metadata.gz: 7ba4c487f87fdbd58130ba06fc0184c9c5b5dabe5ee3934aa03930c27467072a7f89ac77ba423fe89f69ad9739c2dfcbeac1bb947e64804757e6efbdb47b47a5
+  data.tar.gz: 223e0693edfd7de08b9d6a770fbdd7ced5c6422cab60d5074657ef65dd7b4ce538c8f61c37cc15156d63824e1d4060a654bca1fef7830d1b587e7ca84d516f62

data/lib/rubocop/cop/mixin.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Autoloads mixin modules included by cops. Mixins are autoloaded to reduce the number of requires
+    # because they're used only when the relevant cop class is loaded.
+    autoload :ActiveRecordHelper, "#{__dir__}/mixin/active_record_helper"
+    autoload :ActiveRecordMigrationsHelper, "#{__dir__}/mixin/active_record_migrations_helper"
+    autoload :ClassSendNodeHelper, "#{__dir__}/mixin/class_send_node_helper"
+    autoload :DatabaseTypeResolvable, "#{__dir__}/mixin/database_type_resolvable"
+    autoload :EnforceSuperclass, "#{__dir__}/mixin/enforce_superclass"
+    autoload :IndexMethod, "#{__dir__}/mixin/index_method"
+    autoload :MigrationsHelper, "#{__dir__}/mixin/migrations_helper"
+    autoload :RoutesHelper, "#{__dir__}/mixin/routes_helper"
+    autoload :TargetRailsVersion, "#{__dir__}/mixin/target_rails_version"
+  end
+end

data/lib/rubocop/cop/rails/application_controller.rb

@@ -27,9 +27,8 @@ module RuboCop
         SUPERCLASS = 'ApplicationController'
         BASE_PATTERN = '(const (const {nil? cbase} :ActionController) :Base)'
 
-        # rubocop:disable Layout/ClassStructure
+        # rubocop:disable-next Layout/ClassStructure
         include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
       end
     end
   end

data/lib/rubocop/cop/rails/application_job.rb

@@ -30,9 +30,8 @@ module RuboCop
         SUPERCLASS = 'ApplicationJob'
         BASE_PATTERN = '(const (const {nil? cbase} :ActiveJob) :Base)'
 
-        # rubocop:disable Layout/ClassStructure
+        # rubocop:disable-next Layout/ClassStructure
         include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
 
         def autocorrect(node)
           lambda do |corrector|

data/lib/rubocop/cop/rails/application_mailer.rb

@@ -30,9 +30,8 @@ module RuboCop
         SUPERCLASS = 'ApplicationMailer'
         BASE_PATTERN = '(const (const {nil? cbase} :ActionMailer) :Base)'
 
-        # rubocop:disable Layout/ClassStructure
+        # rubocop:disable-next Layout/ClassStructure
         include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
       end
     end
   end

data/lib/rubocop/cop/rails/application_record.rb

@@ -35,9 +35,8 @@ module RuboCop
         SUPERCLASS = 'ApplicationRecord'
         BASE_PATTERN = '(const (const {nil? cbase} :ActiveRecord) :Base)'
 
-        # rubocop:disable Layout/ClassStructure
+        # rubocop:disable-next Layout/ClassStructure
         include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
       end
     end
   end

data/lib/rubocop/cop/rails/attribute_default_block_value.rb

@@ -29,6 +29,11 @@ module RuboCop
       #     attribute :roles, :string, array: true, default: -> { [] }
       #   end
       #
+      #   # good
+      #   class User < ApplicationRecord
+      #     attribute :roles, :string, array: true, default: [].freeze
+      #   end
+      #
       #   # bad
       #   class User < ApplicationRecord
       #     attribute :configuration, default: {}
@@ -71,10 +76,14 @@ module RuboCop
         PATTERN
 
         def_node_matcher :attribute, '(pair (sym :default) $_)'
+        def_node_matcher :frozen_literal_default?, <<~PATTERN
+          (send {(array) (hash)} :freeze)
+        PATTERN
 
         def on_send(node)
           default_attribute(node) do |attribute|
             value = attribute.children.last
+            return if frozen_literal_default?(value)
             return unless TYPE_OFFENDERS.any?(value.type)
 
             add_offense(value) do |corrector|

data/lib/rubocop/cop/rails/dangerous_column_names.rb

@@ -34,7 +34,7 @@ module RuboCop
         ].to_set.freeze
 
         # Generated from `ActiveRecord::AttributeMethods.dangerous_attribute_methods` on activerecord 7.1.3.
-        # rubocop:disable Metrics/CollectionLiteralLength
+        # rubocop:disable-next Metrics/CollectionLiteralLength
         DANGEROUS_COLUMN_NAMES = %w[
           __callbacks
           __id__
@@ -406,7 +406,6 @@ module RuboCop
           write_attribute
           write_store_attribute
         ].freeze
-        # rubocop:enable Metrics/CollectionLiteralLength
 
         MSG = 'Avoid dangerous column names.'
 

data/lib/rubocop/cop/rails/http_positional_arguments.rb

@@ -51,6 +51,10 @@ module RuboCop
                 (const {nil? cbase} :Rack) :Test) :Methods))
         PATTERN
 
+        def on_new_investigation
+          @use_rack_test_methods = nil
+        end
+
         def on_send(node)
           return if in_routing_block?(node) || use_rack_test_methods?
 
@@ -81,13 +85,16 @@ module RuboCop
           !!node.each_ancestor(:block).detect { |block| ROUTING_METHODS.include?(block.method_name) }
         end
 
+        # The result is the same for every node in a file, so scan the AST only once.
         def use_rack_test_methods?
-          processed_source.ast.each_descendant(:send).any? do |node|
+          return @use_rack_test_methods unless @use_rack_test_methods.nil?
+
+          @use_rack_test_methods = processed_source.ast.each_descendant(:send).any? do |node|
             include_rack_test_methods?(node)
           end
         end
 
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def needs_conversion?(data)
           return false if data.forwarded_args_type? || forwarded_kwrestarg?(data)
           return true unless data.hash_type?
@@ -97,7 +104,6 @@ module RuboCop
             special_keyword_arg?(pair.key) || (format_arg?(pair.key) && data.pairs.one?)
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
 
         def special_keyword_arg?(node)
           node.sym_type? && KEYWORD_ARGS.include?(node.value)

data/lib/rubocop/cop/rails/inverse_of.rb

@@ -178,7 +178,7 @@ module RuboCop
           (pair (sym :inverse_of) nil)
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_send(node)
           recv, arguments = association_recv_arguments(node)
           return unless arguments
@@ -197,7 +197,6 @@ module RuboCop
 
           add_offense(node.loc.selector, message: message(options))
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
         def scope?(arguments)
           !ignore_scopes? && arguments.any?(&:block_type?)

data/lib/rubocop/cop/rails/output.rb

@@ -38,7 +38,7 @@ module RuboCop
             ...)
         PATTERN
 
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def on_send(node)
           return if node.parent&.call_type? || node.block_node
           return if !output?(node) && !io_output?(node)
@@ -50,7 +50,6 @@ module RuboCop
             corrector.replace(range, 'Rails.logger.debug')
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
 
         private
 

data/lib/rubocop/cop/rails/pluck.rb

@@ -62,7 +62,7 @@ module RuboCop
           (any_block (call _ {:map :collect}) $_argument (send lvar :[] $_key))
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_block(node)
           return if node.each_ancestor(:any_block).first&.receiver
 
@@ -82,7 +82,6 @@ module RuboCop
             register_offense(node, key)
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         alias on_numblock on_block
         alias on_itblock on_block
 

data/lib/rubocop/cop/rails/redirect_back_or_to.rb

@@ -47,7 +47,7 @@ module RuboCop
 
         private
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def correct_redirect_back(corrector, node, fallback_pair, fallback_value, options)
           corrector.replace(node.loc.selector, 'redirect_back_or_to')
 
@@ -64,7 +64,6 @@ module RuboCop
 
           wrap_with_parentheses(node, corrector) unless node.parenthesized?
         end
-        # rubocop:enable Metrics/AbcSize
 
         def remove_fallback_location_pair(corrector, hash_node, fallback_pair)
           pairs = hash_node.pairs

data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb

@@ -95,7 +95,7 @@ module RuboCop
           corrector.remove(block_argument_range(send_node)) if node.block_type?
         end
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def redundant_receiver?(send_nodes, node)
           proc = if node.numblock_type?
                    ->(n) { n.receiver.lvar_type? && n.receiver.source == '_1' }
@@ -110,7 +110,6 @@ module RuboCop
 
           send_nodes.all?(&proc)
         end
-        # rubocop:enable Metrics/AbcSize
 
         def block_argument_range(node)
           block_node = node.each_ancestor(:block).first

data/lib/rubocop/cop/rails/save_bang.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/ClassLength
+# rubocop:disable-next Metrics/ClassLength
 module RuboCop
   module Cop
     module Rails
@@ -152,7 +152,7 @@ module RuboCop
           register_offense(node, CREATE_MSG)
         end
 
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def on_send(node)
           return unless persist_method?(node)
           return if return_value_assigned?(node)
@@ -164,7 +164,6 @@ module RuboCop
 
           register_offense(node, MSG)
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
         alias on_csend on_send
 
         private
@@ -356,4 +355,3 @@ module RuboCop
     end
   end
 end
-# rubocop:enable Metrics/ClassLength

data/lib/rubocop/cop/rails/select_map.rb

@@ -58,7 +58,7 @@ module RuboCop
           receiver_chain?(node, select_node) ? select_node : nil
         end
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def autocorrect(corrector, select_node, node, preferred_method)
           if (parent = select_node.parent).loc?(:dot)
             corrector.remove(parent.loc.dot)
@@ -68,7 +68,6 @@ module RuboCop
             corrector.replace(node, "#{select_node.receiver.source}.#{preferred_method}")
           end
         end
-        # rubocop:enable Metrics/AbcSize
 
         def match_column_name?(select_candidate, column_name)
           return false unless select_candidate.arguments.one?

data/lib/rubocop/cop/rails/strong_parameters_expect.rb

@@ -109,7 +109,7 @@ module RuboCop
                  :require  _require_param_name)
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        # rubocop:disable-next Metrics/AbcSize, Metrics/MethodLength
         def on_send(node)
           return if part_of_ignored_node?(node)
 
@@ -141,7 +141,6 @@ module RuboCop
 
           ignore_node(node)
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
         alias on_csend on_send
 
         private
@@ -157,7 +156,7 @@ module RuboCop
           end
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def offensive_bracket_access?(node)
           return false unless (parent = node.parent)
           return false if parent.or_type?
@@ -174,7 +173,6 @@ module RuboCop
             raising_finder_method?(parent)
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
         def raising_finder_method?(node)
           RAISING_FINDER_METHODS.include?(node.method_name)

data/lib/rubocop/cop/rails/where_equals.rb

@@ -74,7 +74,7 @@ module RuboCop
           range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
         def extract_column_and_value(template_node, value_node)
           value =
             case template_node.value
@@ -96,7 +96,6 @@ module RuboCop
 
           [column_qualifier, value]
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
 
         def build_good_method(method_name, column, value)
           if column.include?('.')

data/lib/rubocop/cop/rails/where_missing.rb

@@ -89,7 +89,7 @@ module RuboCop
           end
         end
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def remove_where_method(corrector, node, where_node)
           range = range_between(where_node.loc.selector.begin_pos, where_node.loc.end.end_pos)
           if node.multiline? && !same_line?(node, where_node)
@@ -102,7 +102,6 @@ module RuboCop
 
           corrector.remove(range)
         end
-        # rubocop:enable Metrics/AbcSize
 
         def same_line?(left_joins_node, where_node)
           left_joins_node.loc.selector.line == where_node.loc.selector.line

data/lib/rubocop/cop/rails/where_not.rb

@@ -68,7 +68,7 @@ module RuboCop
           range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
         def extract_column_and_value(template_node, value_node)
           value =
             case template_node.value
@@ -90,7 +90,6 @@ module RuboCop
 
           [column_qualifier, value]
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
 
         def build_good_method(dot, column, value)
           dot ||= '.'

data/lib/rubocop/cop/rails/where_range.rb

@@ -92,7 +92,7 @@ module RuboCop
           receiver&.send_type? && receiver.method?(:where)
         end
 
-        # rubocop:disable Metrics
+        # rubocop:disable-next Metrics
         def extract_column_and_value(template_node, values_node)
           case template_node.value
           when GTEQ_ANONYMOUS_RE
@@ -157,7 +157,6 @@ module RuboCop
 
           [column_qualifier, "#{lhs_source}#{operator}#{rhs_source}"] if operator
         end
-        # rubocop:enable Metrics
 
         def range_operator(comparison_operator)
           comparison_operator == '<' ? '...' : '..'

data/lib/rubocop/cop/rails.rb

@@ -0,0 +1,152 @@
+# frozen_string_literal: true
+
+require_relative 'mixin'
+
+module RuboCop
+  module Cop
+    # Cops for the `Rails` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Rails
+      extend LazyLoader
+
+      register_cop :ActionControllerFlashBeforeRender, "#{__dir__}/rails/action_controller_flash_before_render"
+      register_cop :StrongParametersExpect, "#{__dir__}/rails/strong_parameters_expect"
+      register_cop :ActionControllerTestCase, "#{__dir__}/rails/action_controller_test_case"
+      register_cop :ActionFilter, "#{__dir__}/rails/action_filter"
+      register_cop :ActionOrder, "#{__dir__}/rails/action_order"
+      register_cop :ActiveRecordAliases, "#{__dir__}/rails/active_record_aliases"
+      register_cop :ActiveRecordCallbacksOrder, "#{__dir__}/rails/active_record_callbacks_order"
+      register_cop :ActiveRecordOverride, "#{__dir__}/rails/active_record_override"
+      register_cop :ActiveSupportAliases, "#{__dir__}/rails/active_support_aliases"
+      register_cop :ActiveSupportOnLoad, "#{__dir__}/rails/active_support_on_load"
+      register_cop :AddColumnIndex, "#{__dir__}/rails/add_column_index"
+      register_cop :AfterCommitOverride, "#{__dir__}/rails/after_commit_override"
+      register_cop :ApplicationController, "#{__dir__}/rails/application_controller"
+      register_cop :ApplicationJob, "#{__dir__}/rails/application_job"
+      register_cop :ApplicationMailer, "#{__dir__}/rails/application_mailer"
+      register_cop :ApplicationRecord, "#{__dir__}/rails/application_record"
+      register_cop :ArelStar, "#{__dir__}/rails/arel_star"
+      register_cop :AssertNot, "#{__dir__}/rails/assert_not"
+      register_cop :AttributeDefaultBlockValue, "#{__dir__}/rails/attribute_default_block_value"
+      register_cop :BelongsTo, "#{__dir__}/rails/belongs_to"
+      register_cop :Blank, "#{__dir__}/rails/blank"
+      register_cop :BulkChangeTable, "#{__dir__}/rails/bulk_change_table"
+      register_cop :CompactBlank, "#{__dir__}/rails/compact_blank"
+      register_cop :ContentTag, "#{__dir__}/rails/content_tag"
+      register_cop :CreateTableWithTimestamps, "#{__dir__}/rails/create_table_with_timestamps"
+      register_cop :DangerousColumnNames, "#{__dir__}/rails/dangerous_column_names"
+      register_cop :Date, "#{__dir__}/rails/date"
+      register_cop :DefaultScope, "#{__dir__}/rails/default_scope"
+      register_cop :Delegate, "#{__dir__}/rails/delegate"
+      register_cop :DelegateAllowBlank, "#{__dir__}/rails/delegate_allow_blank"
+      register_cop :DeprecatedActiveModelErrorsMethods, "#{__dir__}/rails/deprecated_active_model_errors_methods"
+      register_cop :DotSeparatedKeys, "#{__dir__}/rails/dot_separated_keys"
+      register_cop :DuplicateAssociation, "#{__dir__}/rails/duplicate_association"
+      register_cop :DuplicateScope, "#{__dir__}/rails/duplicate_scope"
+      register_cop :DurationArithmetic, "#{__dir__}/rails/duration_arithmetic"
+      register_cop :DynamicFindBy, "#{__dir__}/rails/dynamic_find_by"
+      register_cop :EagerEvaluationLogMessage, "#{__dir__}/rails/eager_evaluation_log_message"
+      register_cop :EnumHash, "#{__dir__}/rails/enum_hash"
+      register_cop :EnumSyntax, "#{__dir__}/rails/enum_syntax"
+      register_cop :EnumUniqueness, "#{__dir__}/rails/enum_uniqueness"
+      register_cop :Env, "#{__dir__}/rails/env"
+      register_cop :EnvLocal, "#{__dir__}/rails/env_local"
+      register_cop :EnvironmentComparison, "#{__dir__}/rails/environment_comparison"
+      register_cop :EnvironmentVariableAccess, "#{__dir__}/rails/environment_variable_access"
+      register_cop :Exit, "#{__dir__}/rails/exit"
+      register_cop :ExpandedDateRange, "#{__dir__}/rails/expanded_date_range"
+      register_cop :FilePath, "#{__dir__}/rails/file_path"
+      register_cop :FindBy, "#{__dir__}/rails/find_by"
+      register_cop :FindById, "#{__dir__}/rails/find_by_id"
+      register_cop :FindByOrAssignmentMemoization, "#{__dir__}/rails/find_by_or_assignment_memoization"
+      register_cop :FindEach, "#{__dir__}/rails/find_each"
+      register_cop :FreezeTime, "#{__dir__}/rails/freeze_time"
+      register_cop :HasAndBelongsToMany, "#{__dir__}/rails/has_and_belongs_to_many"
+      register_cop :HasManyOrHasOneDependent, "#{__dir__}/rails/has_many_or_has_one_dependent"
+      register_cop :HelperInstanceVariable, "#{__dir__}/rails/helper_instance_variable"
+      register_cop :HttpPositionalArguments, "#{__dir__}/rails/http_positional_arguments"
+      register_cop :HttpStatus, "#{__dir__}/rails/http_status"
+      register_cop :HttpStatusNameConsistency, "#{__dir__}/rails/http_status_name_consistency"
+      register_cop :I18nLazyLookup, "#{__dir__}/rails/i18n_lazy_lookup"
+      register_cop :I18nLocaleAssignment, "#{__dir__}/rails/i18n_locale_assignment"
+      register_cop :I18nLocaleTexts, "#{__dir__}/rails/i18n_locale_texts"
+      register_cop :IgnoredColumnsAssignment, "#{__dir__}/rails/ignored_columns_assignment"
+      register_cop :IgnoredSkipActionFilterOption, "#{__dir__}/rails/ignored_skip_action_filter_option"
+      register_cop :IndexBy, "#{__dir__}/rails/index_by"
+      register_cop :IndexWith, "#{__dir__}/rails/index_with"
+      register_cop :Inquiry, "#{__dir__}/rails/inquiry"
+      register_cop :InverseOf, "#{__dir__}/rails/inverse_of"
+      register_cop :LexicallyScopedActionFilter, "#{__dir__}/rails/lexically_scoped_action_filter"
+      register_cop :LinkToBlank, "#{__dir__}/rails/link_to_blank"
+      register_cop :MailerName, "#{__dir__}/rails/mailer_name"
+      register_cop :MatchRoute, "#{__dir__}/rails/match_route"
+      register_cop :MigrationClassName, "#{__dir__}/rails/migration_class_name"
+      register_cop :MultipleRoutePaths, "#{__dir__}/rails/multiple_route_paths"
+      register_cop :NegateInclude, "#{__dir__}/rails/negate_include"
+      register_cop :NotNullColumn, "#{__dir__}/rails/not_null_column"
+      register_cop :OrderArguments, "#{__dir__}/rails/order_arguments"
+      register_cop :OrderById, "#{__dir__}/rails/order_by_id"
+      register_cop :Output, "#{__dir__}/rails/output"
+      register_cop :OutputSafety, "#{__dir__}/rails/output_safety"
+      register_cop :Pick, "#{__dir__}/rails/pick"
+      register_cop :Pluck, "#{__dir__}/rails/pluck"
+      register_cop :PluckId, "#{__dir__}/rails/pluck_id"
+      register_cop :PluckInWhere, "#{__dir__}/rails/pluck_in_where"
+      register_cop :PluralizationGrammar, "#{__dir__}/rails/pluralization_grammar"
+      register_cop :Presence, "#{__dir__}/rails/presence"
+      register_cop :Present, "#{__dir__}/rails/present"
+      register_cop :RakeEnvironment, "#{__dir__}/rails/rake_environment"
+      register_cop :ReadWriteAttribute, "#{__dir__}/rails/read_write_attribute"
+      register_cop :RedundantActiveRecordAllMethod, "#{__dir__}/rails/redundant_active_record_all_method"
+      register_cop :RedundantAllowNil, "#{__dir__}/rails/redundant_allow_nil"
+      register_cop :RedundantForeignKey, "#{__dir__}/rails/redundant_foreign_key"
+      register_cop :RedundantPresenceValidationOnBelongsTo, "#{__dir__}/rails/redundant_presence_validation_on_belongs_to"
+      register_cop :RedundantReceiverInWithOptions, "#{__dir__}/rails/redundant_receiver_in_with_options"
+      register_cop :RedundantTravelBack, "#{__dir__}/rails/redundant_travel_back"
+      register_cop :RedirectBackOrTo, "#{__dir__}/rails/redirect_back_or_to"
+      register_cop :ReflectionClassName, "#{__dir__}/rails/reflection_class_name"
+      register_cop :RefuteMethods, "#{__dir__}/rails/refute_methods"
+      register_cop :RelativeDateConstant, "#{__dir__}/rails/relative_date_constant"
+      register_cop :RenderInline, "#{__dir__}/rails/render_inline"
+      register_cop :RenderPlainText, "#{__dir__}/rails/render_plain_text"
+      register_cop :RequestReferer, "#{__dir__}/rails/request_referer"
+      register_cop :RequireDependency, "#{__dir__}/rails/require_dependency"
+      register_cop :ResponseParsedBody, "#{__dir__}/rails/response_parsed_body"
+      register_cop :ReversibleMigration, "#{__dir__}/rails/reversible_migration"
+      register_cop :ReversibleMigrationMethodDefinition, "#{__dir__}/rails/reversible_migration_method_definition"
+      register_cop :RootJoinChain, "#{__dir__}/rails/root_join_chain"
+      register_cop :RootPathnameMethods, "#{__dir__}/rails/root_pathname_methods"
+      register_cop :RootPublicPath, "#{__dir__}/rails/root_public_path"
+      register_cop :SafeNavigation, "#{__dir__}/rails/safe_navigation"
+      register_cop :SafeNavigationWithBlank, "#{__dir__}/rails/safe_navigation_with_blank"
+      register_cop :SaveBang, "#{__dir__}/rails/save_bang"
+      register_cop :SchemaComment, "#{__dir__}/rails/schema_comment"
+      register_cop :ScopeArgs, "#{__dir__}/rails/scope_args"
+      register_cop :SelectMap, "#{__dir__}/rails/select_map"
+      register_cop :ShortI18n, "#{__dir__}/rails/short_i18n"
+      register_cop :SkipsModelValidations, "#{__dir__}/rails/skips_model_validations"
+      register_cop :SquishedSQLHeredocs, "#{__dir__}/rails/squished_sql_heredocs"
+      register_cop :StripHeredoc, "#{__dir__}/rails/strip_heredoc"
+      register_cop :TableNameAssignment, "#{__dir__}/rails/table_name_assignment"
+      register_cop :ThreeStateBooleanColumn, "#{__dir__}/rails/three_state_boolean_column"
+      register_cop :TimeZone, "#{__dir__}/rails/time_zone"
+      register_cop :TimeZoneAssignment, "#{__dir__}/rails/time_zone_assignment"
+      register_cop :ToFormattedS, "#{__dir__}/rails/to_formatted_s"
+      register_cop :ToSWithArgument, "#{__dir__}/rails/to_s_with_argument"
+      register_cop :TopLevelHashWithIndifferentAccess, "#{__dir__}/rails/top_level_hash_with_indifferent_access"
+      register_cop :TransactionExitStatement, "#{__dir__}/rails/transaction_exit_statement"
+      register_cop :UniqBeforePluck, "#{__dir__}/rails/uniq_before_pluck"
+      register_cop :UniqueValidationWithoutIndex, "#{__dir__}/rails/unique_validation_without_index"
+      register_cop :UnknownEnv, "#{__dir__}/rails/unknown_env"
+      register_cop :UnusedIgnoredColumns, "#{__dir__}/rails/unused_ignored_columns"
+      register_cop :UnusedRenderContent, "#{__dir__}/rails/unused_render_content"
+      register_cop :Validation, "#{__dir__}/rails/validation"
+      register_cop :WhereEquals, "#{__dir__}/rails/where_equals"
+      register_cop :WhereExists, "#{__dir__}/rails/where_exists"
+      register_cop :WhereMissing, "#{__dir__}/rails/where_missing"
+      register_cop :WhereNot, "#{__dir__}/rails/where_not"
+      register_cop :WhereNotWithMultipleConditions, "#{__dir__}/rails/where_not_with_multiple_conditions"
+      register_cop :WhereRange, "#{__dir__}/rails/where_range"
+    end
+  end
+end

data/lib/rubocop/cop/rails_cops.rb

@@ -1,150 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'mixin/active_record_helper'
-require_relative 'mixin/active_record_migrations_helper'
-require_relative 'mixin/class_send_node_helper'
-require_relative 'mixin/database_type_resolvable'
-require_relative 'mixin/enforce_superclass'
-require_relative 'mixin/index_method'
-require_relative 'mixin/migrations_helper'
-require_relative 'mixin/routes_helper'
-require_relative 'mixin/target_rails_version'
-
-require_relative 'rails/action_controller_flash_before_render'
-require_relative 'rails/strong_parameters_expect'
-require_relative 'rails/action_controller_test_case'
-require_relative 'rails/action_filter'
-require_relative 'rails/action_order'
-require_relative 'rails/active_record_aliases'
-require_relative 'rails/active_record_callbacks_order'
-require_relative 'rails/active_record_override'
-require_relative 'rails/active_support_aliases'
-require_relative 'rails/active_support_on_load'
-require_relative 'rails/add_column_index'
-require_relative 'rails/after_commit_override'
-require_relative 'rails/application_controller'
-require_relative 'rails/application_job'
-require_relative 'rails/application_mailer'
-require_relative 'rails/application_record'
-require_relative 'rails/arel_star'
-require_relative 'rails/assert_not'
-require_relative 'rails/attribute_default_block_value'
-require_relative 'rails/belongs_to'
-require_relative 'rails/blank'
-require_relative 'rails/bulk_change_table'
-require_relative 'rails/compact_blank'
-require_relative 'rails/content_tag'
-require_relative 'rails/create_table_with_timestamps'
-require_relative 'rails/dangerous_column_names'
-require_relative 'rails/date'
-require_relative 'rails/default_scope'
-require_relative 'rails/delegate'
-require_relative 'rails/delegate_allow_blank'
-require_relative 'rails/deprecated_active_model_errors_methods'
-require_relative 'rails/dot_separated_keys'
-require_relative 'rails/duplicate_association'
-require_relative 'rails/duplicate_scope'
-require_relative 'rails/duration_arithmetic'
-require_relative 'rails/dynamic_find_by'
-require_relative 'rails/eager_evaluation_log_message'
-require_relative 'rails/enum_hash'
-require_relative 'rails/enum_syntax'
-require_relative 'rails/enum_uniqueness'
-require_relative 'rails/env'
-require_relative 'rails/env_local'
-require_relative 'rails/environment_comparison'
-require_relative 'rails/environment_variable_access'
-require_relative 'rails/exit'
-require_relative 'rails/expanded_date_range'
-require_relative 'rails/file_path'
-require_relative 'rails/find_by'
-require_relative 'rails/find_by_id'
-require_relative 'rails/find_by_or_assignment_memoization'
-require_relative 'rails/find_each'
-require_relative 'rails/freeze_time'
-require_relative 'rails/has_and_belongs_to_many'
-require_relative 'rails/has_many_or_has_one_dependent'
-require_relative 'rails/helper_instance_variable'
-require_relative 'rails/http_positional_arguments'
-require_relative 'rails/http_status'
-require_relative 'rails/http_status_name_consistency'
-require_relative 'rails/i18n_lazy_lookup'
-require_relative 'rails/i18n_locale_assignment'
-require_relative 'rails/i18n_locale_texts'
-require_relative 'rails/ignored_columns_assignment'
-require_relative 'rails/ignored_skip_action_filter_option'
-require_relative 'rails/index_by'
-require_relative 'rails/index_with'
-require_relative 'rails/inquiry'
-require_relative 'rails/inverse_of'
-require_relative 'rails/lexically_scoped_action_filter'
-require_relative 'rails/link_to_blank'
-require_relative 'rails/mailer_name'
-require_relative 'rails/match_route'
-require_relative 'rails/migration_class_name'
-require_relative 'rails/multiple_route_paths'
-require_relative 'rails/negate_include'
-require_relative 'rails/not_null_column'
-require_relative 'rails/order_arguments'
-require_relative 'rails/order_by_id'
-require_relative 'rails/output'
-require_relative 'rails/output_safety'
-require_relative 'rails/pick'
-require_relative 'rails/pluck'
-require_relative 'rails/pluck_id'
-require_relative 'rails/pluck_in_where'
-require_relative 'rails/pluralization_grammar'
-require_relative 'rails/presence'
-require_relative 'rails/present'
-require_relative 'rails/rake_environment'
-require_relative 'rails/read_write_attribute'
-require_relative 'rails/redundant_active_record_all_method'
-require_relative 'rails/redundant_allow_nil'
-require_relative 'rails/redundant_foreign_key'
-require_relative 'rails/redundant_presence_validation_on_belongs_to'
-require_relative 'rails/redundant_receiver_in_with_options'
-require_relative 'rails/redundant_travel_back'
-require_relative 'rails/redirect_back_or_to'
-require_relative 'rails/reflection_class_name'
-require_relative 'rails/refute_methods'
-require_relative 'rails/relative_date_constant'
-require_relative 'rails/render_inline'
-require_relative 'rails/render_plain_text'
-require_relative 'rails/request_referer'
-require_relative 'rails/require_dependency'
-require_relative 'rails/response_parsed_body'
-require_relative 'rails/reversible_migration'
-require_relative 'rails/reversible_migration_method_definition'
-require_relative 'rails/root_join_chain'
-require_relative 'rails/root_pathname_methods'
-require_relative 'rails/root_public_path'
-require_relative 'rails/safe_navigation'
-require_relative 'rails/safe_navigation_with_blank'
-require_relative 'rails/save_bang'
-require_relative 'rails/schema_comment'
-require_relative 'rails/scope_args'
-require_relative 'rails/select_map'
-require_relative 'rails/short_i18n'
-require_relative 'rails/skips_model_validations'
-require_relative 'rails/squished_sql_heredocs'
-require_relative 'rails/strip_heredoc'
-require_relative 'rails/table_name_assignment'
-require_relative 'rails/three_state_boolean_column'
-require_relative 'rails/time_zone'
-require_relative 'rails/time_zone_assignment'
-require_relative 'rails/to_formatted_s'
-require_relative 'rails/to_s_with_argument'
-require_relative 'rails/top_level_hash_with_indifferent_access'
-require_relative 'rails/transaction_exit_statement'
-require_relative 'rails/uniq_before_pluck'
-require_relative 'rails/unique_validation_without_index'
-require_relative 'rails/unknown_env'
-require_relative 'rails/unused_ignored_columns'
-require_relative 'rails/unused_render_content'
-require_relative 'rails/validation'
-require_relative 'rails/where_equals'
-require_relative 'rails/where_exists'
-require_relative 'rails/where_missing'
-require_relative 'rails/where_not'
-require_relative 'rails/where_not_with_multiple_conditions'
-require_relative 'rails/where_range'
+# @deprecated This file is deprecated. Cops are registered for lazy loading in
+#   `rubocop/cop/rails`; this file is kept for compatibility with code that
+#   requires it directly.
+require_relative 'rails'

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.36.0'
+      STRING = '2.37.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/lib/rubocop-rails.rb

@@ -9,7 +9,7 @@ require_relative 'rubocop/rails/version'
 require_relative 'rubocop/rails/schema_loader'
 require_relative 'rubocop/rails/schema_loader/schema'
 require_relative 'rubocop/rails/plugin'
-require_relative 'rubocop/cop/rails_cops'
+require_relative 'rubocop/cop/rails'
 
 require_relative 'rubocop/rails/migration_file_skippable'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.36.0
+  version: 2.37.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -59,7 +59,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.75.0
+        version: 1.89.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -69,7 +69,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.75.0
+        version: 1.89.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -108,6 +108,7 @@ files:
 - config/default.yml
 - config/obsoletion.yml
 - lib/rubocop-rails.rb
+- lib/rubocop/cop/mixin.rb
 - lib/rubocop/cop/mixin/active_record_helper.rb
 - lib/rubocop/cop/mixin/active_record_migrations_helper.rb
 - lib/rubocop/cop/mixin/class_send_node_helper.rb
@@ -117,6 +118,7 @@ files:
 - lib/rubocop/cop/mixin/migrations_helper.rb
 - lib/rubocop/cop/mixin/routes_helper.rb
 - lib/rubocop/cop/mixin/target_rails_version.rb
+- lib/rubocop/cop/rails.rb
 - lib/rubocop/cop/rails/action_controller_flash_before_render.rb
 - lib/rubocop/cop/rails/action_controller_test_case.rb
 - lib/rubocop/cop/rails/action_filter.rb
@@ -269,7 +271,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-rails/
   changelog_uri: https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-rails/
-  documentation_uri: https://docs.rubocop.org/rubocop-rails/2.36/
+  documentation_uri: https://docs.rubocop.org/rubocop-rails/2.37/
   bug_tracker_uri: https://github.com/rubocop/rubocop-rails/issues
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: RuboCop::Rails::Plugin