rubocop-rails 2.35.0 → 2.35.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4946e79ccf9661248df014d69703665df3b0a72aa800e8c456afc59594ad944
-  data.tar.gz: 7575ea946eb4e6985d6c0c365a0f39345fc6d32b0634c74949526f987d1ac38d
+  metadata.gz: 409bf447cc0d5a3b6529407611f53ad1331a5c1bd908e35b7f50193e53bb2c95
+  data.tar.gz: 5d3b83383d138616bcfbbe292413f6ddd6f49b60be33dbe57fdcd481bb7d1c1c
 SHA512:
-  metadata.gz: 7a660eb16537b1dafe092cb100229fd9f039f8d98b51e1408b9438997176c8fc0fde61494ae462bfa8ea15e65524f5ec99e4d2efac42d0461395da65bfe8cb8b
-  data.tar.gz: ad601bb6b3296dceb196159604975b5e2efecaca5c66f715523368344f8a77e62d93cf8e22c4b3d53ce67d849a34cf9a1f4d184d6b655ecea0f12da23490bb35
+  metadata.gz: ea50f3fad3d83f62ec110dd0a5b32688f92fcd0963d486714e4a71867343316b67842476f67dd64a5c6d7ccde5f43aeca5c1980ec20e96f097703fdf6ad7c15c
+  data.tar.gz: eb75cb4c5b5a21562ff42dd194fea691e2feec9563095a1a1509b3263a41693ce072a075a269e1416c8f150cf201a602e2301ac1d993dc7a237c3bbe19083d04

data/lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -12,7 +12,7 @@ module RuboCop
       # which can affect their behavior.
       #
       # @safety
-      #   This cop is unsafe for autocorrection if the receiver for `all` is not an Active Record object.
+      #   This cop is unsafe because false positives will occur if the receiver is not an Active Record object.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/rails/strong_parameters_expect.rb

@@ -8,7 +8,8 @@ module RuboCop
       # In the following cases, `params[:key]` is treated as a key that is expected to be passed from the HTTP client,
       # and the cop detects it using the `expect` method.
       #
-      # - Method calls on `params[:key]` without comparison methods
+      # - Method calls on `params[:key]` without comparison methods, methods that are safe to call
+      #   on `nil` (such as `to_i`, `to_s`, or `is_a?`), or key-check methods such as `key?`
       # - Passing `params[:key]` as an argument to finder methods that raise on missing records
       # - Strong parameter methods using `require` or `permit`
       #
@@ -54,6 +55,8 @@ module RuboCop
         MSG = 'Use `%<prefer>s` instead.'
         RESTRICT_ON_SEND = %i[[] require permit].freeze
         PRESENCE_CHECK_METHODS = %i[nil? blank? present? presence].freeze
+        NIL_SAFE_METHODS = %i[instance_of? is_a? kind_of? to_a to_f to_h to_i to_s].freeze
+        KEY_CHECK_METHODS = %i[key? has_key? include? member?].freeze
         RAISING_FINDER_METHODS = %i[find find_by! find_sole_by].freeze
 
         minimum_target_rails_version 8.0
@@ -131,9 +134,13 @@ module RuboCop
           return false unless parent.call_type?
 
           if parent.receiver == node
-            return false if parent.comparison_method?
+            return false if parent.comparison_method? || parent.method?(:[])
 
-            !parent.method?(:[]) && !PRESENCE_CHECK_METHODS.include?(parent.method_name)
+            method_name = parent.method_name
+
+            !PRESENCE_CHECK_METHODS.include?(method_name) &&
+              !NIL_SAFE_METHODS.include?(method_name) &&
+              !KEY_CHECK_METHODS.include?(method_name)
           else
             raising_finder_method?(parent)
           end

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.35.0'
+      STRING = '2.35.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.35.0
+  version: 2.35.1
 platform: ruby
 authors:
 - Bozhidar Batsov