rubocop-rails 2.14.2 → 2.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: babf21479a37aa37cba8b6b8401b23ddb6532e14afd679095d456f749aca3ca0
-  data.tar.gz: 11a94f8219a5b9d241d68af1c3ecd69afb0a47ccf988db59d00f48caaf73dfbf
+  metadata.gz: 6e850e3f6c08903dd860f5865cb24cab1037189bbd7418c0db047d36094808d8
+  data.tar.gz: a91a77471ae5e9a4c7a188d5fb958402844ba04c3641f14a6bf82161ea43ebf7
 SHA512:
-  metadata.gz: 02b2646080a54c50c8708cd6feeed501b5aafd7ae77d04e42ed0bf5b8779f43fa778bc3f46daec2c06474ac76f40ae144bf0afed35e5acf996c4b2213df53f89
-  data.tar.gz: 4b29b44608474ead97651327e5c896bfb403eadcc1deffd10730853f303e75682e3ebebed80f8b3b05c1f9f0862441845bea89135d694ecf70ee3d6c776f2a97
+  metadata.gz: 753768200576274520f9f6a8d8ab959436e0b87c44a7b51a6eb20803fee0ec842fb1d0debb4c4fef997e8b51f7caee4198692bb8de3e1603ce16fdadf386692f
+  data.tar.gz: eeabca82a842cea89cb8f3b5fbb54abe83c4d6405112a6493e30aeaa9ebb4df39b67c71a6e43342e77d80b2ca901978d48b77e7a52952254f20545ab9eaaf74a

data/config/default.yml

@@ -60,6 +60,7 @@ Rails/ActionFilter:
     - filter
   Include:
     - app/controllers/**/*.rb
+    - app/mailers/**/*.rb
 
 Rails/ActiveRecordAliases:
   Description: >-
@@ -107,7 +108,7 @@ Rails/AddColumnIndex:
 
 Rails/AfterCommitOverride:
   Description: >-
-                  This cop enforces that there is only one call to `after_commit`
+                  Enforces that there is only one call to `after_commit`
                   (and its aliases - `after_create_commit`, `after_update_commit`,
                   and `after_destroy_commit`) with the same callback name per model.
   Enabled: 'pending'
@@ -271,6 +272,13 @@ Rails/DeprecatedActiveModelErrorsMethods:
   Enabled: pending
   Safe: false
   VersionAdded: '2.14'
+  VersionChanged: '2.15'
+
+Rails/DotSeparatedKeys:
+  Description: 'Enforces the use of dot-separated keys instead of `:scope` options in `I18n` translation methods.'
+  StyleGuide: 'https://rails.rubystyle.guide/#dot-separated-keys'
+  Enabled: pending
+  VersionAdded: '2.15'
 
 Rails/DuplicateAssociation:
   Description: "Don't repeat associations in a model."
@@ -476,6 +484,7 @@ Rails/IgnoredSkipActionFilterOption:
   VersionAdded: '0.63'
   Include:
     - app/controllers/**/*.rb
+    - app/mailers/**/*.rb
 
 Rails/IndexBy:
   Description: 'Prefer `index_by` over `each_with_object`, `to_h`, or `map`.'
@@ -504,13 +513,14 @@ Rails/InverseOf:
     - app/models/**/*.rb
 
 Rails/LexicallyScopedActionFilter:
-  Description: "Checks that methods specified in the filter's `only` or `except` options are explicitly defined in the controller."
+  Description: "Checks that methods specified in the filter's `only` or `except` options are explicitly defined in the class."
   StyleGuide: 'https://rails.rubystyle.guide#lexically-scoped-action-filter'
   Enabled: true
   Safe: false
   VersionAdded: '0.52'
   Include:
     - app/controllers/**/*.rb
+    - app/mailers/**/*.rb
 
 Rails/LinkToBlank:
   Description: 'Checks that `link_to` with a `target: "_blank"` have a `rel: "noopener"` option passed to them.'
@@ -690,7 +700,7 @@ Rails/RedundantReceiverInWithOptions:
   VersionAdded: '0.52'
 
 Rails/RedundantTravelBack:
-  Description: This cop checks for redundant `travel_back` calls.
+  Description: Checks for redundant `travel_back` calls.
   Enabled: pending
   VersionAdded: '2.12'
   Include:
@@ -774,6 +784,11 @@ Rails/RootJoinChain:
   Enabled: pending
   VersionAdded: '2.13'
 
+Rails/RootPublicPath:
+  Description: "Favor `Rails.public_path` over `Rails.root` with `'public'`."
+  Enabled: pending
+  VersionAdded: '2.15'
+
 Rails/SafeNavigation:
   Description: "Use Ruby's safe navigation operator (`&.`) instead of `try!`."
   Enabled: true
@@ -808,7 +823,7 @@ Rails/SaveBang:
 
 Rails/SchemaComment:
   Description: >-
-    This cop enforces the use of the `comment` option when adding a new table or column
+    Enforces the use of the `comment` option when adding a new table or column
     to the database during a migration.
   Enabled: false
   VersionAdded: '2.13'
@@ -867,9 +882,15 @@ Rails/SquishedSQLHeredocs:
   VersionAdded: '2.8'
   VersionChanged: '2.9'
   # Some SQL syntax (e.g. PostgreSQL comments and functions) requires newlines
-  # to be preserved in order to work, thus auto-correction is not safe.
+  # to be preserved in order to work, thus autocorrection is not safe.
   SafeAutoCorrect: false
 
+Rails/StripHeredoc:
+  Description: 'Enforces the use of squiggly heredoc over `strip_heredoc`.'
+  StyleGuide: 'https://rails.rubystyle.guide/#prefer-squiggly-heredoc'
+  Enabled: pending
+  VersionAdded: '2.15'
+
 Rails/TableNameAssignment:
   Description: >-
     Do not use `self.table_name =`. Use Inflections or `table_name_prefix` instead.
@@ -905,6 +926,16 @@ Rails/TimeZoneAssignment:
     - spec/**/*.rb
     - test/**/*.rb
 
+Rails/ToFormattedS:
+  Description: 'Checks for consistent uses of `to_fs` or `to_formatted_s`.'
+  StyleGuide: 'https://rails.rubystyle.guide/#prefer-to-fs'
+  Enabled: pending
+  EnforcedStyle: to_fs
+  SupportedStyles:
+    - to_fs
+    - to_formatted_s
+  VersionAdded: '2.15'
+
 Rails/TransactionExitStatement:
   Description: 'Avoid the usage of `return`, `break` and `throw` in transaction blocks.'
   Enabled: pending

data/lib/rubocop/cop/rails/action_filter.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop enforces the consistent use of action filter methods.
+      # Enforces the consistent use of action filter methods.
       #
       # The cop is configurable and can enforce the use of the older
       # something_filter methods or the newer something_action methods.

data/lib/rubocop/cop/rails/active_record_callbacks_order.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that Active Record callbacks are declared
+      # Checks that Active Record callbacks are declared
       # in the order in which they will be executed.
       #
       # @example

data/lib/rubocop/cop/rails/active_support_aliases.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that ActiveSupport aliases to core ruby methods
+      # Checks that ActiveSupport aliases to core ruby methods
       # are not used.
       #
       # @example

data/lib/rubocop/cop/rails/add_column_index.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks for migrations using `add_column` that have an `index`
+      # Checks for migrations using `add_column` that have an `index`
       # key. `add_column` does not accept `index`, but also does not raise an
       # error for extra keys, so it is possible to mistakenly add the key without
       # realizing it will not actually add an index.

data/lib/rubocop/cop/rails/after_commit_override.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop enforces that there is only one call to `after_commit`
+      # Enforces that there is only one call to `after_commit`
       # (and its aliases - `after_create_commit`, `after_update_commit`,
       # and `after_destroy_commit`) with the same callback name per model.
       #

data/lib/rubocop/cop/rails/application_controller.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that controllers subclass `ApplicationController`.
+      # Checks that controllers subclass `ApplicationController`.
       #
       # @safety
       #   This cop's autocorrection is unsafe because it may let the logic from `ApplicationController`

data/lib/rubocop/cop/rails/application_job.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that jobs subclass `ApplicationJob` with Rails 5.0.
+      # Checks that jobs subclass `ApplicationJob` with Rails 5.0.
       #
       # @safety
       #   This cop's autocorrection is unsafe because it may let the logic from `ApplicationJob`

data/lib/rubocop/cop/rails/application_mailer.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that mailers subclass `ApplicationMailer` with Rails 5.0.
+      # Checks that mailers subclass `ApplicationMailer` with Rails 5.0.
       #
       # @safety
       #   This cop's autocorrection is unsafe because it may let the logic from `ApplicationMailer`

data/lib/rubocop/cop/rails/application_record.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that models subclass `ApplicationRecord` with Rails 5.0.
+      # Checks that models subclass `ApplicationRecord` with Rails 5.0.
       #
       # @safety
       #   This cop's autocorrection is unsafe because it may let the logic from `ApplicationRecord`

data/lib/rubocop/cop/rails/arel_star.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop prevents usage of `"*"` on an Arel::Table column reference.
+      # Prevents usage of `"*"` on an Arel::Table column reference.
       #
       # Using `arel_table["*"]` causes the outputted string to be a literal
       # quoted asterisk (e.g. <tt>`my_model`.`*`</tt>). This causes the

data/lib/rubocop/cop/rails/attribute_default_block_value.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for `attribute` class methods that specify a `:default` option
+      # Looks for `attribute` class methods that specify a `:default` option
       # which value is an array, string literal or method call without a block.
       # It will accept all other values, such as string, symbol, integer and float literals
       # as well as constants.

data/lib/rubocop/cop/rails/belongs_to.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for belongs_to associations where we control whether the
+      # Looks for belongs_to associations where we control whether the
       # association is required via the deprecated `required` option instead.
       #
       # Since Rails 5, belongs_to associations are required by default and this

data/lib/rubocop/cop/rails/blank.rb

@@ -3,17 +3,17 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks for code that can be written with simpler conditionals
+      # Checks for code that can be written with simpler conditionals
       # using `Object#blank?` defined by Active Support.
       #
       # Interaction with `Style/UnlessElse`:
       # The configuration of `NotPresent` will not produce an offense in the
       # context of `unless else` if `Style/UnlessElse` is inabled. This is
-      # to prevent interference between the auto-correction of the two cops.
+      # to prevent interference between the autocorrection of the two cops.
       #
       # @safety
-      #   This cop is unsafe auto-correction, because `' '.empty?` returns false,
-      #   but `' '.blank?` returns true. Therefore, auto-correction is not compatible
+      #   This cop is unsafe autocorrection, because `' '.empty?` returns false,
+      #   but `' '.blank?` returns true. Therefore, autocorrection is not compatible
       #   if the receiver is a non-empty blank string, tab, or newline meta characters.
       #
       # @example NilOrEmpty: true (default)

data/lib/rubocop/cop/rails/bulk_change_table.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This Cop checks whether alter queries are combinable.
+      # Checks whether alter queries are combinable.
       # If combinable queries are detected, it suggests to you
       # to use `change_table` with `bulk: true` instead.
       # This option causes the migration to generate a single

data/lib/rubocop/cop/rails/compact_blank.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   `ActionController::Parameters`.
       #   `Array#compact_blank!`, `Hash#compact_blank!` are equivalent to `delete_if(&:blank?)`.
       #   `ActionController::Parameters#compact_blank!` is equivalent to `reject!(&:blank?)`.
-      #   If the cop makes a mistake, auto-corrected code may get unexpected behavior.
+      #   If the cop makes a mistake, autocorrected code may get unexpected behavior.
       #
       # @example
       #

data/lib/rubocop/cop/rails/content_tag.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks legacy syntax usage of `tag`
+      # Checks legacy syntax usage of `tag`
       #
       # NOTE: Allow `tag` when the first argument is a variable because
       # `tag(name)` is simpler rather than `tag.public_send(name)`.

data/lib/rubocop/cop/rails/create_table_with_timestamps.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks the migration for which timestamps are not included
+      # Checks the migration for which timestamps are not included
       # when creating a new table.
       # In many cases, timestamps are useful information and should be added.
       #

data/lib/rubocop/cop/rails/date.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks for the correct use of Date methods,
+      # Checks for the correct use of Date methods,
       # such as Date.today, Date.current etc.
       #
       # Using `Date.today` is dangerous, because it doesn't know anything about
@@ -22,26 +22,26 @@ module RuboCop
       # And you can set a warning for `to_time` with `AllowToTime: false`.
       # `AllowToTime` is `true` by default to prevent false positive on `DateTime` object.
       #
-      # @example EnforcedStyle: strict
+      # @example EnforcedStyle: flexible (default)
       #   # bad
-      #   Date.current
-      #   Date.yesterday
       #   Date.today
       #
       #   # good
       #   Time.zone.today
       #   Time.zone.today - 1.day
+      #   Date.current
+      #   Date.yesterday
+      #   date.in_time_zone
       #
-      # @example EnforcedStyle: flexible (default)
+      # @example EnforcedStyle: strict
       #   # bad
+      #   Date.current
+      #   Date.yesterday
       #   Date.today
       #
       #   # good
       #   Time.zone.today
       #   Time.zone.today - 1.day
-      #   Date.current
-      #   Date.yesterday
-      #   date.in_time_zone
       #
       # @example AllowToTime: true (default)
       #   # good

data/lib/rubocop/cop/rails/default_scope.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for uses of `default_scope`.
+      # Looks for uses of `default_scope`.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/rails/delegate.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for delegations that could have been created
+      # Looks for delegations that could have been created
       # automatically with the `delegate` method.
       #
       # Safe navigation `&.` is ignored because Rails' `allow_nil`

data/lib/rubocop/cop/rails/delegate_allow_blank.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for delegations that pass :allow_blank as an option
+      # Looks for delegations that pass :allow_blank as an option
       # instead of :allow_nil. :allow_blank is not a valid option to pass
       # to ActiveSupport#delegate.
       #

data/lib/rubocop/cop/rails/deprecated_active_model_errors_methods.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks direct manipulation of ActiveModel#errors as hash.
+      # Checks direct manipulation of ActiveModel#errors as hash.
       # These operations are deprecated in Rails 6.1 and will not work in Rails 7.
       #
       # @safety
@@ -26,8 +26,18 @@ module RuboCop
       #   # good
       #   user.errors.delete(:name)
       #
+      #   # bad
+      #   user.errors.keys.include?(:attr)
+      #
+      #   # good
+      #   user.errors.attribute_names.include?(:attr)
+      #
       class DeprecatedActiveModelErrorsMethods < Base
+        include RangeHelp
+        extend AutoCorrector
+
         MSG = 'Avoid manipulating ActiveModel errors as hash directly.'
+        AUTOCORECTABLE_METHODS = %i[<< clear keys].freeze
 
         MANIPULATIVE_METHODS = Set[
           *%i[
@@ -45,6 +55,7 @@ module RuboCop
           {
             #root_manipulation?
             #root_assignment?
+            #errors_keys?
             #messages_details_manipulation?
             #messages_details_assignment?
           }
@@ -66,6 +77,12 @@ module RuboCop
             ...)
         PATTERN
 
+        def_node_matcher :errors_keys?, <<~PATTERN
+          (send
+            (send #receiver_matcher :errors)
+            :keys)
+        PATTERN
+
         def_node_matcher :messages_details_manipulation?, <<~PATTERN
           (send
             (send
@@ -89,12 +106,49 @@ module RuboCop
 
         def on_send(node)
           any_manipulation?(node) do
-            add_offense(node)
+            add_offense(node) do |corrector|
+              next unless AUTOCORECTABLE_METHODS.include?(node.method_name)
+
+              autocorrect(corrector, node)
+            end
           end
         end
 
         private
 
+        def autocorrect(corrector, node)
+          receiver = node.receiver
+
+          if receiver.receiver.method?(:messages)
+            corrector.remove(receiver.receiver.loc.dot)
+            corrector.remove(receiver.receiver.loc.selector)
+          end
+
+          range = offense_range(node, receiver)
+          replacement = replacement(node, receiver)
+
+          corrector.replace(range, replacement)
+        end
+
+        def offense_range(node, receiver)
+          range_between(receiver.receiver.source_range.end_pos, node.source_range.end_pos)
+        end
+
+        def replacement(node, receiver)
+          return '.errors.attribute_names' if node.method?(:keys)
+
+          key = receiver.first_argument.source
+
+          case node.method_name
+          when :<<
+            value = node.first_argument.source
+
+            ".add(#{key}, #{value})"
+          when :clear
+            ".delete(#{key})"
+          end
+        end
+
         def receiver_matcher(node)
           model_file? ? receiver_matcher_inside_model(node) : receiver_matcher_outside_model(node)
         end

data/lib/rubocop/cop/rails/dot_separated_keys.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rails
+      # Enforces the use of dot-separated locale keys instead of specifying the `:scope` option
+      # with an array or a single symbol in `I18n` translation methods.
+      # Dot-separated notation is easier to read and trace the hierarchy.
+      #
+      # @example
+      #   # bad
+      #   I18n.t :record_invalid, scope: [:activerecord, :errors, :messages]
+      #   I18n.t :title, scope: :invitation
+      #
+      #   # good
+      #   I18n.t 'activerecord.errors.messages.record_invalid'
+      #   I18n.t :record_invalid, scope: 'activerecord.errors.messages'
+      #
+      class DotSeparatedKeys < Base
+        include RangeHelp
+        extend AutoCorrector
+
+        MSG = 'Use the dot-separated keys instead of specifying the `:scope` option.'
+        TRANSLATE_METHODS = %i[translate t].freeze
+
+        def_node_matcher :translate_with_scope?, <<~PATTERN
+          (send {nil? (const nil? :I18n)} {:translate :t} ${sym_type? str_type?}
+            (hash <$(pair (sym :scope) ${array_type? sym_type?}) ...>)
+          )
+        PATTERN
+
+        def on_send(node)
+          return unless TRANSLATE_METHODS.include?(node.method_name)
+
+          translate_with_scope?(node) do |key_node, scope_node|
+            return unless should_convert_scope?(scope_node)
+
+            add_offense(scope_node) do |corrector|
+              # Eat the comma on the left.
+              range = range_with_surrounding_space(range: scope_node.source_range, side: :left)
+              range = range_with_surrounding_comma(range, :left)
+              corrector.remove(range)
+
+              corrector.replace(key_node, new_key(key_node, scope_node))
+            end
+          end
+        end
+
+        private
+
+        def should_convert_scope?(scope_node)
+          scopes(scope_node).all?(&:basic_literal?)
+        end
+
+        def new_key(key_node, scope_node)
+          "'#{scopes(scope_node).map(&:value).join('.')}.#{key_node.value}'"
+        end
+
+        def scopes(scope_node)
+          value = scope_node.value
+
+          if value.array_type?
+            value.values
+          else
+            [value]
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rails/duplicate_association.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for associations that have been defined multiple times in the same file.
+      # Looks for associations that have been defined multiple times in the same file.
       #
       # When an association is defined multiple times on a model, Active Record overrides the
       # previously defined association with the new one. Because of this, this cop's autocorrection
@@ -35,7 +35,7 @@ module RuboCop
           offenses(class_node).each do |name, nodes|
             nodes.each do |node|
               add_offense(node, message: format(MSG, name: name)) do |corrector|
-                next if nodes.last == node
+                next if same_line?(nodes.last, node)
 
                 corrector.remove(range_by_whole_lines(node.source_range, include_final_newline: true))
               end

data/lib/rubocop/cop/rails/duplicate_scope.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks for multiple scopes in a model that have the same `where` clause. This
+      # Checks for multiple scopes in a model that have the same `where` clause. This
       # often means you copy/pasted a scope, updated the name, and forgot to change the condition.
       #
       # @example

data/lib/rubocop/cop/rails/duration_arithmetic.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks if a duration is added to or subtracted from `Time.current`.
+      # Checks if a duration is added to or subtracted from `Time.current`.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/rails/dynamic_find_by.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks dynamic `find_by_*` methods.
+      # Checks dynamic `find_by_*` methods.
       # Use `find_by` instead of dynamic method.
       # See. https://rails.rubystyle.guide#find_by
       #

data/lib/rubocop/cop/rails/eager_evaluation_log_message.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that blocks are used for interpolated strings passed to
+      # Checks that blocks are used for interpolated strings passed to
       # `Rails.logger.debug`.
       #
       # By default, Rails production environments use the `:info` log level.

data/lib/rubocop/cop/rails/enum_hash.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for enums written with array syntax.
+      # Looks for enums written with array syntax.
       #
       # When using array syntax, adding an element in a
       # position other than the last causes all previous

data/lib/rubocop/cop/rails/enum_uniqueness.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for duplicate values in enum declarations.
+      # Looks for duplicate values in enum declarations.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/rails/environment_comparison.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that Rails.env is compared using `.production?`-like
+      # Checks that Rails.env is compared using `.production?`-like
       # methods instead of equality against a string or symbol.
       #
       # @example

data/lib/rubocop/cop/rails/environment_variable_access.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop looks for direct access to environment variables through the
+      # Looks for direct access to environment variables through the
       # `ENV` variable within the application code. This can lead to runtime
       # errors due to misconfiguration that could have been discovered at boot
       # time if the environment variables were loaded as part of initialization