rubocop-rails-accessibility 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9be54c50ab9a31b3bcac4ecd45f4f73ad6861c042034005da32588303622baf4
-  data.tar.gz: c024d057c7ad6339be03b35bfd9153574515d1790c62f82e52e155bc34e18736
+  metadata.gz: 2def62d1c73f8ef14e06d1eaca55ca244d12cd2e924f8a0d7025ade68f0b36a4
+  data.tar.gz: 8b229af38423902ebe468cf0d2a77803dcf0f3df785ffab6e1f43e45a55bc246
 SHA512:
-  metadata.gz: 91dd212f8fab3b256a2eb34015dc9a7b19889cb6ff7403255bf6b60be299120972e44a061b7b478b9ad64bfb683af02abd21a89a594a870e08b82aaa55d849ab
-  data.tar.gz: 59a4b0dfcf465dec709f2fa27528607064c8968987a99365f0aad5f4cb202880e32dbd1b27432a570298357101bd2d2cfdd14b6836a9f5657c992dbd855c87e4
+  metadata.gz: 91d417a156fb4c761264ad623f762a52b2864f0848c38e7ff15d7f467fa26c283d7ab1170fd00b880b177158dfaeafc343264c286a9bcf8cd70c25fd10a19df8
+  data.tar.gz: 38e510e2d4014dc6ccccc71ee97841425e3f55df36b3b673092a0a7101dc5fb019d8b3eb8a4f6692530b933f2ce0d9a6eb99cc679401f573ee017c905521c68e

data/CODEOWNERS

@@ -0,0 +1 @@
+* @github/accessibility-reviewers

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-rails-accessibility (0.1.1)
+    rubocop-rails-accessibility (0.1.2)
       rubocop (>= 1.0.0)
 
 GEM

data/README.md

@@ -28,7 +28,6 @@ Put this into your `.rubocop.yml`.
 inherit_gem:
   rubocop-rails-accessibility:
     - config/default.yml
-    - config/rubocop_rails_accessibility.yml
 ```
 
 ## Testing
@@ -48,13 +47,12 @@ bundle exec rake
 ## The Cops
 
 All cops are located under
-[`lib/rubocop/cop/rubocop_rails_accessibility`](lib/rubocop/cop/rubocop_rails_accessibility), and contain
+[`lib/rubocop/cop/rubocop-rails-accessibility`](lib/rubocop/cop/rubocop-rails-accessibility), and contain
 examples/documentation.
 
 ## Rules
 
 - [RuboCop::Cop::Accessibility::ImageHasAlt](guides/image-has-alt.md)
-- [RuboCop::Cop::Accessibility::LinkHasHref](guides/link-has-href.md)
 - [RuboCop::Cop::Accessibility::NoPositiveTabindex](guides/no-positive-tabindex.md)
 - [RuboCop::Cop::Accessibility::NoRedundantImageAlt](guides/no-redundant-image-alt.md)
 

data/config/default.yml

@@ -7,9 +7,6 @@ AllCops:
 RubocopRailsAccessibility/ImageHasAlt:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/image-has-alt.md
-RubocopRailsAccessibility/LinkHasHref:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/link-has-href.md
 RubocopRailsAccessibility/NoPositiveTabindex:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/no-positive-tabindex.md

data/lib/rubocop/cop/rubocop_rails_accessibility_cops.rb

@@ -6,6 +6,5 @@ require "yaml"
 require_relative "inject"
 require_relative "version"
 require_relative "rubocop-rails-accessibility/image_has_alt"
-require_relative "rubocop-rails-accessibility/link_has_href"
 require_relative "rubocop-rails-accessibility/no_positive_tabindex"
 require_relative "rubocop-rails-accessibility/no_redundant_image_alt"

data/lib/rubocop/cop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubocopRailsAccessibility
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails-accessibility
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - GitHub Accessibility Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-31 00:00:00.000000000 Z
+date: 2022-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -131,6 +131,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- CODEOWNERS
 - CONTRIBUTING.md
 - Gemfile
 - Gemfile.lock
@@ -139,12 +140,10 @@ files:
 - Rakefile
 - config/default.yml
 - guides/image-has-alt.md
-- guides/link-has-href.md
 - guides/no-positive-tabindex.md
 - guides/no-redundant-image-alt.md
 - lib/rubocop/cop/inject.rb
 - lib/rubocop/cop/rubocop-rails-accessibility/image_has_alt.rb
-- lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb
 - lib/rubocop/cop/rubocop-rails-accessibility/no_positive_tabindex.rb
 - lib/rubocop/cop/rubocop-rails-accessibility/no_redundant_image_alt.rb
 - lib/rubocop/cop/rubocop_rails_accessibility_cops.rb

data/guides/link-has-href.md

@@ -1,29 +0,0 @@
-# RubocopRailsAccessibility/LinkHasHref
-
-## Rule Details
-
-Links should go somewhere, you probably want to use a `<button>` instead.
-
-## Resources
-
-- [`<a>`: The Anchor element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a)
-- [Primer: Links](https://primer.style/design/accessibility/links)
-- [HTML Spec: The a element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= link_to 'Go to GitHub' %>
-```
-
-```erb
-<%= link_to 'Go to GitHub', '#' %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= link_to 'Go to GitHub', 'https://github.com/' %>
-```

data/lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module RubocopRailsAccessibility
-      class LinkHasHref < Base
-        MSG = "Links should go somewhere, you probably want to use a `<button>` instead."
-
-        def on_send(node)
-          receiver, method_name, *args = *node
-
-          return unless receiver.nil? && method_name == :link_to
-
-          return unless args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
-
-          add_offense(node.loc.selector)
-        end
-      end
-    end
-  end
-end