rubocop-prompt 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c56a2dd1808a3e8adf174b26793942f80b7bdf5e8e12d7272180fdd714c7e2d1
-  data.tar.gz: 50459b65a2d22032658fb7c81d4f89b3f19ac8ee1040d6b7e807c28785e79cb2
+  metadata.gz: f026b256cf28252627df48e3c2a4bbe671661a6a655d7612cb7608f0f543609b
+  data.tar.gz: '0187b65632f0856d6b62a6e0b4d410737e8f26840c5bca9a5bc7d6692965b268'
 SHA512:
-  metadata.gz: 2c3f7ca5e599e459c10b3b03222982132fa2022d956d1d6372d83f350ffb87889ea76f016384e1cebf527c818759f22f26631d3d3b19be289d9f7787bb7de100
-  data.tar.gz: 4f4bf1e4a4cd476ee9696fe9a03ba1547cf9a5879b4a0a90605ad277eeb8c3b69699799096b23a4f5c4015ecfb99b474ecd5502238334a5acead52f852687c8d
+  metadata.gz: 15f9af32e189230966dba8ba5596f3d7eb1f1619edc5062d9e373fa964dbc14723507fb6c3ad4ce6ac482a36dcb992f1d3b74a112a57b2b779e88e431ad155d3
+  data.tar.gz: 888687654e0ce23cf280fd6262e4eb0489e9d2052f3dd006692826d95a87946beaf35df374a2e1fbd1286f66df1d9e0d1e36634fcb36796320437bf69d16239c

data/CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.1] - 2025-06-06
+
+### Changed
+-  Enhance OpenAI Client Detection and Specification Handling
+
 ## [0.1.0] - 2025-06-06
 
 ### Added

data/README.md

@@ -215,9 +215,10 @@ This cop identifies OpenAI::Client.chat method calls and ensures they include ei
 
 **Key Features:**
 - Detects explicit OpenAI::Client.new.chat calls
+- Detects variable-assigned client calls (e.g., client.chat)
 - Checks for presence of stop: or max_tokens: parameters
 - Helps prevent runaway generation and unexpected token consumption
-- Only analyzes explicit OpenAI::Client calls to avoid false positives
+- Intelligently identifies OpenAI client usage patterns
 
 **Bad:**
 ```ruby
@@ -230,6 +231,18 @@ class ChatService
       }
     )
   end
+
+  # Also bad - variable client without stop controls
+  def chat_completion(user_msg, context)
+    client = OpenAI::Client.new(access_token: ENV["OPENAI_API_KEY"])
+    client.chat(parameters: {
+      model: "gpt-4o-mini",
+      messages: [
+        { role: "system", content: "You are an AI assistant" },
+        { role: "user", content: "#{user_msg}\n\n### 参考資料\n#{context}" }
+      ]
+    })
+  end
 end
 ```
 

data/lib/rubocop/cop/prompt/missing_stop.rb

@@ -82,11 +82,17 @@ module RuboCop
           return false unless receiver
 
           # Case 1: OpenAI::Client.new.chat
-          return openai_client_const?(receiver.receiver) if receiver.type == :send && receiver.method_name == :new
+          if receiver.type == :send && receiver.method_name == :new && openai_client_const?(receiver.receiver)
+            return true
+          end
+
+          # Case 2: Variable/method call that likely contains an OpenAI::Client
+          # Look for patterns like:
+          # - client.chat (where client variable is used)
+          # - method_returning_client.chat
+          # We'll check the surrounding context for OpenAI::Client instantiation
+          return true if openai_client_context?(node)
 
-          # Case 2: For now, we'll be conservative and only check explicit OpenAI::Client calls
-          # to avoid false positives. In the future, this could be enhanced with more
-          # sophisticated type analysis.
           false
         end
 
@@ -104,6 +110,53 @@ module RuboCop
           end
         end
 
+        def openai_client_context?(node)
+          # Check if we're in a context that suggests OpenAI::Client usage
+          # Look for OpenAI::Client.new assignment in the same method or class
+          return true if find_openai_client_assignment(node)
+
+          # Check if the receiver variable name suggests it's an OpenAI client
+          receiver = node.receiver
+          return true if receiver&.type == :lvar && openai_client_variable_name?(receiver.children[0])
+
+          false
+        end
+
+        def find_openai_client_assignment(node)
+          # Traverse up to find the containing method or class
+          current = node
+          while current&.parent
+            current = current.parent
+            break if %i[def defs class module].include?(current.type)
+          end
+
+          return false unless current
+
+          # Search for OpenAI::Client.new assignments in the same scope
+          found_assignment = false
+          current.each_descendant(:lvasgn, :ivasgn, :cvasgn, :gvasgn) do |assignment_node|
+            next unless assignment_node.children[1]
+
+            # Check if the assignment is to OpenAI::Client.new
+            value_node = assignment_node.children[1]
+            next unless value_node.type == :send && value_node.method_name == :new &&
+                        openai_client_const?(value_node.receiver)
+
+            found_assignment = true
+            break
+          end
+
+          found_assignment
+        end
+
+        def openai_client_variable_name?(var_name)
+          # Common variable names that suggest OpenAI client usage
+          client_patterns = %w[client openai_client ai_client llm_client chat_client api_client]
+          var_name_str = var_name.to_s.downcase
+
+          client_patterns.any? { |pattern| var_name_str.include?(pattern) }
+        end
+
         def extract_parameters_hash(node)
           # Look for parameters: { ... } in the method arguments
           node.arguments.each do |arg|

data/lib/rubocop/prompt/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Prompt
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-prompt
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Masumi Kawasaki
@@ -13,16 +13,16 @@ dependencies:
   name: lint_roller
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -111,11 +111,11 @@ homepage: https://github.com/geeknees/rubocop-prompt
 licenses:
 - MIT
 metadata:
+  allowed_push_host: https://rubygems.org
   default_lint_roller_plugin: RuboCop::Prompt::Plugin
   homepage_uri: https://github.com/geeknees/rubocop-prompt
   source_code_uri: https://github.com/geeknees/rubocop-prompt
   changelog_uri: https://github.com/geeknees/rubocop-prompt/blob/main/CHANGELOG.md
-  documentation_uri: https://github.com/geeknees/rubocop-prompt/blob/main/README.md
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths: