rubocop-packs 0.0.33 → 0.0.34

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e56f9a941b630002bfb4af833716b2cc58a3d2a3f21fbb673f86b04cf0eab0eb
-  data.tar.gz: abd74e0ecf25630da93a7ddff425060373787e33c209e0ce850599675ee6b842
+  metadata.gz: aa1524fd9d2f94de215b45b9b2a26bd0984286d21e59c787caf70717d1ebb3ae
+  data.tar.gz: b749545874b549013197564cccce90f58cdafb838b38e9045e1cbcd53f325d97
 SHA512:
-  metadata.gz: c45aa69414bc48fe5e0874defaee69dee2ddfc5372f4683ce9644c70aace411e64c46ef3630513d4e6660868116116ef2dc4d03363865e7f39059ffa5630e007
-  data.tar.gz: 794ffd4ad403ca046bac4b22e21d419207fe9bb49215ef8b56f3b5f3b3ef7ced9e8cbd33c331a7b13f9d8e0aebb986d9c512d14b880af757bb6e52cc0ba8b1b0
+  metadata.gz: 054c01a73226e1cae5bbc96f17f3757156aeeb4980745d46cac49a9661b67e29b4fd802e4b83668ad5468122fe6c351e81b06db90b44ac98c3e3705efe1d7dbb
+  data.tar.gz: df0a6e1355e1d455c03c5fd3b067ca7bb97d14f86bf94829d1909aa6e4d03812ddd743291cd93b35261147f0adc29ebffafa6efc10d4380df8f7301a8fc0aad3

data/lib/rubocop/cop/packs/documented_public_apis.rb

@@ -54,9 +54,14 @@ module RuboCop
           return if non_public?(node) && !require_for_non_public_methods?
 
           left_sibling = node.left_sibling
-          left_sibling_is_sig = left_sibling && (left_sibling.source.include?('sig do') || left_sibling.source.include?('sig {'))
-          # Is there a better way to check if the left sibling is a sorbet signature? Probably!
-          if left_sibling_is_sig
+
+          if left_sibling == :private_class_method
+            if node_is_sorbet_signature?(node.parent.left_sibling)
+              return if documentation_comment?(node.parent.left_sibling)
+            elsif documentation_comment?(node.parent)
+              return
+            end
+          elsif node_is_sorbet_signature?(left_sibling)
             return if documentation_comment?(node.left_sibling)
           elsif documentation_comment?(node)
             return
@@ -64,6 +69,12 @@ module RuboCop
 
           add_offense(node)
         end
+
+        sig { params(node: T.untyped).returns(T::Boolean) }
+        def node_is_sorbet_signature?(node)
+          # Is there a better way to check if a node is a sorbet signature? Probably!
+          !!(node && (node.source.include?('sig do') || node.source.include?('sig {')))
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-packs
 version: !ruby/object:Gem::Version
-  version: 0.0.33
+  version: 0.0.34
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-28 00:00:00.000000000 Z
+date: 2023-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport