rubocop-openproject 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 216a0869e29d95a92306d0d02e2bc340b7914733f86d56c4f27cce5fbcf8e466
-  data.tar.gz: d3ca3bc8f408a56843a5cbd7f8d69a8a1eadc6bda76c5ea8139201181a1e0de8
+  metadata.gz: 9cfe3bab3bbbc3032190c71f7e824eb2d451f854248d076aca30db79723f346b
+  data.tar.gz: b265782c32033cd8315f9a0b3bef3cb4cf7c0bdcf01d3fb85de59559fa9a9935
 SHA512:
-  metadata.gz: 7041d99b3774a92ae145c93bf64ec52628aee9b04ebd08b04a3803c2d662f956404893306d8274762d0b1050c2f6787b135cc15f58d514e0d508bc8673487881
-  data.tar.gz: 989852deeca12ee26502f448d85e660f6539fca125cd5f174650acf2646da07eef463db5aa025c30d46976484730d2bc0cd363d9953af42fb25f688e24fd3541
+  metadata.gz: cde9e717e29db386ab61514b4533f0861956fe2aefe5eeadc9b5baf0c12fb4fa3851f565c0cab2ca9919ed652c27623a45ef1f41ed9c6f2f9bce81fcf2f9aff7
+  data.tar.gz: 690ebd432e8719ba28f5bd2e146304883626dde1cdd8fab45a6dc518cf16401615c3cdab7382c258db7cc166b40baac9e512c915a26a59aafe5fbb0897d74d22

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.4.0] - 2026-03-27
+
+- Add NoNotImplementedError cop
+
 ## [0.3.0] - 2025-07-11
 
 - Remove redundant NoDoEndBlockWithRSpecCapybaraMatcherInExpect cop

data/config/default.yml

@@ -8,6 +8,11 @@ OpenProject/NoDoEndBlockWithRSpecCapybaraMatcherInExpect:
   Enabled: true
   VersionAdded: '0.1.0'
 
+OpenProject/NoNotImplementedError:
+  Description: 'Do not raise `NotImplementedError` to signal an unimplemented abstract method.'
+  Enabled: true
+  VersionAdded: '0.4.0'
+
 OpenProject/NoSleepInFeatureSpecs:
   Description: 'Avoid using `sleep` greater than 1 second in feature specs.'
   Enabled: true

data/lib/rubocop/cop/open_project/no_not_implemented_error.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module OpenProject
+      # Warns against using a `NotImplementedError` exception when a method
+      # should be implemented by a subclass or including module. Ruby's
+      # `NotImplementedError` is reserved for platform-specific missing
+      # features (e.g., methods depending on `fsync` or `fork`), not for
+      # abstract method patterns.
+      #
+      # @example
+      #   # bad
+      #   raise NotImplementedError
+      #
+      #   # bad
+      #   raise NotImplementedError, "Subclasses must implement #foo"
+      #
+      #   # bad
+      #   raise NotImplementedError.new("Subclasses must implement #foo")
+      #
+      #   # bad
+      #   fail NotImplementedError
+      #
+      #   # good
+      #   raise NotYetImplementedError
+      #
+      #   # good
+      #   raise SubclassResponsibilityError, "#{self.class} must implement #foo"
+      #
+      class NoNotImplementedError < Base
+        MSG = "Do not raise `NotImplementedError` to signal an unimplemented abstract method. " \
+              "Ruby's `NotImplementedError` is reserved for platform-specific missing features. " \
+              "Raise a descriptive custom error class instead."
+
+        RESTRICT_ON_SEND = %i[raise fail].freeze
+
+        def_node_matcher :raises_not_implemented_error?, <<~PATTERN
+          {
+            (send nil? {:raise :fail} (const nil? :NotImplementedError) ...)
+            (send nil? {:raise :fail} (send (const nil? :NotImplementedError) :new ...) ...)
+          }
+        PATTERN
+
+        def on_send(node)
+          return unless raises_not_implemented_error?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/open_project_cops.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "open_project/add_preview_for_view_component"
+require_relative "open_project/no_not_implemented_error"
 require_relative "open_project/use_service_result_factory_methods"
 require_relative "open_project/no_sleep_in_feature_specs"

data/lib/rubocop/open_project/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module OpenProject
-    VERSION = "0.3.0"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-openproject
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - OpenProject GmbH
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-07-11 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -40,6 +39,7 @@ files:
 - config/default.yml
 - lib/rubocop-openproject.rb
 - lib/rubocop/cop/open_project/add_preview_for_view_component.rb
+- lib/rubocop/cop/open_project/no_not_implemented_error.rb
 - lib/rubocop/cop/open_project/no_sleep_in_feature_specs.rb
 - lib/rubocop/cop/open_project/use_service_result_factory_methods.rb
 - lib/rubocop/cop/open_project_cops.rb
@@ -54,7 +54,6 @@ metadata:
   source_code_uri: https://github.com/opf/rubocop-openproject
   changelog_uri: https://github.com/opf/rubocop-openproject/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -69,8 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: RuboCop cops for OpenProject
 test_files: []