rubocop-on-rbs 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2d0a08d15b11889f3e9cb30b870ab7f10708d79fc88984271cd0d1d229a6eb2
-  data.tar.gz: c5bbecab5e33bbbddcab3081b1df9c0370948e1c4cbd2fbe9ea1f9bb8e7cf820
+  metadata.gz: b70070f22849df33c71ad69c0f2a08c1a6a2d0523c19f779868dda630787de43
+  data.tar.gz: 43789ae285bc5e4f155ba5641fed3471cf27715e58007c02e26661d853304084
 SHA512:
-  metadata.gz: 8153af6d71ecd6f087d9511de6a3caa2ded02a2edf6a1e51833a212d1a1fee269bfcf8c398b536ce89fedebf91b86784aba445117779101a64efb83e1082ffd8
-  data.tar.gz: aa38d915d25385ae67af7a84d7b480b28fcd23a6e4110e273e5d42571ff1b7bf5daf0116c7803b14297cbbd4a4f4e706836b2b1d6bc770edf8d81104f76aff46
+  metadata.gz: 5a3dece661499c49c0f62c9db11c5a3ee5d0e926d4aedbced0c27b09fda4425eaea161663d22cbf3edf7f37a12fd83e56350b6832f4d90eeac17d027dd5c6f3f
+  data.tar.gz: '0662672318876ae0d61e604c3e5e9d7405000fb5632ece629ee7497ba5d45b9e9c0ebd1b11aa687472a07bf4b1fdde988f803975007841c47b21ed313ee3482c'

data/README.md

@@ -117,15 +117,13 @@ $ bundle exec rubocop --only RBS/Style
 
 ## Installation
 
-TODO: Replace `UPDATE_WITH_YOUR_GEM_NAME_IMMEDIATELY_AFTER_RELEASE_TO_RUBYGEMS_ORG` with your gem name right after releasing it to RubyGems.org. Please do not do it earlier due to security reasons. Alternatively, replace this section with instructions to install your gem from git if you don't plan to release to RubyGems.org.
-
 Install the gem and add to the application's Gemfile by executing:
 
-    $ bundle add UPDATE_WITH_YOUR_GEM_NAME_IMMEDIATELY_AFTER_RELEASE_TO_RUBYGEMS_ORG
+    $ bundle add rubocop-on-rbs --require false
 
 If bundler is not being used to manage dependencies, install the gem by executing:
 
-    $ gem install UPDATE_WITH_YOUR_GEM_NAME_IMMEDIATELY_AFTER_RELEASE_TO_RUBYGEMS_ORG
+    $ gem install rubocop-on-rbs
 
 ## Usage
 

data/config/default.yml

@@ -11,6 +11,10 @@ Lint:
   Exclude:
     - '**/*.rbs'
 
+Style:
+  Exclude:
+    - '**/*.rbs'
+
 # RBS
 
 RBS:
@@ -70,14 +74,25 @@ RBS/Layout/TrailingWhitespace:
 ## RBS/Lint
 
 RBS/Lint:
+  Enabled: true
+
+RBS/Lint/DuplicateOverload:
+  Severity: warning
+  Description: 'Checks that there are no repeated overload bodies'
+  Enabled: true
+
+RBS/Lint/RedundantOverloadTypeParams:
   Severity: warning
+  Description: 'Check redundant overload type params'
   Enabled: true
 
 RBS/Lint/Syntax:
+  Severity: fatal
   Description: 'Check RBS syntax'
   Enabled: true
 
 RBS/Lint/TypeParamsArity:
+  Severity: warning
   Description: 'Check type params arity'
   Enabled: true
   Expects:
@@ -123,11 +138,8 @@ RBS/Lint/TypeParamsArity:
     hash: 2
     range: 1
 
-RBS/Lint/UselessOverloadTypeParams:
-  Description: 'Check useless overload type params'
-  Enabled: true
-
 RBS/Lint/WillSyntaxError:
+  Severity: warning
   Description: 'Check RBS will syntax error'
   Enabled: true
 

data/lib/rubocop/cop/rbs/lint/duplicate_overload.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RBS
+      module Lint
+        # Checks that there are no repeated overload bodies
+        #
+        # @example default
+        #   # bad
+        #   def foo: () -> void
+        #          | () -> void
+        #
+        class DuplicateOverload < RuboCop::RBS::CopBase
+          MSG = 'Duplicate overload body detected.'
+
+          def on_rbs_def(decl)
+            overloads = decl.overloads
+            overloads.each_with_index do |overload, idx|
+              next if idx == overloads.size - 1
+
+              next_overloads = overloads[(idx + 1)..-1]
+              next_overloads.each do |next_overload|
+                next unless overload.method_type == next_overload.method_type
+
+                range = location_to_range(next_overload.method_type.location)
+                add_offense(range)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rbs/lint/{useless_overload_type_params.rb → redundant_overload_type_params.rb}

@@ -11,12 +11,15 @@ module RuboCop
         #   def foo: [T] () -> void
         #
         #   # bad
-        #   def bar: [T, U] (T) -> void
+        #   def bar: [T] () -> T
+        #
+        #   # bad
+        #   def baz: [T] () { () -> T } -> void
         #
         #   # good
         #   def foo: [T] (Array[T]) -> T
-        class UselessOverloadTypeParams < RuboCop::RBS::CopBase
-          MSG = 'Useless overload type variable - `%<variable>s`.'
+        class RedundantOverloadTypeParams < RuboCop::RBS::CopBase
+          MSG = 'Redundant overload type variable - `%<variable>s`.'
 
           def on_rbs_def(decl)
             decl.overloads.each do |overload|
@@ -24,7 +27,16 @@ module RuboCop
 
               type_params = overload.method_type.type_params
 
-              overload.method_type.each_type do |type|
+              types = []
+              overload.method_type.type.each_param do |param|
+                types << param.type
+              end
+              overload.method_type.block&.then do |block|
+                block.type.each_type do |t|
+                  types << t
+                end
+              end
+              types.each do |type|
                 used_variable_in_type(type) do |var|
                   type_params.delete_if { |type_param| type_param.name == var.name }
                 end

data/lib/rubocop/cop/rbs_cops.rb

@@ -14,9 +14,10 @@ require_relative 'rbs/layout/space_before_colon'
 require_relative 'rbs/layout/space_before_overload'
 require_relative 'rbs/layout/trailing_whitespace'
 
+require_relative 'rbs/lint/duplicate_overload'
+require_relative 'rbs/lint/redundant_overload_type_params'
 require_relative 'rbs/lint/syntax'
 require_relative 'rbs/lint/type_params_arity'
-require_relative 'rbs/lint/useless_overload_type_params'
 require_relative 'rbs/lint/will_syntax_error'
 
 require_relative 'rbs/style/block_return_boolish'

data/lib/rubocop/rbs/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RBS
-    VERSION = '0.2.0'
+    VERSION = '0.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-on-rbs
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - ksss
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-06-06 00:00:00.000000000 Z
+date: 2024-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbs
@@ -62,9 +62,10 @@ files:
 - lib/rubocop/cop/rbs/layout/space_before_colon.rb
 - lib/rubocop/cop/rbs/layout/space_before_overload.rb
 - lib/rubocop/cop/rbs/layout/trailing_whitespace.rb
+- lib/rubocop/cop/rbs/lint/duplicate_overload.rb
+- lib/rubocop/cop/rbs/lint/redundant_overload_type_params.rb
 - lib/rubocop/cop/rbs/lint/syntax.rb
 - lib/rubocop/cop/rbs/lint/type_params_arity.rb
-- lib/rubocop/cop/rbs/lint/useless_overload_type_params.rb
 - lib/rubocop/cop/rbs/lint/will_syntax_error.rb
 - lib/rubocop/cop/rbs/style/block_return_boolish.rb
 - lib/rubocop/cop/rbs/style/classic_type.rb