rubocop-ogat 1.0.3 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 22560b279ac4cc6764eab83dc90bdbc53a3f0538
-  data.tar.gz: fce2cec359b1940fd9230bbf0a0a74cbbbe425ae
+SHA256:
+  metadata.gz: 503811c7400d964cdc03b8666ed43875faa065897874db0498f8d0ca5dc036a5
+  data.tar.gz: 3ef6c3dd5c921805fa448b7cd14b3b73bd8cc109f3a30b1164cef1ad9fc845df
 SHA512:
-  metadata.gz: c6bd010281e8e36aeae094a650961419df7100fe71c4eb93415e189af8d6e87febbe9fbfd6f7b8888bf2d8927dc1f134a40d551df8ffa3ddbf3b73a7d8295a3f
-  data.tar.gz: 23ff275a34cc35c6d288119788016e54cc10f1134f9370786b2b5f4e22b75a696ee0c3a7f188c8e9190492a79f034a9f3587ef582dfdb7c42c6f60323c087866
+  metadata.gz: d3bb8c7944f0734afb2f8b8a0d50fbdc496f0aabe61fee00b9d360a373a1869ef8a1682d5706199d9ddd1b3787f9bc0994deb7566735900d760769a59e163ad3
+  data.tar.gz: 3ce6c2d375e894d31b4e0d5832e7e4cbba3c356f34f10b9929d111779d4d275cbe6954fdc54930dbae914d28352f5306089e8b4e681fa0f72ddc3ad376b4999a

data/.gitignore

@@ -0,0 +1,13 @@
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+
+# rspec failure tracking
+.rspec_status
+
+Gemfile.lock

data/.rspec

@@ -0,0 +1,3 @@
+--format documentation
+--color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: config/default.yml
+AllCops:
+  TargetRubyVersion: 2.4
+Metrics/LineLength:
+  Max: 80

data/.travis.yml

@@ -1,8 +1,25 @@
+sudo: false
+language: ruby
+cache: bundler
+rvm:
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - ruby-head
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+  fast_finish: true
+before_install: gem install bundler -v 1.16.1
+script:
+  - bundle exec rubocop
+  - bundle exec rake
 deploy:
   provider: rubygems
   api_key:
     secure: kazURR5idcANlaYnqiGLnkXfsYWluTc3H87sg73H6s2JwEkA69FieZA3tUrDVX8kfbOxsqDphyv3fZmqrQtmG74ksUPVGsouoth7gpUMNh6Uj8Hr/e3Cgt/4b/SeGCAdpIsx869w8fA9kEKuf1NhQ0taazfiqToau3amyal6QblxMaalX8ThvWtO98ViJkEeIszxRK+uzd3t1aIEW/Lds9jWUm9Rf1tI/ajlRecwStA74pCQHJ2wuPQRcAB8DYz82pNjlyGwIZd14Gmbys0en+r+av3tYLjzwN+z9y7vlXwp1xAeRKU9GoJCHuevKmT1joRnFFfp3xGoKn63b6yS7KHVFT7v4l+qRbMnL+m/wrz5Xv3ZUyk0un9O3+MFLy0jIYP1adcvh+KkqenAktzSekjGstZn8oRk8lAEYfGLUD45nijdGjbYF7VAUPhoP5g6vxGlbZDCHslHuLGMjiEd/vP+SGEhtEMzk6cvir1yoMzryilRTfBfkut7iVsy/MaMvTShxF0qd1hdtx+Htfcq2zad98lAASsciz8su6u9vaqmqyxLKxdMptbWks4bCd0lB9g6fjIT79cIzjwQB6Hv3WNDpMLGDxWH8PkZf4ZEIlvV1goLlzt5t0SoZryn1hWbO4VJMvGLXtVj9MvdgskN95Ww9FTvO3wlm0PVK5iQWkU=
   gem: rubocop-ogat
   on:
+    rvm: 2.4.3
     tags: true
     repo: Outwood/rubocop-ogat

data/Gemfile

@@ -1,17 +1,8 @@
-source "https://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
+# frozen_string_literal: true
 
-gem 'rubocop', '~> 0.52'
-gem 'rubocop-rspec', '~> 1.22'
+source 'https://rubygems.org'
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
-group :development do
-  gem "shoulda", ">= 0"
-  gem "rdoc", "~> 6.0"
-  gem "bundler", "~> 1.0"
-  gem "juwelier", "~> 2.4.9"
-  gem "simplecov", ">= 0"
-end
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
+
+# Specify your gem's dependencies in rubocop-ogat.gemspec
+gemspec

data/LICENSE.txt

@@ -1,20 +1,21 @@
+The MIT License (MIT)
+
 Copyright (c) 2018 Outwood Grange Academies Trust
 
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -1,27 +1,53 @@
-# RuboCop OGAT
+# Rubocop::Ogat
 
-This repository provides recommended RuboCop configuration for use on OGAT open source and internal Ruby projects.
+Applies the default RuboCop configuration used by OGAT Ruby projects.
 
 ## Installation
 
-**Gemfile**
+Add this line to your application's Gemfile:
 
-``` ruby
-gem 'rubocop-ogat', require: false
+```ruby
+gem 'rubocop-ogat', require: false, groups: [:test, :development]
 ```
 
-**.rubocop.yml**
+And then execute:
 
-``` yaml
-inherit_from: .rubocop_todo.yml
+    $ bundle
 
+Or install it yourself as:
+
+    $ gem install rubocop-ogat
+
+## Usage
+
+Add this to your `.rubocop.yml`:
+
+```yaml
 inherit_gem:
   rubocop-ogat:
     - config/default.yml
+```
+
+Then define the following as appropriate to the project:
 
-# Set Ruby and Rails versions below
+```yaml
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   TargetRailsVersion: 4.2
-
+Rails:
+  Enabled: true
 ```
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/outwood/rubocop-ogat.
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,50 +1,8 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'rubygems'
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'rake'
-require 'juwelier'
-Juwelier::Tasks.new do |gem|
-  # gem is a Gem::Specification... see http://guides.rubygems.org/specification-reference/ for more options
-  gem.name = "rubocop-ogat"
-  gem.homepage = "http://github.com/Outwood/rubocop-ogat"
-  gem.license = "MIT"
-  gem.summary = %Q{RuboCop OGAT}
-  gem.description = %Q{Provides recommended RuboCop configuration for use on OGAT open source and internal Ruby projects.}
-  gem.email = "webmaster@outwood.com"
-  gem.authors = ["Elliot Bowes", "Tom Crouch"]
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
-  # dependencies defined in Gemfile
-end
-Juwelier::RubygemsDotOrgTasks.new
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
-end
+RSpec::Core::RakeTask.new(:spec)
 
-desc "Code coverage detail"
-task :simplecov do
-  ENV['COVERAGE'] = "true"
-  Rake::Task['test'].execute
-end
-
-task :default => :test
-
-require 'rdoc/task'
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "rubocop-ogat #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+task default: :spec

data/bin/console

@@ -0,0 +1,15 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'rubocop/ogat'
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require 'irb'
+IRB.start(__FILE__)

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/config/default.yml

@@ -8,11 +8,6 @@ AllCops:
     - 'db/schema.rb'
     - 'vendor/**/*'
 
-Rails:
-  Enabled: true
-
-# OGAT Desired Config
-
 Layout/AlignParameters:
   EnforcedStyle: with_fixed_indentation
 
@@ -68,19 +63,6 @@ Metrics/BlockLength:
     - 'config/routes.rb'
     - 'spec/**/*.rb'
 
-
-RSpec/AlignLeftLetBrace:
-  Enabled: false
-
-RSpec/AlignRightLetBrace:
-  Enabled: false
-
-RSpec/LetSetup:
-  Enabled: false
-
-RSpec/NestedGroups:
-  Max: 6
-
 Style/ClassAndModuleChildren:
   EnforcedStyle: nested
 
@@ -95,6 +77,12 @@ Style/CollectionMethods:
 Style/Copyright:
   Enabled: false
 
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'db/migrate/**/*'
+
 Style/DocumentationMethod:
   Enabled: false
 
@@ -109,3 +97,15 @@ Style/MissingElse:
 
 Style/RescueStandardError:
   EnforcedStyle: implicit
+
+RSpec/AlignLeftLetBrace:
+  Enabled: false
+
+RSpec/AlignRightLetBrace:
+  Enabled: false
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 6

data/lib/rubocop/ogat.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'rubocop/ogat/version'
+
+module Rubocop
+  # ogat extentions to rubocop
+  module Ogat
+    # Your code goes here...
+  end
+end

data/lib/rubocop/ogat/version.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Rubocop
+  module Ogat
+    VERSION = '1.1.0'
+  end
+end

data/rubocop-ogat.gemspec

@@ -1,68 +1,30 @@
-# Generated by juwelier
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
-# -*- encoding: utf-8 -*-
-# stub: rubocop-ogat 1.0.3 ruby lib
+# frozen_string_literal: true
 
-Gem::Specification.new do |s|
-  s.name = "rubocop-ogat".freeze
-  s.version = "1.0.3"
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'rubocop/ogat/version'
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib".freeze]
-  s.authors = ["Elliot Bowes".freeze, "Tom Crouch".freeze]
-  s.date = "2018-01-18"
-  s.description = "Provides recommended RuboCop configuration for use on OGAT open source and internal Ruby projects.".freeze
-  s.email = "webmaster@outwood.com".freeze
-  s.extra_rdoc_files = [
-    "LICENSE.txt",
-    "README.md"
-  ]
-  s.files = [
-    ".document",
-    ".travis.yml",
-    "Gemfile",
-    "LICENSE.txt",
-    "README.md",
-    "Rakefile",
-    "VERSION",
-    "config/default.yml",
-    "lib/rubocop-ogat.rb",
-    "rubocop-ogat.gemspec"
-  ]
-  s.homepage = "http://github.com/Outwood/rubocop-ogat".freeze
-  s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.6.13".freeze
-  s.summary = "RuboCop OGAT".freeze
+Gem::Specification.new do |spec|
+  spec.name          = 'rubocop-ogat'
+  spec.version       = Rubocop::Ogat::VERSION
+  spec.authors       = ['Elliot Bowes', 'Tom Crouch']
+  spec.email         = ['webmaster@outwood.com']
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 4
+  spec.summary       = 'Default RuboCop configuration for OGAT Ruby projects'
+  spec.homepage      = 'https://github.com/Outwood/rubocop-ogat'
+  spec.license       = 'MIT'
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<rubocop>.freeze, ["~> 0.52"])
-      s.add_runtime_dependency(%q<rubocop-rspec>.freeze, ["~> 1.22"])
-      s.add_development_dependency(%q<shoulda>.freeze, [">= 0"])
-      s.add_development_dependency(%q<rdoc>.freeze, ["~> 6.0"])
-      s.add_development_dependency(%q<bundler>.freeze, ["~> 1.0"])
-      s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.4.9"])
-      s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-    else
-      s.add_dependency(%q<rubocop>.freeze, ["~> 0.52"])
-      s.add_dependency(%q<rubocop-rspec>.freeze, ["~> 1.22"])
-      s.add_dependency(%q<shoulda>.freeze, [">= 0"])
-      s.add_dependency(%q<rdoc>.freeze, ["~> 6.0"])
-      s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
-      s.add_dependency(%q<juwelier>.freeze, ["~> 2.4.9"])
-      s.add_dependency(%q<simplecov>.freeze, [">= 0"])
+  spec.files         =
+    `git ls-files -z`.split("\x0").reject do |f|
+      f.match(%r{^(test|spec|features)/})
     end
-  else
-    s.add_dependency(%q<rubocop>.freeze, ["~> 0.52"])
-    s.add_dependency(%q<rubocop-rspec>.freeze, ["~> 1.22"])
-    s.add_dependency(%q<shoulda>.freeze, [">= 0"])
-    s.add_dependency(%q<rdoc>.freeze, ["~> 6.0"])
-    s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
-    s.add_dependency(%q<juwelier>.freeze, ["~> 2.4.9"])
-    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-  end
-end
+  spec.bindir        = 'exe'
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
 
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_runtime_dependency 'rubocop', '~> 0.52'
+  spec.add_runtime_dependency 'rubocop-rspec', '~> 1.22'
+end

metadata

@@ -1,134 +1,108 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-ogat
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - Elliot Bowes
 - Tom Crouch
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2018-01-18 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
-  type: :runtime
+        version: '1.16'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.22'
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+        version: '0.52'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.52'
 - !ruby/object:Gem::Dependency
-  name: juwelier
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.9
-  type: :development
+        version: '1.22'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.9
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: Provides recommended RuboCop configuration for use on OGAT open source
-  and internal Ruby projects.
-email: webmaster@outwood.com
+        version: '1.22'
+description: 
+email:
+- webmaster@outwood.com
 executables: []
 extensions: []
-extra_rdoc_files:
-- LICENSE.txt
-- README.md
+extra_rdoc_files: []
 files:
-- ".document"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- VERSION
+- bin/console
+- bin/setup
 - config/default.yml
-- lib/rubocop-ogat.rb
+- lib/rubocop/ogat.rb
+- lib/rubocop/ogat/version.rb
 - rubocop-ogat.gemspec
-homepage: http://github.com/Outwood/rubocop-ogat
+homepage: https://github.com/Outwood/rubocop-ogat
 licenses:
 - MIT
 metadata: {}
@@ -148,8 +122,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
-summary: RuboCop OGAT
+summary: Default RuboCop configuration for OGAT Ruby projects
 test_files: []

data/.document

@@ -1,5 +0,0 @@
-lib/**/*.rb
-bin/*
-- 
-features/**/*.feature
-LICENSE.txt

data/VERSION

@@ -1 +0,0 @@
-1.0.3