rubocop-nosolosoftware 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c83a65769879a3c1f22426f2676c8fa027c2bd1073f3cb907e93f993addcae35
-  data.tar.gz: a222df910618f9b51e9da57daa3a9fc736fa17686b58bfc0c155e49186152180
+  metadata.gz: 2fbf5c4e18589b5c8fa2008cb83979e418a36aafb7e86f9a370de3f8e1a651c7
+  data.tar.gz: 1f542c72065363864f45b677defb9d9de0bf14b92241275428bbd6ef58a7bbc1
 SHA512:
-  metadata.gz: e80e154e0dc55f972ccdd4e7e381d53ed4b47a145ea4e870b71b1d80cbc52d971ed91ec06cbdd00ccaf4cdbacbcd1ff61b9e8ff29940c15cad9a832e1bfc6ce1
-  data.tar.gz: '001117963311d3a63df48f9b3153f932abbc6036a1a3c781c0a95d1d99cc978b4250f0d2bf22ff06f153657ed20ac2c8e122d8612a4e24f3e4101a1e7d7fb884'
+  metadata.gz: b49b5e051a9d99ded77a8c5c335d81cf5eb10f4fb23b5e890b6df84e6da5b6d01b6a9d528b8085d04eabd3f6992415a48fe26d8d29d32ec70c3038f98bd7806b
+  data.tar.gz: 5f5f862ef2545aa16e4a9c036e01456fc26fb8388a2769c2e42940510d8c3a492c4a55dca238f082eb477b24acaed1ac1a3e2cf11ec76c5777a6327c6e33aa86

data/CHANGELOG.md

@@ -6,6 +6,65 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 The following rules have been added:
+## 1.17.0 - 2023-03-14
+  - Added rubocop-capybara as deprecation rules in rubocop-rspec 2.18.0 [link](https://github.com/rubocop/rubocop-rspec/releases/tag/v2.18.0)
+  - Added new rules
+    - rubocop
+      - Lint/DuplicateMagicComment (1.37.0)
+      - Style/OperatorMethodCall (1.37.0)
+      - Style/RedundantStringEscape (1.37.0)
+      - Style/RedundantEach (1.38.0)
+      - Style/RedundantConstantBase (1.40.0)
+      - Style/RequireOrder (1.40.0)
+      - Style/ArrayIntersect (1.40.0)
+      - Style/RedundantDoubleSplatHashBraces (1.41.0)
+      - Style/ConcatArrayLiterals (1.41.0)
+      - Style/MapToSet (1.42.0)
+      - Style/MinMaxComparison (1.42.0)
+      - Style/YodaExpression (1.42.0)
+      - Lint/UselessRescue (1.43.0)
+      - Style/InvertibleUnlessCondition (1.44.0)
+      - Style/ComparableClamp (1.44.0)
+      - Gemspec/DevelopmentDependencies (1.44.0)
+      - Style/RedundantHeredocDelimiterQuotes (1.45.0)
+      - Metrics/CollectionLiteralLength (1.47.0)
+      - Style/DirEmpty (1.48.0)
+      - Style/FileEmpty (1.48.0)
+    - rubocop-rails
+      - Rails/FreezeTime (2.16.0)
+      - Rails/WhereMissing (2.16.0)
+      - Rails/RootPathnameMethods (2.16.0)
+      - Rails/TopLevelHashWithIndifferentAccess (2.16.0)
+      - Rails/ActionControllerFlashBeforeRender (2.16.0)
+      - Rails/ActiveSupportOnLoad (2.16.0)
+      - Rails/ToSWithArgument (2.16.0)
+      - Rails/ActionOrder (2.17.0)
+      - Rails/WhereNotWithMultipleConditions (2.17.0)
+      - Rails/IgnoredColumnsAssignment (2.17.0)
+      - Rails/ResponseParsedBody (2.18.0)
+    - rubocop-performance:
+      - Performance/ConcurrentMonotonicTime (1.12.0)
+    - rubocop-rspec
+      - RSpec/NoExpectationExample (2.13.0)
+      - RSpec/ClassCheck (2.13.0)
+      - RSpec/FactoryBot/ConsistentParenthesesStyle (2.14.0)
+      - RSpec/Rails/InferredSpecType (2.14.0)
+      - RSpec/SortMetadata (2.14.0)
+      - RSpec/FactoryBot/FactoryNameStyle (2.16.0)
+      - RSpec/DuplicatedMetadata (2.16.0)
+      - RSpec/PendingWithoutReason (2.16.0)
+      - RSpec/Rails/MinitestAssertions (2.17.0)
+      - RSpec/RedundantAround (2.19.0)
+      - RSpec/Rails/TravelAround (2.19.0)
+      - RSpec/ContainExactly (2.19.0)
+      - RSpec/MatchArray (2.19.0)
+      - RSpec/SkipBlockInsideExample (2.19.0)
+    - rubocop-capybara
+      - Capybara/SpecificFinders (2.17.1)
+      - Capybara/NegationMatcher (2.17.1)
+      - Capybara/SpecificActions (2.17.1)
+      - Capybara/MatchStyle (2.17.1)
+
 ## 1.16.0 - 2022-09-01
   - Added new rules
     - rubocop

data/rubocop-capybara.yml

@@ -0,0 +1,26 @@
+#
+## https://github.com/rubocop/rubocop-capybara/
+#
+
+require: rubocop-capybara
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaraspecificmatcher
+Capybara/SpecificMatcher:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaraspecificfinders
+Capybara/SpecificFinders:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaranegationmatcher
+Capybara/NegationMatcher:
+  Enabled: true
+  EnforcedStyle: have_no
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaraspecificactions
+Capybara/SpecificActions:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaramatchstyle
+Capybara/MatchStyle:
+  Enabled: true

data/rubocop-default.yml

@@ -1,12 +1,17 @@
 inherit_from:
   - rubocop-all.yml
   - rubocop-bundler.yml
+  - rubocop-capybara.yml
+  - rubocop-faker.yml
   - rubocop-gemspec.yml
   - rubocop-layout.yml
   - rubocop-lint.yml
   - rubocop-metrics.yml
   - rubocop-naming.yml
   - rubocop-performance.yml
+  - rubocop-rails.yml
+  - rubocop-rake.yml
+  - rubocop-rspec.yml
   - rubocop-security.yml
   - rubocop-style.yml
 

data/rubocop-gemspec.yml

@@ -14,3 +14,6 @@ Gemspec/DependencyVersion:
 Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 
+# https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies
+Gemspec/DevelopmentDependencies:
+  Enabled: true

data/rubocop-lint.yml

@@ -115,3 +115,11 @@ Lint/ConstantOverwrittenInRescue:
 # https://docs.rubocop.org/rubocop/cops_lint.html#lintrequirerangeparentheses
 Lint/RequireRangeParentheses:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicatemagiccomment
+Lint/DuplicateMagicComment:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintuselessrescue
+Lint/UselessRescue:
+  Enabled: true

data/rubocop-metrics.yml

@@ -29,3 +29,8 @@ Metrics/BlockLength:
     - "**/config/routes.rb"
     - "**/config/routes/**/*.rb"
     - "**/lib/tasks/auto_annotate_models.rake"
+
+# https://docs.rubocop.org/rubocop/cops_metrics.html#metricscollectionliterallength
+Metrics/CollectionLiteralLength:
+  Enabled: true
+  LengthThreshold: 250

data/rubocop-performance.yml

@@ -75,3 +75,7 @@ Performance/RedundantSplitRegexpArgument:
 # https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancestringidentifierargument
 Performance/StringIdentifierArgument:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceconcurrentmonotonictime
+Performance/ConcurrentMonotonicTime:
+  Enabled: true

data/rubocop-rails.yml

@@ -58,6 +58,10 @@ Rails/ActiveRecordCallbacksOrder:
 Rails/FindById:
   Enabled: true
 
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsfindeach
+Rails/FindEach:
+  Enabled: true
+
 # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsinquiry
 Rails/Inquiry:
   Enabled: true
@@ -221,3 +225,47 @@ Rails/ToFormattedS:
 # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsrootpublicpath
 Rails/RootPublicPath:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsfreezetime
+Rails/FreezeTime:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswheremissing
+Rails/WhereMissing:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsrootpathnamemethods
+Rails/RootPathnameMethods:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railstoplevelhashwithindifferentaccess
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsactioncontrollerflashbeforerender
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsactivesupportonload
+Rails/ActiveSupportOnLoad:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railstoswithargument
+Rails/ToSWithArgument:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsactionorder
+Rails/ActionOrder:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswherenotwithmultipleconditions
+Rails/WhereNotWithMultipleConditions:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsignoredcolumnsassignment
+Rails/IgnoredColumnsAssignment:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsresponseparsedbody
+Rails/ResponseParsedBody:
+  Enabled: true

data/rubocop-rspec.yml

@@ -82,10 +82,63 @@ RSpec/VerifiedDoubleReference:
 RSpec/ChangeByZero:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop-rspec/cops_rspec_capybara.html#rspeccapybaraspecificmatcher
-RSpec/Capybara/SpecificMatcher:
-  Enabled: true
-
 # https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailshavehttpstatus
 RSpec/Rails/HaveHttpStatus:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecnoexpectationexample
+RSpec/NoExpectationExample:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecclasscheck
+RSpec/ClassCheck:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_factorybot.html#rspecfactorybotconsistentparenthesesstyle
+RSpec/FactoryBot/ConsistentParenthesesStyle:
+  Enabled: true
+  EnforcedStyle: "require_parentheses"
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailsinferredspectype
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecsortmetadata
+RSpec/SortMetadata:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_factorybot.html#rspecfactorybotfactorynamestyle
+RSpec/FactoryBot/FactoryNameStyle:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecduplicatedmetadata
+RSpec/DuplicatedMetadata:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecpendingwithoutreason
+RSpec/PendingWithoutReason:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailsminitestassertions
+RSpec/Rails/MinitestAssertions:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecredundantaround
+RSpec/RedundantAround:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailstravelaround
+RSpec/Rails/TravelAround:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspeccontainexactly
+RSpec/ContainExactly:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecmatcharray
+RSpec/MatchArray:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecskipblockinsideexample
+RSpec/SkipBlockInsideExample:
+  Enabled: true

data/rubocop-style.yml

@@ -161,3 +161,67 @@ Style/EmptyHeredoc:
 Style/MagicCommentFormat:
   Enabled: true
   EnforcedStyle: snake_case
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleoperatormethodcall
+Style/OperatorMethodCall:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantstringescape
+Style/RedundantStringEscape:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundanteach
+Style/RedundantEach:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantconstantbase
+Style/RedundantConstantBase:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylerequireorder
+Style/RequireOrder:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylearrayintersect
+Style/ArrayIntersect:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantdoublesplathashbraces
+Style/RedundantDoubleSplatHashBraces:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleconcatarrayliterals
+Style/ConcatArrayLiterals:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylemaptoset
+Style/MapToSet:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleminmaxcomparison
+Style/MinMaxComparison:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleyodaexpression
+Style/YodaExpression:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleinvertibleunlesscondition
+Style/InvertibleUnlessCondition:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylecomparableclamp
+Style/ComparableClamp:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantheredocdelimiterquotes
+Style/RedundantHeredocDelimiterQuotes:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styledirempty
+Style/DirEmpty:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylefileempty
+Style/FileEmpty:
+  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nosolosoftware
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - Javier Aranda
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-01 00:00:00.000000000 Z
+date: 2023-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.35.1
+        version: 1.48.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.35.1
+        version: 1.48.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.17.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.17.1
 - !ruby/object:Gem::Dependency
   name: rubocop-faker
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +58,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.3
+        version: 1.16.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.3
+        version: 1.16.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.15.2
+        version: 2.18.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.15.2
+        version: 2.18.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.1
+        version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.1
+        version: 2.19.0
 description: ''
 email: jaranda@nosolosoftware.es
 executables: []
@@ -107,6 +121,7 @@ files:
 - README.md
 - rubocop-all.yml
 - rubocop-bundler.yml
+- rubocop-capybara.yml
 - rubocop-default.yml
 - rubocop-faker.yml
 - rubocop-gemspec.yml
@@ -125,10 +140,10 @@ homepage: https://github.com/nosolosoftware/rubocop-nosolosoftware
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v1.16.0
-  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v1.16.0/CHANGELOG.md
+  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v1.17.0
+  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v1.17.0/CHANGELOG.md
   homepage_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -144,8 +159,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Default Rubocop configuration used in NoSoloSoftware developments
 test_files: []