rubocop-minitest 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: c3c643f7623a14a4a99f813daf392e31a491b7177504cad25760093d80e0b32e
-  data.tar.gz: b2e5de6e39a741828ae69ca48311b366747bb19aebbc85b23c96ff346f180b39
+SHA1:
+  metadata.gz: b6f7bc7c5d1f40800643ddc8cfbdb5b3b716484e
+  data.tar.gz: d2f4fedb8db4422c4f601a4410b04b77ef51bf12
 SHA512:
-  metadata.gz: eada0f53e4b625d321342f22aa80942512fcefa2131443a7d7d1d7a6f9fafabc1f1e8659f7b7fd2cc002bf83dcec037e760def29db035ac2f1e29bb6ace5fba3
-  data.tar.gz: ca010bc26330c8c32a9a28fe12f27870affa6e554c6832b6eedede0daf4c89fd5e28ffd93bca1e152a5e3785240023db9e4d35226f3e1bcfc02f49a7cffc5c68
+  metadata.gz: 0eaa51499fa109978fae23597f05cb11c0003fb7a4d887249b17c4966f6a2422aec2ee29c2c62baa044b006eb2965076072c306a3863b821382019324274c549
+  data.tar.gz: 79225d37425d04fcc425ad661b7970b99ab291f93f2337cf7cb7008ffa55aeb9d29cc0a79d9129f1e089c7eb5f00af95187b785a002f63ffde8b92ea0cd0df52

data/.circleci/config.yml

@@ -35,6 +35,9 @@ workflows:
       - rake_default:
           name: Ruby 2.6
           image: circleci/ruby:2.6
+      - rake_default:
+          name: Ruby 2.7
+          image: circleci/ruby:2.7
       - rake_default:
           name: Ruby HEAD
           image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build

data/CHANGELOG.md

@@ -2,8 +2,16 @@
 
 ## master (unreleased)
 
+## 0.6.0 (2020-02-07)
+
+### New features
+
+* [#49](https://github.com/rubocop-hq/rubocop-minitest/pull/49): New cops `AssertMatch` and `RefuteMatch` check for use of `assert_match`/`refute_match` instead of `assert(foo.match(bar))`/`refute(foo.match(bar))`. ([@fsateler][])
+
 ## 0.5.1 (2019-12-25)
 
+### Bug fixes
+
 * [#42](https://github.com/rubocop-hq/rubocop-minitest/issues/42): Fix an incorrect autocorrect for some cops of `Minitest` department when using heredoc message. ([@koic][])
 
 ## 0.5.0 (2019-11-24)
@@ -72,3 +80,4 @@
 [@tejasbubane]: https://github.com/tejasbubane
 [@abhaynikam]: https://github.com/abhaynikam
 [@herwinw]: https://github.com/herwinw
+[@fsateler]: https://github.com/fsateler

data/Gemfile

@@ -10,7 +10,4 @@ gem 'bump', require: false
 gem 'rake'
 gem 'rubocop', github: 'rubocop-hq/rubocop'
 gem 'rubocop-performance', '~> 1.5.0'
-# Workaround for YARD 0.9.20 or lower.
-# It specifies `github` until the release that includes the following changes:
-# https://github.com/lsegal/yard/pull/1290
-gem 'yard', github: 'lsegal/yard', ref: '10a2e5b'
+gem 'yard', '~> 0.9'

data/README.md

@@ -16,8 +16,8 @@ gem install rubocop-minitest
 
 or if you use bundler put this in your `Gemfile`
 
-```
-gem 'rubocop-minitest'
+```ruby
+gem 'rubocop-minitest', require: false
 ```
 
 ## Usage

data/config/default.yml

@@ -20,6 +20,12 @@ Minitest/AssertEqual:
   Enabled: true
   VersionAdded: '0.4'
 
+Minitest/AssertMatch:
+  Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
+  StyleGuide: 'https://github.com/rubocop-hq/minitest-style-guide#assert-match'
+  Enabled: true
+  VersionAdded: '0.6'
+
 Minitest/AssertIncludes:
   Description: 'This cop enforces the test to use `assert_includes` instead of using `assert(collection.include?(object))`.'
   StyleGuide: 'https://github.com/rubocop-hq/minitest-style-guide#assert-includes'
@@ -74,6 +80,12 @@ Minitest/RefuteIncludes:
   Enabled: true
   VersionAdded: '0.3'
 
+Minitest/RefuteMatch:
+  Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'
+  StyleGuide: 'https://github.com/rubocop-hq/minitest-style-guide#refute-match'
+  Enabled: true
+  VersionAdded: '0.6'
+
 Minitest/RefuteInstanceOf:
   Description: 'This cop enforces the test to use `refute_instance_of(Class, object)` over `refute(object.instance_of?(Class))`.'
   StyleGuide: 'https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of'

data/lib/rubocop/cop/minitest/assert_match.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop enforces the test to use `assert_match`
+      # instead of using `assert(matcher.match(string))`.
+      #
+      # @example
+      #   # bad
+      #   assert(matcher.match(string))
+      #   assert(matcher.match(string), 'the message')
+      #
+      #   # good
+      #   assert_match(regex, string)
+      #   assert_match(matcher, string, 'the message')
+      #
+      class AssertMatch < Cop
+        include ArgumentRangeHelper
+
+        MSG = 'Prefer using `assert_match(%<arguments>s)` over ' \
+              '`assert(%<receiver>s)`.'
+
+        def_node_matcher :assert_with_match, <<~PATTERN
+          (send nil? :assert $(send $_ :match $_) $...)
+        PATTERN
+
+        def on_send(node)
+          assert_with_match(node) do
+            |first_receiver_arg, matcher, actual, rest_receiver_arg|
+            message = rest_receiver_arg.first
+            arguments = node_arguments(matcher, actual, message)
+            receiver = [first_receiver_arg.source, message&.source].compact.join(', ')
+
+            offense_message = format(MSG, arguments: arguments, receiver: receiver)
+
+            add_offense(node, message: offense_message)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            assert_with_match(node) do |_, matcher, actual|
+              corrector.replace(node.loc.selector, 'assert_match')
+
+              replacement = [matcher, actual].map(&:source).join(', ')
+              corrector.replace(first_argument_range(node), replacement)
+            end
+          end
+        end
+
+        private
+
+        def node_arguments(matcher, actual, message)
+          [matcher.source, actual.source, message&.source].compact.join(', ')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/refute_match.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop enforces the test to use `refute_match`
+      # instead of using `refute(matcher.match(string))`.
+      #
+      # @example
+      #   # bad
+      #   refute(matcher.match(string))
+      #   refute(matcher.match(string), 'the message')
+      #
+      #   # good
+      #   refute_match(matcher, string)
+      #   refute_match(matcher, string, 'the message')
+      #
+      class RefuteMatch < Cop
+        include ArgumentRangeHelper
+
+        MSG = 'Prefer using `refute_match(%<arguments>s)` over ' \
+              '`refute(%<receiver>s)`.'
+
+        def_node_matcher :refute_with_match, <<~PATTERN
+          (send nil? :refute $(send $_ :match $_) $...)
+        PATTERN
+
+        def on_send(node)
+          refute_with_match(node) do
+            |first_receiver_arg, matcher, actual, rest_receiver_arg|
+            message = rest_receiver_arg.first
+            arguments = node_arguments(matcher, actual, message)
+            receiver = [first_receiver_arg.source, message&.source].compact.join(', ')
+
+            offense_message = format(MSG, arguments: arguments, receiver: receiver)
+
+            add_offense(node, message: offense_message)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            refute_with_match(node) do |_, matcher, actual|
+              corrector.replace(node.loc.selector, 'refute_match')
+
+              replacement = [matcher, actual].map(&:source).join(', ')
+              corrector.replace(first_argument_range(node), replacement)
+            end
+          end
+        end
+
+        private
+
+        def node_arguments(matcher, actual, message)
+          [matcher.source, actual.source, message&.source].compact.join(', ')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest_cops.rb

@@ -7,6 +7,7 @@ require_relative 'minitest/assert_equal'
 require_relative 'minitest/assert_nil'
 require_relative 'minitest/assert_includes'
 require_relative 'minitest/assert_instance_of'
+require_relative 'minitest/assert_match'
 require_relative 'minitest/assert_respond_to'
 require_relative 'minitest/assert_truthy'
 require_relative 'minitest/refute_empty'
@@ -14,5 +15,6 @@ require_relative 'minitest/refute_false'
 require_relative 'minitest/refute_equal'
 require_relative 'minitest/refute_nil'
 require_relative 'minitest/refute_includes'
+require_relative 'minitest/refute_match'
 require_relative 'minitest/refute_instance_of'
 require_relative 'minitest/refute_respond_to'

data/lib/rubocop/minitest/inject.rb

@@ -8,7 +8,7 @@ module RuboCop
       def self.defaults!
         path = CONFIG_DEFAULT.to_s
         hash = ConfigLoader.send(:load_yaml_configuration, path)
-        config = Config.new(hash, path)
+        config = Config.new(hash, path).tap(&:make_excludes_absolute)
         puts "configuration from #{path}" if ConfigLoader.debug?
         config = ConfigLoader.merge_with_default(config, path)
         ConfigLoader.instance_variable_set(:@default_configuration, config)

data/lib/rubocop/minitest/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Minitest
-    VERSION = '0.5.1'
+    VERSION = '0.6.0'
   end
 end

data/manual/cops.md

@@ -6,6 +6,7 @@
 * [Minitest/AssertEqual](cops_minitest.md#minitestassertequal)
 * [Minitest/AssertIncludes](cops_minitest.md#minitestassertincludes)
 * [Minitest/AssertInstanceOf](cops_minitest.md#minitestassertinstanceof)
+* [Minitest/AssertMatch](cops_minitest.md#minitestassertmatch)
 * [Minitest/AssertNil](cops_minitest.md#minitestassertnil)
 * [Minitest/AssertRespondTo](cops_minitest.md#minitestassertrespondto)
 * [Minitest/AssertTruthy](cops_minitest.md#minitestasserttruthy)
@@ -14,6 +15,7 @@
 * [Minitest/RefuteFalse](cops_minitest.md#minitestrefutefalse)
 * [Minitest/RefuteIncludes](cops_minitest.md#minitestrefuteincludes)
 * [Minitest/RefuteInstanceOf](cops_minitest.md#minitestrefuteinstanceof)
+* [Minitest/RefuteMatch](cops_minitest.md#minitestrefutematch)
 * [Minitest/RefuteNil](cops_minitest.md#minitestrefutenil)
 * [Minitest/RefuteRespondTo](cops_minitest.md#minitestrefuterespondto)
 

data/manual/cops_minitest.md

@@ -118,6 +118,31 @@ assert_instance_of(Class, object, 'the message')
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-instance-of](https://github.com/rubocop-hq/minitest-style-guide#assert-instance-of)
 
+## Minitest/AssertMatch
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.6 | -
+
+This cop enforces the test to use `assert_match`
+instead of using `assert(matcher.match(string))`.
+
+### Examples
+
+```ruby
+# bad
+assert(matcher.match(string))
+assert(matcher.match(string), 'the message')
+
+# good
+assert_match(regex, string)
+assert_match(matcher, string, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#assert-match](https://github.com/rubocop-hq/minitest-style-guide#assert-match)
+
 ## Minitest/AssertNil
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
@@ -319,6 +344,31 @@ refute_instance_of(Class, object, 'the message')
 
 * [https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of](https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of)
 
+## Minitest/RefuteMatch
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.6 | -
+
+This cop enforces the test to use `refute_match`
+instead of using `refute(matcher.match(string))`.
+
+### Examples
+
+```ruby
+# bad
+refute(matcher.match(string))
+refute(matcher.match(string), 'the message')
+
+# good
+refute_match(matcher, string)
+refute_match(matcher, string, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-match](https://github.com/rubocop-hq/minitest-style-guide#refute-match)
+
 ## Minitest/RefuteNil
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged

data/relnotes/v0.5.1.md

@@ -1,3 +1,5 @@
+### Bug fixes
+
 * [#42](https://github.com/rubocop-hq/rubocop-minitest/issues/42): Fix an incorrect autocorrect for some cops of `Minitest` department when using heredoc message. ([@koic][])
 
 [@koic]: https://github.com/koic

data/relnotes/v0.6.0.md

@@ -0,0 +1,5 @@
+### New features
+
+* [#49](https://github.com/rubocop-hq/rubocop-minitest/pull/49): New cops `AssertMatch` and `RefuteMatch` check for use of `assert_match`/`refute_match` instead of `assert(foo.match(bar))`/`refute(foo.match(bar))`. ([@fsateler][])
+
+[@fsateler]: https://github.com/fsateler

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-25 00:00:00.000000000 Z
+date: 2020-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -71,6 +71,7 @@ files:
 - lib/rubocop/cop/minitest/assert_equal.rb
 - lib/rubocop/cop/minitest/assert_includes.rb
 - lib/rubocop/cop/minitest/assert_instance_of.rb
+- lib/rubocop/cop/minitest/assert_match.rb
 - lib/rubocop/cop/minitest/assert_nil.rb
 - lib/rubocop/cop/minitest/assert_respond_to.rb
 - lib/rubocop/cop/minitest/assert_truthy.rb
@@ -79,6 +80,7 @@ files:
 - lib/rubocop/cop/minitest/refute_false.rb
 - lib/rubocop/cop/minitest/refute_includes.rb
 - lib/rubocop/cop/minitest/refute_instance_of.rb
+- lib/rubocop/cop/minitest/refute_match.rb
 - lib/rubocop/cop/minitest/refute_nil.rb
 - lib/rubocop/cop/minitest/refute_respond_to.rb
 - lib/rubocop/cop/minitest_cops.rb
@@ -101,6 +103,7 @@ files:
 - relnotes/v0.4.1.md
 - relnotes/v0.5.0.md
 - relnotes/v0.5.1.md
+- relnotes/v0.6.0.md
 - rubocop-minitest.gemspec
 - tasks/cops_documentation.rake
 - tasks/cut_release.rake
@@ -128,7 +131,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubyforge_project: 
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Automatic Minitest code style checking tool.