rubocop-minitest 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 930866a6157741e50512335bb341add3271a010ce7297d47a2ea439494b48bd1
-  data.tar.gz: 6e3583932fa0d49db8ca8a77f4f8c47b36d4e13bd978f4ee91075190f0e646ed
+  metadata.gz: 4fb2a1153e8f5e4eb37a349fcdfff211a421369606facb6d866fbc4701a60d6c
+  data.tar.gz: 2e258868d43eddc169e142e408e01d52e7d6e63ac5e9f1f53643feca8ff8968e
 SHA512:
-  metadata.gz: 1a84adc4ef08e2c434ef214ac0351f5943ef2fc55b24e7e8d16be6a423d5e2a19e189ec1e23f6bad5ae8f1a23595332949f6f318295680d0ec854efb084d2ff0
-  data.tar.gz: 45725285a52705d75dc544ecc13d644e38cae8338c8fe070599def10ce272357bbc89cd26f9188300cf4b0f8a1d1a82818406242a36ff6f9102066fb052a3ca4
+  metadata.gz: 466706a3aa3020369c7b855c20ad0619cfd8d2e4c94a6f260287908ce2d5ecefdc8190bc88a60d7cb59d0cdd39a276dc87ebdea91c240a5d820e167d984424c9
+  data.tar.gz: 6aede577f029efa7fb8a2cf89151261c16dfe57f980100b568c8e11252b7652e45cac051f404212411e2cac2a0232d0c4c752322f6781fa3c37297e6a10eae11

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.5.0 (2019-11-24)
+
+### New features
+
+* [#32](https://github.com/rubocop-hq/rubocop-minitest/issues/32): Add new `Minitest/AssertEmptyLiteral` cop. ([@tejasbubane][])
+
 ## 0.4.1 (2019-11-10)
 
 ### Bug fixes

data/Gemfile

@@ -9,5 +9,5 @@ gemspec
 gem 'bump', require: false
 gem 'rake'
 gem 'rubocop', github: 'rubocop-hq/rubocop'
-gem 'rubocop-performance', '~> 1.4.0'
+gem 'rubocop-performance', '~> 1.5.0'
 gem 'yard', '~> 0.9'

data/config/default.yml

@@ -9,6 +9,11 @@ Minitest/AssertEmpty:
   Enabled: true
   VersionAdded: '0.2'
 
+Minitest/AssertEmptyLiteral:
+  Description: 'This cop enforces the test to use `assert_empty` instead of using `assert([], object)` or `assert({}, object)`.'
+  Enabled: true
+  VersionAdded: '0.5'
+
 Minitest/AssertEqual:
   Description: 'This cop enforces the test to use `assert_equal` instead of using `assert(expected == actual)`.'
   StyleGuide: 'https://github.com/rubocop-hq/minitest-style-guide#assert-equal-arguments-order'

data/lib/rubocop/cop/minitest/assert_empty_literal.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop enforces the test to use `assert_empty`
+      # instead of using `assert([], object)`.
+      #
+      # @example
+      #   # bad
+      #   assert([], object)
+      #   assert({}, object)
+      #
+      #   # good
+      #   assert_empty(object)
+      #
+      class AssertEmptyLiteral < Cop
+        MSG = 'Prefer using `assert_empty(%<arguments>s)` over ' \
+              '`assert(%<literal>s, %<arguments>s)`.'
+
+        def_node_matcher :assert_with_empty_literal, <<~PATTERN
+          (send nil? :assert ${hash array} $...)
+        PATTERN
+
+        def on_send(node)
+          assert_with_empty_literal(node) do |literal, matchers|
+            args = matchers.map(&:source).join(', ')
+
+            message = format(MSG, literal: literal.source, arguments: args)
+            add_offense(node, message: message)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest_cops.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative 'minitest/assert_empty'
+require_relative 'minitest/assert_empty_literal'
 require_relative 'minitest/assert_equal'
 require_relative 'minitest/assert_nil'
 require_relative 'minitest/assert_includes'

data/lib/rubocop/minitest/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Minitest
-    VERSION = '0.4.1'
+    VERSION = '0.5.0'
   end
 end

data/manual/cops.md

@@ -2,6 +2,7 @@
 #### Department [Minitest](cops_minitest.md)
 
 * [Minitest/AssertEmpty](cops_minitest.md#minitestassertempty)
+* [Minitest/AssertEmptyLiteral](cops_minitest.md#minitestassertemptyliteral)
 * [Minitest/AssertEqual](cops_minitest.md#minitestassertequal)
 * [Minitest/AssertIncludes](cops_minitest.md#minitestassertincludes)
 * [Minitest/AssertInstanceOf](cops_minitest.md#minitestassertinstanceof)

data/manual/cops_minitest.md

@@ -25,6 +25,26 @@ assert_empty(object, 'the message')
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-empty](https://github.com/rubocop-hq/minitest-style-guide#assert-empty)
 
+## Minitest/AssertEmptyLiteral
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | No | 0.5 | -
+
+This cop enforces the test to use `assert_empty`
+instead of using `assert([], object)`.
+
+### Examples
+
+```ruby
+# bad
+assert([], object)
+assert({}, object)
+
+# good
+assert_empty(object)
+```
+
 ## Minitest/AssertEqual
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged

data/relnotes/v0.5.0.md

@@ -0,0 +1,5 @@
+### New features
+
+* [#32](https://github.com/rubocop-hq/rubocop-minitest/issues/32): Add new `Minitest/AssertEmptyLiteral` cop. ([@tejasbubane][])
+
+[@tejasbubane]: https://github.com/tejasbubane

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-09 00:00:00.000000000 Z
+date: 2019-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -67,6 +67,7 @@ files:
 - config/default.yml
 - lib/rubocop-minitest.rb
 - lib/rubocop/cop/minitest/assert_empty.rb
+- lib/rubocop/cop/minitest/assert_empty_literal.rb
 - lib/rubocop/cop/minitest/assert_equal.rb
 - lib/rubocop/cop/minitest/assert_includes.rb
 - lib/rubocop/cop/minitest/assert_instance_of.rb
@@ -97,6 +98,7 @@ files:
 - relnotes/v0.3.0.md
 - relnotes/v0.4.0.md
 - relnotes/v0.4.1.md
+- relnotes/v0.5.0.md
 - rubocop-minitest.gemspec
 - tasks/cops_documentation.rake
 - tasks/cut_release.rake