rubocop-minitest 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '06679af4eeb82332ac490d8aceb5cd0668cb3686e1bf7f7d8fb83d1bc6d99f50'
-  data.tar.gz: f967a4cff6cfdc23182befb62fbc4363197213065acb21da6fc99e62d685951d
+  metadata.gz: 930866a6157741e50512335bb341add3271a010ce7297d47a2ea439494b48bd1
+  data.tar.gz: 6e3583932fa0d49db8ca8a77f4f8c47b36d4e13bd978f4ee91075190f0e646ed
 SHA512:
-  metadata.gz: 3b2bbdefbd8de0346adb4b06884ab674ed88588bfaf8550ebcbadcd8f07be0199a0270c50ac15a9f36f607e157b3edde095db6e7caf3814cd8ff9ecc7350b9f3
-  data.tar.gz: 0f45beaa717b0d0135dd41462d372a794a66aea60e700f6cd942b79cd01a61f69914d45ad83ccad26ca95aa88b681d20f04b6b2b2e0a5278464399ef1a8ee47c
+  metadata.gz: 1a84adc4ef08e2c434ef214ac0351f5943ef2fc55b24e7e8d16be6a423d5e2a19e189ec1e23f6bad5ae8f1a23595332949f6f318295680d0ec854efb084d2ff0
+  data.tar.gz: 45725285a52705d75dc544ecc13d644e38cae8338c8fe070599def10ce272357bbc89cd26f9188300cf4b0f8a1d1a82818406242a36ff6f9102066fb052a3ca4

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.4.1 (2019-11-10)
+
+### Bug fixes
+
+* [#39](https://github.com/rubocop-hq/rubocop-minitest/issues/39): Fix an incorrect autocorrect for `Minitest/AssertRespondTo` and `Minitest/RefuteRespondTo` when using assertion method calling `respond_to` with receiver omitted. ([@koic][])
+
 ## 0.4.0 (2019-11-07)
 
 ### New features

data/lib/rubocop/cop/minitest/assert_respond_to.rb

@@ -10,10 +10,12 @@ module RuboCop
       #   # bad
       #   assert(object.respond_to?(:some_method))
       #   assert(object.respond_to?(:some_method), 'the message')
+      #   assert(respond_to?(:some_method))
       #
       #   # good
       #   assert_respond_to(object, :some_method)
       #   assert_respond_to(object, :some_method, 'the message')
+      #   assert_respond_to(self, some_method)
       #
       class AssertRespondTo < Cop
         MSG = 'Prefer using `assert_respond_to(%<preferred>s)` over ' \
@@ -26,9 +28,8 @@ module RuboCop
         def on_send(node)
           assert_with_respond_to(node) do |over, object, method, rest_args|
             custom_message = rest_args.first
-            preferred = [object, method, custom_message]
-                        .compact.map(&:source).join(', ')
-            over      = [over, custom_message].compact.map(&:source).join(', ')
+            preferred = build_preferred_arguments(object, method, custom_message)
+            over = [over, custom_message].compact.map(&:source).join(', ')
             message = format(MSG, preferred: preferred, over: over)
             add_offense(node, message: message)
           end
@@ -38,13 +39,20 @@ module RuboCop
           lambda do |corrector|
             assert_with_respond_to(node) do |_, object, method, rest_args|
               custom_message = rest_args.first
-              preferred = [object, method, custom_message]
-                          .compact.map(&:source).join(', ')
+              preferred = build_preferred_arguments(object, method, custom_message)
               replacement = "assert_respond_to(#{preferred})"
               corrector.replace(node.loc.expression, replacement)
             end
           end
         end
+
+        private
+
+        def build_preferred_arguments(receiver, method, message)
+          receiver = receiver ? receiver.source : 'self'
+
+          [receiver, method.source, message&.source].compact.join(', ')
+        end
       end
     end
   end

data/lib/rubocop/cop/minitest/refute_respond_to.rb

@@ -10,10 +10,12 @@ module RuboCop
       #   # bad
       #   refute(object.respond_to?(:some_method))
       #   refute(object.respond_to?(:some_method), 'the message')
+      #   refute(respond_to?(:some_method))
       #
       #   # good
       #   refute_respond_to(object, :some_method)
       #   refute_respond_to(object, :some_method, 'the message')
+      #   refute_respond_to(self, :some_method)
       #
       class RefuteRespondTo < Cop
         MSG = 'Prefer using `refute_respond_to(%<preferred>s)` over ' \
@@ -26,9 +28,8 @@ module RuboCop
         def on_send(node)
           refute_with_respond_to(node) do |over, object, method, rest_args|
             custom_message = rest_args.first
-            preferred = [object, method, custom_message]
-                        .compact.map(&:source).join(', ')
-            over      = [over, custom_message].compact.map(&:source).join(', ')
+            preferred = build_preferred_arguments(object, method, custom_message)
+            over = [over, custom_message].compact.map(&:source).join(', ')
             message = format(MSG, preferred: preferred, over: over)
             add_offense(node, message: message)
           end
@@ -38,13 +39,20 @@ module RuboCop
           lambda do |corrector|
             refute_with_respond_to(node) do |_, object, method, rest_args|
               custom_message = rest_args.first
-              preferred = [object, method, custom_message]
-                          .compact.map(&:source).join(', ')
+              preferred = build_preferred_arguments(object, method, custom_message)
               replacement = "refute_respond_to(#{preferred})"
               corrector.replace(node.loc.expression, replacement)
             end
           end
         end
+
+        private
+
+        def build_preferred_arguments(receiver, method, message)
+          receiver = receiver ? receiver.source : 'self'
+
+          [receiver, method.source, message&.source].compact.join(', ')
+        end
       end
     end
   end

data/lib/rubocop/minitest/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Minitest
-    VERSION = '0.4.0'
+    VERSION = '0.4.1'
   end
 end

data/manual/cops_minitest.md

@@ -138,10 +138,12 @@ over `assert(object.respond_to?(:some_method))`.
 # bad
 assert(object.respond_to?(:some_method))
 assert(object.respond_to?(:some_method), 'the message')
+assert(respond_to?(:some_method))
 
 # good
 assert_respond_to(object, :some_method)
 assert_respond_to(object, :some_method, 'the message')
+assert_respond_to(self, some_method)
 ```
 
 ### References
@@ -337,10 +339,12 @@ over `refute(object.respond_to?(:some_method))`.
 # bad
 refute(object.respond_to?(:some_method))
 refute(object.respond_to?(:some_method), 'the message')
+refute(respond_to?(:some_method))
 
 # good
 refute_respond_to(object, :some_method)
 refute_respond_to(object, :some_method, 'the message')
+refute_respond_to(self, :some_method)
 ```
 
 ### References

data/relnotes/v0.4.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#39](https://github.com/rubocop-hq/rubocop-minitest/issues/39): Fix an incorrect autocorrect for `Minitest/AssertRespondTo` and `Minitest/RefuteRespondTo` when using assertion method calling `respond_to` with receiver omitted. ([@koic][])
+
+[@koic]: https://github.com/koic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-07 00:00:00.000000000 Z
+date: 2019-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -96,6 +96,7 @@ files:
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
 - relnotes/v0.4.0.md
+- relnotes/v0.4.1.md
 - rubocop-minitest.gemspec
 - tasks/cops_documentation.rake
 - tasks/cut_release.rake