rubocop-minitest 0.34.4 → 0.34.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e4b8d1f63d66f8d5c75e7df19dba8c07f62d7da0ac637a9b92014d865fe0314
-  data.tar.gz: 1bf5ef6960646dd7b2e84b947bde08fe5b6fabbdd40a4c78c41cc59112a9181b
+  metadata.gz: cc9ea3b370ec30f86a9e1ddb422255552f643a605b6e744518afcfa1e6ae6de0
+  data.tar.gz: ba67151e3d30de7f5634ef62feb6663fb0109c69886bdf231417dea06a55ba99
 SHA512:
-  metadata.gz: a5bf6ff7d580d5223a90735e7f4f81a528ef14ce943689b24fad9561070bb02f2bbd569bd4dd5c79466781b1e5292e5008be428b1b5694b6c501c91d567fc933
-  data.tar.gz: 37f1a56983839444e99921b3f8c664e4b7d3388e6dff081e17b899a3281e44ec45fe9bca3fcd06aef6791d955a88053010efddaa5ffd9d30e2b875a54aff3118
+  metadata.gz: d7ab44585e54b9cd0cd85d8e36adfd9ba9f9a7b560c791e15af082691e391a38f313857f323eb897c831d277d73b67e13707cdb76db45bce8cf38286099d7640
+  data.tar.gz: d592eb50f633074ac727f0fb493d734ca70320ff8fb9441dfab46b45916a7d730a5e439486642755cc83797bacbdfaf85cbb6b6cc95415a491230f64e2645102

data/config/default.yml

@@ -46,6 +46,7 @@ Minitest/AssertKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#assert-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/AssertMatch:
   Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
@@ -252,6 +253,7 @@ Minitest/RefuteKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#refute-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/RefuteMatch:
   Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'

data/lib/rubocop/cop/minitest/assert_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   assert(object.kind_of?(Class))
       #   assert(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   assert(object.is_a?(Class))
+      #   assert(object.is_a?(Class), 'message')
+      #
       #   # good
       #   assert_kind_of(Class, object)
       #   assert_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class AssertKindOf < Base
         extend MinitestCopRule
 
-        define_rule :assert, target_method: :kind_of?, inverse: true
+        define_rule :assert, target_method: %i[kind_of? is_a?], preferred_method: :assert_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/refute_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   refute(object.kind_of?(Class))
       #   refute(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   refute(object.is_of?(Class))
+      #   refute(object.is_of?(Class), 'message')
+      #
       #   # good
       #   refute_kind_of(Class, object)
       #   refute_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class RefuteKindOf < Base
         extend MinitestCopRule
 
-        define_rule :refute, target_method: :kind_of?, inverse: true
+        define_rule :refute, target_method: %i[kind_of? is_a?], preferred_method: :refute_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/useless_assertion.rb

@@ -48,7 +48,7 @@ module RuboCop
           when *SINGLE_ASSERTION_ARGUMENT_METHODS
             actual.nil? && expected&.literal? && !expected.xstr_type?
           when *TWO_ASSERTION_ARGUMENTS_METHODS
-            return false unless expected || actual
+            return false unless expected && actual
             return false if expected.source != actual.source
 
             (expected.variable? && actual.variable?) ||

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.34.4'
+      STRING = '0.34.5'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.34.4
+  version: 0.34.5
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-09 00:00:00.000000000 Z
+date: 2024-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop