rubocop-minitest 0.17.0 → 0.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f04d27399103835be508a28975344afe09018c9f480217824f65c0c43be34b3d
-  data.tar.gz: 3021b9fa8b826d056b69d2c91b6d447dc66a3acecc82bf439a2931e6f25ea9f6
+  metadata.gz: 06bac8581123850a3beb2e5f9e740279d6ef05889119afd4418d1d079b357b6e
+  data.tar.gz: e0257e30d0b413979b7ce990beae6fc685e3f12161f97ed3fc8391dd023544b2
 SHA512:
-  metadata.gz: 61ae0ab74e4a736221044989b3ef08e5c743b6cd43024c6ed236e276a4fefb0ec6c3fd23232f401ef205d0db5e8575c8cb1b85b31186a8e26c7be031e65f9772
-  data.tar.gz: a574a9d994741b69bf4280b91ef7321498aeeaec391cdfee7784230baf55a0d45bf4013a8395418b96b442a39fb13b5a33fa23b8bb03d2cce92bb77c040317c9
+  metadata.gz: a358ed867fb7a16f3430835a11560c1159940c67b66627db9116d4cf6c45efd2519701f93c8333ed722d1c296bd527ea7b52c970ba472056b7170f363d95ae05
+  data.tar.gz: a22c800e537e5461cb7446d88e60e3a73f7ac63119c72d4acc32d72707670550b16cb7e1f015668d35dcca7a746f947f93df2a4ee6db571ad23f0f0c17766475

data/.circleci/config.yml

@@ -37,16 +37,19 @@ workflows:
       - documentation-checks
       - rake_default:
           name: Ruby 2.5
-          image: circleci/ruby:2.5
+          image: cimg/ruby:2.5
       - rake_default:
           name: Ruby 2.6
-          image: circleci/ruby:2.6
+          image: cimg/ruby:2.6
       - rake_default:
           name: Ruby 2.7
-          image: circleci/ruby:2.7
+          image: cimg/ruby:2.7
       - rake_default:
           name: Ruby 3.0
-          image: circleci/ruby:3.0
+          image: cimg/ruby:3.0
+      - rake_default:
+          name: Ruby 3.1
+          image: cimg/ruby:3.1
       - rake_default:
           name: Ruby HEAD
           image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -5,14 +5,13 @@ The more detailed you are, the better.**
 
 Before submitting the PR make sure the following are checked:
 
+* [ ] The PR relates to *only* one subject with a clear title and description in grammatically correct, complete sentences.
 * [ ] Wrote [good commit messages][1].
 * [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).
 * [ ] Feature branch is up-to-date with `master` (if not - rebase it).
 * [ ] Squashed related commits together.
 * [ ] Added tests.
+* [ ] Ran `bundle exec rake default`. It executes all tests and runs RuboCop on its own code.
 * [ ] Added an entry (file) to the [changelog folder](https://github.com/rubocop/rubocop-minitest/blob/master/changelog/) named `{change_type}_{change_description}.md` if the new code introduces user-observable changes. See [changelog entry format](https://github.com/rubocop/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format) for details.
-* [ ] The PR relates to *only* one subject with a clear title
-  and description in grammatically correct, complete sentences.
-* [ ] Run `bundle exec rake default`. It executes all tests and RuboCop for itself, and generates the documentation.
 
 [1]: https://chris.beams.io/posts/git-commit/

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.17.1 (2022-01-30)
+
+### Changes
+
+* [#158](https://github.com/rubocop/rubocop-minitest/pull/158): Make `Minitest/UnreachableAssertion` aware of `assert` and `refute` prefix methods. ([@koic][])
+
 ## 0.17.0 (2021-11-23)
 
 ### New features

data/Gemfile

@@ -11,3 +11,6 @@ gem 'rake'
 gem 'rubocop', github: 'rubocop/rubocop'
 gem 'rubocop-performance', '~> 1.12.0'
 gem 'yard', '~> 0.9'
+
+local_gemfile = File.expand_path('Gemfile.local', __dir__)
+eval_gemfile local_gemfile if File.exist?(local_gemfile)

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019-2021 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
+Copyright (c) 2019-2022 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Rakefile

@@ -48,7 +48,7 @@ task :new_cop, [:cop] do |_task, args|
   generator.write_source
   generator.write_test
   generator.inject_require(root_file_path: 'lib/rubocop/cop/minitest_cops.rb')
-  generator.inject_config(config_file_path: 'config/default.yml', version_added: bump_minor_version)
+  generator.inject_config(config_file_path: 'config/default.yml')
 
   puts generator.todo
 end

data/docs/modules/ROOT/pages/installation.adoc

@@ -11,5 +11,5 @@ or if you use bundler put this in your `Gemfile`
 
 [source,ruby]
 ----
-gem 'rubocop-minitest'
+gem 'rubocop-minitest', require: false
 ----

data/lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb

@@ -30,7 +30,7 @@ module RuboCop
 
           lifecycle_hooks(class_node).each do |hook_node|
             hook_node.each_descendant(:send) do |node|
-              if assertion?(node)
+              if assertion_method?(node)
                 message = format(MSG, assertion: node.method_name, hook: hook_node.method_name)
                 add_offense(node, message: message)
               end

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -50,7 +50,7 @@ module RuboCop
         private
 
         def assertions_count(node)
-          base = assertion?(node) ? 1 : 0
+          base = assertion_method?(node) ? 1 : 0
           base + node.each_child_node.sum { |c| assertions_count(c) }
         end
 

data/lib/rubocop/cop/minitest/no_assertions.rb

@@ -39,7 +39,7 @@ module RuboCop
         private
 
         def assertions_count(node)
-          base = assertion?(node) ? 1 : 0
+          base = assertion_method?(node) ? 1 : 0
           base + node.each_child_node.sum { |c| assertions_count(c) }
         end
       end

data/lib/rubocop/cop/minitest/unreachable_assertion.rb

@@ -30,11 +30,9 @@ module RuboCop
 
           last_node = body.begin_type? ? body.children.last : body
           return unless last_node.send_type?
+          return unless assertion_method?(last_node)
 
-          method_name = last_node.method_name
-          return unless assertion_method?(method_name)
-
-          add_offense(last_node, message: format(MSG, assertion_method: method_name))
+          add_offense(last_node, message: format(MSG, assertion_method: last_node.method_name))
         end
       end
     end

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -10,17 +10,6 @@ module RuboCop
 
       ASSERTION_PREFIXES = %w[assert refute].freeze
 
-      ASSERTION_METHODS = %i[
-        assert assert_empty assert_equal assert_in_delta assert_in_epsilon assert_includes assert_instance_of
-        assert_kind_of assert_match assert_nil assert_operator assert_output assert_path_exists assert_predicate
-        assert_raises assert_respond_to assert_same assert_send assert_silent assert_throws
-        refute refute_empty refute_equal refute_in_delta refute_in_epsilon refute_includes refute_instance_of
-        refute_kind_of refute_match refute_nil refute_operator refute_path_exists refute_predicate
-        refute_respond_to refute_same
-      ].freeze
-
-      FLUNK = 'flunk'
-
       LIFECYCLE_HOOK_METHODS = %i[
         before_setup
         setup
@@ -84,19 +73,18 @@ module RuboCop
             method_def.each_child_node(:send)
           end
 
-        send_nodes.select { |send_node| assertion?(send_node) }
+        send_nodes.select { |send_node| assertion_method?(send_node) }
       end
 
-      def assertion?(node)
-        node.send_type? &&
-          ASSERTION_PREFIXES.any? do |prefix|
-            method_name = node.method_name.to_s
-            method_name == FLUNK || method_name.start_with?(prefix)
-          end
-      end
+      def assertion_method?(node)
+        return false unless node.send_type?
+
+        ASSERTION_PREFIXES.any? do |prefix|
+          method_name = node.method_name
 
-      def assertion_method?(method_name)
-        method_name == FLUNK || ASSERTION_METHODS.include?(method_name)
+          # TODO: Remove the fllowing `to_s` since Ruby 2.7 that supports `Symbol#start_with?`.
+          method_name.to_s.start_with?(prefix) || node.method?(:flunk)
+        end
       end
 
       def lifecycle_hook_method?(node)

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.17.0'
+      STRING = '0.17.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/mkdocs.yml

@@ -1,7 +1,7 @@
 site_name: "A RuboCop extension focused on enforcing Minitest best practices and coding conventions."
 repo_url: https://github.com/rubocop/rubocop-minitest
 edit_uri: edit/master/legacy-docs/
-copyright: "Copyright © 2021 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
+copyright: "Copyright © 2022 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
 docs_dir: legacy-docs
 pages:
 - Home: index.md

data/relnotes/v0.17.1.md

@@ -0,0 +1,5 @@
+### Changes
+
+* [#158](https://github.com/rubocop/rubocop-minitest/pull/158): Make `Minitest/UnreachableAssertion` aware of `assert` and `refute` prefix methods. ([@koic][])
+
+[@koic]: https://github.com/koic

data/tasks/cops_documentation.rake

@@ -12,12 +12,12 @@ end
 
 task update_cops_documentation: :yard_for_generate_documentation do
   deps = ['Minitest']
-  CopsDocumentationGenerator.new(departments: deps).call
-end
 
-desc 'Generate docs of all cops departments (obsolete)'
-task :generate_cops_documentation do
-  puts 'Updating the documentation is now done automatically!'
+  # NOTE: Update `<<next>>` version for docs/modules/ROOT/pages/cops_minitest.adoc
+  # when running release tasks.
+  RuboCop::Minitest::Inject.defaults!
+
+  CopsDocumentationGenerator.new(departments: deps).call
 end
 
 desc 'Syntax check for the documentation comments'

data/tasks/cut_release.rake

@@ -39,7 +39,7 @@ namespace :cut_release do
 
     File.open('docs/antora.yml', 'w') do |f|
       f << antora_metadata.sub(
-        'version: master',
+        "version: 'master'",
         "version: '#{version_sans_patch(new_version)}'"
       )
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.17.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-22 00:00:00.000000000 Z
+date: 2022-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -152,6 +152,7 @@ files:
 - relnotes/v0.15.2.md
 - relnotes/v0.16.0.md
 - relnotes/v0.17.0.md
+- relnotes/v0.17.1.md
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
@@ -196,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.0.dev
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.