rubocop-minitest 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa7a9c739cc54955a9c7647d8d5442c18f7888acb54212da90598fbec357717b
-  data.tar.gz: 784f7adfaeb34d54fedeaedcadd528cdffb6c888569a1314082b2c93217b5f3f
+  metadata.gz: 95de9dbe9caf21c7034e137bdaf33e41000e9d418c70e889e3b108ae8aaff2bb
+  data.tar.gz: c58e39ff5277a4c511ba8c34a4378155efb185375edcba187f4c1eae8b44efbd
 SHA512:
-  metadata.gz: b7bf8ad7fa1be35b461ab54c2097ccd4c6fd320f1b15341c253f527099afeebee139feb33007f6b471309aaad6bb0f6f4534a52e32b2e3bc0f45344a4e5588ef
-  data.tar.gz: a73427443b2f4cb050f5e7893809f8026dbb41c4dc77461e6aa07fc13228e60f36a6bec7e893745eb14d911f143556003166028eb5abfcfea8f49b676ae50dbb
+  metadata.gz: 43a96338e7c17fab54a4e50d3f7cea66d52f18633f78f016987dc681e6aae197ec9899044dd310c7c0fe09859b7f861fa65bd4997112df1527ebc184f15f903d
+  data.tar.gz: 772dc16b3f51fd39c67618a49797f020765eafa6d18a6d74970950fc148ef774ef37c3771c055ff4921139ad7a7de1bb84615f6ba256933ff07008a9d624a7da

data/.rubocop.yml

@@ -15,6 +15,10 @@ AllCops:
 InternalAffairs/NodeMatcherDirective:
   Enabled: false
 
+# FIXME: Workaround for a false positive caused by this cop when using `bundle exec rake`.
+InternalAffairs/UndefinedConfig:
+  Enabled: false
+
 Naming/PredicateName:
   # Method define macros for dynamically generated method.
   MethodDefinitionMacros:
@@ -91,6 +95,3 @@ Naming/FileName:
 Metrics/ModuleLength:
   Exclude:
     - 'test/**/*.rb'
-
-Performance/ChainArrayAllocation:
-  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.15.1 (2021-09-26)
+
+### Bug fixes
+
+* [#143](https://github.com/rubocop/rubocop-minitest/issues/143): Fix an error for `Minitest/LiteralAsActualArgumentTest` when expected and actual arguments are literals. ([@koic][])
+
 ## 0.15.0 (2021-08-09)
 
 ### New features

data/Rakefile

@@ -24,12 +24,7 @@ Rake::TestTask.new do |t|
 end
 
 desc 'Run RuboCop over itself'
-RuboCop::RakeTask.new(:internal_investigation).tap do |task|
-  if RUBY_ENGINE == 'ruby' &&
-     RbConfig::CONFIG['host_os'] !~ /mswin|msys|mingw|cygwin|bccwin|wince|emc/
-    task.options = %w[--parallel]
-  end
-end
+RuboCop::RakeTask.new(:internal_investigation)
 
 task default: %i[
   documentation_syntax_check

data/docs/modules/ROOT/pages/cops_minitest.adoc

@@ -3,7 +3,7 @@
 == Minitest/AssertEmpty
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -35,7 +35,7 @@ assert_empty(object, 'message')
 == Minitest/AssertEmptyLiteral
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -62,7 +62,7 @@ assert_empty(object)
 == Minitest/AssertEqual
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -92,7 +92,7 @@ assert_equal("rubocop-minitest", actual)
 == Minitest/AssertInDelta
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -124,7 +124,7 @@ assert_in_delta(0.2, actual, 0.001, 'message')
 == Minitest/AssertIncludes
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -156,7 +156,7 @@ assert_includes(collection, object, 'message')
 == Minitest/AssertInstanceOf
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -188,7 +188,7 @@ assert_instance_of(Class, object, 'message')
 == Minitest/AssertKindOf
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -220,7 +220,7 @@ assert_kind_of(Class, object, 'message')
 == Minitest/AssertMatch
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -252,7 +252,7 @@ assert_match(matcher, string, 'message')
 == Minitest/AssertNil
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -286,7 +286,7 @@ assert_nil(actual, 'message')
 == Minitest/AssertOutput
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -318,7 +318,7 @@ assert_output(expected) { puts object.method }
 == Minitest/AssertPathExists
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -350,7 +350,7 @@ assert_path_exists(path, 'message')
 == Minitest/AssertRespondTo
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -384,7 +384,7 @@ assert_respond_to(self, :do_something)
 == Minitest/AssertSilent
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -414,7 +414,7 @@ assert_silent { puts object.do_something }
 == Minitest/AssertTruthy
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -446,7 +446,7 @@ assert(actual, 'message')
 == Minitest/AssertWithExpectedArgument
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | No
@@ -478,7 +478,7 @@ assert(foo, 'message')
 == Minitest/AssertionInLifecycleHook
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -511,7 +511,7 @@ end
 == Minitest/GlobalExpectations
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -545,7 +545,7 @@ _ { musts }.must_raise TypeError
 == Minitest/LiteralAsActualArgument
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -579,7 +579,7 @@ assert_equal [1, 2], foo, 'message'
 == Minitest/MultipleAssertions
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -630,7 +630,7 @@ end
 == Minitest/NoAssertions
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Disabled
 | Yes
@@ -662,7 +662,7 @@ end
 == Minitest/RefuteEmpty
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -694,7 +694,7 @@ refute_empty(object, 'message')
 == Minitest/RefuteEqual
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -725,7 +725,7 @@ refute_equal("rubocop-minitest", actual)
 == Minitest/RefuteFalse
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -760,7 +760,7 @@ refute(actual, 'message')
 == Minitest/RefuteInDelta
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -792,7 +792,7 @@ refute_in_delta(0.2, actual, 0.001, 'message')
 == Minitest/RefuteIncludes
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -824,7 +824,7 @@ refute_includes(collection, object, 'message')
 == Minitest/RefuteInstanceOf
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -856,7 +856,7 @@ refute_instance_of(Class, object, 'message')
 == Minitest/RefuteKindOf
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -888,7 +888,7 @@ refute_kind_of(Class, object, 'message')
 == Minitest/RefuteMatch
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -920,7 +920,7 @@ refute_match(matcher, string, 'message')
 == Minitest/RefuteNil
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -954,7 +954,7 @@ refute_nil(actual, 'message')
 == Minitest/RefutePathExists
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -986,7 +986,7 @@ refute_path_exists(path, 'message')
 == Minitest/RefuteRespondTo
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Enabled
 | Yes
@@ -1020,7 +1020,7 @@ refute_respond_to(self, :do_something)
 == Minitest/TestMethodName
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -1060,7 +1060,7 @@ end
 == Minitest/UnreachableAssertion
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes
@@ -1092,7 +1092,7 @@ assert_equal('foo', obj.bar)
 == Minitest/UnspecifiedException
 
 |===
-| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
 | Yes

data/lib/rubocop/cop/minitest/literal_as_actual_argument.rb

@@ -27,17 +27,16 @@ module RuboCop
         def on_send(node)
           return unless node.method?(:assert_equal)
 
-          actual = node.arguments[1]
+          expected, actual, message = *node.arguments
           return unless actual&.recursive_basic_literal?
+          return if expected.recursive_basic_literal?
 
           add_offense(all_arguments_range(node)) do |corrector|
-            autocorrect(corrector, node)
+            autocorrect(corrector, node, expected, actual, message)
           end
         end
 
-        def autocorrect(corrector, node)
-          expected, actual, message = *node.arguments
-
+        def autocorrect(corrector, node, expected, actual, message)
           new_actual_source = if actual.hash_type? && !actual.braces?
                                 "{#{actual.source}}"
                               else

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.15.0'
+      STRING = '0.15.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/relnotes/v0.15.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#143](https://github.com/rubocop/rubocop-minitest/issues/143): Fix an error for `Minitest/LiteralAsActualArgumentTest` when expected and actual arguments are literals. ([@koic][])
+
+[@koic]: https://github.com/koic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-09 00:00:00.000000000 Z
+date: 2021-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -143,6 +143,7 @@ files:
 - relnotes/v0.13.0.md
 - relnotes/v0.14.0.md
 - relnotes/v0.15.0.md
+- relnotes/v0.15.1.md
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
@@ -184,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.18
+rubygems_version: 3.3.0.dev
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.