rubocop-minitest 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2581fbadb9e19f8827cc513bb86e86b431295047c2f37401416793de014f1d52
-  data.tar.gz: 8dc80007c469db266b85d99e672a47e1f7c4c245dcbc713896232afc87a97818
+  metadata.gz: a7a721b7443b19d1ff86922a0500d12daa296622bee5dc17ddcc2bdbf943245e
+  data.tar.gz: 14616b62fce87850843091ed66d9f76281a31038fcbf78bc5ea99a2b38c5b7db
 SHA512:
-  metadata.gz: f9e6da24df8a6dbd427a26f00a09a4a14eed05fccfd6bfc8c31e9195237f999a3c822fda7ada6c64467d07f2542a981d1b7851e6bd2ab04cf4ac4c7c343bdb47
-  data.tar.gz: debd9d0030d135360d6019e85cfdd5dd090ed50781f3c68cf4b8687f6e7ac8dc917124b866298159858fe359a1017f177b61269b310ac5aed76b8dade6577f93
+  metadata.gz: bb0913607602b41d7c05e9ca5228b3dcecdd44ea10a7b5adcfb407b9c78801aa3f5d160dba9f2a629f95377c3d12001b68aac3b08cd3f44fa708255247989c71
+  data.tar.gz: 56a97c8ff0938d66b565b3578c5c698c85188bc7130fcf3ac7955df466b5c48a0abbed8ace45af2ea2c66aaa1f2635aaad6fb02de1f294da4a710e983aec1b94

data/.circleci/config.yml

@@ -38,9 +38,6 @@ workflows:
   build:
     jobs:
       - documentation-checks
-      - rake_default:
-          name: Ruby 2.4
-          image: circleci/ruby:2.4
       - rake_default:
           name: Ruby 2.5
           image: circleci/ruby:2.5

data/.rubocop.yml

@@ -9,7 +9,7 @@ require:
 
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
   SuggestExtensions: false
 
 InternalAffairs/NodeMatcherDirective:

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## master (unreleased)
 
+## 0.12.0 (2021-04-23)
+
+### New features
+
+* [#124](https://github.com/rubocop/rubocop-minitest/pull/124): Add new `Minitest/NoAssertions` cop. ([@ghiculescu][])
+
+### Changes
+
+* [#129](https://github.com/rubocop/rubocop-minitest/pull/129): Drop Ruby 2.4 support. ([@koic][])
+
 ## 0.11.1 (2021-03-31)
 
 ### Changes

data/config/default.yml

@@ -118,6 +118,11 @@ Minitest/MultipleAssertions:
   VersionAdded: '0.10'
   Max: 3
 
+Minitest/NoAssertions:
+  Description: 'This cop checks for at least one assertion (or flunk) in tests.'
+  Enabled: false
+  VersionAdded: '0.12'
+
 Minitest/RefuteEmpty:
   Description: 'This cop enforces to use `refute_empty` instead of using `refute(object.empty?)`.'
   StyleGuide: 'https://minitest.rubystyle.guide#refute-empty'

data/docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-minitest
 title: RuboCop Minitest
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: '0.11'
+version: '0.12'
 nav:
 - modules/ROOT/nav.adoc

data/docs/modules/ROOT/pages/cops.adoc

@@ -32,6 +32,7 @@ based on the https://minitest.rubystyle.guide/[Minitest Style Guide].
 * xref:cops_minitest.adoc#minitestglobalexpectations[Minitest/GlobalExpectations]
 * xref:cops_minitest.adoc#minitestliteralasactualargument[Minitest/LiteralAsActualArgument]
 * xref:cops_minitest.adoc#minitestmultipleassertions[Minitest/MultipleAssertions]
+* xref:cops_minitest.adoc#minitestnoassertions[Minitest/NoAssertions]
 * xref:cops_minitest.adoc#minitestrefuteempty[Minitest/RefuteEmpty]
 * xref:cops_minitest.adoc#minitestrefuteequal[Minitest/RefuteEqual]
 * xref:cops_minitest.adoc#minitestrefutefalse[Minitest/RefuteFalse]

data/docs/modules/ROOT/pages/cops_minitest.adoc

@@ -625,6 +625,38 @@ end
 | Integer
 |===
 
+== Minitest/NoAssertions
+
+|===
+| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+
+| Disabled
+| Yes
+| No
+| 0.12
+| -
+|===
+
+This cop checks if test cases contain any assertion calls.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+class FooTest < Minitest::Test
+  def test_the_truth
+  end
+end
+
+# good
+class FooTest < Minitest::Test
+  def test_the_truth
+    assert true
+  end
+end
+----
+
 == Minitest/RefuteEmpty
 
 |===

data/lib/rubocop/cop/minitest/assert_empty.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   assert_empty(object)
       #   assert_empty(object, 'message')
       #
-      class AssertEmpty < Cop
+      class AssertEmpty < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :empty?

data/lib/rubocop/cop/minitest/assert_empty_literal.rb

@@ -14,8 +14,9 @@ module RuboCop
       #   # good
       #   assert_empty(object)
       #
-      class AssertEmptyLiteral < Cop
+      class AssertEmptyLiteral < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Prefer using `assert_empty(%<arguments>s)` over ' \
               '`assert_equal(%<literal>s, %<arguments>s)`.'
@@ -32,15 +33,9 @@ module RuboCop
             args = matchers.map(&:source).join(', ')
 
             message = format(MSG, literal: literal.source, arguments: args)
-            add_offense(node, message: message)
-          end
-        end
-
-        def autocorrect(node)
-          assert_equal_with_empty_literal(node) do |_literal, matchers|
-            object = matchers.first
+            add_offense(node, message: message) do |corrector|
+              object = matchers.first
 
-            lambda do |corrector|
               corrector.replace(node.loc.selector, 'assert_empty')
               corrector.replace(first_and_second_arguments_range(node), object.source)
             end

data/lib/rubocop/cop/minitest/assert_equal.rb

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   assert_equal("rubocop-minitest", actual)
       #
-      class AssertEqual < Cop
+      class AssertEqual < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :==, preferred_method: :assert_equal

data/lib/rubocop/cop/minitest/assert_in_delta.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   assert_in_delta(0.2, actual)
       #   assert_in_delta(0.2, actual, 0.001, 'message')
       #
-      class AssertInDelta < Cop
+      class AssertInDelta < Base
         include InDeltaMixin
+        extend AutoCorrector
 
         RESTRICT_ON_SEND = %i[assert_equal].freeze
 

data/lib/rubocop/cop/minitest/assert_includes.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   assert_includes(collection, object)
       #   assert_includes(collection, object, 'message')
       #
-      class AssertIncludes < Cop
+      class AssertIncludes < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :include?, preferred_method: :assert_includes

data/lib/rubocop/cop/minitest/assert_instance_of.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   assert_instance_of(Class, object)
       #   assert_instance_of(Class, object, 'message')
       #
-      class AssertInstanceOf < Cop
+      class AssertInstanceOf < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :instance_of?, inverse: true

data/lib/rubocop/cop/minitest/assert_kind_of.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   assert_kind_of(Class, object)
       #   assert_kind_of(Class, object, 'message')
       #
-      class AssertKindOf < Cop
+      class AssertKindOf < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :kind_of?, inverse: true

data/lib/rubocop/cop/minitest/assert_match.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   assert_match(regex, string)
       #   assert_match(matcher, string, 'message')
       #
-      class AssertMatch < Cop
+      class AssertMatch < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :match

data/lib/rubocop/cop/minitest/assert_nil.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   assert_nil(actual)
       #   assert_nil(actual, 'message')
       #
-      class AssertNil < Cop
+      class AssertNil < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Prefer using `assert_nil(%<arguments>s)` over ' \
               '`assert_equal(nil, %<arguments>s)`.'
@@ -32,17 +33,9 @@ module RuboCop
 
             arguments = [actual.source, message&.source].compact.join(', ')
 
-            add_offense(node, message: format(MSG, arguments: arguments))
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            assert_equal_with_nil(node) do |actual|
+            add_offense(node, message: format(MSG, arguments: arguments)) do |corrector|
               corrector.replace(node.loc.selector, 'assert_nil')
-              corrector.replace(
-                first_and_second_arguments_range(node), actual.source
-              )
+              corrector.replace(first_and_second_arguments_range(node), actual.source)
             end
           end
         end

data/lib/rubocop/cop/minitest/assert_output.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   # good
       #   assert_output(expected) { puts object.method }
       #
-      class AssertOutput < Cop
+      class AssertOutput < Base
         include MinitestExplorationHelpers
 
         MSG = 'Use `assert_output` instead of mutating %<name>s.'

data/lib/rubocop/cop/minitest/assert_path_exists.rb

@@ -15,7 +15,9 @@ module RuboCop
       #   assert_path_exists(path)
       #   assert_path_exists(path, 'message')
       #
-      class AssertPathExists < Cop
+      class AssertPathExists < Base
+        extend AutoCorrector
+
         MSG = 'Prefer using `%<good_method>s` over `%<bad_method>s`.'
         RESTRICT_ON_SEND = %i[assert].freeze
 
@@ -32,17 +34,8 @@ module RuboCop
             good_method = build_good_method(path, failure_message)
             message = format(MSG, good_method: good_method, bad_method: node.source)
 
-            add_offense(node, message: message)
-          end
-        end
-
-        def autocorrect(node)
-          assert_file_exists(node) do |path, failure_message|
-            failure_message = failure_message.first
-
-            lambda do |corrector|
-              replacement = build_good_method(path, failure_message)
-              corrector.replace(node, replacement)
+            add_offense(node, message: message) do |corrector|
+              corrector.replace(node, good_method)
             end
           end
         end

data/lib/rubocop/cop/minitest/assert_respond_to.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   assert_respond_to(object, :do_something, 'message')
       #   assert_respond_to(self, :do_something)
       #
-      class AssertRespondTo < Cop
+      class AssertRespondTo < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :respond_to?

data/lib/rubocop/cop/minitest/assert_silent.rb

@@ -13,7 +13,9 @@ module RuboCop
       #   # good
       #   assert_silent { puts object.do_something }
       #
-      class AssertSilent < Cop
+      class AssertSilent < Base
+        extend AutoCorrector
+
         MSG = 'Prefer using `assert_silent` over `assert_output("", "")`.'
 
         def_node_matcher :assert_silent_candidate?, <<~PATTERN
@@ -25,12 +27,12 @@ module RuboCop
         PATTERN
 
         def on_block(node)
-          add_offense(node.send_node) if assert_silent_candidate?(node)
-        end
+          return unless assert_silent_candidate?(node)
+
+          send_node = node.send_node
 
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node, 'assert_silent')
+          add_offense(send_node) do |corrector|
+            corrector.replace(send_node, 'assert_silent')
           end
         end
 

data/lib/rubocop/cop/minitest/assert_truthy.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   assert(actual)
       #   assert(actual, 'message')
       #
-      class AssertTruthy < Cop
+      class AssertTruthy < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Prefer using `assert(%<arguments>s)` over ' \
               '`assert_equal(true, %<arguments>s)`.'
@@ -32,17 +33,9 @@ module RuboCop
 
             arguments = [actual.source, message&.source].compact.join(', ')
 
-            add_offense(node, message: format(MSG, arguments: arguments))
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            assert_equal_with_truthy(node) do |actual|
+            add_offense(node, message: format(MSG, arguments: arguments)) do |corrector|
               corrector.replace(node.loc.selector, 'assert')
-              corrector.replace(
-                first_and_second_arguments_range(node), actual.source
-              )
+              corrector.replace(first_and_second_arguments_range(node), actual.source)
             end
           end
         end

data/lib/rubocop/cop/minitest/assert_with_expected_argument.rb

@@ -19,7 +19,7 @@ module RuboCop
       #   assert_equal(expected, actual)
       #   assert(foo, 'message')
       #
-      class AssertWithExpectedArgument < Cop
+      class AssertWithExpectedArgument < Base
         MSG = 'Did you mean to use `assert_equal(%<arguments>s)`?'
         RESTRICT_ON_SEND = %i[assert].freeze
 

data/lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb

@@ -20,7 +20,7 @@ module RuboCop
       #     end
       #   end
       #
-      class AssertionInLifecycleHook < Cop
+      class AssertionInLifecycleHook < Base
         include MinitestExplorationHelpers
 
         MSG = 'Do not use `%<assertion>s` in `%<hook>s` hook.'

data/lib/rubocop/cop/minitest/global_expectations.rb

@@ -16,7 +16,9 @@ module RuboCop
       #   _(musts).must_equal expected_musts
       #   _(wonts).wont_match expected_wonts
       #   _ { musts }.must_raise TypeError
-      class GlobalExpectations < Cop
+      class GlobalExpectations < Base
+        extend AutoCorrector
+
         MSG = 'Use `%<preferred>s` instead.'
 
         VALUE_MATCHERS = %i[
@@ -64,13 +66,8 @@ module RuboCop
           return unless value_global_expectation?(node) || block_global_expectation?(node)
 
           message = format(MSG, preferred: preferred_receiver(node))
-          add_offense(node, location: node.receiver.source_range, message: message)
-        end
-
-        def autocorrect(node)
-          return unless value_global_expectation?(node) || block_global_expectation?(node)
 
-          lambda do |corrector|
+          add_offense(node.receiver.source_range, message: message) do |corrector|
             receiver = node.receiver.source_range
 
             if BLOCK_MATCHERS.include?(node.method_name)

data/lib/rubocop/cop/minitest/literal_as_actual_argument.rb

@@ -17,8 +17,9 @@ module RuboCop
       #   assert_equal [1, 2], foo
       #   assert_equal [1, 2], foo, 'message'
       #
-      class LiteralAsActualArgument < Cop
+      class LiteralAsActualArgument < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Replace the literal with the first argument.'
         RESTRICT_ON_SEND = %i[assert_equal].freeze
@@ -27,25 +28,24 @@ module RuboCop
           return unless node.method?(:assert_equal)
 
           actual = node.arguments[1]
-          return unless actual
+          return unless actual&.recursive_basic_literal?
 
-          add_offense(node, location: all_arguments_range(node)) if actual.recursive_basic_literal?
+          add_offense(all_arguments_range(node)) do |corrector|
+            autocorrect(corrector, node)
+          end
         end
 
-        def autocorrect(node)
+        def autocorrect(corrector, node)
           expected, actual, message = *node.arguments
 
-          lambda do |corrector|
-            new_actual_source =
-              if actual.hash_type? && !actual.braces?
-                "{#{actual.source}}"
-              else
-                actual.source
-              end
-            arguments = [new_actual_source, expected.source, message&.source].compact.join(', ')
+          new_actual_source = if actual.hash_type? && !actual.braces?
+                                "{#{actual.source}}"
+                              else
+                                actual.source
+                              end
+          arguments = [new_actual_source, expected.source, message&.source].compact.join(', ')
 
-            corrector.replace(node, "assert_equal(#{arguments})")
-          end
+          corrector.replace(node, "assert_equal(#{arguments})")
         end
       end
     end

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -26,7 +26,7 @@ module RuboCop
       #     end
       #   end
       #
-      class MultipleAssertions < Cop
+      class MultipleAssertions < Base
         include ConfigurableMax
         include MinitestExplorationHelpers
 
@@ -43,7 +43,7 @@ module RuboCop
             self.max = assertions_count
 
             message = format(MSG, total: assertions_count, max: max_assertions)
-            add_offense(node, location: :name, message: message)
+            add_offense(node.loc.name, message: message)
           end
         end
 

data/lib/rubocop/cop/minitest/no_assertions.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop checks if test cases contain any assertion calls.
+      #
+      # @example
+      #   # bad
+      #   class FooTest < Minitest::Test
+      #     def test_the_truth
+      #     end
+      #   end
+      #
+      #   # good
+      #   class FooTest < Minitest::Test
+      #     def test_the_truth
+      #       assert true
+      #     end
+      #   end
+      #
+      class NoAssertions < Base
+        include MinitestExplorationHelpers
+
+        MSG = 'Test case has no assertions.'
+
+        def on_class(class_node)
+          return unless test_class?(class_node)
+
+          test_cases(class_node).each do |node|
+            assertions_count = assertions_count(node)
+
+            next if assertions_count.positive?
+
+            add_offense(node.block_type? ? node.loc.expression : node.loc.name)
+          end
+        end
+
+        private
+
+        def assertions_count(node)
+          base = assertion?(node) ? 1 : 0
+          base + node.each_child_node.sum { |c| assertions_count(c) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/refute_empty.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   refute_empty(object)
       #   refute_empty(object, 'message')
       #
-      class RefuteEmpty < Cop
+      class RefuteEmpty < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :empty?

data/lib/rubocop/cop/minitest/refute_equal.rb

@@ -14,8 +14,9 @@ module RuboCop
       #   # good
       #   refute_equal("rubocop-minitest", actual)
       #
-      class RefuteEqual < Cop
+      class RefuteEqual < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Prefer using `refute_equal(%<preferred>s)` over ' \
               '`assert(%<over>s)`.'
@@ -29,13 +30,10 @@ module RuboCop
           preferred, over = process_not_equal(node)
           return unless preferred && over
 
-          message = format(MSG, preferred: preferred, over: over)
-          add_offense(node, message: message)
-        end
+          assert_not_equal(node) do |_, expected, actual|
+            message = format(MSG, preferred: preferred, over: over)
 
-        def autocorrect(node)
-          lambda do |corrector|
-            assert_not_equal(node) do |_, expected, actual|
+            add_offense(node, message: message) do |corrector|
               corrector.replace(node.loc.selector, 'refute_equal')
 
               replacement = [expected, actual].map(&:source).join(', ')

data/lib/rubocop/cop/minitest/refute_false.rb

@@ -18,8 +18,9 @@ module RuboCop
       #   refute(actual)
       #   refute(actual, 'message')
       #
-      class RefuteFalse < Cop
+      class RefuteFalse < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG_FOR_ASSERT_EQUAL = 'Prefer using `refute(%<arguments>s)` over ' \
               '`assert_equal(false, %<arguments>s)`.'
@@ -36,38 +37,29 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          actual, rest_receiver_arg = assert_equal_with_false(node) ||
-                                      assert_with_bang_argument(node)
+          actual, rest_receiver_arg = assert_equal_with_false(node) || assert_with_bang_argument(node)
           return unless actual
 
           message_argument = rest_receiver_arg.first
 
           arguments = [actual.source, message_argument&.source].compact.join(', ')
 
-          message = if node.method?(:assert_equal)
-                      MSG_FOR_ASSERT_EQUAL
-                    else
-                      MSG_FOR_ASSERT
-                    end
+          message = node.method?(:assert_equal) ? MSG_FOR_ASSERT_EQUAL : MSG_FOR_ASSERT
 
-          add_offense(node, message: format(message, arguments: arguments))
+          add_offense(node, message: format(message, arguments: arguments)) do |corrector|
+            autocorrect(corrector, node, actual)
+          end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.loc.selector, 'refute')
+        private
 
-            assert_equal_with_false(node) do |actual|
-              corrector.replace(
-                first_and_second_arguments_range(node), actual.source
-              )
-            end
+        def autocorrect(corrector, node, actual)
+          corrector.replace(node.loc.selector, 'refute')
 
-            assert_with_bang_argument(node) do |actual|
-              corrector.replace(
-                first_argument_range(node), actual.source
-              )
-            end
+          if node.method?(:assert_equal)
+            corrector.replace(first_and_second_arguments_range(node), actual.source)
+          else
+            corrector.replace(first_argument_range(node), actual.source)
           end
         end
       end

data/lib/rubocop/cop/minitest/refute_in_delta.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   refute_in_delta(0.2, actual)
       #   refute_in_delta(0.2, actual, 0.001, 'message')
       #
-      class RefuteInDelta < Cop
+      class RefuteInDelta < Base
         include InDeltaMixin
+        extend AutoCorrector
 
         RESTRICT_ON_SEND = %i[refute_equal].freeze
 

data/lib/rubocop/cop/minitest/refute_includes.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   refute_includes(collection, object)
       #   refute_includes(collection, object, 'message')
       #
-      class RefuteIncludes < Cop
+      class RefuteIncludes < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :include?, preferred_method: :refute_includes

data/lib/rubocop/cop/minitest/refute_instance_of.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   refute_instance_of(Class, object)
       #   refute_instance_of(Class, object, 'message')
       #
-      class RefuteInstanceOf < Cop
+      class RefuteInstanceOf < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :instance_of?, inverse: true

data/lib/rubocop/cop/minitest/refute_kind_of.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   refute_kind_of(Class, object)
       #   refute_kind_of(Class, object, 'message')
       #
-      class RefuteKindOf < Cop
+      class RefuteKindOf < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :kind_of?, inverse: true

data/lib/rubocop/cop/minitest/refute_match.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   refute_match(matcher, string)
       #   refute_match(matcher, string, 'message')
       #
-      class RefuteMatch < Cop
+      class RefuteMatch < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :match

data/lib/rubocop/cop/minitest/refute_nil.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   refute_nil(actual)
       #   refute_nil(actual, 'message')
       #
-      class RefuteNil < Cop
+      class RefuteNil < Base
         include ArgumentRangeHelper
+        extend AutoCorrector
 
         MSG = 'Prefer using `refute_nil(%<arguments>s)` over ' \
               '`refute_equal(nil, %<arguments>s)`.'
@@ -32,13 +33,7 @@ module RuboCop
 
             arguments = [actual.source, message&.source].compact.join(', ')
 
-            add_offense(node, message: format(MSG, arguments: arguments))
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            refute_equal_with_nil(node) do |actual|
+            add_offense(node, message: format(MSG, arguments: arguments)) do |corrector|
               corrector.replace(node.loc.selector, 'refute_nil')
               corrector.replace(
                 first_and_second_arguments_range(node), actual.source

data/lib/rubocop/cop/minitest/refute_path_exists.rb

@@ -15,7 +15,9 @@ module RuboCop
       #   refute_path_exists(path)
       #   refute_path_exists(path, 'message')
       #
-      class RefutePathExists < Cop
+      class RefutePathExists < Base
+        extend AutoCorrector
+
         MSG = 'Prefer using `%<good_method>s` over `%<bad_method>s`.'
         RESTRICT_ON_SEND = %i[refute].freeze
 
@@ -32,17 +34,8 @@ module RuboCop
             good_method = build_good_method(path, failure_message)
             message = format(MSG, good_method: good_method, bad_method: node.source)
 
-            add_offense(node, message: message)
-          end
-        end
-
-        def autocorrect(node)
-          refute_file_exists(node) do |path, failure_message|
-            failure_message = failure_message.first
-
-            lambda do |corrector|
-              replacement = build_good_method(path, failure_message)
-              corrector.replace(node, replacement)
+            add_offense(node, message: message) do |corrector|
+              corrector.replace(node, good_method)
             end
           end
         end

data/lib/rubocop/cop/minitest/refute_respond_to.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   refute_respond_to(object, :do_something, 'message')
       #   refute_respond_to(self, :do_something)
       #
-      class RefuteRespondTo < Cop
+      class RefuteRespondTo < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :respond_to?

data/lib/rubocop/cop/minitest/test_method_name.rb

@@ -27,9 +27,10 @@ module RuboCop
       #     end
       #   end
       #
-      class TestMethodName < Cop
+      class TestMethodName < Base
         include MinitestExplorationHelpers
         include DefNode
+        extend AutoCorrector
 
         MSG = 'Test method name should start with `test_` prefix.'
 
@@ -37,13 +38,13 @@ module RuboCop
           return unless test_class?(class_node)
 
           class_elements(class_node).each do |node|
-            add_offense(node, location: :name) if offense?(node)
-          end
-        end
+            next unless offense?(node)
+
+            test_method_name = node.loc.name
 
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.loc.name, "test_#{node.method_name}")
+            add_offense(test_method_name) do |corrector|
+              corrector.replace(test_method_name, "test_#{node.method_name}")
+            end
           end
         end
 

data/lib/rubocop/cop/minitest/unspecified_exception.rb

@@ -14,7 +14,7 @@ module RuboCop
       #   assert_raises(FooException) { raise FooException }
       #   assert_raises(FooException, 'This should have raised') { raise FooException }
       #
-      class UnspecifiedException < Cop
+      class UnspecifiedException < Base
         MSG = 'Specify the exception being captured.'
 
         def on_block(block_node)

data/lib/rubocop/cop/minitest_cops.rb

@@ -23,6 +23,7 @@ require_relative 'minitest/assert_truthy'
 require_relative 'minitest/global_expectations'
 require_relative 'minitest/literal_as_actual_argument'
 require_relative 'minitest/multiple_assertions'
+require_relative 'minitest/no_assertions'
 require_relative 'minitest/refute_empty'
 require_relative 'minitest/refute_false'
 require_relative 'minitest/refute_equal'

data/lib/rubocop/cop/mixin/in_delta_mixin.rb

@@ -9,24 +9,14 @@ module RuboCop
       def on_send(node)
         equal_floats_call(node) do |expected, actual, message|
           message = message.first
+          good_method = build_good_method(expected, actual, message)
 
           if expected.float_type? || actual.float_type?
-            message = format(MSG,
-                             good_method: build_good_method(expected, actual, message),
-                             bad_method: node.source)
+            message = format(MSG, good_method: good_method, bad_method: node.source)
 
-            add_offense(node, message: message)
-          end
-        end
-      end
-
-      def autocorrect(node)
-        equal_floats_call(node) do |expected, actual, message|
-          message = message.first
-          replacement = build_good_method(expected, actual, message)
-
-          lambda do |corrector|
-            corrector.replace(node, replacement)
+            add_offense(node, message: message) do |corrector|
+              corrector.replace(node, good_method)
+            end
           end
         end
       end

data/lib/rubocop/cop/mixin/minitest_cop_rule.rb

@@ -26,6 +26,7 @@ module RuboCop
 
         class_eval(<<~RUBY, __FILE__, __LINE__ + 1)
           include ArgumentRangeHelper
+          extend AutoCorrector
 
           MSG = 'Prefer using `#{preferred_method}(%<new_arguments>s)` over ' \
                 '`#{assertion_method}(%<original_arguments>s)`.'
@@ -36,23 +37,21 @@ module RuboCop
             return unless (arguments = peel_redundant_parentheses_from(node.arguments))
             return unless arguments.first.respond_to?(:method?) && arguments.first.method?(:#{target_method})
 
-            add_offense(node, message: offense_message(arguments))
+            add_offense(node, message: offense_message(arguments)) do |corrector|
+              autocorrect(corrector, node, arguments)
+            end
           end
 
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.replace(node.loc.selector, '#{preferred_method}')
-
-              arguments = peel_redundant_parentheses_from(node.arguments)
+          def autocorrect(corrector, node, arguments)
+            corrector.replace(node.loc.selector, '#{preferred_method}')
 
-              new_arguments = new_arguments(arguments).join(', ')
+            new_arguments = new_arguments(arguments).join(', ')
 
-              if enclosed_in_redundant_parentheses?(node)
-                new_arguments = '(' + new_arguments + ')'
-              end
-
-              corrector.replace(first_argument_range(node), new_arguments)
+            if enclosed_in_redundant_parentheses?(node)
+              new_arguments = '(' + new_arguments + ')'
             end
+
+            corrector.replace(first_argument_range(node), new_arguments)
           end
 
           private

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -19,6 +19,8 @@ module RuboCop
         refute_respond_to refute_same
       ].freeze
 
+      FLUNK = 'flunk'
+
       LIFECYCLE_HOOK_METHODS = %i[
         before_setup
         setup
@@ -42,8 +44,8 @@ module RuboCop
       end
 
       def test_cases(class_node)
-        class_def_nodes(class_node)
-          .select { |def_node| test_case_name?(def_node.method_name) }
+        (class_def_nodes(class_node).select { |def_node| test_case_name?(def_node.method_name) }) +
+          test_method_calls(class_node)
       end
 
       def lifecycle_hooks(class_node)
@@ -62,6 +64,12 @@ module RuboCop
         end
       end
 
+      # support https://api.rubyonrails.org/classes/ActiveSupport/Testing/Declarative.html
+      def test_method_calls(class_node)
+        block_nodes = class_node.each_descendant(:block)
+        block_nodes.select { |block_node| block_node.method?(:test) }
+      end
+
       def test_case_name?(name)
         name.to_s.start_with?('test_')
       end
@@ -82,11 +90,14 @@ module RuboCop
 
       def assertion?(node)
         node.send_type? &&
-          ASSERTION_PREFIXES.any? { |prefix| node.method_name.to_s.start_with?(prefix) }
+          ASSERTION_PREFIXES.any? do |prefix|
+            method_name = node.method_name.to_s
+            method_name == FLUNK || method_name.start_with?(prefix)
+          end
       end
 
       def assertion_method?(method_name)
-        ASSERTION_METHODS.include?(method_name)
+        method_name == FLUNK || ASSERTION_METHODS.include?(method_name)
       end
 
       def lifecycle_hook_method?(node)

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.11.1'
+      STRING = '0.12.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/relnotes/v0.12.0.md

@@ -0,0 +1,10 @@
+### New features
+
+* [#124](https://github.com/rubocop/rubocop-minitest/pull/124): Add new `Minitest/NoAssertions` cop. ([@ghiculescu][])
+
+### Changes
+
+* [#129](https://github.com/rubocop/rubocop-minitest/pull/129): Drop Ruby 2.4 support. ([@koic][])
+
+[@ghiculescu]: https://github.com/ghiculescu
+[@koic]: https://github.com/koic

data/rubocop-minitest.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   DESCRIPTION
   spec.license = 'MIT'
 
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = '>= 2.5.0'
   spec.metadata = {
     'homepage_uri' => 'https://docs.rubocop.org/rubocop-minitest/',
     'changelog_uri' => 'https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md',

data/tasks/cops_documentation.rake

@@ -46,17 +46,15 @@ task documentation_syntax_check: :yard_for_generate_documentation do
     end
 
     examples.to_a.each do |example|
-      begin
-        buffer = Parser::Source::Buffer.new('<code>', 1)
-        buffer.source = example.text
-        parser = Parser::Ruby25.new(RuboCop::AST::Builder.new)
-        parser.diagnostics.all_errors_are_fatal = true
-        parser.parse(buffer)
-      rescue Parser::SyntaxError => e
-        path = example.object.file
-        puts "#{path}: Syntax Error in an example. #{e}"
-        ok = false
-      end
+      buffer = Parser::Source::Buffer.new('<code>', 1)
+      buffer.source = example.text
+      parser = Parser::Ruby25.new(RuboCop::AST::Builder.new)
+      parser.diagnostics.all_errors_are_fatal = true
+      parser.parse(buffer)
+    rescue Parser::SyntaxError => e
+      path = example.object.file
+      puts "#{path}: Syntax Error in an example. #{e}"
+      ok = false
     end
   end
   abort unless ok

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-03-30 00:00:00.000000000 Z
+date: 2021-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -105,6 +105,7 @@ files:
 - lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/literal_as_actual_argument.rb
 - lib/rubocop/cop/minitest/multiple_assertions.rb
+- lib/rubocop/cop/minitest/no_assertions.rb
 - lib/rubocop/cop/minitest/refute_empty.rb
 - lib/rubocop/cop/minitest/refute_equal.rb
 - lib/rubocop/cop/minitest/refute_false.rb
@@ -135,6 +136,7 @@ files:
 - relnotes/v0.10.3.md
 - relnotes/v0.11.0.md
 - relnotes/v0.11.1.md
+- relnotes/v0.12.0.md
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
@@ -159,7 +161,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.11
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.12
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
 post_install_message:
 rdoc_options: []
@@ -169,7 +171,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="