rubocop-minitest 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ad49b7b1f0f0d916cb20400f58ea616d13663e99a57719d9b4a8a373a859a5d
-  data.tar.gz: c69990256d72a503f7bf072273fe077f7c2eea32fd6c7f13b2f2fe83f18c8780
+  metadata.gz: 578c35f660ca4c19f2a5d9864cb79eb0092923999c6d4e36ced55680ea7c0789
+  data.tar.gz: 1ba667604ca929938ac8a13754728eb879bb7e6fe09d48475779bc8a2c05c2b0
 SHA512:
-  metadata.gz: c6899f78263d3d2728d5f0074d36c6813b8392d910524193f871ef1313af59fc78270ddb7ffa8b5b11c83c6c6f9bc6f0a8e57203dd54ffb3d81f1b036b025913
-  data.tar.gz: c402e470711d7432317c48c19c64e3b27c701855ceea1557abcf8418e6dd5ecfa33b0433372f9a73fa58ab956989aed7fbdb6b8f227e16b32272d9813d29c5d3
+  metadata.gz: 1328f2b45769ce5020394625744839ab2658442c0c1e14dc07a98bd26826064c623b5ba0106b93a2ba40a4b6052110b84233d3ea9ff71c5334fd790bdc107965
+  data.tar.gz: 8d815f7813ce9dd261ad72dbf39a741456a504a04d1dd01f986ad96ad3da26d1c095541ac0a8b6eeaadb4945a02321664bdf9e70e02c028a4dfbe70c354d40db

data/.circleci/config.yml

@@ -50,6 +50,9 @@ workflows:
       - rake_default:
           name: Ruby 2.7
           image: circleci/ruby:2.7
+      - rake_default:
+          name: Ruby 3.0
+          image: circleci/ruby:3.0
       - rake_default:
           name: Ruby HEAD
           image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build

data/CHANGELOG.md

@@ -2,11 +2,17 @@
 
 ## master (unreleased)
 
+## 0.10.3 (2021-01-12)
+
+### Bug fixes
+
+* [#115](https://github.com/rubocop-hq/rubocop-minitest/issues/115): Fix a false positive for `Minitest/TestMethodName` for when defining test method has an argument, and test method without assertion methods. ([@koic][])
+
 ## 0.10.2 (2020-12-27)
 
 ### Bug fixes
 
-* [#113](https://github.com/rubocop-hq/rubocop-minitest/issues/113): This PR fixes an error for `Minitest/AssertEqual` and some cops when using `assert` with block argument. ([@koic][])
+* [#113](https://github.com/rubocop-hq/rubocop-minitest/issues/113): Fix an error for `Minitest/AssertEqual` and some cops when using `assert` with block argument. ([@koic][])
 
 ## 0.10.1 (2020-07-25)
 

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019-2020 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
+Copyright (c) 2019-2021 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/docs/modules/ROOT/pages/cops_minitest.adoc

@@ -962,6 +962,7 @@ refute_respond_to(self, :do_something)
 |===
 
 This cop enforces that test method names start with `test_` prefix.
+It aims to prevent tests that aren't executed by forgetting to start test method name with `test_`.
 
 === Examples
 
@@ -980,6 +981,12 @@ class FooTest < Minitest::Test
     assert_equal 42, do_something
   end
 end
+
+# good
+class FooTest < Minitest::Test
+  def helper_method(argument)
+  end
+end
 ----
 
 == Minitest/UnspecifiedException

data/lib/rubocop/cop/minitest/test_method_name.rb

@@ -4,6 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # This cop enforces that test method names start with `test_` prefix.
+      # It aims to prevent tests that aren't executed by forgetting to start test method name with `test_`.
       #
       # @example
       #   # bad
@@ -20,6 +21,12 @@ module RuboCop
       #     end
       #   end
       #
+      #   # good
+      #   class FooTest < Minitest::Test
+      #     def helper_method(argument)
+      #     end
+      #   end
+      #
       class TestMethodName < Cop
         include MinitestExplorationHelpers
         include DefNode
@@ -54,7 +61,9 @@ module RuboCop
         end
 
         def offense?(node)
-          public?(node) && !test_method_name?(node) && !lifecycle_hook_method?(node)
+          return false if node.each_child_node(:send).none? { |send_node| assertion_method?(send_node.method_name) }
+
+          public?(node) && node.arguments.empty? && !test_method_name?(node) && !lifecycle_hook_method?(node)
         end
 
         def public?(node)

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -10,6 +10,15 @@ module RuboCop
 
       ASSERTION_PREFIXES = %w[assert refute].freeze
 
+      ASSERTION_METHODS = %i[
+        assert assert_empty assert_equal assert_in_delta assert_in_epsilon assert_includes assert_instance_of
+        assert_kind_of assert_match assert_nil assert_operator assert_output assert_path_exists assert_predicate
+        assert_raises assert_respond_to assert_same assert_send assert_silent assert_throws
+        refute refute_empty refute_equal refute_in_delta refute_in_epsilon refute_includes refute_instance_of
+        refute_kind_of refute_match refute_nil refute_operator refute_path_exists refute_predicate
+        refute_respond_to refute_same
+      ].freeze
+
       LIFECYCLE_HOOK_METHODS = %i[
         before_setup
         setup
@@ -76,6 +85,10 @@ module RuboCop
           ASSERTION_PREFIXES.any? { |prefix| node.method_name.to_s.start_with?(prefix) }
       end
 
+      def assertion_method?(method_name)
+        ASSERTION_METHODS.include?(method_name)
+      end
+
       def lifecycle_hook_method?(node)
         node.def_type? && LIFECYCLE_HOOK_METHODS.include?(node.method_name)
       end

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.10.2'
+      STRING = '0.10.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/mkdocs.yml

@@ -1,7 +1,7 @@
 site_name: "A RuboCop extension focused on enforcing Minitest best practices and coding conventions."
 repo_url: https://github.com/rubocop-hq/rubocop-minitest
 edit_uri: edit/master/legacy-docs/
-copyright: "Copyright © 2019 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
+copyright: "Copyright © 2021 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
 docs_dir: legacy-docs
 pages:
 - Home: index.md

data/relnotes/v0.10.3.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#115](https://github.com/rubocop-hq/rubocop-minitest/issues/115): Fix a false positive for `Minitest/TestMethodName` for when defining test method has an argument, and test method without assertion methods. ([@koic][])
+
+[@koic]: https://github.com/koic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-12-27 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -131,6 +131,7 @@ files:
 - relnotes/v0.10.0.md
 - relnotes/v0.10.1.md
 - relnotes/v0.10.2.md
+- relnotes/v0.10.3.md
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
@@ -172,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.4
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.