rubocop-mable 0.1.2.4 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5d683e80171e6ec4ddb878fc71c230a22478b10bd934599a1dc82f4f4a7d3db
-  data.tar.gz: 1176a6e964f99beaa4bf7678c26af5cf491ac7a2c1e04bb7336bae5931099de3
+  metadata.gz: 402b8f356986fdfa523dcecccf1b2fb74f4a9c6ce34c191db74d1b839f00058b
+  data.tar.gz: 1e671dd68702a88b13eb3b0fe39954a710f5422e3c13d3c331424f2ab5fa9b17
 SHA512:
-  metadata.gz: c3b5cedd1881ca5ecd2d1a6733f88cef38446ccfb198bf0e5207b0419e22fcd88b71723ace06d2e727b65a20ea062882ce939b4337e272f61414949db5bee0b8
-  data.tar.gz: 0ff53b079406c6d0010ad331331bf9687e38387a3a2d9d80f3b439331677b32b5e5499abf2470bd3e0a3e65ee4d338b7fbb546cb54b345baf67c172b0a21bfb0
+  metadata.gz: c261761ae3726394462842ff37774f47984567e66c3152e7a86a6d960b15c15251a660c5f53e949bb2b4669e76aa1344b4d3eaea82c410d9cc19bbd83a088a19
+  data.tar.gz: 6d07e483bc9da12e4d7875d12673cbf05401ffaaadb76db3cb42d226d467e7f19bf04bd39d77a19e2a206b8733649dedbbd9e77804691db12c6660ad7ec9ed50

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-mable (0.1.2.4)
+    rubocop-mable (0.1.3)
       rubocop
 
 GEM

data/README.md

@@ -5,6 +5,11 @@ Mable's custom Rubocop cops
 ## Cops
 
 ```
+Mable/NoSafetyAssured:
+  Description: 'An extra check to ensure that the safety_assured is required'
+  Enabled: true
+  VersionAdded: '0.1.3'
+
 Mable/GraphQLHelperSpecs:
   Description: 'Avoid hardcoding GraphQl path use helper instead.'
   Enabled: true

data/config/default.yml

@@ -7,3 +7,8 @@ Mable/HardcodedDatabaseFactoryBotId:
   Enabled: true
   Description: 'Avoid hardcoding factory bot database IDs, instead, dynamically test for the ID'
   VersionAdded: '0.1.1'
+
+Mable/NoSafetyAssured:
+  Description: 'An extra check to ensure that the safety_assured is required'
+  Enabled: true
+  VersionAdded: '0.1.3'

data/lib/rubocop/cop/mable/no_safety_assured.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Mable
+      # An extra check to ensure that the safety_assured is required
+      # https://github.com/ankane/strong_migrations
+
+      # @safety
+      #   Can't be autocorrected because it's a manual check
+      #
+      # @example
+      #   # bad
+      #   safety_assured { remove_column :model_name....
+
+      #   # good
+      #   remove_column :model_name....
+
+      class NoSafetyAssured < Base
+        MSG = 'Are you sure safety_assured is required, is there a better way? https://github.com/ankane/strong_migrations'
+
+        RESTRICT_ON_SEND = %i[safety_assured].freeze
+
+        # @!method bad_method?(node)
+        def_node_matcher :safety_assured?, <<~PATTERN
+          (send nil? :safety_assured ...)
+        PATTERN
+
+        def on_send(node)
+          return unless safety_assured?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/mable_cops.rb

@@ -2,3 +2,4 @@
 
 require_relative 'mable/graph_ql_helper_specs'
 require_relative 'mable/hardcoded_database_factory_bot_id'
+require_relative 'mable/no_safety_assured'

data/lib/rubocop/mable/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Mable
-    VERSION = '0.1.2.4'
+    VERSION = '0.1.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-mable
 version: !ruby/object:Gem::Version
-  version: 0.1.2.4
+  version: 0.1.3
 platform: ruby
 authors:
 - Mable Engineers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-16 00:00:00.000000000 Z
+date: 2022-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -59,6 +59,7 @@ files:
 - lib/rubocop-mable.rb
 - lib/rubocop/cop/mable/graph_ql_helper_specs.rb
 - lib/rubocop/cop/mable/hardcoded_database_factory_bot_id.rb
+- lib/rubocop/cop/mable/no_safety_assured.rb
 - lib/rubocop/cop/mable_cops.rb
 - lib/rubocop/mable.rb
 - lib/rubocop/mable/inject.rb