rubocop-legion 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 761ab5c8fe6b85b1df48dddace038f224e7a1a65289c8f06a4c8e37543a284f3
-  data.tar.gz: 20316578e3b32c13a62b1524167523ce2f9105557d4bf4301b1f146108cbf05c
+  metadata.gz: 1d2c3a1967dcc9bd66a2c806d2b471b59594d51ae9fec7c2c3eaad9946898932
+  data.tar.gz: cdd7fcb62b6b0ff1eb17d595aa6a7b76259fdefa7ae5ecd6d6b1306f98e817c1
 SHA512:
-  metadata.gz: ca163ec06479b86169f5fa4016950c85b9d7ffdb2d7636fbd7f2a5afaf93cf98ad488ff23acee8c77b6ce505c09e8ac6928592b7d16a7a088f8edeeed11a97e0
-  data.tar.gz: 51ec78f8b560249fb871e185e0989f3f9af27bfc40b637adc46b9c6d20c4f10a376a60aa7ad397f08f89b10e10267de3e815a98bc9faf7dddd0903e55ffe0a8f
+  metadata.gz: 0515bb7d5ea06e80069a937b9899e23bf281366660d718cd707460b0ed63a9955ed4ff531f6e592c9b203ea090bda1ba620d5d80fbb4b758dab3b91f9190dc71
+  data.tar.gz: 673910f539a627bd4697e1bfd86ee8c8b0f9644d257090fafcad43907bd080af80be71e961340e53be6077251dd8dd302b957fcb8d74a4418be228b3f6fd175c

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [0.1.2] - 2026-03-29
+
+### Added
+- New cop `Legion/HelperMigration/LoggingGuard`: flags unnecessary `respond_to?(:log_warn)` etc. and `defined?(Legion::Logging)` guards
+
 ## [0.1.1] - 2026-03-29
 
 ### Fixed

data/config/default.yml

@@ -43,6 +43,12 @@ Legion/HelperMigration/DirectCrypt:
   Severity: warning
   VersionAdded: '0.1'
 
+Legion/HelperMigration/LoggingGuard:
+  Description: 'Remove unnecessary `respond_to?(:log_warn)` or `defined?(Legion::Logging)` guards.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.2'
+
 # Legion/ConstantSafety — prevent namespace resolution bugs inside module Legion
 
 Legion/ConstantSafety:

data/lib/rubocop/cop/legion/helper_migration/logging_guard.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Legion
+      module HelperMigration
+        # Detects unnecessary guard checks around logging that are no longer
+        # needed. The `log` helper is always available in extensions via
+        # `Helpers::Lex`.
+        #
+        # Catches two patterns:
+        # 1. `respond_to?` checks for old logging methods or `log`
+        # 2. `defined?(Legion::Logging)` guards
+        #
+        # @example
+        #   # bad
+        #   log.warn(msg) if respond_to?(:log_warn, true)
+        #   log.info(msg) if respond_to?(:log)
+        #   Legion::Logging.info(msg) if defined?(Legion::Logging)
+        #
+        #   # good
+        #   log.warn(msg)
+        #   log.info(msg)
+        class LoggingGuard < RuboCop::Cop::Base
+          MSG_RESPOND_TO = '`respond_to?(:%<method>s)` guard is unnecessary. ' \
+                           '`log` is always available via `Helpers::Lex`.'
+          MSG_DEFINED = '`defined?(Legion::Logging)` guard is unnecessary. ' \
+                        '`Legion::Logging` is always loaded in the framework.'
+
+          OLD_METHODS = %i[log log_info log_warn log_error log_debug log_fatal].to_set.freeze
+
+          RESTRICT_ON_SEND = %i[respond_to?].freeze
+
+          # respond_to?(:log_warn) or respond_to?(:log_warn, true)
+          # @!method old_logging_respond_to?(node)
+          def_node_matcher :old_logging_respond_to?, <<~PATTERN
+            (send nil? :respond_to? (sym $_) ...)
+          PATTERN
+
+          def on_send(node)
+            old_logging_respond_to?(node) do |method_name|
+              next unless OLD_METHODS.include?(method_name)
+
+              add_offense(node, message: format(MSG_RESPOND_TO, method: method_name))
+            end
+          end
+
+          # defined? is a keyword, not a send — handle via on_defined? callback
+          def on_defined?(node)
+            return false unless legion_logging_defined?(node)
+
+            add_offense(node, message: MSG_DEFINED)
+          end
+
+          private
+
+          def legion_logging_defined?(node)
+            child = node.children.first
+            return false unless child&.const_type?
+
+            # Match Legion::Logging — (const (const nil :Legion) :Logging)
+            parent_const = child.children.first
+            parent_const&.const_type? &&
+              parent_const.children == [nil, :Legion] &&
+              child.children.last == :Logging
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/legion/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Legion
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

data/lib/rubocop-legion.rb

@@ -13,6 +13,7 @@ require 'rubocop/cop/legion/helper_migration/direct_json'
 require 'rubocop/cop/legion/helper_migration/direct_cache'
 require 'rubocop/cop/legion/helper_migration/direct_local_cache'
 require 'rubocop/cop/legion/helper_migration/direct_crypt'
+require 'rubocop/cop/legion/helper_migration/logging_guard'
 
 # Legion/ConstantSafety
 require 'rubocop/cop/legion/constant_safety/bare_data_define'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-legion
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Esity
@@ -110,6 +110,7 @@ files:
 - lib/rubocop/cop/legion/helper_migration/direct_json.rb
 - lib/rubocop/cop/legion/helper_migration/direct_local_cache.rb
 - lib/rubocop/cop/legion/helper_migration/direct_logging.rb
+- lib/rubocop/cop/legion/helper_migration/logging_guard.rb
 - lib/rubocop/cop/legion/helper_migration/old_logging_methods.rb
 - lib/rubocop/cop/legion/rescue_logging/bare_rescue.rb
 - lib/rubocop/cop/legion/rescue_logging/no_capture.rb