rubocop-legion 0.1.10 → 0.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d9316d83d8676fe5adb80fd7500f3daece09203ece25f0ce0c81887d19982ca
-  data.tar.gz: 646cab78aebc73b233882dcfc594d6c0efbea0acb3e2881e02a1f888ec5513e4
+  metadata.gz: ab19d4bce0d274768b632aa0579aa8997cb503befa24d4d613442f4cc894cb09
+  data.tar.gz: 85caebdfc215b98b74febd7b59c09c90fc6574e36f9dd2c126c866ca43138cde
 SHA512:
-  metadata.gz: 83f63897f48898014d992e98b11cdfd9f2b830e405b2fd49bff484acffdaaeafd853dea8016baaa280787302a0c15a701e2f1d0c71274d1bf0fa04761574e8bd
-  data.tar.gz: 69aa65b8634cef75041fe37a57b87ca54bdc911a59fc12710193a66550b71c01926831618ef9100b775c5fc498d0705d8eaab50af11c5c1446d36ab801be51ae
+  metadata.gz: 93425642d48e67c4897e9466b34394aa88b43048435c0841d0c6b1c05a6eee4ce022fd3211757ed6a3de084b5f154dea614a764e763b92a845be779cc717a0b9
+  data.tar.gz: e45f70a81e9e658b90e984a5561e027d88044450831c0a714d31f96a231e3933662128d167b60666624d3631077672898f8e5a50627c77e267423b00f9fb32f2

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [0.1.11] - 2026-08-04
+
+### Added
+- New cop `Legion/Framework/NoUnusedArgDisable` (universal): bans `# rubocop:disable`/`:todo`/`:enable Lint/UnusedMethodArgument`. An unused kwarg is a real offense, not something to hide — autocorrect removes the directive so it resurfaces and must be fixed properly (drop the arg, or `**` → `**opts` and read `opts[:key]`). Single-cop directives autocorrect; multi-cop directives are flagged without autocorrect. `# rubocop:disable all` is out of scope.
+
+### Fixed
+- `Legion/Framework/NoUnderscorePrefixedKwargs` now autocorrects an unused splat (`**_opts`, `**_rest`, `**_`) to `**` (nameless accept-and-ignore) instead of `**opts`. The underscore signals the splat is unused; rewriting to a named `**opts` produced a named-but-unused splat that falsely claims the body reads `opts`. `**opts` is correct only when the body actually reads it.
+
 ## [0.1.10] - 2026-07-31
 
 ### Fixed

data/config/default.yml

@@ -340,11 +340,17 @@ Legion/Extension/DefinitionCallMismatched:
 # Legion/Framework — N×N routing guard cops (Phase 6 enforcement)
 
 Legion/Framework/NoUnderscorePrefixedKwargs:
-  Description: 'Ban underscore-prefixed kwargs and `**_rest` splats. Use plain kwarg, defaulted kwarg, or `**opts`.'
+  Description: 'Ban underscore-prefixed kwargs and `**_rest` splats. Use plain kwarg, defaulted kwarg, `**opts`, or `**`.'
   Enabled: true
   Severity: warning
   VersionAdded: '0.1.8'
 
+Legion/Framework/NoUnusedArgDisable:
+  Description: 'Ban `# rubocop:disable Lint/UnusedMethodArgument`. Drop the arg or use `**opts`.'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.11'
+
 Legion/Framework/NoInlineSettingDefaults:
   Description: 'Flag `Legion::Settings[...] || <literal>` and shadow-default patterns. Defaults belong in `settings.rb`.'
   Enabled: true

data/lib/rubocop/cop/legion/framework/no_underscore_prefixed_kwargs.rb

@@ -18,15 +18,16 @@ module RuboCop
         #   # good
         #   def foo(bar:); end
         #   def foo(bar: nil); end
-        #   def foo(**opts); end
+        #   def foo(**); end       # unused passthrough
+        #   def foo(**opts); end   # only when the body reads `opts`
         class NoUnderscorePrefixedKwargs < Base
           extend AutoCorrector
 
           MSG_KWARG = 'Underscore-prefixed kwarg `%<name>s` is not allowed. ' \
                       'Use plain kwarg (required), defaulted kwarg (optional), ' \
                       'or `**opts` for passthrough.'
-          MSG_SPLAT = 'Underscore-prefixed kwarg splat `%<name>s` is not allowed. ' \
-                      'Use `**opts` for passthrough.'
+          MSG_SPLAT = 'Underscore-prefixed splat `%<name>s` means unused — use `**` to ' \
+                      'accept-and-ignore, or `**opts` only if the body reads `opts`.'
 
           def on_def(node)
             check_params(node)
@@ -70,7 +71,7 @@ module RuboCop
             return unless name.to_s.start_with?('_')
 
             add_offense(arg, message: format(MSG_SPLAT, name: name)) do |corrector|
-              corrector.replace(arg.source_range, '**opts')
+              corrector.replace(arg.source_range, '**')
             end
           end
 

data/lib/rubocop/cop/legion/framework/no_unused_arg_disable.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Legion
+      module Framework
+        # Bans disabling `Lint/UnusedMethodArgument` with an inline directive.
+        # An unused kwarg is a real offense, not something to hide — a `**` /
+        # `**opts` splat already swallows extras, so the arg should be dropped;
+        # if it is genuinely optional, change `**` to `**opts` and read
+        # `opts[:key]`. RuboCop's own `RedundantCopDisableDirective` never flags
+        # this because the offense is genuine, so the directive stays invisible.
+        #
+        # Autocorrect removes the directive so the real `Lint/UnusedMethodArgument`
+        # offense resurfaces and must be fixed properly. It never edits the method
+        # signature — dropping a load-bearing public kwarg is a human decision.
+        #
+        # A blanket "disable all" directive is intentionally out of scope; only
+        # directives that name `Lint/UnusedMethodArgument` explicitly are flagged.
+        #
+        # @example
+        #   # bad — a disable directive naming Lint/UnusedMethodArgument on the def
+        #   def foo(bar:, unused:)
+        #   end
+        #
+        #   # good — drop the unused arg (a splat already swallows it)
+        #   def foo(bar:, **)
+        #   end
+        #
+        #   # good — keep it and actually read it
+        #   def foo(bar:, **opts)
+        #     opts[:unused]
+        #   end
+        class NoUnusedArgDisable < Base
+          include RangeHelp
+          extend AutoCorrector
+
+          MSG = 'Do not disable `Lint/UnusedMethodArgument`. Drop the unused arg ' \
+                '(a `**`/`**opts` splat already swallows it) or change `**` to ' \
+                '`**opts` and read `opts[:key]`.'
+
+          TARGET = 'Lint/UnusedMethodArgument'
+
+          # Matches a disable / todo / enable directive and captures the cop list.
+          DIRECTIVE = /#\s*rubocop:(?:disable|todo|enable)\s+(?<cops>[^#]+)/
+
+          def on_new_investigation
+            processed_source.comments.each do |comment|
+              match = DIRECTIVE.match(comment.text)
+              next unless match
+
+              cops = match[:cops].split(',').map(&:strip)
+              next unless cops.include?(TARGET)
+
+              register(comment, cops)
+            end
+          end
+
+          private
+
+          def register(comment, cops)
+            add_offense(comment) do |corrector|
+              # Only autocorrect the unambiguous single-cop case; leave multi-cop
+              # directives to a human so we never strip an unrelated disable.
+              corrector.remove(removal_range(comment)) if cops == [TARGET]
+            end
+          end
+
+          # Trailing directive (`code # rubocop:disable ...`) → strip the comment
+          # and the whitespace before it. Standalone directive line → strip the
+          # whole line including its newline.
+          def removal_range(comment)
+            range = comment.source_range
+            line_range = range.source_line
+            leading = line_range[0...range.column]
+
+            if leading.strip.empty?
+              range_by_whole_lines(range, include_final_newline: true)
+            else
+              range.with(begin_pos: range.begin_pos - trailing_ws(leading))
+            end
+          end
+
+          def trailing_ws(leading)
+            leading.length - leading.rstrip.length
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/legion/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Legion
-    VERSION = '0.1.10'
+    VERSION = '0.1.11'
   end
 end

data/lib/rubocop-legion.rb

@@ -45,6 +45,7 @@ require 'rubocop/cop/legion/framework/cache_time_coercion'
 require 'rubocop/cop/legion/framework/api_string_keys'
 require 'rubocop/cop/legion/framework/mutex_nested_sync'
 require 'rubocop/cop/legion/framework/no_underscore_prefixed_kwargs'
+require 'rubocop/cop/legion/framework/no_unused_arg_disable'
 require 'rubocop/cop/legion/framework/no_inline_setting_defaults'
 require 'rubocop/cop/legion/framework/no_direct_dispatch'
 require 'rubocop/cop/legion/framework/no_shape_duck_typing'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-legion
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
 platform: ruby
 authors:
 - Esity
@@ -148,6 +148,7 @@ files:
 - lib/rubocop/cop/legion/framework/no_inline_setting_defaults.rb
 - lib/rubocop/cop/legion/framework/no_shape_duck_typing.rb
 - lib/rubocop/cop/legion/framework/no_underscore_prefixed_kwargs.rb
+- lib/rubocop/cop/legion/framework/no_unused_arg_disable.rb
 - lib/rubocop/cop/legion/framework/sinatra_host_auth.rb
 - lib/rubocop/cop/legion/framework/thor_reserved_run.rb
 - lib/rubocop/cop/legion/helper_migration/defined_transport_guard.rb