rubocop-legion 0.1.9 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88034e8168ad8e5634a580f3a07ca2f030bd46be31b6c9607dbc64a28935bcd0
-  data.tar.gz: 353647b902a3271fe17809769674778b528eb3e97dda8704934addf80b69b397
+  metadata.gz: 4d9316d83d8676fe5adb80fd7500f3daece09203ece25f0ce0c81887d19982ca
+  data.tar.gz: 646cab78aebc73b233882dcfc594d6c0efbea0acb3e2881e02a1f888ec5513e4
 SHA512:
-  metadata.gz: 0b7d05703e9bd6762628d25f082a738fba9972f66eda2b650ab5e3c0dace6b3569df16c754f935f8f62caf861eaf3984018c3a4f3f73de01cc0871fcf91cfebd
-  data.tar.gz: d598e5090c4ba1242ec371fd2d3b935412f9fe8c4e24fe907a9e18bd6052999568bed0c252a983559e4b33e1c0502a724e02df5244db46b98c5cdad899f62e93
+  metadata.gz: 83f63897f48898014d992e98b11cdfd9f2b830e405b2fd49bff484acffdaaeafd853dea8016baaa280787302a0c15a701e2f1d0c71274d1bf0fa04761574e8bd
+  data.tar.gz: 69aa65b8634cef75041fe37a57b87ca54bdc911a59fc12710193a66550b71c01926831618ef9100b775c5fc498d0705d8eaab50af11c5c1446d36ab801be51ae

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.1.10] - 2026-07-31
+
+### Fixed
+- `Legion/Llm/TaxonomyEnum` no longer over-matches: `:type` is only validated when it appears alongside `:tier` or `:circuit_state` in the same hash (taxonomy context). Previously any `{ type: :string }` or schema hash triggered a false positive.
+- Added `Legion/Llm` department to `config/default.yml` — all four cops (`TaxonomyEnum`, `SettingsAccessPath`, `NoLoopDo`, `RescueLogLevel`) were loaded but never registered in the config, causing consumer repos to report "unrecognized cop" when referencing `Legion/Llm/TaxonomyEnum`.
+- `TaxonomyEnum` is now Include-scoped to `lib/legion/llm/**/*.rb` and `lib/legion/extensions/llm/**/*.rb` so it only runs on LLM routing code.
+
 ## [0.1.8] - 2026-06-16
 
 ### Added

data/config/default.yml

@@ -363,3 +363,38 @@ Legion/Framework/NoShapeDuckTyping:
   Severity: convention
   VersionAdded: '0.1.8'
   Safe: false
+
+# Legion/Llm — cops specific to legion-llm and lex-llm-* provider pipelines
+
+Legion/Llm:
+  Enabled: true
+  Include:
+    - 'lib/legion/llm/**/*.rb'
+    - 'lib/legion/extensions/llm/**/*.rb'
+
+Legion/Llm/TaxonomyEnum:
+  Description: 'Validate :tier, :type, and :circuit_state literals against LegionIO taxonomy enums.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.9'
+  Include:
+    - 'lib/legion/llm/**/*.rb'
+    - 'lib/legion/extensions/llm/**/*.rb'
+
+Legion/Llm/SettingsAccessPath:
+  Description: 'Use `Legion::Settings.dig(...)` instead of `Legion::Settings.loader.settings[...][...]`.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.9'
+
+Legion/Llm/NoLoopDo:
+  Description: 'Ban `loop do` — use bounded iteration (`N.times`, `each`, or `while` with explicit bound).'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.9'
+
+Legion/Llm/RescueLogLevel:
+  Description: 'Minimum log level for `handle_exception` in rescue blocks is `:warn`.'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.9'

data/lib/rubocop/cop/legion/llm/taxonomy_enum.rb

@@ -8,6 +8,11 @@ module RuboCop
         # Flags `:tier`, `:type`, and `:circuit_state` literals that are not in
         # the known-valid sets, catching typos at lint time.
         #
+        # `:tier` and `:circuit_state` are domain-specific keys and are always
+        # validated. `:type` is only validated when it appears in a hash that
+        # also contains `:tier` or `:circuit_state`, since `:type` alone is too
+        # common in non-taxonomy contexts.
+        #
         # Valid values (from Inventory::DEFAULT_PROVIDER_TIERS and the SSOT design):
         #   tier:          :local, :fleet, :cloud, :frontier, :direct
         #   type:          :inference, :embedding, :moderation, :rerank, :image
@@ -17,15 +22,24 @@ module RuboCop
         #   # bad  (typo)
         #   { tier: :fronteir }
         #   health[:circuit_state] = :half_opened
+        #   { tier: :cloud, type: :inferencing }
         #
         #   # good
         #   { tier: :frontier }
         #   health[:circuit_state] = :half_open
+        #   { tier: :cloud, type: :inference }
+        #
+        #   # ignored (`:type` alone, no taxonomy context)
+        #   { type: :string }
+        #   { type: :integer }
         class TaxonomyEnum < Base
           VALID_TIERS          = %i[local fleet cloud frontier direct].freeze
           VALID_TYPES          = %i[inference embedding moderation rerank image].freeze
           VALID_CIRCUIT_STATES = %i[closed open half_open].freeze
 
+          TAXONOMY_KEYS = %i[tier type circuit_state].freeze
+          CONTEXT_KEYS  = %i[tier circuit_state].freeze
+
           MSG_TIER    = 'Unknown tier `%<val>s`. Valid: %<valid>s.'
           MSG_TYPE    = 'Unknown type `%<val>s`. Valid: %<valid>s.'
           MSG_CIRCUIT = 'Unknown circuit_state `%<val>s`. Valid: %<valid>s.'
@@ -38,7 +52,6 @@ module RuboCop
           end
 
           def on_send(node)
-            # health[:circuit_state] = :bad_value
             return unless node.method_name == :[]=
             return unless node.arguments.size == 2
 
@@ -54,22 +67,34 @@ module RuboCop
             val = val_node.value
             case key
             when :tier
-              unless VALID_TIERS.include?(val)
-                add_offense(parent_node,
-                            message: format(MSG_TIER, val: val, valid: VALID_TIERS.join(', ')))
-              end
+              return if VALID_TIERS.include?(val)
+
+              add_offense(parent_node,
+                          message: format(MSG_TIER, val: val, valid: VALID_TIERS.join(', ')))
             when :type
-              unless VALID_TYPES.include?(val)
-                add_offense(parent_node,
-                            message: format(MSG_TYPE, val: val, valid: VALID_TYPES.join(', ')))
-              end
+              return if VALID_TYPES.include?(val)
+              return unless taxonomy_context?(parent_node)
+
+              add_offense(parent_node,
+                          message: format(MSG_TYPE, val: val, valid: VALID_TYPES.join(', ')))
             when :circuit_state
-              unless VALID_CIRCUIT_STATES.include?(val)
-                msg = format(MSG_CIRCUIT, val: val, valid: VALID_CIRCUIT_STATES.join(', '))
-                add_offense(parent_node, message: msg)
-              end
+              return if VALID_CIRCUIT_STATES.include?(val)
+
+              add_offense(parent_node,
+                          message: format(MSG_CIRCUIT, val: val, valid: VALID_CIRCUIT_STATES.join(', ')))
             end
           end
+
+          def taxonomy_context?(pair_node)
+            hash_node = pair_node.parent
+            return false unless hash_node&.hash_type?
+
+            sibling_keys = hash_node.pairs.filter_map do |pair|
+              pair.key.value if pair.key.sym_type?
+            end
+
+            sibling_keys.intersect?(CONTEXT_KEYS)
+          end
         end
       end
     end

data/lib/rubocop/legion/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Legion
-    VERSION = '0.1.9'
+    VERSION = '0.1.10'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-legion
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors:
 - Esity